This revision was automatically updated to reflect the committed changes.
Closed by commit rL285909: Support for Python 3 in libclang python bindings
(authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D26082?vs=76774&id=76854#toc
Repository:
rL LLVM
https://reviews.llvm.
jbcoe added inline comments.
Comment at: bindings/python/clang/cindex.py:77
+# Python 3 strings are unicode, translate them to/from utf8 for C-interop
+if type(u"") == str:
+class c_string_p(c_char_p):
mgorny wrote:
> What is the Python3 version you're aiming
jbcoe updated this revision to Diff 76774.
jbcoe marked an inline comment as done.
jbcoe added a comment.
Respond to review comments.
https://reviews.llvm.org/D26082
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_translation_unit.py
Index: bindings/python/tests/ci
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 76344.
jbcoe added a comment.
Remove mistakenly committed debugging output.
https://reviews.llvm.org/D26082
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_translation_uni
jbcoe retitled this revision from "Incomplete support for Python 3 in libclang
python bindings" to "Support for Python 3 in libclang python bindings".
jbcoe updated the summary for this revision.
jbcoe updated this revision to Diff 76338.
jbcoe added a comment.
Python bindings tests now pass in P
jbcoe created this revision.
jbcoe added reviewers: eliben, compnerd, nemanjai, skalinichev.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
This is incomplete and I'm in need of some input.
Some test pass in Python 3 now. Python 2 tests pass as befor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277523: [clang-tidy] Fix segfault in
cppcore-guidelines-special-member-functions check (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D23008?vs=66541&id=66558#toc
Repository:
jbcoe marked an inline comment as done.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,3 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+static std::string
+join(ArrayRef SMFS,
+
jbcoe updated this revision to Diff 66541.
jbcoe added a comment.
static `join` function is no longer a function template.
https://reviews.llvm.org/D23008
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.h
test/cl
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64
@@ -62,4 +62,4 @@
-std::string SpecialMemberFunctionsCheck::join(
-llvm::ArrayRef SMFS, llvm::StringRef AndOr) {
+template
+static std::string join(const R &SMFS, llv
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 66444.
jbcoe added a comment.
Add test that triggers segfault without fix in place.
https://reviews.llvm.org/D23008
Files:
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp
clang-tidy/c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277262: [clang-tidy] add check
cppcoreguidelines-special-member-functions (authored by jbcoe).
Changed prior to commit:
https://reviews.llvm.org/D22513?vs=66161&id=66219#toc
Repository:
rL LLVM
http
jbcoe marked 9 inline comments as done.
jbcoe added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 66161.
jbcoe added a comment.
Fix MSVC warning.
Repository:
rL LLVM
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelines
jbcoe added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:62
@@ +61,3 @@
+std::string
+SpecialMemberFunctionsCheck::join(llvm::ArrayRef
SMFS,
+ llvm::StringRef AndOr) {
aaron.ballman wrote:
>
jbcoe updated this revision to Diff 66011.
jbcoe added a comment.
Minor changes from review.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
clang-tidy/cppcoreguidelines/SpecialMemberFunctionsC
jbcoe marked an inline comment as done.
jbcoe added a comment.
https://reviews.llvm.org/D22513
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 65423.
jbcoe added a comment.
Fix underline length in docs.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyMod
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 65414.
jbcoe marked an inline comment as done.
jbcoe added a comment.
Rename to cppcoreguidelines-special-member-functions to avoid the duplication
required with naming it rule-of-3 and rule-of-5.
Reduce c
jbcoe updated this revision to Diff 65096.
jbcoe marked 6 inline comments as done.
jbcoe added a comment.
Address comments from review, thanks for those.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModu
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 65092.
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
Addressed review comments, thanks for those, check is nicer now.
https://reviews.llvm.org/D22513
Files:
clang-tidy/cppcoreguidel
jbcoe retitled this revision from "clang-tidy check:
misc-deprecated-special-member-functions" to "clang-tidy check:
cppcoreguidelines-rule-of-five-and-zero".
jbcoe updated the summary for this revision.
jbcoe updated this revision to Diff 64490.
jbcoe added a comment.
Herald added a subscriber:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269341: [clang-tidy] Adds modernize-avoid-bind check
(authored by jbcoe).
Changed prior to commit:
http://reviews.llvm.org/D16962?vs=57067&id=57095#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
jbcoe updated this revision to Diff 57067.
jbcoe added a comment.
update diff to allow arc to apply patch.
http://reviews.llvm.org/D16962
Files:
clang-tidy/modernize/AvoidBindCheck.cpp
clang-tidy/modernize/AvoidBindCheck.h
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Moderni
jbcoe added a comment.
I can submit the patch myself, thanks.
Thanks again for taking the time to give such a thorough review.
http://reviews.llvm.org/D16962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
jbcoe updated this revision to Diff 57022.
jbcoe marked 6 inline comments as done.
jbcoe added a comment.
Apply fixes from review.
http://reviews.llvm.org/D16962
Files:
clang-tidy/modernize/AvoidBindCheck.cpp
clang-tidy/modernize/AvoidBindCheck.h
clang-tidy/modernize/CMakeLists.txt
clan
jbcoe removed a reviewer: djasper.
jbcoe updated this revision to Diff 56273.
jbcoe added a comment.
Move to modernize. Rename to `avoid-bind` as a later patch will add support for
`boost::bind`, `std::bind1st` etc.
http://reviews.llvm.org/D16962
Files:
clang-tidy/modernize/AvoidBindCheck.cp
jbcoe added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:17
@@ -15,2 +16,2 @@
#include "ContainerSizeEmptyCheck.h"
#include "DeletedDefaultCheck.h"
aaron.ballman wrote:
> I believe we use "modernize" to really mean "migrate from
jbcoe added a comment.
After some pondering I think I **will**extend move this check to
cppcoreguidelines and call it rule-of-five.
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all
http://r
jbcoe updated this revision to Diff 55974.
jbcoe added a comment.
Remove unused function `isStdBind`.
http://reviews.llvm.org/D16962
Files:
clang-tidy/readability/AvoidStdBindCheck.cpp
clang-tidy/readability/AvoidStdBindCheck.h
clang-tidy/readability/CMakeLists.txt
clang-tidy/readabilit
jbcoe updated this revision to Diff 55970.
jbcoe marked 16 inline comments as done.
jbcoe added a comment.
Minor fixes from review.
http://reviews.llvm.org/D16962
Files:
clang-tidy/readability/AvoidStdBindCheck.cpp
clang-tidy/readability/AvoidStdBindCheck.h
clang-tidy/readability/CMakeLis
jbcoe added inline comments.
Comment at: clang-tidy/readability/ReadabilityTidyModule.cpp:37
@@ -35,1 +36,3 @@
+CheckFactories.registerCheck(
+"readability-avoid-std-bind");
CheckFactories.registerCheck(
aaron.ballman wrote:
> I kind of wonder if
jbcoe abandoned this revision.
jbcoe added a comment.
I'm abandoning this revision for lack of interest.
http://reviews.llvm.org/D15654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL267706: Expose cxx constructor and method properties through
libclang and python… (authored by jbcoe).
Changed prior to commit:
http://reviews.llvm.org/D15469?vs=53519&id=55196#toc
Repository:
rL LLV
jbcoe updated this revision to Diff 53519.
jbcoe added a comment.
Remove python test for deleted method.
I missed this because the python tests are not run as part of check-clang - is
this something I could submit a patch to change?
http://reviews.llvm.org/D15469
Files:
bindings/python/clan
jbcoe abandoned this revision.
jbcoe added a comment.
Fixed in http://reviews.llvm.org/D17278
Repository:
rL LLVM
http://reviews.llvm.org/D17180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
jbcoe updated this revision to Diff 53316.
jbcoe added a comment.
This revision is now accepted and ready to land.
Remove `isDeleted` as it needs to be added for non-member functions.
I will add `isDeleted` as an isolated follow up patch.
http://reviews.llvm.org/D15469
Files:
bindings/python
jbcoe added a comment.
I plan to strip out the `isDeleted` methods as the associated tests now fail
(which I need to raise a bug for) and need reworking to apply to non-member
functions.
I'll submit a new patch for `isDeleted` on its own. The rest of this patch
seems uncontentious.
I hope to
jbcoe added a comment.
The other python test fix has been applied in r263170 (Differential Revision:
http://reviews.llvm.org/D17226).
Has anyone had a chance to look at _this_ patch yet?
Repository:
rL LLVM
http://reviews.llvm.org/D17180
___
cf
jbcoe added a comment.
Do you have commit access? I can apply this patch for you if not.
http://reviews.llvm.org/D17811
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe added a comment.
If I remove `= delete` from the declaration of the member function `foo` in
test/Index/index-file.cpp line 36 then `foo` is reported in the output as
[indexDeclaration]: kind: c++-instance-method | name: foo | USR:
c:@S@B@F@foo# | lang: C++ | cursor: CXXMethod=foo:36:8
jbcoe added inline comments.
Comment at: clang-tidy/readability/AvoidStdBindCheck.cpp:42
@@ +41,3 @@
+
+ for (size_t I = 1, ArgCount = C->getNumArgs(); I < ArgCount; ++I) {
+const Expr *E = C->getArg(I);
alexfh wrote:
> Please use a range-based for loop over
jbcoe updated this revision to Diff 50623.
jbcoe marked 15 inline comments as done.
jbcoe added a comment.
Apply requested fixes from review.
Thanks for taking time to review this, the patch is much improved for the
attention.
http://reviews.llvm.org/D16962
Files:
clang-tidy/readability/Avo
jbcoe planned changes to this revision.
jbcoe added a comment.
I'll move this to `modernize` and update docs when I get over my cold. Thanks
for the feedback.
http://reviews.llvm.org/D16376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
jbcoe added a comment.
I don't know if it's at all helpful but I get the following output from
llvm-lit on the failing test file. There's no mention of a function `foo` at
all:
[startedTranslationUnit]
[enteredMainFile]:
/Users/jon/DEV/llvm-git-svn/tools/clang/test/Index/index-file.cpp
[
jbcoe added a comment.
@skalinichev I get the same failure as you. This patch is old now, all tests
used to pass. Can you see what is wrong with the test logic?
http://reviews.llvm.org/D15469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jbcoe added inline comments.
Comment at: test/clang-tidy/misc-dangling-handle.cpp:86
@@ +85,3 @@
+ // CHECK-MESSAGES: [[@LINE-1]]:20: warning: std::basic_string_view outlives
+
+ view1 = std::string();
Thanks.
http://reviews.llvm.org/D17811
This revision was automatically updated to reflect the committed changes.
Closed by commit rL263170: libclang python bindings: Fix for bug 26394
(authored by jbcoe).
Changed prior to commit:
http://reviews.llvm.org/D17226?vs=47874&id=50369#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17
jbcoe added a comment.
I think there are some minor issues with the tests, easily fixed. I wonder if
the matchers can catch things inside implementation-defined inline namespaces
like `std::_v1_::experimental::library_fundamentals_v1::string_view`.
Comment at: clang-tidy/misc/
jbcoe abandoned this revision.
jbcoe added a comment.
rendered obsolete by http://reviews.llvm.org/D17811
Repository:
rL LLVM
http://reviews.llvm.org/D17772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
jbcoe added a comment.
Has anyone had a chance to look over this?
http://reviews.llvm.org/D15654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe created this revision.
jbcoe added reviewers: aaron.ballman, alexfh.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
Find instances where a string_view is constructed from a temporary string and
replace the string_view with a string.
Repository
jbcoe added a comment.
The Sema diagnostic warning is only produced if a deprecated special member
function is used whereas I want to find places where it would be
compiler-generated and explicitly delete them. This is useful for library code
where I don't have control over the warnings my user
jbcoe added a comment.
It's more than the warning because it offers fixits. Other than that it should
be the same. Using the same code as used to warn on deprecated special members
would be a great idea. I'm not too sure where to start looking and how much of
Sema is exposed to clang-tidy thoug
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
http://reviews.llvm.org/D16376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 48028.
jbcoe added a comment.
Minor fixes from review.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DeprecatedSpecialMemberGenerationCheck.cpp
clang-tidy/
jbcoe created this revision.
jbcoe added a reviewer: akyrtzi.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
Order of compilation database commands has changed causing test failure.
Reordering fixes the test `cindex.test_cdb.test_all_compilecommand`
jbcoe updated this revision to Diff 47747.
jbcoe added a comment.
Add missing test for types - apologies for noise.
http://reviews.llvm.org/D15654
Files:
bindings/python/clang/cppmodel.py
bindings/python/tests/cppmodel/__init__.py
bindings/python/tests/cppmodel/test_classes.py
bindings/
jbcoe updated this revision to Diff 47745.
jbcoe added a comment.
I've added more python classes to handle types and free functions.
http://reviews.llvm.org/D15654
Files:
bindings/python/clang/cppmodel.py
bindings/python/tests/cppmodel/__init__.py
bindings/python/tests/cppmodel/test_class
jbcoe added a comment.
Tests are now more thorough and more readable.
Insertions are always pre-insertions as getting the correct post-insertion
position is ambiguous if end-of-line comments exist.
Repository:
rL LLVM
http://reviews.llvm.org/D16376
___
jbcoe retitled this revision from "clang-tidy check: rule-of-five" to
"clang-tidy check: misc-deprecated-special-member-functions".
jbcoe updated the summary for this revision.
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 47735.
jbcoe added a comment.
jbcoe updated this revision to Diff 47259.
jbcoe added a comment.
Moved check to readability module.
Aside: would it be worthwhile creating a python script to move checks from one
module to another?
http://reviews.llvm.org/D16962
Files:
clang-tidy/readability/AvoidStdBindCheck.cpp
clang-t
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 47247.
jbcoe added a comment.
Require C++14 for improved fixits.
Do not attempt to generate fixits for more complicated uses of bind.
http://reviews.llvm.org/D16962
Files:
clang-tidy/misc/AvoidStdB
jbcoe planned changes to this revision.
jbcoe added a comment.
Placeholder handling needs correcting.
Repository:
rL LLVM
http://reviews.llvm.org/D16962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
jbcoe added a comment.
The method I'm using to insert after a function declaration is flawed.
Advancing by one character is not always the right thing to do and won't handle
cases where there is a space before a semi-colon. I'll add extra tests and see
if I can come up with a neater way of hand
jbcoe created this revision.
jbcoe added reviewers: aaron.ballman, alexfh, djasper.
jbcoe added a subscriber: cfe-commits.
jbcoe set the repository for this revision to rL LLVM.
Replace std::bind with a lambda.
Not yet working for member functions.
Repository:
rL LLVM
http://reviews.llvm.org/
jbcoe planned changes to this revision.
jbcoe added a comment.
If the destructor is user-declared then I need to `=delete` the
compiler-generated copy constructor and copy assignment operator (if they are
not defined, if either is defined then they are already handled by this check).
The move
jbcoe marked an inline comment as done.
jbcoe added a comment.
I think I'll move this check to `cppcoreguidelines` and call it `rule-of-five`.
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#c21-if-you-define-or-delete-any-default-operation-define-or-delete-them-all
jbcoe retitled this revision from "clang-tidy check: Assignment and
Construction" to "clang-tidy check: rule-of-five".
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 46775.
jbcoe added a comment.
I've responded to review comments (thanks for those)
jbcoe retitled this revision from "clang-tidy check: User-defined copy without
assignment" to "clang-tidy check: Assignment and Construction".
jbcoe updated the summary for this revision.
jbcoe set the repository for this revision to rL LLVM.
jbcoe updated this revision to Diff 45987.
jbcoe added
jbcoe added inline comments.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp:52
@@ +51,3 @@
+ hasDescendant(
+ cxxMethodDecl(isMoveAssignmentOperator(), unless(isImplicit()))
+ .bind("move-assignment")),
jbcoe updated this revision to Diff 45729.
jbcoe added a comment.
Added handling for move-constructor/move-assignment pairs.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.cpp
jbcoe planned changes to this revision.
jbcoe added a comment.
i need the matcher from http://reviews.llvm.org/D16470 to add a corresponding
pair of checks and fixes for move-constructors and move-assignment.
http://reviews.llvm.org/D16376
___
cfe-
jbcoe added inline comments.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25
@@ +24,3 @@
+/// assignment operator to be `= delete`.
+///
+/// For the user-facing documentation see:
jbcoe wrote:
> The standard says that compiler generation of
jbcoe updated this revision to Diff 45573.
jbcoe added a comment.
Added symmetric check for user-defined assignment but no copy constructor.
Check now adds '=default' to the missing special function if the user-specified
one was specified as '=default'.
Check needs renaming, I'll update it alon
jbcoe marked 2 inline comments as done.
jbcoe added a comment.
http://reviews.llvm.org/D16376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbcoe marked 5 inline comments as done.
Comment at: clang-tidy/misc/UserDefinedCopyWithoutAssignmentCheck.h:25
@@ +24,3 @@
+/// assignment operator to be `= delete`.
+///
+/// For the user-facing documentation see:
The standard says that compiler generation of the
jbcoe removed rL LLVM as the repository for this revision.
jbcoe updated this revision to Diff 45554.
jbcoe added a comment.
Made requested changes.
http://reviews.llvm.org/D16376
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UserDefinedCopyWitho
jbcoe abandoned this revision.
jbcoe added a comment.
This work needs such extensive revision that I'll submit a new version when I
start work on it again.
Repository:
rL LLVM
http://reviews.llvm.org/D7714
___
cfe-commits mailing list
cfe-commit
79 matches
Mail list logo
