jbcoe marked an inline comment as done. ================ Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:63-64 @@ -62,3 +62,4 @@ -std::string SpecialMemberFunctionsCheck::join( - llvm::ArrayRef<SpecialMemberFunctionKind> SMFS, llvm::StringRef AndOr) { +static std::string +join(ArrayRef<SpecialMemberFunctionsCheck::SpecialMemberFunctionKind> SMFS, + llvm::StringRef AndOr) { ---------------- iterator_range loses me size, empty and index access. There's a function that gets and ArrayRef from a SmallSetVector (I wonder why there's no implicit conversion defined) so I can change the signature to take ArrayRef.
https://reviews.llvm.org/D23008 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits