On Tue, Jul 18, 2023 at 8:41 PM serge via Phabricator <
revi...@reviews.llvm.org> wrote:
> serge-sans-paille created this revision.
> serge-sans-paille added reviewers: nickdesaulniers, jfb, aaron.ballman.
> Herald added a subscriber: kristof.beyls.
> Herald added a project: All.
> serge-sans-pail
Author: Thorsten Schuett
Date: 2020-08-04T11:10:29-07:00
New Revision: e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d
URL:
https://github.com/llvm/llvm-project/commit/e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d
DIFF:
https://github.com/llvm/llvm-project/commit/e18c6ef6b41a59af73bf5c3d7d52a8c53a471e5d.di
Author: JF Bastien
Date: 2020-07-28T13:41:06-07:00
New Revision: 389f009c5757cf09c0b2d77a15b3b541fb0f2a1c
URL:
https://github.com/llvm/llvm-project/commit/389f009c5757cf09c0b2d77a15b3b541fb0f2a1c
DIFF:
https://github.com/llvm/llvm-project/commit/389f009c5757cf09c0b2d77a15b3b541fb0f2a1c.diff
LO
Author: Oliver Hunt
Date: 2020-07-09T20:27:33-07:00
New Revision: 00c9a504aeed2603bd8bc9b89d753534e929c8e8
URL:
https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8
DIFF:
https://github.com/llvm/llvm-project/commit/00c9a504aeed2603bd8bc9b89d753534e929c8e8.diff
L
Author: JF Bastien
Date: 2020-06-26T13:48:51-07:00
New Revision: b10bd6dfc62161671892b2dd3be5152754d14995
URL:
https://github.com/llvm/llvm-project/commit/b10bd6dfc62161671892b2dd3be5152754d14995
DIFF:
https://github.com/llvm/llvm-project/commit/b10bd6dfc62161671892b2dd3be5152754d14995.diff
LO
Author: JF Bastien
Date: 2020-06-26T12:58:17-07:00
New Revision: 13fdcd37b325f62ff2513c59807de9ad0a9d2a51
URL:
https://github.com/llvm/llvm-project/commit/13fdcd37b325f62ff2513c59807de9ad0a9d2a51
DIFF:
https://github.com/llvm/llvm-project/commit/13fdcd37b325f62ff2513c59807de9ad0a9d2a51.diff
LO
Author: jfb
Date: Wed Aug 14 15:48:12 2019
New Revision: 368939
URL: http://llvm.org/viewvc/llvm-project?rev=368939&view=rev
Log:
Remove LVALUE / RVALUE workarounds
Summary: LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION shouldn't be
needed anymore because the minimum compiler versions
1/builders/clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio>
>>
>> Warning, treated as error:
>> /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:995:
>> WARNING: unknown option: -Wno-c++98-compat
>>
>>
Author: jfb
Date: Mon Aug 5 12:59:07 2019
New Revision: 367918
URL: http://llvm.org/viewvc/llvm-project?rev=367918&view=rev
Log:
[docs] don't use :option: for Wall Wextra
The bots are sad that they're not documented.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersMa
clang-sphinx-docs/builds/45204/steps/docs-clang-html/logs/stdio>
>
> Warning, treated as error:
> /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/src/tools/clang/docs/UsersManual.rst:995:
> WARNING: unknown option: -Wno-c++98-compat
>
> On Mon, Aug 5, 2019 at 12:52 PM JF
Author: jfb
Date: Mon Aug 5 12:45:23 2019
New Revision: 367914
URL: http://llvm.org/viewvc/llvm-project?rev=367914&view=rev
Log:
[docs] don't use :option: for C++ compat
The bots are sad that they're not documented.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersMan
Author: jfb
Date: Mon Aug 5 09:53:45 2019
New Revision: 367889
URL: http://llvm.org/viewvc/llvm-project?rev=367889&view=rev
Log:
[docs] document -Weveything more betterer
Reviewers: aaron.ballman
Subscribers: jkorous, dexonsmith, cfe-commits
Tags: #clang
Differential Revision: https://reviews
Author: jfb
Date: Tue Jul 30 20:22:08 2019
New Revision: 367383
URL: http://llvm.org/viewvc/llvm-project?rev=367383&view=rev
Log:
[NFC] Remove LLVM_ALIGNAS
Summary: The minimum compilers support all have alignas, and we don't use
LLVM_ALIGNAS anywhere anymore. This also removes an MSVC diagnosti
Author: jfb
Date: Tue Jul 30 20:22:08 2019
New Revision: 367383
URL: http://llvm.org/viewvc/llvm-project?rev=367383&view=rev
Log:
[NFC] Remove LLVM_ALIGNAS
Summary: The minimum compilers support all have alignas, and we don't use
LLVM_ALIGNAS anywhere anymore. This also removes an MSVC diagnosti
Author: jfb
Date: Tue Jul 30 13:01:46 2019
New Revision: 367350
URL: http://llvm.org/viewvc/llvm-project?rev=367350&view=rev
Log:
[NFC] simplify Darwin environment handling
The previous code detected conflicts through copy-pasta, this versions
uses a 'loop'.
Modified:
cfe/trunk/lib/Driver/To
Author: jfb
Date: Mon Jul 29 16:28:44 2019
New Revision: 367276
URL: http://llvm.org/viewvc/llvm-project?rev=367276&view=rev
Log:
Fix Linux build
r367274 broke it
Modified:
cfe/trunk/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp
Modified: cfe/trunk/lib/DirectoryWatcher/linux/Directo
Author: jfb
Date: Mon Jul 29 16:12:48 2019
New Revision: 367274
URL: http://llvm.org/viewvc/llvm-project?rev=367274&view=rev
Log:
[NFC] avoid AlignedCharArray in clang
As discussed in D65249, don't use AlignedCharArray or std::aligned_storage.
Just use alignas(X) char Buf[Size];. This will allow
Author: jfb
Date: Thu Jul 25 13:50:09 2019
New Revision: 367051
URL: http://llvm.org/viewvc/llvm-project?rev=367051&view=rev
Log:
Revert "CodeGen: ensure placeholder instruction for cleanup is created"
Originally in https://reviews.llvm.org/D64656
Causes bot failures:
/home/buildslave/buildslav
Author: jfb
Date: Thu Jul 25 09:11:57 2019
New Revision: 367032
URL: http://llvm.org/viewvc/llvm-project?rev=367032&view=rev
Log:
Allow prefetching from non-zero address spaces
Summary:
This is useful for targets which have prefetch instructions for non-default
address spaces.
Subscribers: ne
Author: jfb
Date: Sun Jul 14 11:33:51 2019
New Revision: 366028
URL: http://llvm.org/viewvc/llvm-project?rev=366028&view=rev
Log:
Support __seg_fs and __seg_gs on x86
Summary:
GCC supports named address spaces macros:
https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spaces.html
clang does as w
reeImpl::anchor();
> template <> void CFGDominatorTreeImpl::anchor();
>
> Clang will tell you to do this under -Wundefined-func-template (which we
> haven't turned on by default because people get this wrong too often...).
>
> On Mon, 8 Jul 2019 at 12:29, JF Bastien via cfe
Kristof,
It looks like your fix didn’t address all the bots:
/Users/buildslave/jenkins/workspace/clang-stage2-coverage-R/llvm/tools/clang/lib/Analysis/Dominators.cpp:14:48:
error: explicit specialization of 'anchor' after instantiation
void CFGDominatorTreeImpl::anchor() {}
Author: jfb
Date: Mon Jul 1 14:57:31 2019
New Revision: 364855
URL: http://llvm.org/viewvc/llvm-project?rev=364855&view=rev
Log:
Fix breakage introduced by D60974
D60974 added tests which incorrectly assume that llvm-readelf is available.
This is a bad assumption, it should instead declare the
Author: jfb
Date: Wed Jun 26 12:50:12 2019
New Revision: 364464
URL: http://llvm.org/viewvc/llvm-project?rev=364464&view=rev
Log:
BitStream reader: propagate errors
The bitstream reader handles errors poorly. This has two effects:
* Bugs in file handling (especially modules) manifest as an "une
Author: jfb
Date: Wed Jun 26 12:50:12 2019
New Revision: 364464
URL: http://llvm.org/viewvc/llvm-project?rev=364464&view=rev
Log:
BitStream reader: propagate errors
The bitstream reader handles errors poorly. This has two effects:
* Bugs in file handling (especially modules) manifest as an "une
Author: jfb
Date: Tue Apr 30 16:27:28 2019
New Revision: 359636
URL: http://llvm.org/viewvc/llvm-project?rev=359636&view=rev
Log:
Fix auto-init test
r359628 changed the initialization of padding to follow C, but I didn't update
the C++ tests.
Modified:
cfe/trunk/test/CodeGenCXX/auto-var-ini
Author: jfb
Date: Tue Apr 30 15:56:53 2019
New Revision: 359628
URL: http://llvm.org/viewvc/llvm-project?rev=359628&view=rev
Log:
Variable auto-init: don't initialize aggregate padding of all aggregates
Summary:
C guarantees that brace-init with fewer initializers than members in the
aggregate wi
Author: jfb
Date: Mon Apr 29 17:19:43 2019
New Revision: 359524
URL: http://llvm.org/viewvc/llvm-project?rev=359524&view=rev
Log:
[NFC] typo
Modified:
cfe/trunk/lib/Sema/Sema.cpp
Modified: cfe/trunk/lib/Sema/Sema.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/Sema.cpp?rev=3
Author: jfb
Date: Mon Apr 29 17:11:53 2019
New Revision: 359523
URL: http://llvm.org/viewvc/llvm-project?rev=359523&view=rev
Log:
[NFC] typo
Modified:
cfe/trunk/include/clang/AST/ASTContext.h
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/include/clang/AST/ASTContext.h
URL:
http:/
Author: jfb
Date: Thu Apr 11 17:11:27 2019
New Revision: 358243
URL: http://llvm.org/viewvc/llvm-project?rev=358243&view=rev
Log:
Variable auto-init: also auto-init alloca
Summary:
alloca isn’t auto-init’d right now because it’s a different path in clang that
all the other stuff we support (it’s
Author: jfb
Date: Mon Mar 25 13:06:32 2019
New Revision: 356940
URL: http://llvm.org/viewvc/llvm-project?rev=356940&view=rev
Log:
Thread Safety: also look at ObjC methods
Summary:
SExprBuilder::translateDeclRefExpr was only looking at FunctionDecl and not
also looking at ObjCMethodDecl. It shoul
Author: jfb
Date: Thu Mar 7 17:26:49 2019
New Revision: 355660
URL: http://llvm.org/viewvc/llvm-project?rev=355660&view=rev
Log:
Variable auto-init: split out small arrays
Summary: Following up with r355181, initialize small arrays as well.
LLVM stage2 shows a tiny size gain.
Reviewers: glid
Author: jfb
Date: Wed Mar 6 12:36:00 2019
New Revision: 355547
URL: http://llvm.org/viewvc/llvm-project?rev=355547&view=rev
Log:
Passthrough compiler launcher
Summary: Not having this seems like an oversight, and makes stage2 builds odd.
Reviewers: ddunbar, dexonsmith
Subscribers: mgorny, jkor
Author: jfb
Date: Mon Feb 25 15:09:34 2019
New Revision: 354831
URL: http://llvm.org/viewvc/llvm-project?rev=354831&view=rev
Log:
[NFC] Reorder some mis-ordered tests
I somehow had misaligned some of the tests when I originally wrote this.
Re-order them properly.
Modified:
cfe/trunk/test/Co
Author: jfb
Date: Fri Feb 15 09:26:29 2019
New Revision: 354147
URL: http://llvm.org/viewvc/llvm-project?rev=354147&view=rev
Log:
Variable auto-init of blocks capturing self after init bugfix
Summary:
Blocks that capture themselves (and escape) after initialization currently
codegen wrong becaus
Author: jfb
Date: Tue Feb 12 12:19:16 2019
New Revision: 353875
URL: http://llvm.org/viewvc/llvm-project?rev=353875&view=rev
Log:
[NFC] typo
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/c
Author: jfb
Date: Thu Feb 7 17:29:17 2019
New Revision: 353495
URL: http://llvm.org/viewvc/llvm-project?rev=353495&view=rev
Log:
Variable auto-init: fix __block initialization
Summary:
Automatic initialization [1] of __block variables was trampling over the block's
headers after they'd been init
Author: jfb
Date: Thu Feb 7 16:51:05 2019
New Revision: 353490
URL: http://llvm.org/viewvc/llvm-project?rev=353490&view=rev
Log:
[NFC] Variable auto-init: use getAsVariableArrayType helper
As suggested by @rjmccall in D57797.
Modified:
cfe/trunk/lib/CodeGen/CGDecl.cpp
Modified: cfe/trunk/l
Author: jfb
Date: Tue Jan 8 10:51:38 2019
New Revision: 350644
URL: http://llvm.org/viewvc/llvm-project?rev=350644&view=rev
Log:
[NFC] Don't over-eagerly check block alignment
Alignment of __block isn't relevant to this test, remove its checking.
Modified:
cfe/trunk/test/CodeGenCXX/trivial-
Author: jfb
Date: Mon Dec 17 21:12:21 2018
New Revision: 349442
URL: http://llvm.org/viewvc/llvm-project?rev=349442&view=rev
Log:
Automatic variable initialization
Summary:
Add an option to initialize automatic variables with either a pattern or with
zeroes. The default is still that automatic va
Author: jfb
Date: Wed Nov 14 16:19:18 2018
New Revision: 346915
URL: http://llvm.org/viewvc/llvm-project?rev=346915&view=rev
Log:
CGDecl::emitStoresForConstant fix synthesized constant's name
Summary: The name of the synthesized constants for constant initialization was
using mangling for static
Author: jfb
Date: Fri Sep 21 10:38:41 2018
New Revision: 342750
URL: http://llvm.org/viewvc/llvm-project?rev=342750&view=rev
Log:
[NFC] remove unused variable
It was causing a warning.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
UR
Author: jfb
Date: Fri Sep 21 06:54:09 2018
New Revision: 342734
URL: http://llvm.org/viewvc/llvm-project?rev=342734&view=rev
Log:
NFC: deduplicate isRepeatedBytePattern from clang to LLVM's isBytewiseValue
Summary:
This code was in CGDecl.cpp and really belongs in LLVM. It happened to have
isByt
Author: jfb
Date: Mon Sep 10 13:42:56 2018
New Revision: 341860
URL: http://llvm.org/viewvc/llvm-project?rev=341860&view=rev
Log:
Implement -Watomic-implicit-seq-cst
Summary:
_Atomic and __sync_* operations are implicitly sequentially-consistent. Some
codebases want to force explicit usage of mem
Author: jfb
Date: Wed Aug 22 21:09:49 2018
New Revision: 340511
URL: http://llvm.org/viewvc/llvm-project?rev=340511&view=rev
Log:
Missing quote in previous commit
The test was failing because I missed a quote.
Modified:
cfe/trunk/test/CodeGen/pr18235.c
Modified: cfe/trunk/test/CodeGen/pr182
Author: jfb
Date: Wed Aug 22 20:55:24 2018
New Revision: 340510
URL: http://llvm.org/viewvc/llvm-project?rev=340510&view=rev
Log:
Improve incompatible triple error
When complaining that the triple is incompatible with all targets, print out
the triple not just a generic error about triples not m
Author: jfb
Date: Wed Aug 8 10:05:17 2018
New Revision: 339273
URL: http://llvm.org/viewvc/llvm-project?rev=339273&view=rev
Log:
CDDecl More automatic variable tail padding test
Test tail padded automatic variable at different width, because they encounter
different codegen.
Modified:
cfe/
Author: jfb
Date: Tue Aug 7 15:43:44 2018
New Revision: 339196
URL: http://llvm.org/viewvc/llvm-project?rev=339196&view=rev
Log:
[NFC] Improve auto-var-init alignment check
We're not actually testing for alignment, we just want to know that whatever
incoming alignment got propagated. Do that by
Author: jfb
Date: Tue Aug 7 14:55:13 2018
New Revision: 339191
URL: http://llvm.org/viewvc/llvm-project?rev=339191&view=rev
Log:
[NFC] CGDecl factor out constant emission
The code is cleaner this way, and with some changes I'm playing with it makes
sense to split it out so we can reuse it.
Mod
Author: jfb
Date: Mon Aug 6 21:44:13 2018
New Revision: 339093
URL: http://llvm.org/viewvc/llvm-project?rev=339093&view=rev
Log:
Auto var init test fix #2
It turns out that the AVX bots have different alignment for their vectors, and
my test mistakenly assumed a particular vector alignent on th
Author: jfb
Date: Mon Aug 6 21:03:03 2018
New Revision: 339090
URL: http://llvm.org/viewvc/llvm-project?rev=339090&view=rev
Log:
Remove broken command flag
I was using it for testing, r339089 shouldn't have contained it.
Modified:
cfe/trunk/test/CodeGenCXX/auto-var-init.cpp
Modified: cfe/t
Author: jfb
Date: Mon Aug 6 20:12:52 2018
New Revision: 339089
URL: http://llvm.org/viewvc/llvm-project?rev=339089&view=rev
Log:
[NFC] Test automatic variable initialization
Summary:
r337887 started using memset for automatic variable initialization where
sensible. A follow-up discussion leads
Author: jfb
Date: Thu Aug 2 10:35:46 2018
New Revision: 338743
URL: http://llvm.org/viewvc/llvm-project?rev=338743&view=rev
Log:
__c11_atomic_load's _Atomic can be const
Summary:
C++11 onwards specs the non-member functions atomic_load and
atomic_load_explicit as taking the atomic by const (pot
Author: jfb
Date: Tue Jul 24 21:29:03 2018
New Revision: 337887
URL: http://llvm.org/viewvc/llvm-project?rev=337887&view=rev
Log:
CodeGen: use non-zero memset when possible for automatic variables
Summary:
Right now automatic variables are either initialized with bzero followed by a
few stores,
Author: jfb
Date: Fri Jul 20 16:37:12 2018
New Revision: 337636
URL: http://llvm.org/viewvc/llvm-project?rev=337636&view=rev
Log:
[NFC] CodeGen: rename memset to bzero
The optimization looks for opportunities to emit bzero, not memset. Rename the
functions accordingly (and clang-format the diff)
Author: jfb
Date: Wed Jul 18 11:01:41 2018
New Revision: 337410
URL: http://llvm.org/viewvc/llvm-project?rev=337410&view=rev
Log:
Support implicit _Atomic struct load / store
Summary:
Using _Atomic to do implicit load / store is just a seq_cst atomic_load /
atomic_store. Stores currently assert
Author: jfb
Date: Fri Jul 13 13:33:23 2018
New Revision: 337041
URL: http://llvm.org/viewvc/llvm-project?rev=337041&view=rev
Log:
CodeGen: specify alignment + inbounds for automatic variable initialization
Summary: Automatic variable initialization was generating default-aligned
stores (which ar
Author: jfb
Date: Wed Jul 11 12:51:40 2018
New Revision: 336840
URL: http://llvm.org/viewvc/llvm-project?rev=336840&view=rev
Log:
[NFC] typo
Modified:
cfe/trunk/lib/CodeGen/ConstantEmitter.h
Modified: cfe/trunk/lib/CodeGen/ConstantEmitter.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk
Author: jfb
Date: Fri Jun 22 14:54:40 2018
New Revision: 335393
URL: http://llvm.org/viewvc/llvm-project?rev=335393&view=rev
Log:
[Sema] -Wformat-pedantic only for NSInteger/NSUInteger %zu/%zi on Darwin
Summary:
Pick D42933 back up, and make NSInteger/NSUInteger with %zu/%zi specifiers on
Darwin
Author: jfb
Date: Fri Jun 1 11:02:53 2018
New Revision: 333776
URL: http://llvm.org/viewvc/llvm-project?rev=333776&view=rev
Log:
Mark __c11_atomic_load as const
Summary:
C++11 onwards specs the non-member functions atomic_load and
atomic_load_explicit as taking the atomic by const (potentially
Author: jfb
Date: Thu May 31 21:59:48 2018
New Revision: 333723
URL: http://llvm.org/viewvc/llvm-project?rev=333723&view=rev
Log:
Filesystem tests: un-confuse write time
Summary:
The filesystem test was confused about access versus write / modification time.
The spec says:
file_time_type last
Author: jfb
Date: Tue May 29 16:28:04 2018
New Revision: 333479
URL: http://llvm.org/viewvc/llvm-project?rev=333479&view=rev
Log:
Mark deduction guide tests as failing on apple-clang-9
As discussed here: http://lists.llvm.org/pipermail/cfe-dev/2018-May/058116.html
The tests fail on clang-5, as we
26, 2018, at 12:50 PM, JF Bastien via cfe-commits
> wrote:
>
>
>
>> On May 26, 2018, at 12:36 PM, Marshall Clow > <mailto:mclow.li...@gmail.com>> wrote:
>>
>>
>>
>> On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits
>> ma
> On May 26, 2018, at 12:36 PM, Marshall Clow wrote:
>
>
>
> On Fri, May 25, 2018 at 4:43 PM, JF Bastien via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: jfb
> Date: Fri May 25 16:43:53 2018
> New Revision: 25
>
> URL:
Author: jfb
Date: Sat May 26 12:44:45 2018
New Revision: 51
URL: http://llvm.org/viewvc/llvm-project?rev=51&view=rev
Log:
Revert "Add nonnull; use it for atomics"
That's r25, as well as follow-up "Fix GCC handling of ATOMIC_VAR_INIT"
r27.
Marshall asked to revert:
Let's have a d
Author: jfb
Date: Fri May 25 17:13:53 2018
New Revision: 27
URL: http://llvm.org/viewvc/llvm-project?rev=27&view=rev
Log:
Fix GCC handling of ATOMIC_VAR_INIT
r25 from D47225 added warning checks, and the test was written to be C++11
correct by using ATOMIC_VAR_INIT (note that the com
Author: jfb
Date: Fri May 25 16:43:53 2018
New Revision: 25
URL: http://llvm.org/viewvc/llvm-project?rev=25&view=rev
Log:
Add nonnull; use it for atomics
Summary:
The atomic non-member functions accept pointers to std::atomic /
std::atomic_flag as well as to the non-atomic value. These a
Author: jfb
Date: Fri May 25 14:32:27 2018
New Revision: 17
URL: http://llvm.org/viewvc/llvm-project?rev=17&view=rev
Log:
Fix optional test breakage
It seems GCC and clang disagree. Talked to mclow on IRC, disabling for now.
Modified:
libcxx/trunk/test/std/utilities/optional/optiona
Author: jfb
Date: Fri May 25 14:17:43 2018
New Revision: 15
URL: http://llvm.org/viewvc/llvm-project?rev=15&view=rev
Log:
Fix array deduction guide test breakage
No matching constructor
Modified:
libcxx/trunk/test/std/containers/sequences/array/array.cons/deduct.pass.cpp
Modified:
Author: jfb
Date: Fri May 25 13:43:57 2018
New Revision: 08
URL: http://llvm.org/viewvc/llvm-project?rev=08&view=rev
Log:
Fix optional deduction guide test breakage
Modified:
libcxx/trunk/test/std/utilities/optional/optional.object/optional.object.ctor/deduct.fail.cpp
libcxx/tru
Author: jfb
Date: Fri May 25 10:36:49 2018
New Revision: 333290
URL: http://llvm.org/viewvc/llvm-project?rev=333290&view=rev
Log:
Follow-up fix for nonnull atomic non-member functions
Handling of the third parameter was only checking for *_n and not for the C11
variant, which means that cmpxchg
Author: jfb
Date: Thu May 24 17:07:09 2018
New Revision: 333246
URL: http://llvm.org/viewvc/llvm-project?rev=333246&view=rev
Log:
Make atomic non-member functions as nonnull
Summary:
As a companion to libc++ patch https://reviews.llvm.org/D47225, mark builtin
atomic non-member functions which ac
Author: jfb
Date: Fri May 18 21:21:26 2018
New Revision: 332801
URL: http://llvm.org/viewvc/llvm-project?rev=332801&view=rev
Log:
CodeGen: block capture shouldn't ICE
When a lambda capture captures a __block in the same statement, the compiler
asserts out because isCapturedBy assumes that an Exp
> On May 9, 2018, at 1:25 PM, Shoaib Meenai via Phabricator
> wrote:
>
> smeenai added a comment.
>
> Yeah, I think we all agree now that a portability warning isn't really
> tractable. Note that even for the warnings that motivated this diff, they
> should have only fired if `size_t` and N
Author: jfb
Date: Tue May 8 20:51:12 2018
New Revision: 331845
URL: http://llvm.org/viewvc/llvm-project?rev=331845&view=rev
Log:
_Atomic of empty struct shouldn't assert
Summary:
An _Atomic of an empty struct is pretty silly. In general we just widen empty
structs to hold a byte's worth of stor
jfb added a comment.
Warnings look correct. Could they be made more useful by suggesting that
`acq_rel` be `acquire` instead, and `release` be `relaxed` instead?
https://reviews.llvm.org/D22711
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
jfb added a comment.
I wrote a quick test, and I think this is technically OK for x86 because
alignment "Just Works", but I think it's borked on GCC+ARM (I don't have a
system to test that here):
https://github.com/jfbastien/atomic_nullptr/blob/master/atomic_nullptr.cc
https://reviews.llvm.or
jfb added a comment.
@EricWF ran this on configuration `cxx_under_test=g++-4.9`. It generates the
following error:
libcxx/test/libcxx/atomics/atomics.align/align.pass.sh.cpp:32:
atomic_test::atomic_test() [with T = std::nullptr_t]: Assertion
`alignof(this->__a_) >= sizeof(this->__a_) && "exp
jfb created this revision.
jfb added a reviewer: EricWF.
jfb added a subscriber: cfe-commits.
The ABI version flag should fix the error.
https://reviews.llvm.org/D23041
Files:
test/libcxx/atomics/atomics.align/align.pass.sh.cpp
test/libcxx/test/config.py
Index: test/libcxx/test/config.py
==
Author: jfb
Date: Mon Aug 1 18:34:29 2016
New Revision: 277404
URL: http://llvm.org/viewvc/llvm-project?rev=277404&view=rev
Log:
NFC: fix typo
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config.py
URL:
http://llvm.org/viewvc/llvm-project/libcxx
I don't think I can:
- Hack around __gcc_atomic_t.
- Unconditionally pass -fabi-version=6 to the RUN command (because LLVM
won't accept it).
it seems like changing test/libcxx/test/config.py would be better.
WDYT?
On Mon, Aug 1, 2016 at 1:28 PM, JF Bastien via cfe-com
Author: jfb
Date: Mon Aug 1 15:28:13 2016
New Revision: 277380
URL: http://llvm.org/viewvc/llvm-project?rev=277380&view=rev
Log:
atomics.align: XFAIL GCC
It currently fails because GCC changed the mangling of templates, which affects
std::atomic using __attribute__((vector(X))). The bot using G
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277368: libc++: test lock-free atomic alignment (authored by
jfb).
Changed prior to commit:
https://reviews.llvm.org/D22073?vs=66342&id=66356#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22073
Author: jfb
Date: Mon Aug 1 14:27:08 2016
New Revision: 277368
URL: http://llvm.org/viewvc/llvm-project?rev=277368&view=rev
Log:
libc++: test lock-free atomic alignment
Summary:
libc++ implements std::atomic<_Tp> using __atomic_base<_Tp> with
`mutable _Atomic(_Tp) __a_`. That member must be suit
jfb added a comment.
In https://reviews.llvm.org/D22073#486636, @EricWF wrote:
> OK, IMO the way to handle this test is to have it manually link `-latomic`.
> This can be done by renaming the test to `.sh.cpp` and adding the
> following lines:
>
> // REQUIRES: libatomic
> // RUN: %build -la
jfb updated this revision to Diff 66342.
jfb added a comment.
- Move atomics.align to libcxx-specific
- Give names to anonymous structs
- Rename test, use REQUIRES / RUN commands
https://reviews.llvm.org/D22073
Files:
test/libcxx/atomics/atomics.align/align.pass.sh.cpp
Index: test/libcxx/ato
On Jul 22, 2016 4:45 PM, "Eric Fiselier" wrote:
>
> EricWF added inline comments.
>
>
> Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:87
> @@ +86,3 @@
> +x.compare_exchange_weak(val1, val2, std::memory_order_release);
> +}
> +{
> --
jfb added inline comments.
Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:87
@@ +86,3 @@
+x.compare_exchange_weak(val1, val2, std::memory_order_release);
+}
+{
That's not quite true: the failure ordering is auto-deduced from
Author: jfb
Date: Thu Jul 21 12:34:28 2016
New Revision: 276309
URL: http://llvm.org/viewvc/llvm-project?rev=276309&view=rev
Log:
Remove FIXME for feature test macro
The value I'd picked was correct, as per the recently published SG10 paper
http://wg21.link/p0096r3
Modified:
libcxx/trunk/in
jfb added a comment.
Two comments, then lgtm.
Comment at: include/atomic:581
@@ +580,3 @@
+ || __f == memory_order_acq_rel, ""))) \
+__attribute__ ((__unavailable__("memory order argument to atomic operation
is invalid")))
+#endif
jfb added inline comments.
Comment at: include/atomic:569
@@ +568,3 @@
+__attribute__ ((__enable_if__(__m == memory_order_release \
+ || __m == memory_order_acq_rel, ""))) \
+__attribute__ ((__unavailable__("memory ord
jfb added a subscriber: jfb.
jfb added a comment.
Awesome, thanks for doing this!
Should this be a warning or an error?
Comment at: include/atomic:581
@@ +580,3 @@
+ || __f == memory_order_acq_rel, ""))) \
+__attribute__ ((__unavailabl
Author: jfb
Date: Tue Jul 12 15:14:52 2016
New Revision: 275210
URL: http://llvm.org/viewvc/llvm-project?rev=275210&view=rev
Log:
libc++: name anonymous structs
As discussed in http://reviews.llvm.org/D22073
Modified:
libcxx/trunk/test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp
jfb added a comment.
In http://reviews.llvm.org/D22073#481402, @EricWF wrote:
> - The test should be moved to `test/libcxx/atomics/atomics.align` since it's
> libc++ specific.
Done.
> - Please give the anonymous struct declarations unique names. `T1`, `T2`,
> ..., `TN` is fine. Currently the
jfb updated this revision to Diff 63723.
jfb added a comment.
- Move atomics.align to libcxx-specific
- Give names to anonymous structs
http://reviews.llvm.org/D22073
Files:
test/libcxx/atomics/atomics.align/align.pass.cpp
Index: test/libcxx/atomics/atomics.align/align.pass.cpp
=
jfb created this revision.
jfb added a reviewer: cfe-commits.
libc++ implements std::atomic<_Tp> using __atomic_base<_Tp> with
`mutable _Atomic(_Tp) __a_`. That member must be suitably aligned on
relevant ISAs for instructions such as cmpxchg to work properly, but
this alignment isn't checked anyw
jfb accepted this revision.
jfb added a reviewer: jfb.
jfb added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
jfb added inline comments.
Comment at: lib/Transforms/IPO/MergeFunctions.cpp:147
@@ -146,3 +146,3 @@
struct Config : ValueMapConfig {
-enum { FollowRAUW = false };
+enum { FollowRAUW = 0 };
};
This change should go to ValueMap, I think it should be m
jfb added a subscriber: pcc.
jfb added a comment.
> I guess there's a more general issue here which is that LLVM appears to be
> more permissive about prototype mismatch than wasm. Specifically, I'm
> thinking about how swifterror relies on being able to pass extra parameters
> to a function th
jfb added a comment.
@t.p.northover: would an acceptable solution be to add a new trait such as
`CGM.getCXXABI().CanCallMismatchedFunctionType()` or something of the sort? ARM
would set it to true, wasm to false.
http://reviews.llvm.org/D19275
___
1 - 100 of 164 matches
Mail list logo
