jfb added inline comments.

================
Comment at: test/libcxx/atomics/diagnose_invalid_memory_order.fail.cpp:87
@@ +86,3 @@
+        x.compare_exchange_weak(val1, val2, std::memory_order_release);
+    }
+    {
----------------
That's not quite true: the failure ordering is auto-deduced from the success 
one, but it's not necessarily the same! The spec says all success is valid, so 
the auto-mapping has to ensure that all failures are also valid. That's what 
I'm trying to have you test: that the auto-mapping is always valid as well.


https://reviews.llvm.org/D22557



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to