hanhanW wrote:
> > I think they will become something like:
> > ```c++
> > llvmFunc->addFnAttr("nvvm.maxntid", llvm::utostr(workgroupSize[0]));
> > llvmFunc->addFnAttr("nvvm.maxntid", llvm::utostr(workgroupSize[1]));
> > llvmFunc->addFnAttr("nvvm.maxntid", llvm::utostr(workgroupSize[2]));
> > ```
hanhanW wrote:
Thanks for the heads-up! We do have few cases like:
```cpp
setMetadataValueI32("maxntidx", workgroupSize[0]);
setMetadataValueI32("maxntidy", workgroupSize[1]);
setMetadataValueI32("maxntidz", workgroupSize[2]);
https://github.com/llvm/llvm-project/p
https://github.com/hanhanW closed
https://github.com/llvm/llvm-project/pull/77409
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hanhanW updated
https://github.com/llvm/llvm-project/pull/77409
>From e74b859897cdf1b1effbbd48a4e5376a231f7132 Mon Sep 17 00:00:00 2001
From: hanhanW
Date: Mon, 8 Jan 2024 20:17:30 -0800
Subject: [PATCH 1/2] [mlir][tensor] Enhance pack/unpack simplication patterns
for identi
hanhanW wrote:
> I am curious though, what do you mean by more powerful expand_shape op?
> Wouldn't that just be exactly reshape? We don't need a more powerful
> expand_shape to cover all the cases you mention above.
That could be tensor.reshape, but I don't see a scenario about using it. To b
hanhanW wrote:
I'm -1 on using `tensor.reshape` op. IMO, we should only use
tensor.expand/collapse_shape; they work much better with existing
transformations.
Out of curiosity, what use case do you have in mind? Why do we lower fully
dynamic pack op? If it is at high level graph level, we can
https://github.com/hanhanW closed
https://github.com/llvm/llvm-project/pull/75410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hanhanW updated
https://github.com/llvm/llvm-project/pull/75410
>From c07f7e1c5c6f8bbc7189e96096004d39a0a1aa3f Mon Sep 17 00:00:00 2001
From: hanhanW
Date: Wed, 13 Dec 2023 15:59:48 -0800
Subject: [PATCH 1/3] [mlir][TilingInterface] Early return cloned ops if tile
sizes are
@@ -362,14 +362,20 @@ mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter,
TilingInterface op,
auto clonedOp = cast(
cloneOpAndUpdateDestinationArgs(rewriter, op, clonedOpDestination));
- // 5b. Tile the cloned operation.
+ // 5b. Early return cloned op if tiling is
@@ -362,14 +362,20 @@ mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter,
TilingInterface op,
auto clonedOp = cast(
cloneOpAndUpdateDestinationArgs(rewriter, op, clonedOpDestination));
- // 5b. Tile the cloned operation.
+ // 5b. Early return cloned op if tiling is
@@ -362,14 +362,20 @@ mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter,
TilingInterface op,
auto clonedOp = cast(
cloneOpAndUpdateDestinationArgs(rewriter, op, clonedOpDestination));
- // 5b. Tile the cloned operation.
+ // 5b. Early return cloned op if tiling is
https://github.com/hanhanW updated
https://github.com/llvm/llvm-project/pull/75410
>From c07f7e1c5c6f8bbc7189e96096004d39a0a1aa3f Mon Sep 17 00:00:00 2001
From: hanhanW
Date: Wed, 13 Dec 2023 15:59:48 -0800
Subject: [PATCH 1/2] [mlir][TilingInterface] Early return cloned ops if tile
sizes are
@@ -362,14 +362,21 @@ mlir::scf::tileUsingSCFForOp(RewriterBase &rewriter,
TilingInterface op,
auto clonedOp = cast(
cloneOpAndUpdateDestinationArgs(rewriter, op, clonedOpDestination));
- // 5b. Tile the cloned operation.
+ // 5b. Early return cloned op if tiling is
https://github.com/hanhanW closed
https://github.com/llvm/llvm-project/pull/68941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hanhanW wrote:
thanks for the review!
https://github.com/llvm/llvm-project/pull/68941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hanhanW edited
https://github.com/llvm/llvm-project/pull/68941
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -233,6 +233,52 @@ def CmpIExtUI :
CPred<"$0.getValue() == arith::CmpIPredicate::eq || "
"$0.getValue() == arith::CmpIPredicate::ne">> $pred)]>;
+//===--===//
+// SelectOp
+//==
https://github.com/hanhanW updated
https://github.com/llvm/llvm-project/pull/68941
>From 877111a139b2f01037fdbe7c0cb120a2f4e64562 Mon Sep 17 00:00:00 2001
From: hanhanW
Date: Thu, 12 Oct 2023 17:14:29 -0700
Subject: [PATCH 1/2] Reland "[mlir][arith] Canonicalization patterns for
`arith.select`
18 matches
Mail list logo
