[PATCH] D96884: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG529f71811b04: [flang][driver] Add debug measure-parse-tree and pre-fir-tree options (authored by FarisRehman). Repository: rG LLVM Github Monorepo

[PATCH] D96884: [flang][driver] Add more -fdebug options

FarisRehman updated this revision to Diff 324926. FarisRehman added a comment. Remove -fdebug-parsing-log Remove `-fdebug-parsing-log` from this patch as it requires additional work that can be implemented in a separate patch. Also address review comments by @awarzynski Repository: rG LLVM G

[PATCH] D96884: [flang][driver] Add more -fdebug options

FarisRehman updated this revision to Diff 324590. FarisRehman added a comment. Rebase off main Rebase off main and add a comment to MeasurementVisitor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96884/new/ https://reviews.llvm.org/D96884 Files

[PATCH] D96716: [flang][driver] Add debug dump options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bd08dab5ff9: [flang][driver] Add debug dump options (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.org/D96716?vs=324352

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added a comment. In D96716#2569594 , @awarzynski wrote: > We need `%f18` to be replaced with `%flang_fc1`, but we don't need > `-fsyntax-only`, right? Makes sense thanks, I'll remove before committing. Repository: rG LLVM Github Monorepo

[PATCH] D96884: [flang][driver] Add more -fdebug options

FarisRehman created this revision. Herald added subscribers: jansvoboda11, dang, mgorny. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Heral

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added a comment. In D96716#2569102 , @awarzynski wrote: > This patch doesn't require the tests to be updated, does it? They do require updating as `-fdebug-dump-symbol` is otherwise not tested by the new driver in this patch. Repository:

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; FarisRehman wrote: > awarzynski wrote: > > Do we need to expose it? Shouldn't this be private? > It will not compile if th

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman updated this revision to Diff 324352. FarisRehman marked an inline comment as done. FarisRehman added a comment. Make semantics_ private Make semantics_ in PrescanAndSemaAction private, adding semantics() and setSemantics(). Summary of changes: - Add semantics() and setSemantics()

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman added inline comments. Comment at: flang/include/flang/Frontend/FrontendActions.h:54 +public: + std::unique_ptr semantics_; }; awarzynski wrote: > Do we need to expose it? Shouldn't this be private? It will not compile if the variable is private as

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10826ea7b1c1: [flang][driver] Add extension options and -finput-charset (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.o

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman updated this revision to Diff 323938. FarisRehman added a comment. Rebase off main Rebase off main and remove dependency on patch D96344 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96407/new/ https

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman updated this revision to Diff 323929. FarisRehman added a comment. Rebase off main Rebase off main and update some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96716/new/ https://reviews.llvm.org/D96716 Files: clang/inclu

[PATCH] D96483: [flang][driver] Add options for unparsing

FarisRehman accepted this revision. FarisRehman added a comment. This revision is now accepted and ready to land. Thanks for clarifying Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96483/new/ https://reviews.llvm.org/D96483 __

[PATCH] D96716: [flang][driver] Add debug dump options

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D96483: [flang][driver] Add options for unparsing

FarisRehman added a comment. Thanks for working on this @awarzynski Could you please clarify the situation regarding `GetActionKindName` in `FrontendOptions.h` as it is currently not being used anywhere and this patch currently does not update that method with the 2 new cases. Other than that, l

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman added inline comments. Comment at: flang/test/Flang-Driver/implicit-none.f90:10 +! RUN: not %flang-new -fsyntax-only -fimplicit-none %s 2>&1 | FileCheck %s --check-prefix=ALWAYS +! RUN: %flang-new -fsyntax-only -fno-implicit-none %s 2>&1 | FileCheck %s --allow-emp

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman updated this revision to Diff 323717. FarisRehman marked 2 inline comments as done. FarisRehman added a comment. Address review comment This revision addresses a review comment by @awarzynski Summary of changes: - Rebase off the latest D96344 revisi

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

FarisRehman created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commit

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d48a1a53fab: [flang][driver] Add support for -fopenmp and -fopenacc (authored by FarisRehman). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:25-26 Args.AddAllArgs(CmdArgs, {options::OPT_ffixed_form, options::OPT_ffree_form, -options::OPT_ffixed_line_length_EQ}); +options::OPT_

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman updated this revision to Diff 322347. FarisRehman marked 3 inline comments as done. FarisRehman added a comment. Address review comment Address review comment by @awarzynski Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96032/new/ http

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman updated this revision to Diff 322071. FarisRehman added a comment. Rebase off main Rebase off main as patch D95448 , which this patch depends on, has been merged into main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r