[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-11-24 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 389520. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-11-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. In D109372#3099969 , @jrtc27 wrote: > In D109372#3099947 , @edward-jones > wrote: > >> I reverted some of the previous changes I made so that this patch matches >> the spec as curre

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-11-01 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. Herald added subscribers: VincentWu, luke957. I reverted some of the previous changes I made so that this patch matches the spec as currently written - this means it's two attributes again, and the diagnostic messages have been updated a bit too. The two Clang attri

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-10-18 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 380347. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109372/new/ https://reviews.llvm.org/D109372 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticDriverKinds.td clang/in

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-09-23 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 374609. edward-jones added a comment. Herald added a subscriber: achieveartificialintelligence. Changes here: - Merged the separate attributes overlaycall and overlaydata into a single overlay attribute (though I may need to undo this to match the hig

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-09-08 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. In D109372#2987411 , @jrtc27 wrote: > In D109372#2987405 , @MaskRay wrote: > >> The name "overlay" is ambiguous. Even after I ruled out Gentoo Overlay and >> overlayfs, I am thinking

[PATCH] D109372: [RISCV][RFC] Add Clang support for RISC-V overlay system

2021-09-07 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. Herald added subscribers: vkmr, frasercrmck, dexonsmith, dang, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, simoncook, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-cheng,

[PATCH] D81946: [WIP][RISCV] Enable multilib support even without a detected GCC install

2020-06-16 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. edward-jones added reviewers: asb, simoncook, lenary. Herald added subscribers: cfe-commits, evandro, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, MaskRay

[PATCH] D75061: [RISCV] Fix sysroot tests without GCC on RISC-V hosts with GCC

2020-02-25 Thread Edward Jones via Phabricator via cfe-commits
edward-jones accepted this revision. edward-jones added a comment. This revision is now accepted and ready to land. Looks good to me. Clang tests all pass on my local build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75061/new/ https://reviews.l

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

2019-11-22 Thread Edward Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f22fe04a5c: [RISCV] Use compiler-rt if no GCC installation detected (authored by edward-jones). Changed prior to commit: https://reviews.llvm.org/D68407?vs=229284&id=230708#toc Repository: rG LLVM

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

2019-11-14 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 229284. edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation detected". edward-jones added a comment. Added tests that a user can specify a specific ru

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-14 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. If I set `-DCLANG_DEFAULT_RTLIB=compiler-rt` I see the following failure in `clang/test/Driver/cross-linux.c`: /home/ed/work/proj/riscv-testing/llvm/clang/test/Driver/cross-linux.c:62:26: error: CHECK-MULTI32-X86-64: expected string not found in input // CHECK-

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-14 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 229273. edward-jones added a comment. It seems that the option `--rtlib=platform` exists to force the driver to ignore the `-DCLANG_DEFAULT_RTLIB` for testing purposes, so I've added this option to the tests that were broken. These tests now seem to pa

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-14 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. Okay. I'll see if I can find a way to test this when `CLANG_DEFAULT_RTLIB` is set, and then I'll resubmit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407 ___

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-13 Thread Edward Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3289352e6bb9: [RISCV] Use compiler-rt if no GCC installation detected (authored by edward-jones). Changed prior to commit: https://reviews.llvm.org/D68407?vs=228268&id=229121#toc Repository: rG LLVM

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

2019-11-07 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. Okay I've reverted this in rG90ecfa2f5f7f . I'll make improvements and resubmit this for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5889

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-07 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 228268. edward-jones added a comment. I've changed this to always return `ToolChain::UNW_None` from `RISCVToolChain::GetUnwindLibType` now. As a consequence we get the original behaviour of only `-lgcc` being added to the link command. CHANGES SINCE L

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

2019-11-07 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. In D58896#1737113 , @sberg wrote: > But how about literals like `'\x80'` where the promoted value depends on > whether plain `char` is signed or unsigned? If 'char' is signed and index into an array then this will typically

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-07 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. In D68407#1732685 , @lenary wrote: > This patch is looking much better, thanks for updating it. > > Please may you clarify what RISC-V gcc does for `-lgcc`, `-lgcc_s`, > `-lgcc_eh`? Is it different to what gcc does on other t

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

2019-11-07 Thread Edward Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7adab7719e55: [Sema] Suppress -Wchar-subscripts if the index is a literal char (authored by edward-jones). Herald added a subscriber: simoncook. Changed prior to commit: https://reviews.llvm.org/D58896?

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

2019-11-07 Thread Edward Jones via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGde61aa3118b9: [RISCV] Improve sysroot computation if no GCC install detected (authored by edward-jones). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. In D68407#1709235 , @lenary wrote: > Please can you add a test for riscv32 and riscv64 without libgcc? I'm not sure what you mean here; I believe the existing tests already cover riscv{32,64} without libgcc. CHANGES SINCE

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-11-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 227722. edward-jones retitled this revision from "[RISCV] Use compiler-rt if no GCC installation detected" to "[WIP][RISCV] Use compiler-rt if no GCC installation detected". edward-jones edited the summary of this revision. edward-jones added a comment.

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

2019-11-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 227721. edward-jones added a comment. Rebased, added a comment to explain that this is using the user provided triple instead of the canonical one, and split out the tests requiring a shell into separate files (clang/test/Driver/riscv{32,64}-toolchain-e

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

2019-10-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 223209. edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation detected". edward-jones added a comment. Herald added subscribers: arichardson, emaste. Her

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

2019-10-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 223205. edward-jones added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. Rebased and added tests I've made this use the Triple from the driver rather than the parsed LLVM triple, this means the Triple does

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

2019-10-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones planned changes to this revision. edward-jones added a comment. I'm reworking this at the moment and adding some tests. Standby! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 __

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-10-03 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. Work in progress because this needs tests (and probably clang-format too). My assumption is that libgcc should be used in preference if it is available. At the moment this either uses libgcc and libgcc's crtbegin/crtend, or the Clang equivalents. Potentially a user

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

2019-10-03 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. edward-jones added a reviewer: asb. Herald added subscribers: cfe-commits, pzheng, simoncook, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabu

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

2019-10-03 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. Before falling back to returning the empty string this first looks for a directory with the triple name up one level from the driver. This uses the Triple string in the path, however this Triple has been normalized so even if the user specifies "clang --target=risc

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

2019-10-03 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. Herald added subscribers: cfe-commits, pzheng, simoncook, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, johnrusso, rbar, asb.

[PATCH] D63417: [RISCV] Specify registers used for exception handling

2019-07-03 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 207769. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63417/new/ https://reviews.llvm.org/D63417 Files: lib/Basic/Targets/RISCV.h test/CodeGen/builtins-riscv.c Index: test/CodeGen/builtins-riscv.c ==

[PATCH] D63417: [RISCV] Specify registers used for exception handling

2019-07-03 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 207736. edward-jones added a comment. Add riscv64 target run line, renamed test file to builtins-riscv.c, and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63417/new/ https://reviews.llvm.org/D63417 Files: lib/Basic/Targets/RISCV.h

[PATCH] D63417: [RISCV] Specify registers used for exception handling

2019-06-19 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 205542. edward-jones retitled this revision from "[WIP][RISCV] Specify registers used for exception handling" to "[RISCV] Specify registers used for exception handling". edward-jones edited the summary of this revision. edward-jones added a comment. Add

[PATCH] D63417: [WIP][RISCV] Specify registers used for exception handling

2019-06-17 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. edward-jones added reviewers: asb, lewis-revill. Herald added subscribers: cfe-commits, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

2019-03-14 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. In D58896#1419964 , @aaron.ballman wrote: > Do you have some evidence that the current behavior is causing a lot of false > positives in the wild? For ASCII character literals, I can sort of guess at > why people might want

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

2019-03-04 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Assume that the user knows what they're doing if they provide a char literal as an array index. This more closely matches the behavior of GCC. Repository: rC Clang https://revi

[PATCH] D53392: [RISCV] Collect library directories and triples for riscv64 triple too

2018-10-22 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 170374. edward-jones marked 2 inline comments as done. https://reviews.llvm.org/D53392 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/Inputs/basic_riscv64_tree/bin/riscv64-unknown-elf-ld test/Driver/Inputs/basic_riscv64_tree/lib/gcc/riscv64-unkn

[PATCH] D53392: [RISCV] Collect library directories and triples for riscv64 triple too

2018-10-22 Thread Edward Jones via Phabricator via cfe-commits
edward-jones updated this revision to Diff 170373. edward-jones added a comment. I've incorporated your suggested changes and added riscv32/64-linux-gnu entrys to the Triple + LibDirs lists. Is it worth also updating the riscv32-toolchain.c test in this patch to rename riscv32-linux-unknown-elf

[PATCH] D53392: [RISCV] Collect library directories and triples for riscv64 triple too

2018-10-18 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. edward-jones added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, mgrang, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, arichardson, ema

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

2017-08-15 Thread Edward Jones via Phabricator via cfe-commits
edward-jones added a comment. No, this doesn't seem to have been committed yet. https://reviews.llvm.org/D24461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34103: Allow use of fixed width integer types in builtin definitions

2017-06-12 Thread Edward Jones via Phabricator via cfe-commits
edward-jones created this revision. This makes it possible to specify a bit width after the 'i' integer type specifier when defining builtins. The bswap and bitreverse builtins have been updated so that their definitions use fixed-width types instead of short, int and long, so that they work on