edward-jones added a comment. In D58896#1419964 <https://reviews.llvm.org/D58896#1419964>, @aaron.ballman wrote:
> Do you have some evidence that the current behavior is causing a lot of false > positives in the wild? For ASCII character literals, I can sort of guess at > why people might want to do this, but for things like wide character > literals, or character literals relying on the current code page, etc, I'm > less convinced. I don't know about the false positive rate, just the one report on twitter which triggered me to submit this change. As for wide character literals I was under the impression that they would be promoted to integers and wouldn't have triggered the -Wchar-subscript anyway? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58896/new/ https://reviews.llvm.org/D58896 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
