[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/122095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. My understanding is that: * This PR does not conflict with what the Debian patch does. * It in fact will fix a bug in the Debian build. * This does not change the behaviour of an unmodified Clang from a user's perspective, therefore we

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-16 Thread David Spickett via cfe-commits
@@ -659,13 +659,21 @@ llvm::ARM::FPUKind arm::getARMTargetFeatures(const Driver &D, CPUArgFPUKind != llvm::ARM::FK_INVALID ? CPUArgFPUKind : ArchArgFPUKind; (void)llvm::ARM::getFPUFeatures(FPUKind, Features); } else { +bool Generic = true; if (!ForAS) {

[clang] [Driver][ARM] Change Android's NEON FPU hardcoding to "== 7" as it pessimizes future ArmV8 code (PR #122969)

2025-01-15 Thread David Spickett via cfe-commits
DavidSpickett wrote: Make sure to update the *PR Description* as this becomes the commit message when the squash and merge happens. (yes, this is confusing but that's how llvm is set up) But what I read makes sense thank you for rephrasing the commit message. https://github.com/llvm/llvm-proj

[clang] [Driver][ARM] Fix hardcoding of NEON FPU for armv8 (PR #122969)

2025-01-15 Thread David Spickett via cfe-commits
DavidSpickett wrote: Yeah, my first impression from the commit message was that you removed the check entirely. https://github.com/llvm/llvm-project/pull/122969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang] document that by default FP turned off for ARM baremetal (PR #122881)

2025-01-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/122881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] document that by default FP turned off for ARM baremetal (PR #122881)

2025-01-14 Thread David Spickett via cfe-commits
@@ -1071,6 +1071,10 @@ Arm and AArch64 Support - Implementation of SVE2.1 and SME2.1 in accordance with the Arm C Language Extensions (ACLE) is now available. +- For ARM baremetal targets, the frame pointer (FP) is now turned off by + default. To turn on frame pointers for

[clang] [clang] document that by default FP turned off for ARM baremetal (PR #122881)

2025-01-14 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/122881 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] document that by default FP turned off for ARM baremetal (PR #122881)

2025-01-14 Thread David Spickett via cfe-commits
@@ -1076,6 +1076,8 @@ Arm and AArch64 Support in leaf functions after enabling ``-fno-omit-frame-pointer``, you can do so by adding the ``-momit-leaf-frame-pointer`` option. +- For ARM baremetal targets, the frame pointer (FP) is now turned off by default. --

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Setting default features for a platform based on what we happened to choose (likely with a very thin justification) to be the default CPU sounds fragile to me, so I think this patch is a good step forward. Even if there weren't this downstream patch interacting with it, I

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Or is it that this change allows other downstreams to patch the Linux issue in a way that does not break Windows and iOS in the process? If I'm using clang on Debian, that's where I would find this C can use Neon but assembly cannot problem. https://github.com/llvm/llvm-p

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: > In practice, when compiling C for Windows/ARMv7, NEON actually still is > available, but not when compiling assembly files. So the "bug" if we're going to call it that, is that C code can produce Neon but assembly files compiled in the same way cannot use Neon instructi

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: Updated to list @frasercrmck and @tstellar for libclc. Tell me if that works for now, perhaps you can sort out any additions later. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.ll

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 409dd1184f1c4ff9f11e2d715b6e4a496c70c7e4 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH 1/2] [libclc] Add Maintainers.md for libclc --- libclc/Ma

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/120739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thanks for the fix! https://github.com/llvm/llvm-project/pull/120739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, ->getCanonicalTypeUnqualified(); } } -} +} break; DavidSpickett wrote: On second thought, there are a ton of these in

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/120739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, ->getCanonicalTypeUnqualified(); } } -} +} break; DavidSpickett wrote: Could put it inside the `case : { ...}` scope,

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: Polly pushed in https://github.com/llvm/llvm-project/commit/788d5a5f1e1263657f0a281545e095769f6b375b. Only libclc remains. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 64bfb1cd1bb7aa9e1597c0212dba7067c9f75d9f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [libclc] Add Maintainers.md for libclc --- libclc/Mainta

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: If you look for: ``` FAILED: tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompileCommands.cpp.o ``` In the build log that's the failure reason. All of the tests that reported JSON passed, that's why you have green test reports but failed builds. I wi

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: > The relevant binaries build, but check-lldb currently hits unrelated errors > for me blocking any progress in checking those changes. `ninja check-lldb` passes on AArch64 Linux, and given the changes, it's unlikely to fail on other platforms. https://github.com/llvm/llv

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: My comments have been addressed. https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: Libcxx part pushed as https://github.com/llvm/llvm-project/commit/1bdb0a408f1e2e9f6d5f43b23b4f87f87b3950ab. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[libclc] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 8398d47a413dfbabb9a4eb96809304c240f4e3ad Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: OpenMP part pushed directly: https://github.com/llvm/llvm-project/commit/2137ded301adb430e0616cd835da9838e4fd79ce https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[libclc] [libcxx] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-04 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From fe59fcd2c14f7ff84857ad75bc3564cbe6752c9d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: It already landed, I'll rebase this PR. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
DavidSpickett wrote: @tobiasgrosser (because for some reason I can't add you as a reviewer directly) https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 9d279bcb1174e80e24ddac8755962cb65e20be91 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH 1/2] [llvm] Move sub-project lead maintainers into their ow

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/118309 This adds Maintainers.md files to the sub-projects mentioned here, so that someone going directly to that sub-project will find them more easily. Recently I needed to find a libclc maintainer and I had no

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
@@ -434,29 +433,17 @@ Others only have a lead maintainer listed here. [Flang maintainers](https://github.com/llvm/llvm-project/blob/main/flang/Maintainers.txt) -[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/CODE_OWNERS.TXT) - -[LLDB maintainers](http

[clang] [llvm] [ci] Include a log download link when test report is truncated (PR #117985)

2024-11-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/117985 Now "Download" will be a link to the file so people don't have to know to open the build tab and find the download button. This is a URL from a real build: https://buildkite.com/organizations/llvm-project/

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-11-26 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thanks, I'll leave it open then, this PR is a welcome improvement regardless. https://github.com/llvm/llvm-project/pull/117419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-11-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: Please check if this fixes https://github.com/llvm/llvm-project/issues/109778 too. Seems very similar. https://github.com/llvm/llvm-project/pull/117419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [llvm] Fix report script (PR #116017)

2024-11-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/116017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Fix report script (PR #116017)

2024-11-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/116017 None >From 69a3030e61ab5d4483464cd912d78a4e5d24d644 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 13 Nov 2024 09:19:10 + Subject: [PATCH 1/2] Reland "[ci] New script to generate test report

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-11-12 Thread David Spickett via cfe-commits
DavidSpickett wrote: Abandoning in favour of marking the unique filename option as hidden. https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-11-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also I edited the title tags. They aren't an exact science but clang seems the most appropriate here. https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: I'm not an expert here but added some generic comments for now. FYI with the llvm conference last week, many people are still away so review pace is slower right now. Since this is a Clang change it should have a release note, I think it can go in h

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple arm64-windows-msvc +// expected-no-diagnostics +#pragma clang section bss = "mybss.1" data = "mydata.1" rodata = "myrodata.1" text = "mytext.1" +#pragma clang section bss="" data="" rodata="" text="" +#pragma cl

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: Maybe add " when no -mmcu option is used" to the commit title but otherwise LGTM. https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
DavidSpickett wrote: I have updated this PR to include marking the option as hidden. If folks would be ok with that approach, I will break this up into individual parts for review and landing separately. If no, I will work more on the lit wrapper approach. @boomanaiden154 what do you think to

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
DavidSpickett wrote: > FWIW, I didn't mean to derail this effort or create significant additional > complexity by saying what I said above. My intention was only to point out > the tradeoff of adding new functionality for a temporary benefit, which > wasn't clear to me had been thought about i

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From e9e79e33f06942e471dca6b727a4cd9cd6fa4563 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 29 Oct 2024 15:38:12 + Subject: [PATCH 1/4] [llvm][llvm-lit] Hide --use-unique-output-file-name f

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-29 Thread David Spickett via cfe-commits
DavidSpickett wrote: I also looked through GitHub code search to see if anyone else was hitting this same issue. ROCm avoids it by splitting each check target into its own step: https://github.com/ROCm/ROCm/blob/bce439ecacc86b7f48934f5cc6be7ce2044412cf/.azuredevops/components/llvm-project.yml#L

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-28 Thread David Spickett via cfe-commits
DavidSpickett wrote: I tried a few more things, so I will summarise everything up until this point. There are two layers here: 1. Making test reports. 2. Producing the XML test results. Using the buildkite plugin is not an option (https://github.com/llvm/llvm-project/pull/113290) because we'd

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113896 None >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Bui

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,91 @@ +// RUN: %clang_cc1 -std=c++11 -triple aarch64-arm-none-eabi -target-feature -fp8 -ast-dump %s | \ +// RUN: FileCheck %s --strict-whitespace + +// REQUIRES: aarch64-registered-target || arm-registered-target + +/* Various contexts where type __mfp8 can appear.

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/113703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: mkfifo is a dead end, it silently fails to make the fifo when using bash for Windows. https://github.com/llvm/llvm-project/pull/113703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,91 @@ +// RUN: %clang_cc1 -std=c++11 -triple aarch64-arm-none-eabi -target-feature -fp8 -ast-dump %s | \ +// RUN: FileCheck %s --strict-whitespace + +// REQUIRES: aarch64-registered-target || arm-registered-target + +/* Various contexts where type __mfp8 can appear.

[clang] 81e536e - [clang][test] Fix typo in arm-mfp8.cpp

2024-10-25 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-10-25T15:43:47Z New Revision: 81e536ec87a108d012cf9156a2c3fc672fb92155 URL: https://github.com/llvm/llvm-project/commit/81e536ec87a108d012cf9156a2c3fc672fb92155 DIFF: https://github.com/llvm/llvm-project/commit/81e536ec87a108d012cf9156a2c3fc672fb92155.diff LOG

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113703 >From b7c270ad11c7b19edc7eff71922be9e19e830362 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci fifo (PR #113703)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113703 None >From b7c270ad11c7b19edc7eff71922be9e19e830362 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Bui

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,91 @@ +// RUN: %clang_cc1 -std=c++11 -triple aarch64-arm-none-eabi -target-feature -fp8 -ast-dump %s | \ +// RUN: FileCheck %s --strict-whitespace + +// REQUIRES: aarch64-registered-target || arm-registered-target + +/* Various contexts where type __mfp8 can appear.

[clang] [CLANG][AArch64] Add the modal 8 bit floating-point scalar type (PR #97277)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: FYI Arm 32 bit is failing on a different test than most of these - https://lab.llvm.org/buildbot/#/builders/154/builds/6442 https://github.com/llvm/llvm-project/pull/97277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: The version that does not use the lit feature: https://github.com/llvm/llvm-project/pull/113660 It's not complete but it's good enough to compare approaches I think. Another, probably objectionable choice, is to write a wrapper script that replaces lit, looks for the resu

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 7fa2d66f56af7b6ca6d6f36161825c1b71e8e29a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: Example failing build: https://buildkite.com/llvm-project/github-pull-requests/builds/113045#_ Another example: https://buildkite.com/llvm-project/github-pull-requests/builds/113055#_ The second example should not be failing but this modulemap test is for whatever reason,

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113660 None >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Bui

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Do we make any guarantees about supporting lit flags in the future? It's > mostly an internal tool, and I would personally be in support of removing > flags that are no longer used in tree, unless there are some extremely > compelling downstream use cases and there is an

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Basically, the sort of "plain text" report that gets added is the difference. > Is that correct? Yes, there is also a Linux report there that shows that it succeeded, but you have to select "All" on the "All | Failed" button. Which is maybe redundant but folks like seei

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett ready_for_review https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
DavidSpickett wrote: Example reports can be seen here - https://buildkite.com/llvm-project/github-pull-requests/builds/112660. https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

  1   2   3   4   5   6   >