dpaoliello added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:248-257
+ // The first 4 FP/Vector arguments are passed in XMM registers.
+ CCIfType<[f16],
+ CCAssignToRegWithShadow<[H0, H1, H2, H3],
+
dpaoliello added a comment.
@efriedma the patch is failing to apply - can you please update your baseline,
or move this to a GitHub PR?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157547/new/
https://reviews.llvm.org/D157547
___
dpaoliello added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64MCInstLower.cpp:37-38
MCSymbol *
AArch64MCInstLower::GetGlobalAddressSymbol(const MachineOperand &MO) const {
const GlobalValue *GV = MO.getGlobal();
We now also need to call this
dpaoliello added a comment.
Another issue: looks like the names in `AArch64Subtarget.h` need to be fully
decorated, including the leading `#` - so `#__chkstk_arm64ec` and
`#__security_check_cookie_arm64ec`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
dpaoliello added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64CallingConvention.td:555-557
+def CSR_Win_AArch64_Arm64EC_Thunk : CalleeSavedRegs<(add X19, X20, X21, X22,
X23, X24,
+ X25, X26, X27, X28,
FP, LR
dpaoliello added inline comments.
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2726-2729
+// FIXME: For non-dllimport functions, MSVC emits the same entry
+// twice, for reasons I don't understand. I have to assume the linker
+// ignores the red
dpaoliello added a comment.
Herald added a subscriber: ormris.
@rnk @aganea Ping... Just wanted to see what was happening with this change,
and if there is anything I can do to help get it merged in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D43
