[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

@@ -3058,6 +3058,133 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static QualType commonTypeImpl(Sema &S, TemplateName BaseTemplate, + SourceLocation TemplateLoc, + ArrayRef Ts) { + auto lookUpComm

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

@@ -3058,6 +3058,133 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static QualType commonTypeImpl(Sema &S, TemplateName BaseTemplate, + SourceLocation TemplateLoc, + ArrayRef Ts) { + auto lookUpComm

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

@@ -3058,6 +3058,133 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static QualType commonTypeImpl(Sema &S, TemplateName BaseTemplate, + SourceLocation TemplateLoc, + ArrayRef Ts) { + auto lookUpComm

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

@@ -3058,6 +3058,133 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) { } } +static QualType commonTypeImpl(Sema &S, TemplateName BaseTemplate, + SourceLocation TemplateLoc, + ArrayRef Ts) { + auto lookUpComm

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

https://github.com/cjdb requested changes to this pull request. https://github.com/llvm/llvm-project/pull/99473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Add __common_type builtin (PR #99473)

cjdb wrote: I spent a lot of time trying to implement this myself, but I always struggled to capture detecting user specialisations of `common_type`. Which section of code handles that? https://github.com/llvm/llvm-project/pull/99473 ___ cfe-commits

[clang-tools-extra] [WIP][clang-tidy] Ignore `if consteval` in else-after-return (PR #91588)

cjdb wrote: Thanks for your patch! Would you be able to add a test case for this please? https://github.com/llvm/llvm-project/pull/91588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/87847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

https://github.com/cjdb updated https://github.com/llvm/llvm-project/pull/87847 >From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001 From: Christopher Di Bella Date: Sat, 6 Apr 2024 00:13:29 + Subject: [PATCH 1/2] [Flang] responds to Clang Tidy feedback Line 267: performa

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

https://github.com/cjdb updated https://github.com/llvm/llvm-project/pull/87847 >From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001 From: Christopher Di Bella Date: Sat, 6 Apr 2024 00:13:29 + Subject: [PATCH 1/2] [Flang] responds to Clang Tidy feedback Line 267: performa

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

https://github.com/cjdb created https://github.com/llvm/llvm-project/pull/87847 Line 267: performance-unnecessary-copy-initialization Line 592: readability-container-size-empty >From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001 From: Christopher Di Bella Date: Sat, 6 Apr 20

[clang] [clang][dataflow] Fix crash on unions introduced in ba279934c6ab09d5394a89d8318651aefd8d565b (PR #81918)

https://github.com/cjdb approved this pull request. https://github.com/llvm/llvm-project/pull/81918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [lldb] [llvm] [libunwind] [clang-tools-extra] [libcxx] [libc] [clang] [flang] [libc++] Implement ranges::iota (PR #68494)

@@ -1149,9 +1171,11 @@ struct Proxy { // Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues) // Compare operators are defined for the convenience of the tests - friend constexpr bool operator==(const Proxy&, const Proxy&) -requires (std::equality_comparable && !

[compiler-rt] [lldb] [llvm] [libunwind] [clang-tools-extra] [libcxx] [libc] [clang] [flang] [libc++] Implement ranges::iota (PR #68494)

@@ -0,0 +1,54 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[flang] [compiler-rt] [llvm] [lldb] [clang-tools-extra] [libunwind] [clang] [libcxx] [libc] [libc++] Implement ranges::iota (PR #68494)

@@ -0,0 +1,71 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[libcxx] [flang] [libunwind] [libc] [llvm] [lldb] [clang-tools-extra] [compiler-rt] [clang] [libc++] Implement ranges::iota (PR #68494)

@@ -1161,9 +1185,11 @@ struct Proxy { return lhs.data == rhs.data; } - friend constexpr auto operator<=>(const Proxy&, const Proxy&) -requires (std::three_way_comparable && !std::is_reference_v) - = default; + friend constexpr auto operator<=>(const Proxy& lhs, co

[clang-tools-extra] [libc] [llvm] [libunwind] [flang] [lldb] [libcxx] [clang] [compiler-rt] [libc++] Implement ranges::iota (PR #68494)

@@ -1172,6 +1198,22 @@ struct Proxy { requires std::three_way_comparable_with, std::decay_t> { return lhs.data <=> rhs.data; } + + // Needed to allow certain types to be weakly_incremental + constexpr Proxy& operator++() +requires(HasPreIncrementOp) + { +++

[llvm] [compiler-rt] [libcxx] [lldb] [libunwind] [flang] [libc] [clang-tools-extra] [clang] [libc++] Implement ranges::iota (PR #68494)

https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/68494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [compiler-rt] [clang-tools-extra] [libc] [clang] [flang] [lldb] [llvm] [libunwind] [libc++] Implement ranges::iota (PR #68494)

@@ -0,0 +1,171 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[flang] [libcxx] [libc] [clang-tools-extra] [llvm] [libunwind] [lldb] [clang] [compiler-rt] [libc++] Implement ranges::iota (PR #68494)

@@ -0,0 +1,71 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[clang-tools-extra] [flang] [libunwind] [libc] [llvm] [lldb] [libcxx] [compiler-rt] [clang] [libc++] Implement ranges::iota (PR #68494)

@@ -1149,9 +1171,11 @@ struct Proxy { // Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues) // Compare operators are defined for the convenience of the tests - friend constexpr bool operator==(const Proxy&, const Proxy&) -requires (std::equality_comparable && !

[libunwind] [clang] [clang-tools-extra] [llvm] [flang] [compiler-rt] [libcxx] [libc] [lldb] [libc++] Implement ranges::iota (PR #68494)

@@ -0,0 +1,71 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-

[libunwind] [lldb] [flang] [libc] [llvm] [clang-tools-extra] [clang] [libcxx] [compiler-rt] [libc++] Implement ranges::iota (PR #68494)

@@ -1083,6 +1083,27 @@ rvalue_iterator(T*) -> rvalue_iterator; static_assert(std::random_access_iterator>); +// The ProxyDiffTBase allows us to conditionally specify Proxy::difference_type +// which we need in certain situations. For example when we want +// std::weakly_incr

[flang] [clang] [lldb] [libcxx] [libc] [libunwind] [llvm] [clang-tools-extra] [compiler-rt] [libc++] Implement ranges::iota (PR #68494)

@@ -0,0 +1,171 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [lldb] [llvm] [compiler-rt] [libcxx] [libc] [clang-tools-extra] [flang] [libunwind] [libc++] Implement ranges::iota (PR #68494)

https://github.com/cjdb requested changes to this pull request. Thanks for working on this, it's an important algorithm to have. I've left some comments, but would like to see this merged by the end of January. https://github.com/llvm/llvm-project/pull/68494

[libcxx] [clang] [clang-tools-extra] [compiler-rt] [llvm] [flang] [lldb] [libunwind] [libc] [libc++] Implement ranges::iota (PR #68494)

@@ -13,7 +13,7 @@ // Range algorithms should return `std::ranges::dangling` when given a dangling range. cjdb wrote: Please revert and apply in a separate patch. https://github.com/llvm/llvm-project/pull/68494 ___

[libcxx] [compiler-rt] [flang] [clang-tools-extra] [llvm] [lld] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/73617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [compiler-rt] [flang] [clang-tools-extra] [llvm] [lld] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [compiler-rt] [flang] [clang-tools-extra] [llvm] [lld] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [compiler-rt] [flang] [clang-tools-extra] [llvm] [lld] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [compiler-rt] [llvm] [flang] [lld] [clang-tools-extra] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,104 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm] [clang] [libcxx] [clang-tools-extra] [compiler-rt] [lld] [flang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,77 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[libcxx] [clang-tools-extra] [flang] [compiler-rt] [llvm] [clang] [lld] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,95 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [compiler-rt] [clang] [flang] [lld] [llvm] [libcxx] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,75 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[lld] [compiler-rt] [clang] [libcxx] [llvm] [clang-tools-extra] [flang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,107 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm] [lld] [libcxx] [compiler-rt] [clang-tools-extra] [clang] [flang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [llvm] [lld] [flang] [clang-tools-extra] [clang] [compiler-rt] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,107 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm] [libcxx] [compiler-rt] [flang] [clang] [clang-tools-extra] [lld] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,129 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[lld] [libcxx] [llvm] [clang-tools-extra] [clang] [flang] [compiler-rt] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[compiler-rt] [llvm] [lld] [flang] [clang-tools-extra] [libcxx] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,114 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[flang] [llvm] [clang-tools-extra] [lld] [libcxx] [compiler-rt] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,101 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[lld] [clang] [flang] [libcxx] [llvm] [clang-tools-extra] [compiler-rt] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[llvm] [clang-tools-extra] [flang] [libcxx] [lld] [compiler-rt] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang-tools-extra] [compiler-rt] [flang] [libcxx] [clang] [lld] [llvm] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,96 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[lld] [libcxx] [clang-tools-extra] [flang] [clang] [llvm] [compiler-rt] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [compiler-rt] [clang] [llvm] [clang-tools-extra] [flang] [lld] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,138 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[libcxx] [clang] [lld] [llvm] [clang-tools-extra] [flang] [compiler-rt] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [libcxx] [llvm] [lld] [flang] [clang-tools-extra] [compiler-rt] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang] [lld] [clang-tools-extra] [llvm] [flang] [compiler-rt] [libcxx] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/73617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libcxx] [flang] [compiler-rt] [clang] [lld] [llvm] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,333 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[compiler-rt] [clang-tools-extra] [lld] [libcxx] [llvm] [flang] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

@@ -0,0 +1,129 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[llvm] [libcxx] [lld] [flang] [compiler-rt] [clang-tools-extra] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

https://github.com/cjdb requested changes to this pull request. Thanks for working on this! There's a fair bit that I've provided comments for, but I think you're off to a great start, and I would like to see this merged in January, if at all possible. Some comments are short and repetitive: t

[clang-tools-extra] [llvm] [libcxx] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,118 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [libcxx] [clang] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,118 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[clang-tools-extra] [libcxx] [clang] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,315 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [libcxx] [clang] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,259 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,104 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,89 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [libcxx] [clang] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,89 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang-tools-extra] [llvm] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,104 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,104 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

cjdb wrote: > > I see @var-const has "requested changes" set, but I feel we've addressed > > the one unresolved comment of his. > > @EricWF In fact, this patch changed quite significantly since I last looked > at it (based on your feedback, I believe), so I would have appreciated being > able

[clang-tools-extra] [llvm] [libcxx] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/75259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [libcxx] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

cjdb wrote: Merging, with the promise to diligently resolve post-commit feedback in early January. Anything that's specific to this patch will be actioned before starting work on the remaining fold algorithms, and anything that's generalised to `std::ranges` will be actioned after finishing th

[clang] [libcxx] [llvm] [clang-tools-extra] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,202 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. cjdb wrote: Ah

[libunwind] [libunwind] Bump to CXX_STANDARD 17 (PR #75986)

https://github.com/cjdb approved this pull request. Thanks for making this change! CC @ajordanr-google https://github.com/llvm/llvm-project/pull/75986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[libcxx] [clang] [clang-tools-extra] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,118 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [clang-tools-extra] [llvm] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,118 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License

[libcxx] [clang-tools-extra] [llvm] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -89,9 +89,7 @@ struct __fold_left_with_iter { } }; -inline namespace __cpo { inline constexpr auto fold_left_with_iter = __fold_left_with_iter(); cjdb wrote: I've updated the description in this PR, which I _think_ becomes the main message for a squash

[libcxx] [clang-tools-extra] [llvm] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/75259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [clang-tools-extra] [llvm] [clang] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -83,6 +83,10 @@ static_assert(test(std::ranges::find_end, a, a)); static_assert(test(std::ranges::find_first_of, a, a)); cjdb wrote: I'm a bit hesitant to use that test file, so `left_folds.pass.cpp` does checks to ensure invocable robustness. I'll my concer

[libcxx] [clang-tools-extra] [clang] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[libcxx] [clang-tools-extra] [clang] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [libcxx] [clang-tools-extra] [llvm] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -87,4 +89,15 @@ void test() { std::ranges::unique(iter, iter); // expected-warning {{ignoring return value of function declared with 'nodiscard' attribute}} std::ranges::upper_bound(range, 1); // expected-warning {{ignoring return value of function declared with 'nodisc

[clang-tools-extra] [llvm] [clang] [libcxx] [libcxx] adds ranges::fold_left_with_iter and ranges::fold_left (PR #75259)

@@ -0,0 +1,100 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] changes where a test writes its output (PR #73560)

https://github.com/cjdb created https://github.com/llvm/llvm-project/pull/73560 Writing directly to /dev/null has permission issues on some systems, so we've changed this to a temporary file instead. >From 786d368b9d4d315254df1b8631adead6f8c8e379 Mon Sep 17 00:00:00 2001 From: Christopher Di Be

[clang] [clang] changes where a test writes its output (PR #73560)

https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/73560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sema] Improve -Wsign-compare (PR #65684)

=?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: https://github.com/cjdb commented: Generally speaking, I'm in favour of this; thanks so much for identifying this problem! When C++20 is available, we ought to suggest using `std:: is_lt` and friends instead. Possibly something like ``` n

[clang] [clang][Diagnostics] Add bitfield source range to zero width diags (PR #68312)

https://github.com/cjdb approved this pull request. https://github.com/llvm/llvm-project/pull/68312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/cjdb approved this pull request. LGTM, thanks! Do you require assistance committing? https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/cjdb commented: Thanks for working on this, it seems like an important fix. Would you mind updating the release notes please? I'll approve afterwards. https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-

[clang] Recommit "Implement [[msvc::no_unique_address]] (#65675)" (PR #67199)

cjdb wrote: Thanks @amykhuang! 🎉 https://github.com/llvm/llvm-project/pull/67199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

cjdb wrote: > Not really, CYAN is only cyan if that's what your terminal decides to render > the color 6 as, you can configure it to be orange if you want. Oh, interesting. In that case, I see no problems. https://github.com/llvm/llvm-project/pull/66997

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

cjdb wrote: > This is a one-liner that fixes the problem on terminals with a dark > background and the solution also works on light backgrounds. So, basically > all of them. Before approving this change, I want confirmation that it doesn't adversely impact popular themes. The Tomorrow Night B

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

cjdb wrote: This doesn't really fix the problem, it just shuffles it around. I expect people with blue(ish) terminals will experience the same issue after this is applied, so we ought to try and detect what colours to print out, and then have compatible themes. https://github.com/llvm/llvm-pr

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: cjdb wrote: I'm okay with the change in general. https://github.com/llvm/llvm-project/pull/66514 ___

[clang] 8f3b0b4 - [clang] adds `__reference_constructs_from_temporary`

Author: Christopher Di Bella Date: 2023-09-13T23:51:43Z New Revision: 8f3b0b4171431ced5550d5c8a70d1b683343f062 URL: https://github.com/llvm/llvm-project/commit/8f3b0b4171431ced5550d5c8a70d1b683343f062 DIFF: https://github.com/llvm/llvm-project/commit/8f3b0b4171431ced5550d5c8a70d1b683343f062.dif

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/cjdb requested changes to this pull request. https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

@@ -2999,17 +3139,17 @@ void MicrosoftRecordLayoutBuilder::layoutBitField(const FieldDecl *FD) { auto NewSize = Context.toCharUnitsFromBits( llvm::alignDown(FieldBitOffset, Context.toBits(Info.Alignment)) + Context.toBits(Info.Size)); -Size = std::max(S

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dfd1d8d - Revert "adds `__reference_constructs_from_temporary`"

Author: Christopher Di Bella Date: 2023-09-11T23:44:50Z New Revision: dfd1d8d505d61c9b401a3cdd6a687848f1c37cc5 URL: https://github.com/llvm/llvm-project/commit/dfd1d8d505d61c9b401a3cdd6a687848f1c37cc5 DIFF: https://github.com/llvm/llvm-project/commit/dfd1d8d505d61c9b401a3cdd6a687848f1c37cc5.dif

[clang] e1bfeb6 - adds `__reference_constructs_from_temporary`

Author: Christopher Di Bella Date: 2023-09-11T23:14:08Z New Revision: e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54 URL: https://github.com/llvm/llvm-project/commit/e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54 DIFF: https://github.com/llvm/llvm-project/commit/e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54.dif

[clang] 38e1c59 - [clang] adds `conceptDecl` as an ASTMatcher

Author: Christopher Di Bella Date: 2023-07-20T23:33:46Z New Revision: 38e1c597033de0c7655abb39335b364408865d2a URL: https://github.com/llvm/llvm-project/commit/38e1c597033de0c7655abb39335b364408865d2a DIFF: https://github.com/llvm/llvm-project/commit/38e1c597033de0c7655abb39335b364408865d2a.dif

[clang] 91be60b - Respect "-fdiagnostics-absolute-paths" on emit include location

Author: Charalampos Mitrodimas Date: 2023-06-05T18:07:18Z New Revision: 91be60b34715bfe930dd1c56414c62a63cdaaa9c URL: https://github.com/llvm/llvm-project/commit/91be60b34715bfe930dd1c56414c62a63cdaaa9c DIFF: https://github.com/llvm/llvm-project/commit/91be60b34715bfe930dd1c56414c62a63cdaaa9c.d

[clang] 798c5ba - [clang][NFC] refactors value type traits so we can have more than bools

Author: Christopher Di Bella Date: 2023-06-05T18:07:18Z New Revision: 798c5ba770d30520a7cd6f431068ade2bda5a9f1 URL: https://github.com/llvm/llvm-project/commit/798c5ba770d30520a7cd6f431068ade2bda5a9f1 DIFF: https://github.com/llvm/llvm-project/commit/798c5ba770d30520a7cd6f431068ade2bda5a9f1.dif

[clang] 33e2161 - [clang] makes `__is_trivially_equality_comparable` available as a struct

Author: Christopher Di Bella Date: 2023-04-19T17:16:40Z New Revision: 33e21610f9cd40e991b7cac107ba190678970f81 URL: https://github.com/llvm/llvm-project/commit/33e21610f9cd40e991b7cac107ba190678970f81 DIFF: https://github.com/llvm/llvm-project/commit/33e21610f9cd40e991b7cac107ba190678970f81.dif

[clang-tools-extra] 716469b - [clang-tidy] Fix segfault in bugprone-standalone-empty

Author: Denis Nikitin Date: 2023-01-25T20:06:41Z New Revision: 716469b6139ab5ec5c5b5dac32891300260db8eb URL: https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb DIFF: https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb.diff LOG:

[clang-tools-extra] 7910ee7 - [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

Author: v1nh1shungry Date: 2023-01-13T01:14:51Z New Revision: 7910ee7d8c6dcb679200ba171fba5d8d5f237007 URL: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007 DIFF: https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007.diff LOG:

[clang] 8effeb4 - Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

Author: Adrian Dole Date: 2023-01-12T18:25:12Z New Revision: 8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b URL: https://github.com/llvm/llvm-project/commit/8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b DIFF: https://github.com/llvm/llvm-project/commit/8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b.diff LOG: A

  1   2   >