cjdb wrote: > > I see @var-const has "requested changes" set, but I feel we've addressed > > the one unresolved comment of his. > > @EricWF In fact, this patch changed quite significantly since I last looked > at it (based on your feedback, I believe), so I would have appreciated being > able to do another round of review before this was merged.
That is fair. My understanding is that Eric was trying to balance respecting that you might have feedback with me struggling to switch off while OOO, if a PR is still in my "active context". I ended up coming back into the office early, and prioritised applying your feedback as a result (see #76534). Please do make further commentary as necessary. https://github.com/llvm/llvm-project/pull/75259 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
