everythingfunctional wrote:
> @everythingfunctional with this change and install, we are installing flang
> with the -20 in the install dir: `-- Installing:
> /build/source/debian/tmp/usr/lib/llvm-20/bin/flang-20`
>
> it should not be the case, it should be named `/usr/lib/llvm-20/bin/flang` t
everythingfunctional wrote:
> @everythingfunctional Following are the steps to run the testsuite. Please
> check and confirm if you did not run it before.
>
> ```
> git clone https://github.com/llvm/llvm-test-suite.git
> cd llvm-test-suite
> mkdir build
> cd build
> cmake -DCMAKE_BUILD_TYPE=Rel
everythingfunctional wrote:
@klausler , can you point me specifically at the failure messages? The failures
I've seen so far from the merge did not look related to my (admittedly
untrained) eye. I ran the tests in the repo and they passed locally. Are there
other tests somewhere that need to b
everythingfunctional wrote:
@kiranchandramohan , I don't have commit access, so could you merge for me?
https://github.com/llvm/llvm-project/pull/110023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From c19e89f7358dc638687be4da8f5a51cb483b3637 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/7] [flang][driver] rename flang-new to flang
--
@@ -787,6 +787,9 @@ void Flang::ConstructJob(Compilation &C, const JobAction
&JA,
if (Args.hasArg(options::OPT_fopenmp_force_usm))
CmdArgs.push_back("-fopenmp-force-usm");
+ // TODO: OpenMP support isn't "done" yet, so for now we warn that it
+ // is e
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/7] [flang][driver] rename flang-new to flang
--
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/6] [flang][driver] rename flang-new to flang
--
@@ -339,11 +335,11 @@ just added using your new frontend option.
## CMake Support
As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246)
-(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a
+(and soon to be released CMake 3.24.0), `
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/5] [flang][driver] rename flang-new to flang
--
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/4] [flang][driver] rename flang-new to flang
--
@@ -339,11 +335,11 @@ just added using your new frontend option.
## CMake Support
As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246)
-(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a
+(and soon to be released CMake 3.24.0), `
@@ -339,11 +335,11 @@ just added using your new frontend option.
## CMake Support
As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246)
-(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a
+(and soon to be released CMake 3.24.0), `
everythingfunctional wrote:
Sounds like I should just add the warning to OpenMP for now. I'll work on
getting that added and then figure out why the CI is failing.
https://github.com/llvm/llvm-project/pull/110023
___
cfe-commits mailing list
cfe-commi
everythingfunctional wrote:
> Shouldn't `-fopenacc` then also emit such a warning?
Well, we could get into a philosophical discussion about whether software is
ever *not* experimental. But in this case I think it's fine to be a bit
proactive and warn users that we know there are still some unf
everythingfunctional wrote:
> Since we are making this change now, should this PR be updated to follow
> clang's scheme of having `clang` point to `clang-$version`?
Sure. I've added what I believe does that.
> Having multiple active PR's for one change is IMHO rather confusing. It
> creates u
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/3] [flang][driver] rename flang-new to flang
--
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 649a73478c78389560042030a9717a05e8e338a8 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/2] [flang][driver] rename flang-new to flang
--
everythingfunctional wrote:
> That was all @banach-space's work, I only rebased his commit. Don't think
> that's worth co-authorship; though ultimately you can decide,
You did some of the leg work and pointed me at it. I think that deserves at
least some credit, and it's already there, so I do
everythingfunctional wrote:
> I have seen some more matches for flang-new in the tree:
Good catch. I'm pretty sure I got them all now
> Is there a symbolic link `flang-new` -> `flang`? We would like to have a
> transitional period.
I wasn't quite sure it was warranted, but seems like it is so
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 1e76b6c130953cbfa519c7a00411d47e089afbc4 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH 1/2] [flang][driver] rename flang-new to flang
--
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From f6750a2a1e6710f00a93e11f4c2182dd5377a341 Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH] [flang][driver] rename flang-new to flang
---
c
https://github.com/everythingfunctional updated
https://github.com/llvm/llvm-project/pull/110023
>From 38b43f6c2d90420c775d4658e7c472b323bfc30e Mon Sep 17 00:00:00 2001
From: Brad Richardson
Date: Wed, 25 Sep 2024 13:25:22 -0500
Subject: [PATCH] [flang][driver] rename flang-new to flang
---
c
https://github.com/everythingfunctional created
https://github.com/llvm/llvm-project/pull/110023
This does a global rename from `flang-new` to `flang`. I also removed/changed
any TODOs that I found related to making this change.
>From cd3960354231edcf3dce4860bc56243b33fc7f01 Mon Sep 17 00:00:0
everythingfunctional wrote:
> > Not that it's the end of the world if this doesn't get in before the this
> > release, but @sscalpone , exactly what feedback are we wanting before
> > merging?
>
> IIUC, this:
> https://discourse.llvm.org/t/proposal-rename-flang-new-to-flang/69462/55
ok, but
everythingfunctional wrote:
Not that it's the end of the world if this doesn't get in before the this
release, but @sscalpone , exactly what feedback are we wanting before merging?
https://github.com/llvm/llvm-project/pull/74377
___
cfe-commits mailin
26 matches
Mail list logo
