[PATCH] D154871: [clang] Satisfy clang v12

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46333f71f8e0: [clang] Satisfy clang v12 (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D154871: [clang] Satisfy clang v12

ashay-github updated this revision to Diff 538816. ashay-github added a comment. Rebased with main to trigger rebuild Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154871/new/ https://reviews.llvm.org/D154871 Files: clang/lib/StaticAnalyzer/Chec

[PATCH] D154871: [clang] Satisfy clang v12

ashay-github created this revision. ashay-github added reviewers: steakhal, xazax.hun, Szelethus. Herald added a subscriber: martong. Herald added a reviewer: NoQ. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ashay-github added a comment. > For pure test updates, best to include `[test] `in the subject :) Ah, sorry! Thanks for letting me know, I'll keep that in mind for the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https://revi

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG969ab7134f4d: [clang] drop buggy use of `-serialize-diagnostics` flag (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https:/

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ashay-github updated this revision to Diff 501516. ashay-github added a comment. Rebased with main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144934/new/ https://reviews.llvm.org/D144934 Files: clang/test/ClangScanDeps/P1689.cppm In

[PATCH] D144934: [clang] drop buggy use of `-serialize-diagnostics` flag

ashay-github created this revision. ashay-github added reviewers: ChuanqiXu, jansvoboda11, ben.boeckel. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `-serialize-diagnostics` flag requires a f

[PATCH] D133773: [clang] fix linker executable path in test

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1848b0a0ed7: [clang] fix linker executable path in test (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github added a comment. @alvinhochun @mstorsjo Let me know if you'd like to see more changes. With the new regex, the tests pass at my end as well as in the Phabricator CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://re

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github updated this revision to Diff 459791. ashay-github added a comment. Updated the regex to `ld{{(.lld)?}}{{(.exe)?}}"`, so that it matches the following sequences: `ld`, `ld.lld`, `ld.exe`, `ld.lld.exe`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github updated this revision to Diff 459771. ashay-github added a comment. Thanks! I updated the regex to be `ld{{.*}}"`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133773/new/ https://reviews.llvm.org/D133773 Files: clang/test/Driver/

[PATCH] D133773: [clang] fix linker executable path in test

ashay-github created this revision. ashay-github added reviewers: alvinhochun, rnk, mstorsjo, stella.stamenova. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A previous patch (https://reviews.llvm

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1bb3016ddc8: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github added inline comments. Comment at: llvm/cmake/modules/TableGen.cmake:147 + cmake_parse_arguments(ADD_TABLEGEN "${options}" "${oneValueArgs}" +"${multiValueArgs}" ${ARGN}) + nikic wrote: > I think it would be fine to write this as just > `cmake_

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github updated this revision to Diff 450661. ashay-github marked an inline comment as done. ashay-github added a comment. Simply invocation of `cmake_parse_arguments()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131282/new/ https://review

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github marked an inline comment as done. ashay-github added inline comments. Comment at: llvm/cmake/modules/TableGen.cmake:199 COMPONENT ${target} RUNTIME DESTINATION "${${project}_TOOLS_INSTALL_DIR}") if(NOT LLVM_ENABLE_IDE)

[PATCH] D131282: [mlir] fix `add_tablegen()` macro to allow installing mlir-pdll

ashay-github updated this revision to Diff 450614. ashay-github added a comment. Herald added subscribers: cfe-commits, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, nicolasvasilache,