ashay-github created this revision. ashay-github added reviewers: ChuanqiXu, jansvoboda11, ben.boeckel. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits.
The `-serialize-diagnostics` flag requires a filename to be passed immediately after it, but the filename argument was skipped in the P1689 <https://reviews.llvm.org/P1689>.cppm clang test. This caused the code to incorrectly consume the argument that followed as the dignostics file. Since the `-serialize-diagnostics` flag isn't needed for this test to work, this patch removes it instead of passing a file argument. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D144934 Files: clang/test/ClangScanDeps/P1689.cppm Index: clang/test/ClangScanDeps/P1689.cppm =================================================================== --- clang/test/ClangScanDeps/P1689.cppm +++ clang/test/ClangScanDeps/P1689.cppm @@ -40,7 +40,7 @@ // // Check that we can mix the use of -format=p1689 and -fmodules. // RUN: clang-scan-deps -format=p1689 \ -// RUN: -- %clang++ -std=c++20 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -serialize-diagnostics -c %t/impl_part.cppm -o %t/impl_part.o \ +// RUN: -- %clang++ -std=c++20 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -c %t/impl_part.cppm -o %t/impl_part.o \ // RUN: | FileCheck %t/impl_part.cppm -DPREFIX=%/t //--- P1689.json.in
Index: clang/test/ClangScanDeps/P1689.cppm =================================================================== --- clang/test/ClangScanDeps/P1689.cppm +++ clang/test/ClangScanDeps/P1689.cppm @@ -40,7 +40,7 @@ // // Check that we can mix the use of -format=p1689 and -fmodules. // RUN: clang-scan-deps -format=p1689 \ -// RUN: -- %clang++ -std=c++20 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -serialize-diagnostics -c %t/impl_part.cppm -o %t/impl_part.o \ +// RUN: -- %clang++ -std=c++20 -fmodules -fimplicit-module-maps -fmodules-cache-path=%t/cache -c %t/impl_part.cppm -o %t/impl_part.o \ // RUN: | FileCheck %t/impl_part.cppm -DPREFIX=%/t //--- P1689.json.in
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
