[PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud abandoned this revision. aaboud marked an inline comment as not done. aaboud added a comment. Changes in this patch are being reviewed in a new patch https://reviews.llvm.org/D31871. https://reviews.llvm.org/D22045 ___ cfe-commits mailing li

[PATCH] D16135: Macro Debug Info support in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL294637: [DebugInfo] Added support to Clang FE for generating debug info for… (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D16135?vs=87819&id=87881#toc Repository: rL LLVM

r294637 - [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros.

Author: aaboud Date: Thu Feb 9 16:07:24 2017 New Revision: 294637 URL: http://llvm.org/viewvc/llvm-project?rev=294637&view=rev Log: [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros. Added "-fdebug-macro" flag (and "-fno-debug-macro" flag) to enable (and to

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87819. aaboud marked 2 inline comments as done. aaboud added a comment. Added test cases for driver debug info macro flags in test/Driver/debug-options.c Applied some changes to the documentation suggested by Ardian. https://reviews.llvm.org/D16135 Files:

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. > How are you measuring the build time? Total time for, say "ninja clang" with > full parallelism? That'd be hard to measure the actual impact (since it could > be the link time or other things are dominating, etc). If you have a reliable > way to time (I'm assuming Inte

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87796. aaboud added a comment. Added flag to control macro debug info generation: 1. -fdebug-macro (-fno-debug-macro) for Clang driver 2. -debug-info-macro for Clang compiler (-cc1) Also, made sure FE will discard this flag when debug info is not required, i.

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. > How much does the build directory grow? > Is there any noticeable compile time regression? I build clang in release mode using GCC, then used that build to build clang in debug mode with "-fstandalone-debug" flag, one time with my changes and another time without my c

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. In https://reviews.llvm.org/D16135#669416, @aprantl wrote: > In https://reviews.llvm.org/D16135#669045, @aaboud wrote: > > > Addressed Adrian last comments. > > Added a LIT tests that covers all the macro kinds: > > > > 1. built-in (define) > > 2. command-line (define, in

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87408. aaboud marked 2 inline comments as done. aaboud added a comment. Addressed Adrian last comments. Added a LIT tests that covers all the macro kinds: 1. built-in (define) 2. command-line (define, include, undef) 3. main source (define, include, undef) Ch

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 87020. aaboud marked 4 inline comments as done. aaboud added a comment. Addressed Adrian's comments. Please, let me know if I missed any. Also, I improved the code and added explanation about the file inclusion structure that is being handled in the macro cal

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Thanks Adrian for the fast response. See some answers below. I will update the code and upload a new patch soon. Comment at: lib/CodeGen/MacroPPCallbacks.cpp:154 +StringRef SearchPath, StringRef RelativePath, const Module *Imported) { + // Only car

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 86669. aaboud marked an inline comment as done. aaboud added a comment. Address Adrian and Richard comments. Please, review the new patch and let me know if I need to change anything else. Thanks, Amjad https://reviews.llvm.org/D16135 Files: include/clan

[PATCH] D16135: Macro Debug Info support in Clang

aaboud marked 7 inline comments as done. aaboud added a comment. Thanks Adrian and Richard for the comments, I appreciate that. I am uploading a new patch that address most of the comments. Adrian, I answered some of your comments below. Thanks, Amjad Comment at: lib/CodeGen/

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Kindly reminder, I am still waiting for a review on this new patch. Thanks https://reviews.llvm.org/D16135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Richard, can you please review the new patch? https://reviews.llvm.org/D16135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 82696. aaboud added a comment. Herald added subscribers: mgorny, nemanjai. Improved code based on Richard's comments. Removed the change to ASTConsumer, now it does not need to know anything about PP consumer. However, I still needed to change the CodeGenerato

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

This revision was automatically updated to reflect the committed changes. aaboud marked an inline comment as done. Closed by commit rL290515: [DebugInfo] Added support for Checksum debug info feature. (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D27641?vs=81953&id=824

r290515 - [DebugInfo] Added support for Checksum debug info feature.

Author: aaboud Date: Sun Dec 25 04:12:27 2016 New Revision: 290515 URL: http://llvm.org/viewvc/llvm-project?rev=290515&view=rev Log: [DebugInfo] Added support for Checksum debug info feature. Differential Revision: https://reviews.llvm.org/D27641 Added: cfe/trunk/test/CodeGen/Inputs/debug-in

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud updated this revision to Diff 81953. aaboud marked 3 inline comments as done. aaboud added a comment. Addressed comments by Reid and David. https://reviews.llvm.org/D27641 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h test/CodeGen/Inputs/debug-info-file-checksum.c

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud added a subscriber: bwyma. aaboud updated this revision to Diff 81640. aaboud added a comment. Moved getChecksum from SourceManager to CGDebugInfo. Also, now checksum is emitted only for CodeView. https://reviews.llvm.org/D27641 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugI

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL289701: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of… (authored by aaboud). Changed prior to commit: https://reviews.llvm.org/D27763?vs=81397&id=81438#toc Repository:

r289701 - [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory.

Author: aaboud Date: Wed Dec 14 14:24:40 2016 New Revision: 289701 URL: http://llvm.org/viewvc/llvm-project?rev=289701&view=rev Log: [DebugInfo] Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. This way it will be easier to expand DIFile (e.g., to contain c

[PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

aaboud created this revision. aaboud added a reviewer: rnk. aaboud added a subscriber: cfe-commits. Changed DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. This way it will be easier to expand DIFile (e.g., to contain checksum) without the need to modify the crea

[PATCH] D27641: DebugInfo: Added support for Checksum debug info feature (Clang part)

aaboud created this revision. aaboud added reviewers: rnk, probinson, rsmith. aaboud added a subscriber: cfe-commits. Resolve Bug 30978 . This patch contains changes in Clang to support Checksum debug info feature. https://reviews.llvm.org/D27641 Fi

[PATCH] D16135: Macro Debug Info support in Clang

aaboud added a comment. Thanks Richard for reviewing the patch and for the comments. Please, see answers below. Regards, Amjad Comment at: include/clang/AST/ASTConsumer.h:163 + /// The caller takes ownership on the returned pointer. + virtual std::unique_ptr CreatePreproces

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud marked an inline comment as not done. Comment at: include/clang/Basic/Attr.td:1674 @@ +1673,3 @@ + TargetSpecificAttr { + let Spellings = [GNU<"no_caller_saved_registers">]; + let Subjects = SubjectList<[FunctionLike], WarnDiag, "Expected

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud marked 3 inline comments as done. aaboud added a comment. In https://reviews.llvm.org/D22045#506996, @joerg wrote: > For what it is worth, this certainly seems to be misnamed. By nature, if it > doesn't preserve at least the stack pointer, there is no way to recover on > return, right?

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud updated this revision to Diff 66810. aaboud added a comment. Made "no_caller_saved_registers" part of function prototype. This will allow Clang to yell a warning when there is a mismatch between function pointer and assigned function value. Thanks to Erich for implementing this addition c

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

aaboud added a comment. > ISTM that the DWARF spec intended such thunks to be encoded as > `DW_AT_trampoline`. That seems more appropriate than relying on codegen > emitting a tailcall. This way the debugger can make the policy decision of > whether or not thunks should show up in the backtra

Re: [PATCH] D22900: Revert r244207 - Mark calls in thunk functions as tail-call optimization

aaboud added a comment. Reverting https://reviews.llvm.org/rL244207, would be fine if we assure that PR24235, is fixed in another way. I added Reid who helped reviewing the original patch https://reviews.llvm.org/D11476. https://reviews.llvm.org/D22900 __

Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud added reviewers: erichkeane, bwyma. aaboud updated this revision to Diff 65551. aaboud added a comment. Updated patch to top of trunk (r276746) - Thanks to Ranjeet Singh. Please, provide your feedback. https://reviews.llvm.org/D16135 Files: include/clang/AST/ASTConsumer.h lib/AST/AS

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud updated this revision to Diff 65269. aaboud added a comment. Updated test according to comments. https://reviews.llvm.org/D22045 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td lib/CodeGen/CGCall.cpp lib/Sema/SemaDeclAttr.cpp test/CodeGenCXX/attr-x86-no_calle

Re: [PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud marked an inline comment as done. Comment at: include/clang/Basic/Attr.td:1657 @@ +1656,3 @@ + TargetSpecificAttr { + let Spellings = [GNU<"no_caller_saved_registers">]; + let Subjects = SubjectList<[FunctionLike], WarnDiag, "ExpectedFunc

[PATCH] D22045: [X86] Support of no_caller_saved_registers attribute (Clang part)

aaboud created this revision. aaboud added reviewers: ABataev, DavidKreitzer, hjl.tools, qcolombet. aaboud added a subscriber: cfe-commits. This patch implements the Clang part for no_caller_saved_registers attribute as appear in [[ https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=5ed3cc7b66af4758f

Re: [PATCH] D21766: [codeview][clang] Added support for unnamed bitfield type.

aaboud abandoned this revision. aaboud added a comment. Different implementation was committed at http://reviews.llvm.org/rL274201. http://reviews.llvm.org/D21766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

aaboud accepted this revision. aaboud added a comment. This revision is now accepted and ready to land. LGTM. Please update PR28162. http://reviews.llvm.org/D21783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

Re: [PATCH] D21783: [CodeView] Implement support for bitfields in Clang

aaboud added a comment. Looks good, one minor comments below. Comment at: lib/CodeGen/CGDebugInfo.h:243 @@ +242,3 @@ + llvm::DIScope *RecordTy, + const RecordDecl *RD, SourceLocation Loc); + You

[PATCH] D21766: [codeview][clang] Added support for unnamed bitfield type.

aaboud created this revision. aaboud added reviewers: rnk, majnemer. aaboud added subscribers: cfe-commits, bwyma. Allow creating DI metadata for non-zero width unnamed bitfield members when emitting CodeView. This is needed for patch D21489. http://reviews.llvm.org/D21766 Files: lib/CodeGen/

r268151 - Reverting 268055 as it caused PR27579.

Author: aaboud Date: Fri Apr 29 20:44:38 2016 New Revision: 268151 URL: http://llvm.org/viewvc/llvm-project?rev=268151&view=rev Log: Reverting 268055 as it caused PR27579. Removed: cfe/trunk/test/CodeGenCXX/debug-info-lb.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp cfe/trunk/li

Re: [PATCH] D19727: [MS] Improved implementation #pragma pack (MS pragmas, part 2)

aaboud added a subscriber: aaboud. Comment at: cfe/trunk/lib/Sema/SemaAttr.cpp:110 @@ -200,3 +109,3 @@ case POAK_Reset: // Reset just pops the top of the stack, or resets the current alignment to You forgot to initialize "Alignment" in this case. This is

r268055 - Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Fri Apr 29 11:08:08 2016 New Revision: 268055 URL: http://llvm.org/viewvc/llvm-project?rev=268055&view=rev Log: Recommitted r264281 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 in r267004. Added: cfe/trunk/test/CodeGenCXX/d

r264281 - Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Thu Mar 24 08:30:41 2016 New Revision: 264281 URL: http://llvm.org/viewvc/llvm-project?rev=264281&view=rev Log: Recommitted r263425 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26942 (the fix is included in this commit). Differential

r263425 - Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info."

Author: aaboud Date: Mon Mar 14 07:03:55 2016 New Revision: 263425 URL: http://llvm.org/viewvc/llvm-project?rev=263425&view=rev Log: Recommitted r261634 "Supporting all entities declared in lexical scope in LLVM debug info." After fixing PR26715 at r263379. Added: cfe/trunk/test/CodeGenCXX/d

r263380 - Added test that covers changes in r263379.

Author: aaboud Date: Sun Mar 13 06:12:57 2016 New Revision: 263380 URL: http://llvm.org/viewvc/llvm-project?rev=263380&view=rev Log: Added test that covers changes in r263379. Added: cfe/trunk/test/CodeGen/debug-info-imported-entity.cpp Added: cfe/trunk/test/CodeGen/debug-info-imported-entit

r262830 - Resolved Bug 26414.

Author: aaboud Date: Mon Mar 7 08:22:46 2016 New Revision: 262830 URL: http://llvm.org/viewvc/llvm-project?rev=262830&view=rev Log: Resolved Bug 26414. https://llvm.org/bugs/show_bug.cgi?id=26414 Since interrupt handler must be returned with iret, tail call can't be used. Differential Revision:

Re: [PATCH] D17853: Disable tail-call optimization for X86 interrupt handlers

This revision was automatically updated to reflect the committed changes. Closed by commit rL262830: Resolved Bug 26414. (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D17853?vs=49746&id=49953#toc Repository: rL LLVM http://reviews.llvm.org/D17853 Files: cfe/trunk/

[PATCH] D17853: Disable tail-call optimization for X86 interrupt handlers

aaboud created this revision. aaboud added reviewers: hjl.tools, DavidKreitzer, ABataev. aaboud added a subscriber: cfe-commits. Resolved Bug 26414. https://llvm.org/bugs/show_bug.cgi?id=26414 Since interrupt handler must be returned with iretq, tail call can't be used. http://reviews.llvm.org/

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

This revision was automatically updated to reflect the committed changes. Closed by commit rL261634: Supporting all entities declared in lexical scope in LLVM debug info. (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D15977?vs=47988&id=48808#toc Repository: rL LLVM

r261634 - Supporting all entities declared in lexical scope in LLVM debug info.

Author: aaboud Date: Tue Feb 23 07:37:18 2016 New Revision: 261634 URL: http://llvm.org/viewvc/llvm-project?rev=261634&view=rev Log: Supporting all entities declared in lexical scope in LLVM debug info. Differential Revision: http://reviews.llvm.org/D15977 Added: cfe/trunk/test/CodeGenCXX/de

Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 47997. aaboud marked an inline comment as done. aaboud added a comment. Applied Adrian comment. http://reviews.llvm.org/D16135 Files: include/clang/AST/ASTConsumer.h lib/AST/ASTConsumer.cpp lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud updated this revision to Diff 47988. aaboud added a comment. Simplified LIT tests according to David comment. http://reviews.llvm.org/D15977 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp test/CodeGenCXX/debug-info-lb.cpp Index: lib/CodeGen/C

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud updated this revision to Diff 46708. aaboud added a comment. Reduced the LIT tests and added comment explaining part of it. http://reviews.llvm.org/D15977 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp test/CodeGenCXX/debug-info-lb.cpp Index:

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud marked an inline comment as done. aaboud added a comment. Thanks David for the comments. See answer below. Comment at: lib/CodeGen/CGDebugInfo.cpp:1489 @@ +1488,3 @@ + if (I != LexicalBlockMap.end()) { +RetainedTypes.push_back(Ty.getAsOpaquePtr()); +return I->sec

Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud updated this revision to Diff 46034. aaboud marked 6 inline comments as done. aaboud added a comment. Added comments explaining the implementation. http://reviews.llvm.org/D16135 Files: include/clang/AST/ASTConsumer.h lib/AST/ASTConsumer.cpp lib/CodeGen/CGDebugInfo.cpp lib/CodeGe

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud marked an inline comment as done. aaboud added a comment. Thanks David for the feedback. I have some answers below, please let me know if they are not sufficient or you are still have concerns. Comment at: lib/CodeGen/CGDebugInfo.cpp:1479 @@ +1478,3 @@ +void CGDebugInfo:

Re: [PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud updated this revision to Diff 45400. aaboud added a comment. Merged all 4 Lit tests into one. http://reviews.llvm.org/D15977 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGDecl.cpp test/CodeGenCXX/debug-info-lb.cpp Index: lib/CodeGen/CGDecl.cpp ==

Re: [PATCH] D16135: Macro Debug Info support in Clang

aaboud added inline comments. Comment at: include/clang/AST/ASTConsumer.h:163 @@ -155,1 +162,3 @@ + /// The caller takes ownership on the returned pointer. + virtual std::unique_ptr CreatePreprocessorCallbacks(Preprocessor &PP); }; Richard, I know that you sug

[PATCH] D16135: Macro Debug Info support in Clang

aaboud created this revision. aaboud added reviewers: dblaikie, rsmith, aprantl, probinson. aaboud added a subscriber: cfe-commits. Added support for FE Clang to create Debug Info entries (DIMacro and DIMacroFile) into generated module if "debug-info-kind" flag is set to "standalone". http://re

[PATCH] D15977: [Clang] Supporting all entities declared in lexical scope in LLVM debug info

aaboud created this revision. aaboud added reviewers: probinson, aprantl, echristo, dblaikie. aaboud added a subscriber: cfe-commits. This is the full implementation in Clang of the proposal: http://lists.llvm.org/pipermail/llvm-dev/2015-December/093313.html http://reviews.llvm.org/D15977 Files:

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

This revision was automatically updated to reflect the committed changes. Closed by commit rL250158: [X86] Add XSAVE intrinsic family (authored by aaboud). Changed prior to commit: http://reviews.llvm.org/D13014?vs=37108&id=37238#toc Repository: rL LLVM http://reviews.llvm.org/D13014 Files

r250158 - [X86] Add XSAVE intrinsic family

Author: aaboud Date: Tue Oct 13 07:29:35 2015 New Revision: 250158 URL: http://llvm.org/viewvc/llvm-project?rev=250158&view=rev Log: [X86] Add XSAVE intrinsic family Add intrinsics for the XSAVE instructions (XSAVE/XSAVE64/XRSTOR/XRSTOR64) XSAVEOPT instructions (XSAVEOPT/XSAVEOPT64) XSAVEC

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

aaboud updated this revision to Diff 37108. aaboud added a comment. Added two LIT tests to check the xsave intrinsic instructions. Repository: rL LLVM http://reviews.llvm.org/D13014 Files: include/clang/Basic/BuiltinsX86.def lib/CodeGen/CGBuiltin.cpp lib/Headers/CMakeLists.txt lib/He

Re: [PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

aaboud added a comment. In http://reviews.llvm.org/D13014#264638, @delena wrote: > Do you need to add some tests for clang? I thought I did (see "builtins-x86.c"). This is how other intrinsic instructions are tested by clang, am I missing something? Repository: rL LLVM http://reviews.llvm

[PATCH] D13014: [X86] Add XSAVE intrinsics (Clang part)

aaboud created this revision. aaboud added reviewers: mkuper, delena, craig.topper. aaboud added a subscriber: cfe-commits. aaboud set the repository for this revision to rL LLVM. Add intrinsics for the XSAVE instructions: XSAVE, XSAVE64 XRSTOR, XRSTOR64 XSAVEOPT, XSAVEOPT64 XRSTORS, XRSTORS64 XSA

Re: [PATCH] D11476: Marked call instruction in thunk function with tail attribute when applicable

aaboud retitled this revision from "Marked call instruction in thunk function with musttail attribute when applicable" to "Marked call instruction in thunk function with tail attribute when applicable". aaboud updated the summary for this revision. aaboud updated this revision to Diff 31341. Rep