alanzhao1 wrote:
FYI this change messes up formatting of angle brackets for member function
template parameters.
See #123144
https://github.com/llvm/llvm-project/pull/100980
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
alanzhao1 wrote:
Managed to reproduce it. This seems to break if the sysroot is set to the one
Chrome uses. Our sysroot can be downloaded at
https://commondatastorage.googleapis.com/chrome-linux-sysroot/dec7a3a0fc5b83b909cba1b6d119077e0429a138eadef6bf5a0f2e03b1904631
Command I used:
```
$ cma
https://github.com/alanzhao1 closed
https://github.com/llvm/llvm-project/pull/115570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alanzhao1 created
https://github.com/llvm/llvm-project/pull/115570
Reverts llvm/llvm-project#114070
Reason: Causes `immintrin.h` to fail to compile if `-msse` and `-mno-sse2` are
passed to clang:
https://github.com/llvm/llvm-project/pull/114070#issuecomment-2465926700
>Fro
alanzhao1 wrote:
Figured out a repro - `immintrin.h` doesn't compile if both `-msse` and
`-mno-sse2` are passed to clang:
```
$ cat ~/src/test-mac.c
#include
$ bin/clang -msse -mno-sse2 -o /dev/null -c ~/src/test-mac.c
In file included from /usr/local/google/home/ayzhao/src/test-mac.c:1:
In fi
alanzhao1 wrote:
> FYI this is causing Chrome X86 MacOS builds to fail due to `error: unknown
> type name '__m512bh'`: https://crbug.com/378111077
As I mentioned in https://crbug.com/378111077#comment3, the issue is that we
pull in avx512bf16intrin.h because `__SCE__` is not defined, but `__SS
alanzhao1 wrote:
FYI this is causing Chrome X86 MacOS builds to fail due to `error: unknown type
name '__m512bh'`: https://crbug.com/378111077
https://github.com/llvm/llvm-project/pull/114070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
alanzhao1 wrote:
> Reverted. The issue looks like the instantiation of the default argument was
> skipped, but without any previous error actually being produced, so it
> proceeded to CodeGen with invalid AST.
Thanks! Still waiting on CReduce for that repro.
https://github.com/llvm/llvm-proje
alanzhao1 wrote:
For posterity, here's the entire stacktrace I got:
```
/usr/local/google/home/ayzhao/src/llvm-project/build/bin/clang++ -MMD -MF
obj/third_party/dawn/src/dawn/tests/dawn_unittests/CacheRequestTests.o.d
-DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 -D__STDC_CONSTANT_MACROS
alanzhao1 wrote:
Based on the [patch reversion
policy](https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy), I
think reverting is the right thing to do.
(I'm working on the reduced repro, but creduce is _really_ slow. In the
meantime, I attached the unreduced files).
[unreduce
alanzhao1 wrote:
FYI this is causing Clang to crash with Chrome: https://crbug.com/377956048
I'm currently working on getting a reduced repro with CReduce.
https://github.com/llvm/llvm-project/pull/113777
___
cfe-commits mailing list
cfe-commits@lists
alanzhao1 wrote:
> @alanzhao1 @efriedma-quic It should be fixed now by #101268 if you role the
> clang build to latest.
Confirmed. Thanks!
https://github.com/llvm/llvm-project/pull/98949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
alanzhao1 wrote:
We (Chrome) are seeing linker failures on our x86 Windows builds due to this
PR: https://crbug.com/355455678
```
[12702/86218] LINK glmark2_wgl.exe glmark2_wgl.exe.pdb
..\..\third_party\llvm-build\Release+Asserts\bin\lld-link.exe
/OUT:./glmark2_wgl.exe /nologo
-libpath:..\..\
alanzhao1 wrote:
> > @alanzhao1 do you think it's reasonable for the workaround to only apply to
> > code in system headers, or does the NDK get included as regular headers
> > generally?
>
> Having it only apply to system headers should be OK - in our case, chrome
> imports these headers as
alanzhao1 wrote:
> @alanzhao1 do you think it's reasonable for the workaround to only apply to
> code in system headers, or does the NDK get included as regular headers
> generally?
Having it only apply to system headers should be OK - in our case, chrome
imports these headers as part of a `
alanzhao1 wrote:
Chrome's Windows debug builds also saw crashes due to this commit:
https://crbug.com/350541784
https://github.com/llvm/llvm-project/pull/93913
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
alanzhao1 wrote:
FYI this patch messes up some diagnostics with `-Wunreachable-code`:
https://godbolt.org/z/6TEdrx55d
If the unreachable code is a constructor with a default parameter that is a
builtin function, clang incorrectly highlights the call to the builtin instead
of the call to the c
https://github.com/alanzhao1 closed
https://github.com/llvm/llvm-project/pull/79225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alanzhao1 created
https://github.com/llvm/llvm-project/pull/79225
This test was originally introduced in
https://github.com/llvm/llvm-project/pull/76976, but it incorrectly tests
braced-list initialization instead of parenthesized initialization.
>From e68891368098b2ea488359
https://github.com/alanzhao1 closed
https://github.com/llvm/llvm-project/pull/76976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From 1ac47a1548f0dbd21747ef05c64fc2f08668e0e1 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH] [clang] Fix parenthesized list initialization of arrays not
working
alanzhao1 wrote:
If we pass `-v` to Clang, we get the following include directories:
without this patch:
```
clang -cc1 version 18.0.0git based upon LLVM 18.0.0git default target
arm64-apple-darwin23.3.0
ignoring nonexistent directory
"/Applications/Xcode.app/Contents/Developer/Platforms/MacO
alanzhao1 wrote:
Here's what I did to repro:
`include.cc`:
```cpp
#include
```
Build clang:
```
$ cmake -G Ninja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_LLD=False
-DLLVM_CCACHE_BUILD=True -DLLVM_ENABLE_PROJECTS="clang"
-DLLVM_TARGETS_TO_BUILD="X86;ARM;AArch64" ../llvm
$ ninja clang
```
I
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/9] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/8] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/7] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 edited
https://github.com/llvm/llvm-project/pull/76976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer(
return true;
};
+ const InitListExpr *ILE = dyn_cast(Init);
+ const CXXParenListInitExpr *CPLIE = dyn_cast(Init);
+ const StringLiteral *SL = dyn_cast(Init);
// If the initializer is an initiali
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer(
return true;
};
+ const InitListExpr *ILE = dyn_cast(Init);
+ const CXXParenListInitExpr *CPLIE = dyn_cast(Init);
+ const StringLiteral *SL = dyn_cast(Init);
// If the initializer is an initiali
alanzhao1 wrote:
Ping. Any more comments?
https://github.com/llvm/llvm-project/pull/76976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alanzhao1 wrote:
> I believe the approach here is not sufficient and we have a current PR in
> progress: #76976
>
> we also need codegen work to implement this.
Correct - here are some examples that will cause this to fail:
```cpp
void foo(int n) {
new int[n](1, 2);
}
```
```cpp
void bar()
@@ -1038,11 +1038,14 @@ void CodeGenFunction::EmitNewArrayInitializer(
return true;
};
+ const InitListExpr *ILE = dyn_cast(Init);
+ const CXXParenListInitExpr *CPLIE = dyn_cast(Init);
+ const StringLiteral *SL = dyn_cast(Init);
// If the initializer is an initiali
@@ -5495,14 +5495,12 @@ static void TryOrBuildParenListInitialization(
return;
}
// ...and value-initialized for each k < i <= n;
-if (ArrayLength > Args.size()) {
alanzhao1 wrote:
> What is this change supposed to do?
`CodeGenFunction::
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/6] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/5] [clang] Fix parenthesized list initialization of arrays
not wor
alanzhao1 wrote:
> Have you considered the following case?
>
> ```
> void foo() {
> char* arr = new char[]("asdf");
> }
> ```
Thanks for catching this - this causes this patch to crash. Working on this
right now.
https://github.com/llvm/llvm-project/pull/76976
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/4] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/3] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 updated
https://github.com/llvm/llvm-project/pull/76976
>From ee4e3c8634bb876166ee753a4ebcbf3c1699a175 Mon Sep 17 00:00:00 2001
From: Alan Zhao
Date: Wed, 3 Jan 2024 12:29:21 -0800
Subject: [PATCH 1/2] [clang] Fix parenthesized list initialization of arrays
not wor
https://github.com/alanzhao1 created
https://github.com/llvm/llvm-project/pull/76976
This bug is caused by parenthesized list initialization not being implemented
in `CodeGenFunction::EmitNewArrayInitializer(...)`.
Parenthesized list initialization of `struct`s with `operator new` already
wo
Author: Alan Zhao
Date: 2023-07-18T09:48:17-07:00
New Revision: fe0116aba833ee8597e2155d1e555c326acfaafc
URL:
https://github.com/llvm/llvm-project/commit/fe0116aba833ee8597e2155d1e555c326acfaafc
DIFF:
https://github.com/llvm/llvm-project/commit/fe0116aba833ee8597e2155d1e555c326acfaafc.diff
LOG
Author: Alan Zhao
Date: 2023-05-31T13:52:45-07:00
New Revision: 1cf5188c72902e85e85095d788f5dfa138c320f8
URL:
https://github.com/llvm/llvm-project/commit/1cf5188c72902e85e85095d788f5dfa138c320f8
DIFF:
https://github.com/llvm/llvm-project/commit/1cf5188c72902e85e85095d788f5dfa138c320f8.diff
LOG
Author: Alan Zhao
Date: 2023-05-09T10:31:43-07:00
New Revision: d1d35f04c6cb2e3d5b0fbc6101d5425a33f8fc63
URL:
https://github.com/llvm/llvm-project/commit/d1d35f04c6cb2e3d5b0fbc6101d5425a33f8fc63
DIFF:
https://github.com/llvm/llvm-project/commit/d1d35f04c6cb2e3d5b0fbc6101d5425a33f8fc63.diff
LOG
Author: Alan Zhao
Date: 2023-05-01T10:26:15-07:00
New Revision: f762798599171efca03964f4371cc8104d2392f9
URL:
https://github.com/llvm/llvm-project/commit/f762798599171efca03964f4371cc8104d2392f9
DIFF:
https://github.com/llvm/llvm-project/commit/f762798599171efca03964f4371cc8104d2392f9.diff
LOG
Author: Alan Zhao
Date: 2023-05-01T10:02:15-07:00
New Revision: 9b4faa11c68be4b45ddf29acd575bb52a3c2fad7
URL:
https://github.com/llvm/llvm-project/commit/9b4faa11c68be4b45ddf29acd575bb52a3c2fad7
DIFF:
https://github.com/llvm/llvm-project/commit/9b4faa11c68be4b45ddf29acd575bb52a3c2fad7.diff
LOG
Author: Alan Zhao
Date: 2023-05-01T09:27:52-07:00
New Revision: da0089c99ba1507b876cf3d2a205ba108aad65ff
URL:
https://github.com/llvm/llvm-project/commit/da0089c99ba1507b876cf3d2a205ba108aad65ff
DIFF:
https://github.com/llvm/llvm-project/commit/da0089c99ba1507b876cf3d2a205ba108aad65ff.diff
LOG
Author: Alan Zhao
Date: 2023-04-27T11:41:21-07:00
New Revision: 3e22eb36b6ffd60608a0e70401b021738c1c4fe8
URL:
https://github.com/llvm/llvm-project/commit/3e22eb36b6ffd60608a0e70401b021738c1c4fe8
DIFF:
https://github.com/llvm/llvm-project/commit/3e22eb36b6ffd60608a0e70401b021738c1c4fe8.diff
LOG
Author: Alan Zhao
Date: 2023-04-27T10:43:16-07:00
New Revision: 7417e9d75c9af7dd0d3dad12eebdee84b10b56d7
URL:
https://github.com/llvm/llvm-project/commit/7417e9d75c9af7dd0d3dad12eebdee84b10b56d7
DIFF:
https://github.com/llvm/llvm-project/commit/7417e9d75c9af7dd0d3dad12eebdee84b10b56d7.diff
LOG
Author: Alan Zhao
Date: 2023-03-30T15:06:37-07:00
New Revision: 7df3c71b508b65284483225685f1ba19777f2bbb
URL:
https://github.com/llvm/llvm-project/commit/7df3c71b508b65284483225685f1ba19777f2bbb
DIFF:
https://github.com/llvm/llvm-project/commit/7df3c71b508b65284483225685f1ba19777f2bbb.diff
LOG
Author: Alan Zhao
Date: 2023-01-12T09:58:15-08:00
New Revision: 95a4c0c83554c025ef709a6805e67233d0dedba0
URL:
https://github.com/llvm/llvm-project/commit/95a4c0c83554c025ef709a6805e67233d0dedba0
DIFF:
https://github.com/llvm/llvm-project/commit/95a4c0c83554c025ef709a6805e67233d0dedba0.diff
LOG
Author: Alan Zhao
Date: 2023-01-04T15:09:36-08:00
New Revision: 4e02ff2303f8a69cc2459b77bbb879b248df6ca9
URL:
https://github.com/llvm/llvm-project/commit/4e02ff2303f8a69cc2459b77bbb879b248df6ca9
DIFF:
https://github.com/llvm/llvm-project/commit/4e02ff2303f8a69cc2459b77bbb879b248df6ca9.diff
LOG
Author: Alan Zhao
Date: 2022-12-21T08:21:05-08:00
New Revision: c77a91bb7ba793ec3a6a5da3743ed55056291658
URL:
https://github.com/llvm/llvm-project/commit/c77a91bb7ba793ec3a6a5da3743ed55056291658
DIFF:
https://github.com/llvm/llvm-project/commit/c77a91bb7ba793ec3a6a5da3743ed55056291658.diff
LOG
Author: Alan Zhao
Date: 2022-12-14T07:54:15-08:00
New Revision: 40c52159d3ee337dbed14e4c73b5616ea354c337
URL:
https://github.com/llvm/llvm-project/commit/40c52159d3ee337dbed14e4c73b5616ea354c337
DIFF:
https://github.com/llvm/llvm-project/commit/40c52159d3ee337dbed14e4c73b5616ea354c337.diff
LOG
Author: Nicolas Lesser
Date: 2022-09-28T09:50:19-07:00
New Revision: 4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735
URL:
https://github.com/llvm/llvm-project/commit/4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735
DIFF:
https://github.com/llvm/llvm-project/commit/4848f3bf2ff5ec57a8e2b8d3676c947dcf0fd735.diff
Author: Alan Zhao
Date: 2022-09-28T09:48:00-07:00
New Revision: 6f2b34789541ff95d7f339eac5dc031d29655a58
URL:
https://github.com/llvm/llvm-project/commit/6f2b34789541ff95d7f339eac5dc031d29655a58
DIFF:
https://github.com/llvm/llvm-project/commit/6f2b34789541ff95d7f339eac5dc031d29655a58.diff
LOG
Author: Alan Zhao
Date: 2022-08-15T15:24:39-04:00
New Revision: ff8aadf58d1a0ea7d8fa2b9a7a17ff0c6059baa5
URL:
https://github.com/llvm/llvm-project/commit/ff8aadf58d1a0ea7d8fa2b9a7a17ff0c6059baa5
DIFF:
https://github.com/llvm/llvm-project/commit/ff8aadf58d1a0ea7d8fa2b9a7a17ff0c6059baa5.diff
LOG
Author: Paul Pluzhnikov
Date: 2022-06-02T18:00:19-04:00
New Revision: 4ad17d2e96a382e5f595bab30920ba26762a6fa9
URL:
https://github.com/llvm/llvm-project/commit/4ad17d2e96a382e5f595bab30920ba26762a6fa9
DIFF:
https://github.com/llvm/llvm-project/commit/4ad17d2e96a382e5f595bab30920ba26762a6fa9.dif
57 matches
Mail list logo
