[clang] [Clang][P1061] Fix template arguments in local classes (PR #121225)

2025-07-12 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/121225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6f92313 - [Clang][P1061] Fix template arguments in local classes (#121225)

2025-07-12 Thread via cfe-commits
Author: Jason Rice Date: 2025-07-13T06:17:41+03:00 New Revision: 6f923134ddf4afc4266c4c32854d7cc2793c23a1 URL: https://github.com/llvm/llvm-project/commit/6f923134ddf4afc4266c4c32854d7cc2793c23a1 DIFF: https://github.com/llvm/llvm-project/commit/6f923134ddf4afc4266c4c32854d7cc2793c23a1.diff LO

[clang] [Clang][P1061] Fix template arguments in local classes (PR #121225)

2025-07-12 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/121225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-07-12 Thread Julian Schmidt via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: @@ -140,6 +140,12 @@ Changes in existing checks calls of ``std::string`` constructor with char pointer

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-07-12 Thread Julian Schmidt via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?Message-ID: In-Reply-To: @@ -147,3 +148,16 @@ struct Name {\ // CHECK-MESSAGES: :[[@LINE+1]]:44: warning: tagged union has more d

[clang-tools-extra] [clang-tidy] Fix bugprone-tagged-union-member-count false-positive (PR #135831)

2025-07-12 Thread Julian Schmidt via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?=,=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?Message-ID: In-Reply-To: @@ -9,6 +9,9 @@ different from the number of data members inside the union. A struct or a class is conside

[clang-tools-extra] [clang-tidy] fix `bugprone-narrowing-conversions` false positive for conditional expression (PR #139474)

2025-07-12 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Please add more tests: - one of the args being, e.g., `int`, since there should still be a warning - also add those same tests to the C++ tests to cover that they are being handled correctly in both languages https://github.com/llvm/llvm-proje

[clang-tools-extra] [clang-tidy] fix `bugprone-narrowing-conversions` false positive for conditional expression (PR #139474)

2025-07-12 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/139474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix `bugprone-narrowing-conversions` false positive for conditional expression (PR #139474)

2025-07-12 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/139474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-12 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,254 @@ +//===--- AvoidPlatformSpecificFundamentalTypesCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-12 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,227 @@ +.. title:: clang-tidy - portability-avoid-platform-specific-fundamental-types + +portability-avoid-platform-specific-fundamental-types += + +Finds fundamental types (e.g. `int`, `float`) and recommends using ty

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-12 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,254 @@ +//===--- AvoidPlatformSpecificFundamentalTypesCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-12 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,254 @@ +//===--- AvoidPlatformSpecificFundamentalTypesCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Add portability-avoid-platform-specific-fundamental-types (PR #146970)

2025-07-12 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,227 @@ +.. title:: clang-tidy - portability-avoid-platform-specific-fundamental-types + +portability-avoid-platform-specific-fundamental-types += + +Finds fundamental types (e.g. `int`, `float`) and recommends using ty

[clang-tools-extra] [clang-tidy] Add filtering of check options by enabled checks in '--dump-config' (PR #147142)

2025-07-12 Thread Julian Schmidt via cfe-commits
@@ -503,6 +503,21 @@ getCheckNames(const ClangTidyOptions &Options, return Factory.getCheckNames(); } +void filterCheckOptions(ClangTidyOptions &Options, +const std::vector &EnabledChecks) { + StringSet<> EnabledChecksSet(llvm::from_range, EnabledChe

[clang-tools-extra] [clang-tidy] Add filtering of check options by enabled checks in '--dump-config' (PR #147142)

2025-07-12 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/147142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add filtering of check options by enabled checks in '--dump-config' (PR #147142)

2025-07-12 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/147142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Update `confusables.txt` in `misc-confusable-identifiers` (PR #148399)

2025-07-12 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook edited https://github.com/llvm/llvm-project/pull/148399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Add -march=unset to cancel and ignore a previous -march. (PR #148321)

2025-07-12 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. Thanks! The reactions include a thumbs-up and a love. Setting my approval. https://github.com/llvm/llvm-project/pull/148321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [RISCV] Add -march=unset to cancel and ignore a previous -march. (PR #148321)

2025-07-12 Thread Fangrui Song via cfe-commits
@@ -403,6 +403,11 @@ // MCPU-MARCH: "-nostdsysteminc" "-target-cpu" "sifive-e31" "-target-feature" "+m" "-target-feature" "+c" // MCPU-MARCH: "-target-abi" "ilp32" +// march=unset erases previous march MaskRay wrote: `/// -march=unset erases previous -march`

[clang] [llvm] [DTLTO][Clang] Add support for Integrated Distributed ThinLTO (PR #147265)

2025-07-12 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,43 @@ +// REQUIRES: lld + +/// Check DTLTO options are forwarded to the linker. + +// RUN: echo "--target=x86_64-linux-gnu \ +// RUN: -Xthinlto-distributor=distarg1 \ +// RUN: -Xthinlto-distributor=distarg2,distarg3 \ +// RUN: -fuse-ld=lld" > %t.rsp + +/// Check t

[clang-tools-extra] [clang-tidy] Improve `bugprone-exception-escape`: add stacktrace of escaped exception (PR #134375)

2025-07-12 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ran this check on `Poco`, `VTK` and `opencv` successfully, stack traces are printed correctly. https://github.com/llvm/llvm-project/pull/134375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] [clang-tools-extra][NFC] Fix link to code review in README.txt (PR #148384)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/148384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add filtering of check options by enabled checks in '--dump-config' (PR #147142)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/147142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][P1061] Fix template arguments in local classes (PR #121225)

2025-07-12 Thread Jason Rice via cfe-commits
ricejasonf wrote: I verified that it is still broken on trunk (on godbolt). It is now rebased on `main` with a shiny new release note. Please merge it if you think it is the right fix (and the tests finish). @cor3ntin https://github.com/llvm/llvm-project/pull/121225 __

[clang-tools-extra] [clang-tidy] `misc-confusable-identifiers`: Update `confusables.txt` (PR #148399)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM. You should place verb in commit message in front so that the whole message would be like a sentence: "Update 'confusables.txt' in 'misc-confusable-identifiers'" That is the usual way of naming in LLVM (see other open PRs) https://git

[clang] [Clang][P1061] Fix template arguments in local classes (PR #121225)

2025-07-12 Thread Jason Rice via cfe-commits
https://github.com/ricejasonf updated https://github.com/llvm/llvm-project/pull/121225 >From 5be8b4b38cb4d595d5e1ec53bdcda3bb24333644 Mon Sep 17 00:00:00 2001 From: Jason Rice Date: Mon, 5 Aug 2024 13:53:33 -0700 Subject: [PATCH] [Clang][P1061] Fix template arguments in local classes --- clan

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
vbvictor wrote: > > I will take a look at the weekend. > > No Rush, enjoy your weekend 😸 Thanks! But that's the only time I can thoughtfully read other code apart from main job 🙃 https://github.com/llvm/llvm-project/pull/144240 ___ cfe-commits maili

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/144240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
@@ -112,14 +115,17 @@ void UseIntegerSignComparisonCheck::registerPPCallbacks( void UseIntegerSignComparisonCheck::check( const MatchFinder::MatchResult &Result) { const auto *SignedCastExpression = - Result.Nodes.getNodeAs("sIntCastExpression"); - assert(SignedCast

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/144240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
@@ -39,21 +39,23 @@ intCastExpression(bool IsSigned, // std::cmp_{} functions trigger a compile-time error if either LHS or RHS // is a non-integer type, char, enum or bool // (unsigned char/ signed char are Ok and can be used). - auto IntTypeExpr = expr(hasType(hasCanon

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
@@ -91,7 +93,8 @@ void UseIntegerSignComparisonCheck::storeOptions( void UseIntegerSignComparisonCheck::registerMatchers(MatchFinder *Finder) { const auto SignedIntCastExpr = intCastExpression(true, "sIntCastExpression"); - const auto UnSignedIntCastExpr = intCastExpression

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr for use-integer-sign-comparison (PR #144240)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor commented: Could you add more tests, e.g. when we have "inverted" casts in GH127471 like this: ```cpp (unsigned int)a2.size() == size() //size() return int ``` I believe we could also be add more tests with different type of casts in GH127471 case. https://github.c

[clang] [RISCV] Add -march=unset to cancel and ignore a previous -march. (PR #148321)

2025-07-12 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/148321 >From 9521bd783966635f3219ac02e3fe43ed33294546 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Fri, 11 Jul 2025 17:42:49 -0700 Subject: [PATCH 1/3] [RISCV] Add -march=unset to cancel and ignore a previous -ma

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-07-12 Thread via cfe-commits
tcottin wrote: Thanks for the review! I pushed some fixes. https://github.com/llvm/llvm-project/pull/140498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-07-12 Thread via cfe-commits
@@ -352,40 +606,59 @@ TEST(BulletList, Render) { DeepDoc.addParagraph().appendText("baz"); StringRef ExpectedMarkdown = R"md(- foo - bar -- foo - baz - - foo -- baz +- foo + tcottin wrote: Yes. We have to add them because we now end a bullet

[clang-tools-extra] [clang-tidy] `misc-confusable-identifiers`: Update `confusables.txt` (PR #148399)

2025-07-12 Thread Victor Chernyakin via cfe-commits
localspook wrote: Taken from: https://www.unicode.org/Public/security/16.0.0/confusables.txt https://github.com/llvm/llvm-project/pull/148399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [clang-tidy] `misc-confusable-identifiers`: Update `confusables.txt` (PR #148399)

2025-07-12 Thread Baranov Victor via cfe-commits
vbvictor wrote: Is this file taken as-is from some place or crafted by hand? Could you share a source? https://github.com/llvm/llvm-project/pull/148399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-07-12 Thread via cfe-commits
@@ -370,40 +497,128 @@ std::unique_ptr Paragraph::clone() const { /// Choose a marker to delimit `Text` from a prioritized list of options. /// This is more readable than escaping for plain-text. -llvm::StringRef chooseMarker(llvm::ArrayRef Options, -

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-07-12 Thread via cfe-commits
@@ -370,40 +497,128 @@ std::unique_ptr Paragraph::clone() const { /// Choose a marker to delimit `Text` from a prioritized list of options. /// This is more readable than escaping for plain-text. -llvm::StringRef chooseMarker(llvm::ArrayRef Options, -

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-07-12 Thread via cfe-commits
@@ -370,40 +497,128 @@ std::unique_ptr Paragraph::clone() const { /// Choose a marker to delimit `Text` from a prioritized list of options. /// This is more readable than escaping for plain-text. -llvm::StringRef chooseMarker(llvm::ArrayRef Options, -

[clang-tools-extra] [clang-tidy] `misc-confusable-identifiers`: Update `confusables.txt` (PR #148399)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Victor Chernyakin (localspook) Changes We're currently on Unicode 14.0.0. This PR updates it to Unicode 16.0.0. --- Patch is 39.17 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/148399.di

[clang-tools-extra] [clang-tidy] `misc-confusable-identifiers`: Update `confusables.txt` (PR #148399)

2025-07-12 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook created https://github.com/llvm/llvm-project/pull/148399 We're currently on Unicode 14.0.0. This PR updates it to Unicode 16.0.0. >From e252ea0a1ac94e8324bb332037508fd3f9b61317 Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Sat, 12 Jul 2025 12:46:01 -0700

[clang-tools-extra] [clangd] Improve Markup Rendering (PR #140498)

2025-07-12 Thread via cfe-commits
@@ -1601,51 +1591,32 @@ std::optional getBacktickQuoteRange(llvm::StringRef Line, return Line.slice(Offset, Next + 1); } -void parseDocumentationLine(llvm::StringRef Line, markup::Paragraph &Out) { +void parseDocumentationParagraph(llvm::StringRef Text, markup::Paragraph &O

[clang] [Sema] Remove unnecessary casts (NFC) (PR #148338)

2025-07-12 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/148338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 78c12d3 - [Sema] Remove unnecessary casts (NFC) (#148338)

2025-07-12 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-07-12T11:28:26-07:00 New Revision: 78c12d380c369b53416518776ae53c3ba168cf7b URL: https://github.com/llvm/llvm-project/commit/78c12d380c369b53416518776ae53c3ba168cf7b DIFF: https://github.com/llvm/llvm-project/commit/78c12d380c369b53416518776ae53c3ba168cf7b.diff L

[clang-tools-extra] [clang-tidy] add modernize-use-constexpr check (PR #146553)

2025-07-12 Thread Thomas Schenker via cfe-commits
schenker wrote: I tested 6040ba1eed8d4fe6c573a11568c15cc66e31d4a3 and found this fixit that does not compile: **Input** ```cpp namespace { struct N { [[maybe_unused]] friend void operator<<(int&, const N&) {} }; } ``` ```console clang-tidy -checks="-*,*constexpr*" -export-fixes fixes.yaml tes

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. https://github.com/llvm/llvm-project/pull/148384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. Looks OK for me, but please wait for other reviewers, I may miss something :-) https://github.com/llvm/llvm-project/pull/148384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread via cfe-commits
EugeneZelenko wrote: > > There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they > > should be mentioned explicitly? > > Added links to them as a list, do you think we need a new entry for each of > the link? IMO from reading the link name, user can understand where it poin

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread Baranov Victor via cfe-commits
vbvictor wrote: > There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they > should be mentioned explicitly? Added links to them as a list, do you think we need a new entry for each of the link? https://github.com/llvm/llvm-project/pull/148384 __

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/148384 >From 11662e5e11ff14667893282cd05c4fa7c4be706e Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 12 Jul 2025 19:51:24 +0300 Subject: [PATCH 1/2] [clang-tools-extra] fix link to code review in README.txt

[clang-tools-extra] [clang-tidy] Use lexical anon-ns matcher in llvm-prefer-static-over-anonymous-namespace (PR #148357)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/148357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 45f7285 - [clang-tidy] Use lexical anon-ns matcher in llvm-prefer-static-over-anonymous-namespace (#148357)

2025-07-12 Thread via cfe-commits
Author: Baranov Victor Date: 2025-07-12T20:05:05+03:00 New Revision: 45f7285d0ef35615cc9ba665ed54fdb4c6d1c711 URL: https://github.com/llvm/llvm-project/commit/45f7285d0ef35615cc9ba665ed54fdb4c6d1c711 DIFF: https://github.com/llvm/llvm-project/commit/45f7285d0ef35615cc9ba665ed54fdb4c6d1c711.diff

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread via cfe-commits
EugeneZelenko wrote: There are dedicated Discourse topics for Clangd and Clang-Tidy. May be they should be mentioned explicitly? https://github.com/llvm/llvm-project/pull/148384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes I'm not sure if we need to add label inside link or not, but `lists.llvm.org` seems outdated for sure, WDYT? --- Full diff: https://github.com/llvm/llvm-project/pull/148384.diff 1 Files Affe

[clang-tools-extra] [clang-tools-extra][NFC] fix link to code review in README.txt (PR #148384)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/148384 I'm not sure if we need to add label inside link or not, but `lists.llvm.org` seems outdated for sure, WDYT? >From 11662e5e11ff14667893282cd05c4fa7c4be706e Mon Sep 17 00:00:00 2001 From: Victor Baranov Date:

[clang] [clang-format] Add FunctionLikeMacros option (PR #148345)

2025-07-12 Thread Owen Pan via cfe-commits
@@ -2786,6 +2786,11 @@ struct FormatStyle { /// \version 3.7 std::vector ForEachMacros; + /// A vector of function-like macros whose invocations should be skipped by + /// ``RemoveParentheses``. + /// \version 21 + std::vector FunctionLikeMacros; owenc

[clang] [clang-format][NFC] Simplify some logic in BreakableLineCommentSection (PR #148324)

2025-07-12 Thread Owen Pan via cfe-commits
@@ -927,14 +927,12 @@ BreakableLineCommentSection::BreakableLineCommentSection( } if (Lines[i].size() != IndentPrefix.size()) { -PrefixSpaceChange[i] = FirstLineSpaceChange; +assert(Lines[i].size() > IndentPrefix.size()); -if (SpacesInPref

[clang] [clang-tools-extra] [Clang] [Diagnostics] Simplify filenames that contain '..' (PR #143520)

2025-07-12 Thread via cfe-commits
Sirraide wrote: > my worry about ill-effects from canonicalization of the user's > build-dir-relative file paths into absolute paths is a more general one Yeah, and moreover, another point I just thought of is that users tend to have more control over their own include directories, i.e. if you

[clang] [CIR] Implement SubOp for ComplexType (PR #148025)

2025-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/10643 Here is the relev

[clang] [Clang] Allow vanilla C function symbol name to be used in __attribute__((alias)) when -funique-internal-linkage-names is specified (PR #145652)

2025-07-12 Thread via cfe-commits
https://github.com/HighW4y2H3ll updated https://github.com/llvm/llvm-project/pull/145652 >From 9a29dd6fa3f28bf507f047a22597f8510bd096b3 Mon Sep 17 00:00:00 2001 From: h2h Date: Tue, 24 Jun 2025 23:24:32 -0700 Subject: [PATCH 1/9] [Clang] Allow vanilla C function symbol name to be used in __att

[clang] [CIR][NFC] Resolve various nits for builtin bit operations (PR #148378)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Sirui Mu (Lancern) Changes This patch contains fixes for various nits mentioned in #147200: - This patch removes the `bit.` prefix in the op mnemonic. The operation names now directly correspond to the builtin function names except for `b

[clang] [CIR][NFC] Resolve various nits for builtin bit operations (PR #148378)

2025-07-12 Thread Sirui Mu via cfe-commits
https://github.com/Lancern created https://github.com/llvm/llvm-project/pull/148378 This patch contains fixes for various nits mentioned in #147200: - This patch removes the `bit.` prefix in the op mnemonic. The operation names now directly correspond to the builtin function names except for `

[clang] 647f02a - [CIR] Implement SubOp for ComplexType (#148025)

2025-07-12 Thread via cfe-commits
Author: Amr Hesham Date: 2025-07-12T17:22:57+02:00 New Revision: 647f02a02a90038b7af1879cf96565f204a2c949 URL: https://github.com/llvm/llvm-project/commit/647f02a02a90038b7af1879cf96565f204a2c949 DIFF: https://github.com/llvm/llvm-project/commit/647f02a02a90038b7af1879cf96565f204a2c949.diff LO

[clang] [CIR] Implement SubOp for ComplexType (PR #148025)

2025-07-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/148025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] [Diagnostics] Simplify filenames that contain '..' (PR #143520)

2025-07-12 Thread James Y Knight via cfe-commits
jyknight wrote: > the main thing you care about is being able to turn off the canonicalisation > entirely with -no-canonical-prefix, is that right? In terms of not breaking the Google buildsystem: yes. But if the question is whether the current patch would be fine if its behavior was also disa

[clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang-tools-extra,clang,lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/18898 Here is the releva

[clang] [CIR] Implement SubOp for ComplexType (PR #148025)

2025-07-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/148025 >From 3658e227161dc3e2cf0a6d7f21d008df6509e9c2 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 10 Jul 2025 20:37:25 +0200 Subject: [PATCH 1/2] [CIR] Implement SubOp for ComplexType --- clang/includ

[clang-tools-extra] Use resolved path when filtering in IncludeInserter (PR #148371)

2025-07-12 Thread via cfe-commits
@@ -306,14 +306,14 @@ IncludeInserter::calculateIncludePath(const HeaderFile &InsertedHeader, return std::nullopt; bool IsAngled = false; for (auto &Filter : AngledHeaders) { -if (Filter(Suggested)) { +if (Filter(InsertedHeader.File)) { Harald-

[clang-tools-extra] Use resolved path when filtering in IncludeInserter (PR #148371)

2025-07-12 Thread via cfe-commits
https://github.com/Harald-R created https://github.com/llvm/llvm-project/pull/148371 Following the discussions from https://github.com/llvm/llvm-project/pull/140594, this PR updates the logic in `IncludeInserter` to also use the resolved paths instead of the spellings when filtering headers.

[clang] [clang-tools-extra] [Clang] [Diagnostics] Simplify filenames that contain '..' (PR #143520)

2025-07-12 Thread via cfe-commits
Sirraide wrote: > do so by default, but disabled by "-no-canonical-prefix" So just to be clear, while there might be a better place to canonicalise the paths (we can’t treat include paths the same as the resource directory because that’s canonicalised in `clang_main`), the main thing you care

[clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `clang-tools-extra,clang,lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/26685 Here is the releva

[clang-tools-extra] c4cc357 - [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (#148195)

2025-07-12 Thread via cfe-commits
Author: Yanzuo Liu Date: 2025-07-12T21:13:30+08:00 New Revision: c4cc3573d144831d2815433646ffcab62cc9ea40 URL: https://github.com/llvm/llvm-project/commit/c4cc3573d144831d2815433646ffcab62cc9ea40 DIFF: https://github.com/llvm/llvm-project/commit/c4cc3573d144831d2815433646ffcab62cc9ea40.diff LO

[clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-12 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis closed https://github.com/llvm/llvm-project/pull/148195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (PR #148367)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (Sirraide) Changes Revert llvm/llvm-project#143520 for now since it’s causing issues for people who are using symlinks and prefer to preserve the original path (i.e. looks like we’ll have to make this configurable after a

[clang] c4cc357 - [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (#148195)

2025-07-12 Thread via cfe-commits
Author: Yanzuo Liu Date: 2025-07-12T21:13:30+08:00 New Revision: c4cc3573d144831d2815433646ffcab62cc9ea40 URL: https://github.com/llvm/llvm-project/commit/c4cc3573d144831d2815433646ffcab62cc9ea40 DIFF: https://github.com/llvm/llvm-project/commit/c4cc3573d144831d2815433646ffcab62cc9ea40.diff LO

[clang] [clang-tools-extra] Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (PR #148367)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: None (Sirraide) Changes Revert llvm/llvm-project#143520 for now since it’s causing issues for people who are using symlinks and prefer to preserve the original path (i.e. looks like we’ll have to make this configurable after all; I j

[clang] [clang-tools-extra] Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (PR #148367)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes Revert llvm/llvm-project#143520 for now since it’s causing issues for people who are using symlinks and prefer to preserve the original path (i.e. looks like we’ll have to make this configurable after all; I just n

[clang-tools-extra] 7b43c6c - Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (#148367)

2025-07-12 Thread via cfe-commits
Author: Sirraide Date: 2025-07-12T15:13:22+02:00 New Revision: 7b43c6c6a729bde8b20143f9620e6323812f1694 URL: https://github.com/llvm/llvm-project/commit/7b43c6c6a729bde8b20143f9620e6323812f1694 DIFF: https://github.com/llvm/llvm-project/commit/7b43c6c6a729bde8b20143f9620e6323812f1694.diff LOG:

[clang] [clang-tools-extra] Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (PR #148367)

2025-07-12 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/148367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-12 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Thanks for your review. https://github.com/llvm/llvm-project/pull/148195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (PR #148367)

2025-07-12 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/148367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Revert "[Clang] [Diagnostics] Simplify filenames that contain '..'" (PR #148367)

2025-07-12 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/148367 Reverts llvm/llvm-project#143520 for now since it’s causing issues for people who are using symlinks and prefer to preserve the original path (i.e. looks like we’ll have to make this configurable after all; I

[clang-tools-extra] [clang-tidy][NFC] fixed invalid formatting in 'ReleaseNotes.rst' (PR #148352)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/148352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] bd7a6bf - [clang-tidy][NFC] fixed invalid formatting in 'ReleaseNotes.rst' (#148352)

2025-07-12 Thread via cfe-commits
Author: Baranov Victor Date: 2025-07-12T15:57:25+03:00 New Revision: bd7a6bfdf4d71f62ce7b536d543592ce73646366 URL: https://github.com/llvm/llvm-project/commit/bd7a6bfdf4d71f62ce7b536d543592ce73646366 DIFF: https://github.com/llvm/llvm-project/commit/bd7a6bfdf4d71f62ce7b536d543592ce73646366.diff

[clang] [clang-tools-extra] [lldb] [Clang][AST][NFC] (`RecordDecl` -> `CXXRecordDecl`)`::isInjectedClassName` (PR #148195)

2025-07-12 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/148195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Remove unnecessary casts (NFC) (PR #148338)

2025-07-12 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/148338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Fix typos and grammar in comments in ASTDiagnostic (PR #148359)

2025-07-12 Thread Corentin Jabot via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/148359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use lexical anon-ns matcher in llvm-prefer-static-over-anonymous-namespace (PR #148357)

2025-07-12 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. https://github.com/llvm/llvm-project/pull/148357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fixed invalid formatting in 'ReleaseNotes.rst' (PR #148352)

2025-07-12 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. https://github.com/llvm/llvm-project/pull/148352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-query] Allow for trailing comma in matchers (PR #148018)

2025-07-12 Thread Remy Farley via cfe-commits
one-d-wide wrote: I don't think this is much of an issue. Once you attempt to interpret a query with trailing comma in it as C++ code, a compiler (or even an LSP) will usually emit a (mostly) unambiguous error, which should be trivial to correct. And that's it. Existing queries, including ones

[clang] [clang-tools-extra] [clang-query] Allow for trailing comma in matchers (PR #148018)

2025-07-12 Thread Remy Farley via cfe-commits
https://github.com/one-d-wide updated https://github.com/llvm/llvm-project/pull/148018 >From b35f9ebdd2e345449c2cea8df8d6731cde33dcb3 Mon Sep 17 00:00:00 2001 From: "Remy D. Farley" Date: Sat, 12 Jul 2025 11:53:58 + Subject: [PATCH] [clang-query] Allow for trailing comma in matchers --- c

[clang] [clang-tools-extra] [ASTMatchers][NFC] Replace `makeMatcher` function with CTAD (PR #147197)

2025-07-12 Thread Baranov Victor via cfe-commits
vbvictor wrote: Build errors seem unrelated to this change https://github.com/llvm/llvm-project/pull/147197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [ASTMatchers][NFC] Replace `makeMatcher` function with CTAD (PR #147197)

2025-07-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang-tools-extra,clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/12990 Here is t

[clang-tools-extra] [clang-tidy] Use lexical anon-ns matcher in llvm-prefer-static-over-anonymous-namespace (PR #148357)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/148357 >From 82bee931621536e7e59910f1833289510909ce23 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 12 Jul 2025 14:24:31 +0300 Subject: [PATCH] [clang-tidy] Use lexical anon-ns matcher in llvm-prefer-stati

[clang] [clang-tools-extra] [ASTMatchers][NFC] Replace `makeMatcher` function with CTAD (PR #147197)

2025-07-12 Thread via cfe-commits
github-actions[bot] wrote: @localspook Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [clang][NFC] Fix typos and grammar in comments in ASTDiagnostic (PR #148359)

2025-07-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Bogdan Vetrenko (bv2k4) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/148359.diff 1 Files Affected: - (modified) clang/lib/AST/ASTDiagnostic.cpp (+6-6) ``diff diff --git a/clang/lib/AST/ASTDiagnostic.cpp b

[clang] [clang-tools-extra] [ASTMatchers][NFC] Replace `makeMatcher` function with CTAD (PR #147197)

2025-07-12 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/147197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >