llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fix #61156
---
Full diff: https://github.com/llvm/llvm-project/pull/138440.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+1-1)
- (modified) clang/unittests/Format/TokenAnnotat
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/138440
Fix #61156
>From 90803c382ecb040e016034d5798d739739ece03a Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 3 May 2025 23:38:18 -0700
Subject: [PATCH] [clang-format] Don't annotate enum colon as InheritanceColo
https://github.com/brad0 approved this pull request.
https://github.com/llvm/llvm-project/pull/137596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brad0 wrote:
cc @MaskRay
https://github.com/llvm/llvm-project/pull/135367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,35 @@
+// Regression test for https://github.com/llvm/llvm-project/issues/59819
+
+// RUN: rm -rf %t && mkdir -p %t
+// RUN: clang-doc --format=md --doxygen --output=%t --executor=standalone %s
+// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.md
--check-prefix=MD-MYC
https://github.com/xen0n commented:
Thank you for the patch!
Test assertions can be updated as well -- check for two occurrences of the
respective `asm` statement.
https://github.com/llvm/llvm-project/pull/138391
___
cfe-commits mailing list
cfe-comm
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sarah Spall (spall)
Changes
Update how Sema Checking is done for HLSL builtins to allow for better error
messages, mainly using 'err_builtin_invalid_arg_type'.
Try to follow the formula outlined in issue #134721
Closes #134721
---
Patch
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Sarah Spall (spall)
Changes
Update how Sema Checking is done for HLSL builtins to allow for better error
messages, mainly using 'err_builtin_invalid_arg_type'.
Try to follow the formula outlined in issue #134721
Closes #134721
---
Patch
https://github.com/spall created
https://github.com/llvm/llvm-project/pull/138429
Update how Sema Checking is done for HLSL builtins to allow for better error
messages, mainly using 'err_builtin_invalid_arg_type'.
Try to follow the formula outlined in issue #134721
Closes #134721
>From 113910
https://github.com/zygoloid approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/138388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/35] Update SemaL
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/120925
>From c1aa5c649c052c230cc76d073186ad8fdd14723f Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Sun, 4 May 2025 02:13:29 +0300
Subject: [PATCH] [Clang] raise extension warning for unknown namespaced
a
@@ -1976,4 +1976,28 @@ def VecCreateOp : CIR_Op<"vec.create", [Pure]> {
let hasVerifier = 1;
}
+//===--===//
+// VecExtractOp
+//===--===//
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-darwin`
running on `doug-worker-3` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/23/builds/9970
Here is the r
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`clang-s390x-linux-multistage` running on `systemz-1` while building `llvm` at
step 5 "ninja check 1".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/98/builds/1349
Here is the relevant piece of the
=?utf-8?q?Félix?= Cloutier ,
=?utf-8?q?Félix?= Cloutier ,
=?utf-8?q?Félix?= Cloutier ,
=?utf-8?q?Félix?= Cloutier
Message-ID:
In-Reply-To:
ojhunt wrote:
The pointer auth options PR would also benefit from this - it currently has an
ad hoc and restricted version of this as it needed to support
https://github.com/a-tarasyuk edited
https://github.com/llvm/llvm-project/pull/120925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/120925
>From 9bb85586f40f659a8bff414511bed9592083efbd Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Sun, 4 May 2025 01:13:20 +0300
Subject: [PATCH 1/2] [Clang] raise extension warning for unknown namespace
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: cor3ntin (cor3ntin)
Changes
There are some limitations.
Because we only know which partial specialization to refer to when
instantiating, and because we can't instantiate the class before we require a
complete type, we can only use the p
https://github.com/a-tarasyuk updated
https://github.com/llvm/llvm-project/pull/120925
>From 9bb85586f40f659a8bff414511bed9592083efbd Mon Sep 17 00:00:00 2001
From: Oleksandr Tarasiuk
Date: Sun, 4 May 2025 01:13:20 +0300
Subject: [PATCH] [Clang] raise extension warning for unknown namespaced
a
https://github.com/cor3ntin created
https://github.com/llvm/llvm-project/pull/138426
There are some limitations.
Because we only know which partial specialization to refer to when
instantiating, and because we can't instantiate the class before we require a
complete type, we can only use the
Author: Owen Pan
Date: 2025-05-03T14:54:48-07:00
New Revision: deec7fb42dd27d38b2d2925f5e635f27007a0bd7
URL:
https://github.com/llvm/llvm-project/commit/deec7fb42dd27d38b2d2925f5e635f27007a0bd7
DIFF:
https://github.com/llvm/llvm-project/commit/deec7fb42dd27d38b2d2925f5e635f27007a0bd7.diff
LOG:
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/34] Update SemaL
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/138389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mstorsjo closed
https://github.com/llvm/llvm-project/pull/138217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: jeremyd2019
Date: 2025-05-04T00:33:54+03:00
New Revision: 74d921c01ab4aefb5f7f14062ab4aef50d5c6413
URL:
https://github.com/llvm/llvm-project/commit/74d921c01ab4aefb5f7f14062ab4aef50d5c6413
DIFF:
https://github.com/llvm/llvm-project/commit/74d921c01ab4aefb5f7f14062ab4aef50d5c6413.diff
L
https://github.com/mstorsjo approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/138343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jeremyd2019 wrote:
`-DLLVM_BUILD_LLVM_DYLIB=OFF -DLLVM_LINK_LLVM_DYLIB=OFF
-DLIBCLANG_BUILD_STATIC=ON`
Now we know that adding `-DLLVM_ENABLE_PIC=OFF` will turn off building
libclang.dll, but otherwise it will be built regardless.
https://github.com/llvm/llvm-project/pull/138351
_
mstorsjo wrote:
Offhand, I don't quite know here. Which configurations is this about? For
mingw, the only cases I'm familiar with is building with
`LLVM_LINK_LLVM_DYLIB=ON`, which iirc implicitly enables a corresponding one
for Clang too. Not sure which of the local variables here that maps to
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/33] Update SemaL
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/32] Update SemaL
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/31] Update SemaL
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/30] Update SemaL
https://github.com/charan-003 updated
https://github.com/llvm/llvm-project/pull/117953
>From b886394f3aca3ea53f2c97d85a8e963d192c122f Mon Sep 17 00:00:00 2001
From: charan-003 <85248228+charan-...@users.noreply.github.com>
Date: Wed, 27 Nov 2024 18:43:38 -0700
Subject: [PATCH 01/29] Update SemaL
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building
`clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/174/builds/17189
Her
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138413
>From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 3 May 2025 13:43:04 +0200
Subject: [PATCH 1/2] [CIR] Upstream extract op for VectorType
---
clang/incl
ojhunt wrote:
@AaronBallman have you made a decision? (if the keyword has to go away I need
to replace all the tests and work out how to integrate with other libraries
downstream in a way that works in both modes)
https://github.com/llvm/llvm-project/pull/137580
___
https://github.com/AmrDeveloper closed
https://github.com/llvm/llvm-project/pull/138415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Amr Hesham
Date: 2025-05-03T22:00:15+02:00
New Revision: 8d8a3d9fdcbe823b94e2821b7beb8ead5288b14e
URL:
https://github.com/llvm/llvm-project/commit/8d8a3d9fdcbe823b94e2821b7beb8ead5288b14e
DIFF:
https://github.com/llvm/llvm-project/commit/8d8a3d9fdcbe823b94e2821b7beb8ead5288b14e.diff
LO
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138413
>From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 3 May 2025 13:43:04 +0200
Subject: [PATCH 1/2] [CIR] Upstream extract op for VectorType
---
clang/incl
https://github.com/xlauko edited
https://github.com/llvm/llvm-project/pull/138413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/xlauko approved this pull request.
lgtm, besides nits
https://github.com/llvm/llvm-project/pull/138413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1976,4 +1976,28 @@ def VecCreateOp : CIR_Op<"vec.create", [Pure]> {
let hasVerifier = 1;
}
+//===--===//
+// VecExtractOp
+//===--===//
https://github.com/xlauko approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/138415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/xlauko edited
https://github.com/llvm/llvm-project/pull/138415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Andres-Salamanca updated
https://github.com/llvm/llvm-project/pull/138003
>From ff564e64a2ca9948e51c174a5e7a71b05acea510 Mon Sep 17 00:00:00 2001
From: Andres Salamanca
Date: Wed, 30 Apr 2025 12:17:31 -0500
Subject: [PATCH 1/5] add support for anyOf, default, and range case k
shiltian wrote:
I got it that you are trying to make it generic. That's why I didn’t roll back
to using builtin bitcode as we did before. However there is one limitation that
we can't really work around, which is the fact that we don't support ABI
linking. This is not a new topic at all and wh
https://github.com/jeremyd2019 edited
https://github.com/llvm/llvm-project/pull/138343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jeremyd2019 approved this pull request.
https://github.com/llvm/llvm-project/pull/138343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE)
DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE})
endif()
-if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR
+if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR
((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC))
---
mati865 wrote:
> But people build mingw clang with gcc, right?
Dunno.
> It seems like having explicit dllexport annotations as libclang does should
> turn off auto-export. I didn't see `--export-all-symbols` in the command line
> anyway.
Yes, linker exports all the symbols by default, but ex
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"],
"fstrict-flex-arrays=">, Group,
NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">,
NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete",
"IncompleteOnly"]>,
- HelpText<"Enabl
jeremyd2019 wrote:
But people build mingw clang with gcc, right? They presumably don't set
`LLVM_ENABLE_PIC=OFF`. It seems like having explicit dllexport annotations as
libclang does should turn off auto-export. I didn't see `--export-all-symbols`
in the command line anyway.
https://github
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Amr Hesham (AmrDeveloper)
Changes
This fixes a warning where a variable assigned in 'if' statement wasn't
referenced again.
---
Full diff: https://github.com/llvm/llvm-project/pull/138415.diff
1 Files Affected:
- (modified) clang/lib
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/138415
>From 1b43e41c4ad14215977e9f2f0a4f1c2ed3895be1 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 3 May 2025 19:05:36 +0200
Subject: [PATCH] [CIR][NFC] Fix an unused variable warning
---
clang/lib/CIR
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amr Hesham (AmrDeveloper)
Changes
This fixes a warning where a variable assigned in 'if' statement wasn't
referenced again.
---
Full diff: https://github.com/llvm/llvm-project/pull/138415.diff
1 Files Affected:
- (modified) clang/lib/C
https://github.com/AmrDeveloper edited
https://github.com/llvm/llvm-project/pull/138415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AmrDeveloper created
https://github.com/llvm/llvm-project/pull/138415
This fixes a warning where a variable assigned in 'if' statement wasn't
referenced again.
>From 6acc708aabc3f53d2899b322d4d96194bfc9440d Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 3 May 2025 1
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"],
"fstrict-flex-arrays=">, Group,
NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">,
NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete",
"IncompleteOnly"]>,
- HelpText<"Enabl
https://github.com/serge-sans-paille updated
https://github.com/llvm/llvm-project/pull/138388
>From 39cf81caaab7257414d72fae3afbb3baa8113b7f Mon Sep 17 00:00:00 2001
From: serge-sans-paille
Date: Sat, 3 May 2025 10:10:09 +0200
Subject: [PATCH] [clang] Document -fstrict-flex-arrays option
Fix #
https://github.com/AmrDeveloper edited
https://github.com/llvm/llvm-project/pull/138413
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clangir
Author: Amr Hesham (AmrDeveloper)
Changes
This change adds local zero initialization for VectorType
Issue https://github.com/llvm/llvm-project/issues/136487
---
Full diff: https://github.com/llvm/llvm-project/pull/138413.diff
7 Files Affected
https://github.com/AmrDeveloper created
https://github.com/llvm/llvm-project/pull/138413
This change adds local zero initialization for VectorType
Issue https://github.com/llvm/llvm-project/issues/136487
>From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001
From: AmrDeveloper
jhuber6 wrote:
> I don't think OpenMP is more special than HIP here. Anything exposed to the
> host should not be internalized. In addition, OpenMP actually also heavily
> uses internalization as well in OpenMPOpt. It is likely that this change
> exposes something bad in the downstream.
>
> T
shiltian wrote:
> also seeing
>
> "PluginInterface" error: Failure to look up global address: Error in
> hsa_executable_get_symbol_by_name(grid_points):
> HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
>
> omptarget error: Failed to load symbol grid_points
>
>
shiltian wrote:
I don't think OpenMP is more special than HIP here. Anything exposed to the
host should not be internalized. In addition, OpenMP actually also heavily uses
internalization as well in OpenMPOpt. It is likely that this change exposes
something bad in the downstream.
The motivati
https://github.com/vbvictor edited
https://github.com/llvm/llvm-project/pull/138282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vbvictor edited
https://github.com/llvm/llvm-project/pull/138282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,26 @@
+.. title:: clang-tidy - modernize-use-enum-class
+
+modernize-use-enum-class
+=
+
+Scoped enums (enum class) should be preferred over unscoped enums:
+https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class
---
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/138368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -365,10 +365,15 @@ mlir::Attribute
ConstantEmitter::tryEmitPrivateForVarInit(const VarDecl &d) {
if (!d.hasLocalStorage()) {
QualType ty = cgm.getASTContext().getBaseElementType(d.getType());
if (ty->isRecordType())
- if (d.getInit() && isa(d.getInit())) {
-
@@ -177,18 +177,26 @@ void CIRRecordLowering::lower() {
return;
}
- if (isa(recordDecl)) {
-cirGenTypes.getCGModule().errorNYI(recordDecl->getSourceRange(),
- "lower: class");
-return;
- }
-
assert(!cir::MissingFeatures:
@@ -237,8 +237,11 @@ mlir::Type CIRGenTypes::convertRecordDeclType(const
clang::RecordDecl *rd) {
assert(insertResult && "isSafeToCovert() should have caught this.");
// Force conversion of non-virtual base classes recursively.
- if (isa(rd)) {
-cgm.errorNYI(rd->getS
@@ -12,6 +12,17 @@ IncompleteS *p;
// LLVM: @p = dso_local global ptr null
// OGCG: @p = global ptr null, align 8
+struct CompleteS {
mmha wrote:
Do simple union work with this? If so, can you add a test for those, too?
https://github.com/llvm/llvm-project/p
https://github.com/mmha approved this pull request.
LGTM, just a few nits
https://github.com/llvm/llvm-project/pull/138368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mmha edited https://github.com/llvm/llvm-project/pull/138368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mati865 wrote:
I think it works when you build with Clang rather than GCC. Clang will not
export symbols with hidden visibility.
https://github.com/llvm/llvm-project/pull/138351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"],
"fstrict-flex-arrays=">, Group,
NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">,
NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete",
"IncompleteOnly"]>,
- HelpText<"Enabl
@@ -1554,7 +1554,10 @@ def fstrict_flex_arrays_EQ : Joined<["-"],
"fstrict-flex-arrays=">, Group,
NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">,
NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete",
"IncompleteOnly"]>,
- HelpText<"Enabl
@@ -365,10 +365,15 @@ mlir::Attribute
ConstantEmitter::tryEmitPrivateForVarInit(const VarDecl &d) {
if (!d.hasLocalStorage()) {
QualType ty = cgm.getASTContext().getBaseElementType(d.getType());
if (ty->isRecordType())
- if (d.getInit() && isa(d.getInit())) {
-
@@ -0,0 +1,26 @@
+.. title:: clang-tidy - modernize-use-enum-class
+
+modernize-use-enum-class
+=
+
+Scoped enums (enum class) should be preferred over unscoped enums:
+https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class
---
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/138389
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/lib/Parse/ParseExprCXX.cpp clang/lib/Sema/SemaL
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const
JobAction &JA,
CmdArgs.push_back(Args.MakeArgString(
"--device-linker=" + TC->getTripleString() + "=" + Arg));
+ // Enable internalization for AMDGPU.
+ if (TC->getTrip
https://github.com/phoebewang commented:
The pre-checkin failures seem related.
https://github.com/llvm/llvm-project/pull/138360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -138,6 +138,12 @@ let Attributes = [Const, NoThrow,
RequiredVectorWidth<256>], Features = "avx" in
}
}
+// PRFCHW
+let Features = "prfchw", Header = "intrin.h", Attributes = [NoThrow, Const] in
{
phoebewang wrote:
Although they are in the same file, bo
https://github.com/phoebewang edited
https://github.com/llvm/llvm-project/pull/138360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> also seeing "PluginInterface" error: Failure to look up global address: Error
> in hsa_executable_get_symbol_by_name(grid_points):
> HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
> omptarget error: Failed to load symbol grid_points
Yeah, this i
ronlieb wrote:
also seeing
"PluginInterface" error: Failure to look up global address: Error in
hsa_executable_get_symbol_by_name(grid_points):
HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
omptarget error: Failed to load symbol grid_points
https://github.com/l
ronlieb wrote:
downstream testing is seeing quite a few tests failing with:
OFFLOAD ERROR: Memory access fault by GPU 2 (agent 0x145ba00) at virtual
address (nil). Reasons: Unknown (0)
https://github.com/llvm/llvm-project/pull/138365
___
cfe-commits
ziyao233 wrote:
Cc @echristo, @xen0n thanks for your time and review.
https://github.com/llvm/llvm-project/pull/138391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-loongarch
Author: Yao Zi (ziyao233)
Changes
There're four possible formats to refer a register in inline assembly,
1. Numeric name without dollar sign ("f0")
2. Numeric name with dollar sign ("$f0")
3. ABI name without dollar sign ("fa0")
4. ABI
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/ziyao233 created
https://github.com/llvm/llvm-project/pull/138391
There're four possible formats to refer a register in inline assembly,
1. Numeric name without dollar sign ("f0")
2. Numeric name with dollar sign ("$f0")
3. ABI name without dollar sign ("fa0")
4. ABI name wit
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/138377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -412,6 +419,12 @@ class Sema;
bool isPerfect(const ASTContext &C) const {
if (!isIdentityConversion())
return false;
+
+ // We might prefer a std::initializer constructor,
cor3ntin wrote:
Oups
https://github.com/llvm/llvm-project/pul
Author: Corentin Jabot
Date: 2025-05-03T11:36:42+02:00
New Revision: 5b02a2647594719454611132b7c05318d959bf58
URL:
https://github.com/llvm/llvm-project/commit/5b02a2647594719454611132b7c05318d959bf58
DIFF:
https://github.com/llvm/llvm-project/commit/5b02a2647594719454611132b7c05318d959bf58.diff
serge-sans-paille wrote:
@zygoloid this restores (and hopefully improves) the original documentation.
The values and behavior are obviously the same as gcc. I don't have a strong
opinion on value aliases.
https://github.com/llvm/llvm-project/pull/138388
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fix #138382
---
Full diff: https://github.com/llvm/llvm-project/pull/138389.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+8-4)
- (modified) clang/unittests/Format/TokenAnnota
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/138389
Fix #138382
>From 36e7e2002439dcdb084e949a265a280551597800 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 3 May 2025 01:21:03 -0700
Subject: [PATCH] [clang-format] Correctly annotate tok::star in braced list
1 - 100 of 106 matches
Mail list logo
