[clang] [randstruct] Also randomize composite function pointer structs (PR #138385)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kees Cook (kees) Changes Check for struct members that are structs filled only with function pointers by recursively examining it. Since the lamba IsFunctionPointerOrForwardDecl cannot call itself directly, move it into a helper function,

[clang] [Clang] Allow simpler visibility annotations when targeting win32 and mingw (PR #133699)

2025-05-02 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/133699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [randstruct] Also randomize composite function pointer structs (PR #138385)

2025-05-02 Thread Kees Cook via cfe-commits
https://github.com/kees created https://github.com/llvm/llvm-project/pull/138385 Check for struct members that are structs filled only with function pointers by recursively examining it. Since the lamba IsFunctionPointerOrForwardDecl cannot call itself directly, move it into a helper function,

[clang] [Clang] Allow simpler visibility annotations when targeting win32 and mingw (PR #133699)

2025-05-02 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: They have to be compatible, but we don't need separate macros anymore for exported classes. https://github.com/llvm/llvm-project/pull/133699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [Clang] Allow simpler visibility annotations when targeting win32 and mingw (PR #133699)

2025-05-02 Thread Nikolas Klauser via cfe-commits
@@ -6606,7 +6606,10 @@ void Sema::checkClassLevelDLLAttribute(CXXRecordDecl *Class) { if (ClassExported && !ClassAttr->isInherited() && TSK == TSK_ExplicitInstantiationDeclaration && !Context.getTargetInfo().getTriple().isWindowsGNUEnvironment()) { -Class->dr

[clang] [Clang] Allow simpler visibility annotations when targeting win32 and mingw (PR #133699)

2025-05-02 Thread Nikolas Klauser via cfe-commits
@@ -4185,6 +4185,14 @@ def DLLExport : InheritableAttr, TargetSpecificAttr { let Documentation = [DLLExportDocs]; } +def DLLExportOnDecl : InheritableAttr, TargetSpecificAttr { philnik777 wrote: Since we don't represent invalid attribute in the AST curren

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread Owen Pan via cfe-commits
https://github.com/owenca demilestoned https://github.com/llvm/llvm-project/pull/138229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Matt Arsenault via cfe-commits
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + // Enable internalization for AMDGPU. + if (TC->getTrip

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Matt Arsenault via cfe-commits
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + // Enable internalization for AMDGPU. + if (TC->getTrip

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/138229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] make it possible to disable c++26 type aware allocators (PR #138372)

2025-05-02 Thread via cfe-commits
cor3ntin wrote: I'm fairly opposed to adding this flag before Sofia - My assumption is that this is a C++26 feature (and one that is backward compatible) - and we should not add a flag for every standard feature. _if_ the committee fails to land this in Sofia, then we can add the flag before t

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread Owen Pan via cfe-commits
https://github.com/owenca demilestoned https://github.com/llvm/llvm-project/pull/138229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread Owen Pan via cfe-commits
owenca wrote: /cherry-pick d3506ee573a2aa1403817642ef45f8c0305bb572 https://github.com/llvm/llvm-project/pull/138229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/138229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Shilei Tian via cfe-commits
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + // Enable internalization for AMDGPU. + if (TC->getTrip

[clang] [HLSL] Implement the `ldexp` intrinsic (PR #138182)

2025-05-02 Thread Kaitlin Peng via cfe-commits
https://github.com/kmpeng closed https://github.com/llvm/llvm-project/pull/138182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d11df05 - [HLSL] Implement the `ldexp` intrinsic (#138182)

2025-05-02 Thread via cfe-commits
Author: Kaitlin Peng Date: 2025-05-02T22:07:37-07:00 New Revision: d11df058416aa2e13c6b2559c1ce21209c445bab URL: https://github.com/llvm/llvm-project/commit/d11df058416aa2e13c6b2559c1ce21209c445bab DIFF: https://github.com/llvm/llvm-project/commit/d11df058416aa2e13c6b2559c1ce21209c445bab.diff

[clang-tools-extra] [clang-tidy] detect arithmetic operations within member list initialization in modernize-use-default-member-init check (PR #129370)

2025-05-02 Thread David Rivera via cfe-commits
RiverDave wrote: Ping :) Is there anything else I should add in here? https://github.com/llvm/llvm-project/pull/129370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] detect arithmetic operations within member list initialization in modernize-use-default-member-init check (PR #129370)

2025-05-02 Thread David Rivera via cfe-commits
https://github.com/RiverDave updated https://github.com/llvm/llvm-project/pull/129370 >From 8c35d9c91ba59de8ba188774385741e5f893ad55 Mon Sep 17 00:00:00 2001 From: David Rivera Date: Sat, 1 Mar 2025 02:09:02 -0500 Subject: [PATCH] [clang-tidy] detect arithmetic operations within member list in

[clang] [CodeGen][RISCV] Use vscale_range to handle more fixed<->scalable casts of i1 vectors. (PR #138378)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Craig Topper (topperc) Changes RISC-V with -mrvv-vector-bits-min supports giving a size to our scalable vector types. To do this, we represent the vector as a fixed vector in memory and need to cast back

[clang] [CodeGen][RISCV] Use vscale_range to handle more fixed<->scalable casts of i1 vectors. (PR #138378)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Craig Topper (topperc) Changes RISC-V with -mrvv-vector-bits-min supports giving a size to our scalable vector types. To do this, we represent the vector as a fixed vector in memory and need to cast back and force to scable vecto

[clang] [CodeGen][RISCV] Use vscale_range to handle more fixed<->scalable casts of i1 vectors. (PR #138378)

2025-05-02 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/138378 RISC-V with -mrvv-vector-bits-min supports giving a size to our scalable vector types. To do this, we represent the vector as a fixed vector in memory and need to cast back and force to scable vectors. For i1

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Joseph Huber via cfe-commits
@@ -9284,6 +9284,12 @@ void LinkerWrapper::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back(Args.MakeArgString( "--device-linker=" + TC->getTripleString() + "=" + Arg)); + // Enable internalization for AMDGPU. + if (TC->getTrip

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-02 Thread Andrew Pinski via cfe-commits
pinskia wrote: Just FYI, the GCC name of the option is -Wjump-misses-init . https://github.com/llvm/llvm-project/pull/138009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/137580 >From 9c29520abea852086f8f4c555e2ad1ea7c711800 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Sun, 27 Apr 2025 22:33:44 -0700 Subject: [PATCH] [clang] Add `__ptrauth_restricted_intptr` qualifier __ptrauth_rest

[clang] [clang][ptrauth] add support for options parameter to __ptrauth (PR #136828)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/136828 >From d51ed1b628eac11e3ff1a2bb5fffd87e7ca127ea Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Wed, 30 Apr 2025 22:26:59 -0700 Subject: [PATCH] [clang][ptrauth] add support for options parameter to __ptrauth T

[clang] [Clang] Never consider conversion from single-element braced-init-list perfect (PR #138307)

2025-05-02 Thread Younan Zhang via cfe-commits
@@ -360,6 +360,13 @@ class Sema; LLVM_PREFERRED_TYPE(bool) unsigned ObjCLifetimeConversionBinding : 1; +/// Whether the source expression was originally a single element +/// braced-init-list. Such a conversion is not a perfect match, +/// as we prefer a st

[clang] [Clang] Never consider conversion from single-element braced-init-list perfect (PR #138307)

2025-05-02 Thread Younan Zhang via cfe-commits
@@ -412,6 +419,12 @@ class Sema; bool isPerfect(const ASTContext &C) const { if (!isIdentityConversion()) return false; + + // We might prefer a std::initializer constructor, zyn0217 wrote: `std::initializer_list` https://github.com/llv

[clang-tools-extra] [clang-tidy][C++20] Add support for Initialization Forwarding in structs and Nested Objects within modernize-use-emplace (PR #131969)

2025-05-02 Thread David Rivera via cfe-commits
RiverDave wrote: Ping https://github.com/llvm/llvm-project/pull/131969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][C++20] Add support for Initialization Forwarding in structs and Nested Objects within modernize-use-emplace (PR #131969)

2025-05-02 Thread David Rivera via cfe-commits
https://github.com/RiverDave updated https://github.com/llvm/llvm-project/pull/131969 >From ed0c4bd4c5200819b82e97dc8032b7defdfd88da Mon Sep 17 00:00:00 2001 From: David Rivera Date: Sun, 16 Mar 2025 16:20:16 -0400 Subject: [PATCH] [clang-tidy] Add support for Initialization Forwarding in Nest

[clang] [Clang] Don't retain template FoundDecl for conversion function calls (PR #138377)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes In consteval calls rewriting, we expect an instantiated AST to remain untouched. However, this was not true when rebuilding a MemberExpr in TreeTransform, as it relies on FoundDecl to build a resolved member

[clang] [Clang] Don't retain template FoundDecl for conversion function calls (PR #138377)

2025-05-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/138377 In consteval calls rewriting, we expect an instantiated AST to remain untouched. However, this was not true when rebuilding a MemberExpr in TreeTransform, as it relies on FoundDecl to build a resolved member ca

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr (PR #134188)

2025-05-02 Thread David Rivera via cfe-commits
@@ -52,8 +54,17 @@ intCastExpression(bool IsSigned, const auto StaticCastExpr = cxxStaticCastExpr(has(ImplicitCastExpr)); const auto FunctionalCastExpr = cxxFunctionalCastExpr(has(ImplicitCastExpr)); + // Match function calls or variable references not directly wrapped by

[clang-tools-extra] [clang-tidy] Improve integer comparison by matching valid expressions outside implicitCastExpr (PR #134188)

2025-05-02 Thread David Rivera via cfe-commits
https://github.com/RiverDave updated https://github.com/llvm/llvm-project/pull/134188 >From f5f0b14c9f49b2b956e6f1c63f24e203d6f4beef Mon Sep 17 00:00:00 2001 From: David Rivera Date: Wed, 2 Apr 2025 21:02:00 -0400 Subject: [PATCH] [clang-tidy] Improve integer comparison by matching valid expre

[clang] [clang][ptrauth] reject incorrectly placed ptrauth qualifier (PR #138376)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) Changes When parsing a function pointer typed field we use Parser::ParseTypeQualifierListOpt, but then drops subsequent type attributes and qualifiers unless explicitly handled. There is an existing solution for the

[clang] [clang][ptrauth] reject incorrectly placed ptrauth qualifier (PR #138376)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/138376 When parsing a function pointer typed field we use Parser::ParseTypeQualifierListOpt, but then drops subsequent type attributes and qualifiers unless explicitly handled. There is an existing solution for the _A

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > LGTM, but I have only done a very isolated change on this code before. Righto, I'll wait for @zahiraam and/or @AaronBallman as well https://github.com/llvm/llvm-project/pull/138374 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-qemu` running on `sanitizer-buildbot3` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/139/builds/14430 Here is the relevant piece

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-02 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. LGTM, but I have only done a very isolated change on this code before. https://github.com/llvm/llvm-project/pull/138374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [clang-format] Fix a crash on formatting missing r_paren/r_brace (PR #138230)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/19405 Here is th

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/15433 Here is the relevant piece of the build lo

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/138374 >From 60eeaf0edd0a58bcdac4afad44ed097efdcd83f3 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Fri, 2 May 2025 19:20:27 -0700 Subject: [PATCH] [clang] rename FPOptions.def's macro to FP_OPTION While investigati

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/include/clang/Basic/LangOptions.h clang/lib/A

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oliver Hunt (ojhunt) Changes While investigating the recent warnings around FEM_Indeterminate I noticed that the macro name for FPOptions.def was given the very generic name `OPTION`. This PR renames it to FP_OPTION instead. --- Full dif

[clang] [clang] rename FPOptions.def's macro to FP_OPTION (PR #138374)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/138374 While investigating the recent warnings around FEM_Indeterminate I noticed that the macro name for FPOptions.def was given the very generic name `OPTION`. This PR renames it to FP_OPTION instead. >From f3351a66

[clang] [clang-format] Fix a crash on formatting missing r_paren/r_brace (PR #138230)

2025-05-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/138230 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 79210fe - [clang-format] Fix a crash on formatting missing r_paren/r_brace (#138230)

2025-05-02 Thread via cfe-commits
Author: Owen Pan Date: 2025-05-02T19:20:42-07:00 New Revision: 79210feb2993ff9a79ef11f8a7016a527d4fcf22 URL: https://github.com/llvm/llvm-project/commit/79210feb2993ff9a79ef11f8a7016a527d4fcf22 DIFF: https://github.com/llvm/llvm-project/commit/79210feb2993ff9a79ef11f8a7016a527d4fcf22.diff LOG:

[clang] [clang-format] RemoveParentheses shouldn't remove empty parentheses (PR #138229)

2025-05-02 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/138229 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d3506ee - [clang-format] RemoveParentheses shouldn't remove empty parentheses (#138229)

2025-05-02 Thread via cfe-commits
Author: Owen Pan Date: 2025-05-02T19:19:39-07:00 New Revision: d3506ee573a2aa1403817642ef45f8c0305bb572 URL: https://github.com/llvm/llvm-project/commit/d3506ee573a2aa1403817642ef45f8c0305bb572 DIFF: https://github.com/llvm/llvm-project/commit/d3506ee573a2aa1403817642ef45f8c0305bb572.diff LOG:

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2025-05-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Currently on medical leave, will be back in July! https://github.com/llvm/llvm-project/pull/96364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] make it possible to disable c++26 type aware allocators (PR #138372)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: (I'm still waiting for the full test suite to finish running, boy howdy does it take a long time :D) https://github.com/llvm/llvm-project/pull/138372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [clang] make it possible to disable c++26 type aware allocators (PR #138372)

2025-05-02 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Adding @AaronBallman and @cor3ntin as reviewers as you were the primary reviewers for the main PR, and I can't recall which of you requested I remove the flag and c++26 gating :D https://github.com/llvm/llvm-project/pull/138372 ___ cfe-

[clang] [clang] make it possible to disable c++26 type aware allocators (PR #138372)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Oliver Hunt (ojhunt) Changes Per the feedback from the Clang Area Team, this PR makes P2719 only on by default when targeting C++26, and adds a flag to explicitly enable or disable support. --- Patch is 60.11 KiB, truncated to 20

[clang] [clang] make it possible to disable c++26 type aware allocators (PR #138372)

2025-05-02 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/138372 Per the feedback from the Clang Area Team, this PR makes P2719 only on by default when targeting C++26, and adds a flag to explicitly enable or disable support. >From ce3630845859d8771ec112c1c091134953bac7c5 Mo

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-msan` running on `sanitizer-buildbot6` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/164/builds/9589 Here is the releva

[clang] [Clang] Bypass TAD during overload resolution if a perfect match exists (PR #136203)

2025-05-02 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > > This change breaks a bunch of other cases, for example, calls to > > `NodeDefBuilder::Attr("...", {some_value})` > > https://android.googlesource.com/platform/external/tensorflow/+/main/tensorflow/core/framework/node_def_builder.h#130 > > Can you provide us with a reduced exa

[clang] [Clang] Bypass TAD during overload resolution if a perfect match exists (PR #136203)

2025-05-02 Thread Alexander Kornienko via cfe-commits
alexfh wrote: Thank you for the prompt fix! It addresses the problems we've found so far. https://github.com/llvm/llvm-project/pull/136203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Shilei Tian via cfe-commits
https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/138365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2b62a31 - [Clang][Driver] Enable internalization by default for AMDGPU (#138365)

2025-05-02 Thread via cfe-commits
Author: Shilei Tian Date: 2025-05-02T21:32:46-04:00 New Revision: 2b62a311d76cfe5cdceab73b3fe145ee50449d08 URL: https://github.com/llvm/llvm-project/commit/2b62a311d76cfe5cdceab73b3fe145ee50449d08 DIFF: https://github.com/llvm/llvm-project/commit/2b62a311d76cfe5cdceab73b3fe145ee50449d08.diff L

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/136807 >From 44a384b8ad774939c7664c8a476e852f1d4a7341 Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Tue, 22 Apr 2025 20:04:34 -0700 Subject: [PATCH 01/14] Upstream enum support --- clang/lib/CIR/CodeGen/CIRGenMo

[clang] [CIR] Upstream enum support (PR #136807)

2025-05-02 Thread Ankur Ahir via cfe-commits
https://github.com/Ankur-0429 updated https://github.com/llvm/llvm-project/pull/136807 >From 44a384b8ad774939c7664c8a476e852f1d4a7341 Mon Sep 17 00:00:00 2001 From: Ankur Ahir Date: Tue, 22 Apr 2025 20:04:34 -0700 Subject: [PATCH 01/13] Upstream enum support --- clang/lib/CIR/CodeGen/CIRGenMo

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-05-02 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I've also seen ConstantEvaluationC99 intermittently fail on our mac bots recently https://github.com/llvm/llvm-project/pull/134196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes This change adds additional checks to a few places where a simple struct in C++ code was triggering `errorNYI` in places where no additional handling was needed, and adds a very small amount of trivial i

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes This change adds additional checks to a few places where a simple struct in C++ code was triggering `errorNYI` in places where no additional handling was needed, and adds a very small amount of trivial ini

[clang] [CIR] Unblock simple C++ structure support (PR #138368)

2025-05-02 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/138368 This change adds additional checks to a few places where a simple struct in C++ code was triggering `errorNYI` in places where no additional handling was needed, and adds a very small amount of trivial initi

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

2025-05-02 Thread via cfe-commits
@@ -0,0 +1,356 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #136026)

2025-05-02 Thread via cfe-commits
@@ -0,0 +1,356 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -finclude-default-header -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -O1 -o - | FileChe

[clang] [llvm] [mlir] [ErrorHandling] Add reportFatalInternalError + reportFatalUsageError (NFC) (PR #138251)

2025-05-02 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/138251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Refactor global variable emission and initialization (PR #138222)

2025-05-02 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/138222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e882590 - [CIR] Refactor global variable emission and initialization (#138222)

2025-05-02 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-02T16:54:29-07:00 New Revision: e8825900838a11afe326e202d19a3df6e3408422 URL: https://github.com/llvm/llvm-project/commit/e8825900838a11afe326e202d19a3df6e3408422 DIFF: https://github.com/llvm/llvm-project/commit/e8825900838a11afe326e202d19a3df6e3408422.diff L

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/138365 >From c9a8e6e2d67d8e7d029e58402c17d8c9419cd028 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 2 May 2025 19:41:11 -0400 Subject: [PATCH] [Clang][Driver] Enable internalization by default for AMDGPU ---

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert approved this pull request. https://github.com/llvm/llvm-project/pull/138365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Shilei Tian (shiltian) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/138365.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+6) - (modified) clang/test/Driver/openmp-offload-gpu.c (

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shilei Tian (shiltian) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/138365.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+6) - (modified) clang/test/Driver/openmp-offload-gpu.c (+7)

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Shilei Tian via cfe-commits
shiltian wrote: * **#138365** https://app.graphite.dev/github/pr/llvm/llvm-project/138365?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/138

[clang] [Clang][Driver] Enable internalization by default for AMDGPU (PR #138365)

2025-05-02 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/138365 None >From acc89cf6a85a8fb758b528a4e2ae587fccd61ce5 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 2 May 2025 19:41:11 -0400 Subject: [PATCH] [Clang][Driver] Enable internalization by default for AMDGPU

[clang] [clang][Sema] Don't warn for implicit uses of builtins in system headers (PR #138205)

2025-05-02 Thread Reid Kleckner via cfe-commits
rnk wrote: > follow what we did for _m_prefetchw, but it seems the same idea was tried > there but that was also reverted for what seems to be the same exact problem. > See https://github.com/llvm/llvm-project/pull/115099 and revert > [here](https://github.com/llvm/llvm-project/commit/83ff9d4a

[clang] [HLSL][SPIRV] Add CLI option `-fspv-extension` (PR #137985)

2025-05-02 Thread Steven Perron via cfe-commits
https://github.com/s-perron closed https://github.com/llvm/llvm-project/pull/137985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 50e1db7 - [HLSL][SPIRV] Add CLI option `-fspv-extension` (#137985)

2025-05-02 Thread via cfe-commits
Author: Steven Perron Date: 2025-05-02T19:41:38-04:00 New Revision: 50e1db7194e70ddf235edad289e726ed5c6027b7 URL: https://github.com/llvm/llvm-project/commit/50e1db7194e70ddf235edad289e726ed5c6027b7 DIFF: https://github.com/llvm/llvm-project/commit/50e1db7194e70ddf235edad289e726ed5c6027b7.diff

[clang] [clang] UEFI default ABI (PR #138364)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Prabhu Rajasekaran (Prabhuk) Changes Set MS ABI as default ABI for UEFI. --- Full diff: https://github.com/llvm/llvm-project/pull/138364.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Arch/X86.cpp (+1-1)

[clang] [clang] UEFI default ABI (PR #138364)

2025-05-02 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk created https://github.com/llvm/llvm-project/pull/138364 Set MS ABI as default ABI for UEFI. >From d0786948b07adb0318a19562c9a9ee72e893feef Mon Sep 17 00:00:00 2001 From: prabhukr Date: Fri, 2 May 2025 23:38:40 + Subject: [PATCH] [clang] UEFI default ABI Set MS

[clang] [Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (PR #115099)

2025-05-02 Thread Reid Kleckner via cfe-commits
@@ -138,6 +142,12 @@ let Attributes = [Const, NoThrow, RequiredVectorWidth<256>], Features = "avx" in } } +// PRFCHW +let Features = "prfchw", Header = "x86intrin.h", Attributes = [NoThrow, Const] in { + def _m_prefetch : X86LibBuiltin<"void(void *)">; rn

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Reid Kleckner (rnk) Changes This reverts commit 83ff9d4a34b1e579dd809759d13b70b8837f0cde. Don't change the builtin signature of _mm_prefetch this time. --- Full diff: https://github.com/llvm/llvm-project/pull/138360.diff 4 Files Affect

[clang] Reapply "[Win/X86] Make _m_prefetch[w] builtins to avoid winnt.h conflicts (#115099)" (PR #138360)

2025-05-02 Thread Reid Kleckner via cfe-commits
https://github.com/rnk created https://github.com/llvm/llvm-project/pull/138360 This reverts commit 83ff9d4a34b1e579dd809759d13b70b8837f0cde. Don't change the builtin signature of _mm_prefetch this time. >From 7da648bdd03a2fce7ab214f0425efb3a1ec1f4fe Mon Sep 17 00:00:00 2001 From: Reid Kleckne

[clang] [clang] Provide to `PPCallbacks` full expression range even in single file parse mode. (PR #138358)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) Changes Restore the behavior existing prior to fe2eefc4718f57e1753f7bd51c158fc03d70b34f. Make reporting of unevaluated directive source range more consistent and with fewer assumptions. In case of a failed eval

[clang] [clang] Provide to `PPCallbacks` full expression range even in single file parse mode. (PR #138358)

2025-05-02 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai created https://github.com/llvm/llvm-project/pull/138358 Restore the behavior existing prior to fe2eefc4718f57e1753f7bd51c158fc03d70b34f. Make reporting of unevaluated directive source range more consistent and with fewer assumptions. In case of a failed evaluation

[clang] 123758b - [IRBuilder] Add versions of createInsertVector/createExtractVector that take a uint64_t index. (#138324)

2025-05-02 Thread via cfe-commits
Author: Craig Topper Date: 2025-05-02T16:10:18-07:00 New Revision: 123758b1f4a8106926d95268ea8dc27158b6393a URL: https://github.com/llvm/llvm-project/commit/123758b1f4a8106926d95268ea8dc27158b6393a DIFF: https://github.com/llvm/llvm-project/commit/123758b1f4a8106926d95268ea8dc27158b6393a.diff

[clang] [llvm] [IRBuilder] Add versions of createInsertVector/createExtractVector that take a uint64_t index. (PR #138324)

2025-05-02 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/138324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread via cfe-commits
https://github.com/jeremyd2019 edited https://github.com/llvm/llvm-project/pull/138343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cmake] Reenable libclang.dll when LLVM_ENABLE_PIC (PR #138343)

2025-05-02 Thread via cfe-commits
@@ -106,7 +106,7 @@ if (LLVM_EXPORTED_SYMBOL_FILE) DEPENDS ${LIBCLANG_VERSION_SCRIPT_FILE}) endif() -if((NOT (WIN32 OR CYGWIN) AND LLVM_ENABLE_PIC) OR +if((NOT CYGWIN AND LLVM_ENABLE_PIC) OR ((WIN32 OR CYGWIN) AND NOT LIBCLANG_BUILD_STATIC)) ---

[clang] [clang] Merge gtest binaries into AllClangUnitTests (PR #134196)

2025-05-02 Thread via cfe-commits
dyung wrote: I've been seeing intermittent failures of AllClangUnitTests/TimeProfilerTest/ConstantEvaluationCxx20 and AllClangUnitTests/TimeProfilerTest/ConstantEvaluationC99 on my MacOS bot, but I haven't had a chance to try and figure out if it might be related to your change or not. Const

[clang] [clang] Remove FEM_Indeterminable (PR #137661)

2025-05-02 Thread Marius Cornea via cfe-commits
marius-cornea wrote: An after-the-fact note: for Intel math libraries, this does not matter at all, as we never use FLT_EVAL_METHOD in our code. We use however other methods to achieve the effect we want, i.e., the equivalent of FLT_EVAL_METHOD = 0 (source). We use fp-model precise, or sometim

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-02 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/138346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread Amr Hesham via cfe-commits
@@ -70,12 +72,15 @@ void foo() { // CIR: %[[VEC_E:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["e", init] // CIR: %[[VEC_F:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["f", init] // CIR: %[[VEC_G:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["g", in

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-02 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138346 >From 821d56db431ec2587eefc18f9f9dab5f5dc48c7e Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 2 May 2025 23:12:34 +0200 Subject: [PATCH 1/2] [CIR] Upstream local VectorType with 0 init elemnts ---

[clang] [Clang][NFC] Use std::move for Detail in timeTraceMetadata (PR #138352)

2025-05-02 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/138352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] attempt to fix building shared libclang. (PR #138351)

2025-05-02 Thread via cfe-commits
https://github.com/jeremyd2019 converted_to_draft https://github.com/llvm/llvm-project/pull/138351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Use std::move for Detail in timeTraceMetadata (PR #138352)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged the use of Detail because we were not using std::move when returning values. Modified the returns to use std::move. --- Full diff: https://github.com/llvm/llvm-project/pull/138352.d

[clang] [Clang][NFC] Use std::move for Detail in timeTraceMetadata (PR #138352)

2025-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Shafik Yaghmour (shafik) Changes Static analysis flagged the use of Detail because we were not using std::move when returning values. Modified the returns to use std::move. --- Full diff: https://github.com/llvm/llvm-pro

  1   2   3   4   5   6   7   >