[clang] [NFC][Driver] Simplify linking of ubsan_standalone_cxx (PR #120938)

2024-12-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/120938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Driver] Simplify linking of ubsan_standalone_cxx (PR #120938)

2024-12-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/120938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Simplify linking of ubsan_standalone_cxx (PR #120938)

2024-12-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/120938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Simplify linking of ubsan_standalone_cxx (PR #120938)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/120938.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp (+6-6) ``diff diff --git a/clang/lib/Driver/Tool

[clang] [Driver] Simplify linking of ubsan_standalone_cxx (PR #120938)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Vitaly Buka (vitalybuka) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/120938.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/CommonArgs.cpp (+6-6) ``diff diff --git a/clang/lib/Driv

[clang] [Driver] Simplify linking of ubsan_standalone_cxx (PR #120938)

2024-12-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/120938 None >From 1b260afe040e879e2202004ff8e33634666f586f Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sun, 22 Dec 2024 23:48:48 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia

[clang] [llvm] [mlir] [IR][ModRef] Introduce `errno` memory location (PR #120783)

2024-12-22 Thread Antonio Frighetto via cfe-commits
https://github.com/antoniofrighetto updated https://github.com/llvm/llvm-project/pull/120783 >From 81c1e35fc28f43c2f23df328244de0528f4bf1d0 Mon Sep 17 00:00:00 2001 From: Antonio Frighetto Date: Fri, 20 Dec 2024 19:30:59 +0100 Subject: [PATCH 1/2] [IR][ModRef] Introduce `errno` memory location

[clang] 4b35dd5 - [Serialization] Try to clean up PendingUndeducedFunctionDecls when

2024-12-22 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-12-23T15:14:38+08:00 New Revision: 4b35dd57b88a59b169c3471cbc398113d3bf98e8 URL: https://github.com/llvm/llvm-project/commit/4b35dd57b88a59b169c3471cbc398113d3bf98e8 DIFF: https://github.com/llvm/llvm-project/commit/4b35dd57b88a59b169c3471cbc398113d3bf98e8.diff LO

[clang] [llvm] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 updated https://github.com/llvm/llvm-project/pull/120904 From f36a48a92999cb791bf79b79adddaa73cab6f135 Mon Sep 17 00:00:00 2001 From: hunter <284050...@qq.com> Date: Mon, 23 Dec 2024 00:35:30 +0800 Subject: [PATCH 1/8] [Clang] Repair the functionrParenEndsCast to make inc

[clang] [llvm] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff db2307d2d7f650aa8f0d9ba727abfe83a32bc3bf 8b1d1162378e7a11902b92a44bfdd75001ea6239 --e

[clang] [llvm] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 updated https://github.com/llvm/llvm-project/pull/120904 From f36a48a92999cb791bf79b79adddaa73cab6f135 Mon Sep 17 00:00:00 2001 From: hunter <284050...@qq.com> Date: Mon, 23 Dec 2024 00:35:30 +0800 Subject: [PATCH 1/7] [Clang] Repair the functionrParenEndsCast to make inc

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-22 Thread via cfe-commits
dyung wrote: > > Sure, I can test it. Just to confirm, what branch/commit should I be > > testing? > > This PR has everything in it so you can just test it. There are 3 commits on > this branch that won't land here (they're under review in their own PRs), but > I've got them all here so you c

[clang] [llvm] [RISCV] Add support of Sdext, Sdtrig extentions (PR #120936)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Shao-Ce SUN (sunshaoce) Changes `Sdext` and `Sdtrig` are RISC-V extensions related to debugging. The full specification can be found at https://github.com/riscv/riscv-debug-spec/releases/download/1.0.0-rc4/riscv-debug-specification.pdf --- F

[clang] [llvm] [RISCV] Add support of Sdext, Sdtrig extentions (PR #120936)

2024-12-22 Thread Shao-Ce SUN via cfe-commits
https://github.com/sunshaoce created https://github.com/llvm/llvm-project/pull/120936 `Sdext` and `Sdtrig` are RISC-V extensions related to debugging. The full specification can be found at https://github.com/riscv/riscv-debug-spec/releases/download/1.0.0-rc4/riscv-debug-specification.pdf >Fro

[clang] [llvm] [ConstantRange] Estimate tighter lower (upper) bounds for masked binary and (or) (PR #120352)

2024-12-22 Thread Stephen Senran Zhang via cfe-commits
@@ -1520,15 +1520,101 @@ ConstantRange ConstantRange::binaryNot() const { return ConstantRange(APInt::getAllOnes(getBitWidth())).sub(*this); } +/// Estimate the 'bit-masked AND' operation's lower bound. +/// +/// E.g., given two ranges as follows (single quotes are separator

[clang] [Clang][Sema] Process warnings conditionally (PR #120591)

2024-12-22 Thread Dmitry Chestnykh via cfe-commits
https://github.com/chestnykh updated https://github.com/llvm/llvm-project/pull/120591 >From 9a0d5d44f70477403a33d2feb3f5518b0d078a66 Mon Sep 17 00:00:00 2001 From: Dmitry Chestnykh Date: Thu, 19 Dec 2024 18:35:35 +0300 Subject: [PATCH 1/2] [Clang][Sema] Process warnings conditionally There are

[clang-tools-extra] [clangd] Re-land "support outgoing calls in call hierarchy" (PR #117673)

2024-12-22 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > > @kadircet perhaps you might be able to pick up this review? > > Or, in the absence of a full review, your opinion on the directional > > question in [this comment](https://reviews.llvm.org/D93829#4654786) would > > be appreciated as well: > > > how would you feel about

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung ready_for_review https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] Introduce SingleByteCoverage tests (w/yaml2obj) (PR #113114)

2024-12-22 Thread NAKAMURA Takumi via cfe-commits
chapuni wrote: @ornata Thanks. I'll merge this possibly tomorrow unless objections. https://github.com/llvm/llvm-project/pull/113114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2024-12-22 Thread Naman Dixit via cfe-commits
namandixit wrote: Hi, is it possible to add a separate warning for unknown prefixes (as requested in the issue)? Enabling `-Wpedantic` is usually considered a best practice, and mixing useful warnings (unknown attribute) and less useful ones (unknown attribute prefix) will only drive people to

[clang] [llvm] [openmp] [OpenMP] Use generic IR for the OpenMP DeviceRTL (PR #119091)

2024-12-22 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/119091 >From 767d34a0469aa67c2c47a35bc9bff29d20ae1222 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Sat, 7 Dec 2024 13:47:23 -0600 Subject: [PATCH] [OpenMP] Use generic IR for the OpenMP DeviceRTL Summary: We prev

[clang] [compiler-rt] [llvm] Single byte coverage with branch coverage (PR #113115)

2024-12-22 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni edited https://github.com/llvm/llvm-project/pull/113115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Coverage] Introduce the type `CounterPair` for RegionCounterMap. NFC. (PR #112724)

2024-12-22 Thread Jessica Paquette via cfe-commits
@@ -362,6 +362,8 @@ CodeGenFunction::AddInitializerToStaticVarDecl(const VarDecl &D, return GV; } + PGO.markStmtMaybeUsed(D.getInit()); // FIXME: Too lazy ornata wrote: OK gotcha https://github.com/llvm/llvm-project/pull/112724 __

[clang] [Coverage] Introduce the type `CounterPair` for RegionCounterMap. NFC. (PR #112724)

2024-12-22 Thread Jessica Paquette via cfe-commits
@@ -1728,6 +1730,7 @@ bool CodeGenFunction::ConstantFoldsToSimpleInteger(const Expr *Cond, if (!AllowLabels && CodeGenFunction::ContainsLabel(Cond)) return false; // Contains a label. + PGO.markStmtMaybeUsed(Cond); ornata wrote: OK gotcha https://gi

[clang] [Coverage] Introduce the type `CounterPair` for RegionCounterMap. NFC. (PR #112724)

2024-12-22 Thread Jessica Paquette via cfe-commits
@@ -1869,7 +1871,10 @@ void CodeGenFunction::EmitAutoVarInit(const AutoVarEmission &emission) { // If we are at an unreachable point, we don't need to emit the initializer // unless it contains a label. if (!HaveInsertPoint()) { -if (!Init || !ContainsLabel(Init)) re

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] Added options to readability-implicit-bool-conversion (PR #120087)

2024-12-22 Thread via cfe-commits
@@ -319,10 +319,11 @@ Changes in existing checks diagnostic. - Improved :doc:`readability-implicit-bool-conversion - ` check - by adding the option `UseUpperCaseLiteralSuffix` to select the - case of the literal suffix in fixes and fixing false positive for implicit - co

[clang-tools-extra] Added options to readability-implicit-bool-conversion (PR #120087)

2024-12-22 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne updated https://github.com/llvm/llvm-project/pull/120087 >From 03f536888ddc5b7be2514c2d880c6d3119b7f4ee Mon Sep 17 00:00:00 2001 From: 4m4n-x-B4w4ne <125849251+4m4n-x-b4w...@users.noreply.github.com> Date: Mon, 16 Dec 2024 19:43:42 +0530 Subject: [PATCH 01/33] Up

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-22 Thread Chandler Carruth via cfe-commits
chandlerc wrote: > > I think I've addressed most of the review comments here at this point. > > But maybe most excitingly, I think the latest version may dodge the issues > > that have cropped up with MSVC -- both LoongArch and X86 fixes have been > > incorporated that hopefully help. @dyung --

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Richard Li via cfe-commits
https://github.com/chomosuke updated https://github.com/llvm/llvm-project/pull/118569 >From efc17a803c9c22543de7d5f9e960a7267ade1f2e Mon Sep 17 00:00:00 2001 From: chomosuke Date: Wed, 4 Dec 2024 14:42:24 + Subject: [PATCH 1/2] [clangd][clang-tidy] Make clangd run `format::cleanupAroundRep

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-22 Thread via cfe-commits
dyung wrote: > I think I've addressed most of the review comments here at this point. > > But maybe most excitingly, I think the latest version may dodge the issues > that have cropped up with MSVC -- both LoongArch and X86 fixes have been > incorporated that hopefully help. @dyung -- if you c

[clang] [llvm] Introduce SingleByteCoverage tests (w/yaml2obj) (PR #113114)

2024-12-22 Thread Jessica Paquette via cfe-commits
https://github.com/ornata approved this pull request. I don't see any problem with this change. https://github.com/llvm/llvm-project/pull/113114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [X86][AVX10.2] Add comments for the avx10_2convertintrin.h file (PR #120766)

2024-12-22 Thread Phoebe Wang via cfe-commits
=?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_P

[clang] [X86][AVX10.2] Add comments for the avx10_2convertintrin.h file (PR #120766)

2024-12-22 Thread Phoebe Wang via cfe-commits
=?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_Piróg?= , =?utf-8?q?Mikołaj_P

[clang-tools-extra] Added options to readability-implicit-bool-conversion (PR #120087)

2024-12-22 Thread via cfe-commits
@@ -319,10 +319,11 @@ Changes in existing checks diagnostic. - Improved :doc:`readability-implicit-bool-conversion - ` check - by adding the option `UseUpperCaseLiteralSuffix` to select the - case of the literal suffix in fixes and fixing false positive for implicit - co

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] dd577c0 - [clang] constexpr built-in reduce min/max function. (#120866)

2024-12-22 Thread via cfe-commits
Author: c8ef Date: 2024-12-23T09:06:38+08:00 New Revision: dd577c05ad0d382b444da01b6a1f56f8c2c15e07 URL: https://github.com/llvm/llvm-project/commit/dd577c05ad0d382b444da01b6a1f56f8c2c15e07 DIFF: https://github.com/llvm/llvm-project/commit/dd577c05ad0d382b444da01b6a1f56f8c2c15e07.diff LOG: [cl

[clang] [X86][AVX10.2] Fix wrong mask bits in cvtpbf8_ph intrinsics (PR #120927)

2024-12-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/120927 >From 2b9cde28c2093556d006b5ff0103137f52a7a751 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Mon, 23 Dec 2024 09:05:06 +0800 Subject: [PATCH] [X86][AVX10.2] Fix wrong mask bits in cvtpbf8_ph intrinsics

[clang] [X86][AVX10.2] Fix wrong mask bits in cvtpbf8_ph intrinsics (PR #120927)

2024-12-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang updated https://github.com/llvm/llvm-project/pull/120927 >From 608ce20a7b3b8fdd7b65c7afc8f2de7ad271369c Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Mon, 23 Dec 2024 09:05:06 +0800 Subject: [PATCH] [X86][AVX10.2] Fix wrong mask bits in cvtpbf8_ph intrinsics

[clang] [X86][AVX10.2] Fix wrong mask bits in cvtpbf8_ph intrinsics (PR #120927)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Phoebe Wang (phoebewang) Changes Found during review #120766 --- Full diff: https://github.com/llvm/llvm-project/pull/120927.diff 4 Files Affected: - (modified) clang/lib/Headers/avx10_2_512convertintrin.h (+2-2) - (modified) clang/lib

[clang] [X86][AVX10.2] Fix wrong mask bits in cvtpbf8_ph intrinsics (PR #120927)

2024-12-22 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/120927 Found during review #120766 >From 13176bdf116f54aee7ffed4b22cace39776c6515 Mon Sep 17 00:00:00 2001 From: "Wang, Phoebe" Date: Mon, 23 Dec 2024 09:05:06 +0800 Subject: [PATCH] [X86][AVX10.2] Fix wrong mask b

[clang] [clang] constexpr built-in reduce min/max function. (PR #120866)

2024-12-22 Thread via cfe-commits
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/120866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/120920 error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2024-12-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 44514316bd5ef656076b6baaf6bccb298d98f0ea bce88b1bb464438828fc177c978ad2b99957530f --e

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Oleksandr T. (a-tarasyuk) Changes Fixes #120875 --- Full diff: https://github.com/llvm/llvm-project/pull/120925.diff 12 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clan

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2024-12-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/120925 Fixes #120875 >From bce88b1bb464438828fc177c978ad2b99957530f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Dec 2024 02:35:07 +0200 Subject: [PATCH] [Clang] raise extension warning for unknown nam

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Please run `ninja FormatTests` before submitting the patch. It fails a few unit tests before crashing. https://github.com/llvm/llvm-project/pull/120904 ___ cfe-commits mailing list cfe-

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
@@ -761,7 +762,37 @@ void StoreDiags::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel, return false; if (!isInsideMainFile(FixIt.RemoveRange.getBegin(), SM)) return false; - Edits.push_back(toTextEdit(FixIt, SM, *LangOpts)); + + auto R = too

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/118569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
@@ -761,7 +762,37 @@ void StoreDiags::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel, return false; if (!isInsideMainFile(FixIt.RemoveRange.getBegin(), SM)) return false; - Edits.push_back(toTextEdit(FixIt, SM, *LangOpts)); + + auto R = too

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
@@ -761,7 +762,37 @@ void StoreDiags::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel, return false; if (!isInsideMainFile(FixIt.RemoveRange.getBegin(), SM)) return false; - Edits.push_back(toTextEdit(FixIt, SM, *LangOpts)); + + auto R = too

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
@@ -342,6 +342,20 @@ llvm::Error Replacements::add(const Replacement &R) { return llvm::Error::success(); } +llvm::Error Replacements::addOrMerge(const Replacement &R) { + auto Err = add(R); + if (Err) { llvm-beanz wrote: nit: You could rewrite this as: `

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
@@ -149,26 +149,12 @@ class ErrorReporter { Repl.getLength(), Repl.getReplacementText()); auto &Entry = FileReplacements[R.getFilePath()]; Replacements &Replacements = Entry.Replaces; -llvm::Error Err = Rep

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/118569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
@@ -761,7 +762,37 @@ void StoreDiags::HandleDiagnostic(DiagnosticsEngine::Level DiagLevel, return false; if (!isInsideMainFile(FixIt.RemoveRange.getBegin(), SM)) return false; - Edits.push_back(toTextEdit(FixIt, SM, *LangOpts)); + + auto R = too

[clang] [clang-tools-extra] [clangd] Make clangd run `format::cleanupAroundReplacements()` for all code actions just as clang-tidy does (PR #118569)

2024-12-22 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. This mostly looks good to me. I have a few style nits to use more idomatic patterns and conform better to LLVM coding standards. https://github.com/llvm/llvm-project/pull/118569 ___ cfe-commits

[clang-tools-extra] [clangd] Do not show `aParam` parameter hint for argument spelled `param` (PR #119162)

2024-12-22 Thread Chris B via cfe-commits
https://github.com/llvm-beanz commented: I think this gets really complicated really quickly. The `a` prefix for arguments seems like a coding style derived from Hungarian Notation, and I guess I could see an argument for having an option to disregard variable prefixes when matching the hints,

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-22 Thread Nathan Ridge via cfe-commits
@@ -1863,14 +1863,41 @@ class CodeCompleteFlow { CodeCompleteResult Output; // Convert the results to final form, assembling the expensive strings. +// If necessary, search the index for documentation comments. +LookupRequest Req; +llvm::DenseMap SymbolToCo

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 requested changes to this pull request. Thanks, this patch generally looks great. It would be nice to have a couple of test cases exercising the behaviour with overloaded methods when overload bundling is enabled (`CodeCompleteOptions::BundleOverloads` is set

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-22 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 edited https://github.com/llvm/llvm-project/pull/120099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Augment code completion results with documentation from the index. (PR #120099)

2024-12-22 Thread Nathan Ridge via cfe-commits
@@ -1101,6 +1101,42 @@ int x = foo^ Contains(AllOf(named("foo"), doc("This comment should be retained!"; } +TEST(CompletionTest, CommentsOnMembers) { HighCommander4 wrote: nit: call this `CommentsOnMembersFromHeader` https://github.com/llvm/llvm-pr

[clang] [BoundsSafety][Doc] Add BoundsSafetyAdoptionGuide.rst (PR #120674)

2024-12-22 Thread Yeoul Na via cfe-commits
rapidsna wrote: > Given the number of small changes that need to be made, I think it's worth > mentioning that fix-its exist and how their fixes can be applied, since > that's not always obvious when building in the terminal. Perhaps we also want > to mention that we'd appreciate reports of sn

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread Owen Pan via cfe-commits
owenca wrote: You need to add a unit test. https://github.com/llvm/llvm-project/pull/120904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung edited https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c5492e3c65e40cdcab9771b692f9ad437c65aa04 11ec4bc42c734c5f55047d5c5bd5ed9bcd8c6e01 --e

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx Author: Nhat Nguyen (changkhothuychung) Changes --- Patch is 52.01 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/120920.diff 14 Files Affected: - (added) libcxx/include/__ranges/concat_view.h (+

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung converted_to_draft https://github.com/llvm/llvm-project/pull/120920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [libcxx] [llvm] [libcxx] implement views::concat (PR #120920)

2024-12-22 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung created https://github.com/llvm/llvm-project/pull/120920 None error: too big or took too long to generate ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [X86][AVX10.2] Add comments for the avx10_2convertintrin.h file (PR #120766)

2024-12-22 Thread Mikołaj Piróg via cfe-commits
@@ -24,573 +24,3369 @@ __attribute__((__always_inline__, __nodebug__, __target__("avx10.2-256"), \ __min_vector_width__(256))) +//clang-format off + +/// Convert two 128-bit vectors, \a __A and \a __B, containing packed +///single-precision (32-bit)

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2024-12-22 Thread Mészáros Gergely via cfe-commits
Maetveis wrote: Hi,Thanks for working on this issue. I wanted to preface this by feel free to ignore this during the holidays, zero pressure. I like to interact with the community in my free time, but that obviously does not need to extend to everyone :). What kind of failures are you seeing

[clang] [clang][ObjectiveC] Fix Parsing the `::` Optional Scope Specifier (PR #119908)

2024-12-22 Thread Fangrui Song via cfe-commits
MaskRay wrote: (https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223 the convention is to disable github's hide-email feature) https://github.com/llvm/llvm-project/pull/119908 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] Added options to readability-implicit-bool-conversion (PR #120087)

2024-12-22 Thread via cfe-commits
4m4n-x-B4w4ne wrote: I have written check file for all permutations of configuration of the options and also for the more comprehensive test cases as instructed with clean PR build. Done Thanks. @5chmidti Can you please review it? https://github.com/llvm/llv

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 updated https://github.com/llvm/llvm-project/pull/120904 From f36a48a92999cb791bf79b79adddaa73cab6f135 Mon Sep 17 00:00:00 2001 From: hunter <284050...@qq.com> Date: Mon, 23 Dec 2024 00:35:30 +0800 Subject: [PATCH 1/3] [Clang] Repair the functionrParenEndsCast to make inc

[clang-tools-extra] Added options to readability-implicit-bool-conversion (PR #120087)

2024-12-22 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne updated https://github.com/llvm/llvm-project/pull/120087 >From 03f536888ddc5b7be2514c2d880c6d3119b7f4ee Mon Sep 17 00:00:00 2001 From: 4m4n-x-B4w4ne <125849251+4m4n-x-b4w...@users.noreply.github.com> Date: Mon, 16 Dec 2024 19:43:42 +0530 Subject: [PATCH 01/32] Up

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 updated https://github.com/llvm/llvm-project/pull/120904 From f36a48a92999cb791bf79b79adddaa73cab6f135 Mon Sep 17 00:00:00 2001 From: hunter <284050...@qq.com> Date: Mon, 23 Dec 2024 00:35:30 +0800 Subject: [PATCH 1/2] [Clang] Repair the functionrParenEndsCast to make inc

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 updated https://github.com/llvm/llvm-project/pull/120904 From f36a48a92999cb791bf79b79adddaa73cab6f135 Mon Sep 17 00:00:00 2001 From: hunter <284050...@qq.com> Date: Mon, 23 Dec 2024 00:35:30 +0800 Subject: [PATCH] [Clang] Repair the functionrParenEndsCast to make incorrec

[clang-tools-extra] [clang-tidy][NFC][doc] mention some range algorithms do not work for `vector` in C++20 (PR #120774)

2024-12-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/120774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a4f5e90 - [clang-tidy][NFC][doc] mention some range algorithms do not work for `vector` in C++20 (#120774)

2024-12-22 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-23T00:07:57+08:00 New Revision: a4f5e90e319e8bf36ed421a0445218ff17d4de03 URL: https://github.com/llvm/llvm-project/commit/a4f5e90e319e8bf36ed421a0445218ff17d4de03 DIFF: https://github.com/llvm/llvm-project/commit/a4f5e90e319e8bf36ed421a0445218ff17d4de03.diff

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: 执着 (dty2) Changes Try to fix issue: https://github.com/llvm/llvm-project/issues/120148 I'm a newbie, please give me some suggestions for modification. Especially I use a global array "castIdentifiers", I feel that this implementatio

[clang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120904)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 created https://github.com/llvm/llvm-project/pull/120904 Try to fix issue: https://github.com/llvm/llvm-project/issues/120148 I'm a newbie, please give me some suggestions for modification. Especially I use a global array "castIdentifiers", I feel that this implementation

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2024-12-22 Thread via cfe-commits
https://github.com/GeorgeKA edited https://github.com/llvm/llvm-project/pull/120900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2024-12-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 342fa15a44721799c9314c58df0d803f13f9d805...faf8597dbb58a08991e11e9c4b9a0aad2f0b4234 clang

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2024-12-22 Thread via cfe-commits
https://github.com/GeorgeKA created https://github.com/llvm/llvm-project/pull/120900 Created generate_unsupported_in_drivermode.py which generates a Lit regression test file that validates that options are only exposed to intended driver modes. The options and driver modes are parsed from Opti

[clang] Factor common code for quoting a builtin name (PR #120835)

2024-12-22 Thread Carlo Cabrera via cfe-commits
https://github.com/carlocab approved this pull request. https://github.com/llvm/llvm-project/pull/120835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120897)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 created https://github.com/llvm/llvm-project/pull/120897 Try to fix issue: https://github.com/llvm/llvm-project/issues/120148 I'm a newbie, please give me some suggestions for modification. Especially I use a global array "castIdentifiers", I feel that this implementation

[clang] [flang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120897)

2024-12-22 Thread via cfe-commits
dty2 wrote: Sorry, this is my mistake. The commit of this PR is too messy. I will resubmit a PR. https://github.com/llvm/llvm-project/pull/120897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [flang] [Clang] Repair the function "rParenEndsCast" to make incorrect judgments in template variable cases (PR #120897)

2024-12-22 Thread via cfe-commits
https://github.com/dty2 closed https://github.com/llvm/llvm-project/pull/120897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in reduce min/max function. (PR #120866)

2024-12-22 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon approved this pull request. LGTM - cheers https://github.com/llvm/llvm-project/pull/120866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2024-12-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #92847 --- > Types other than pointer types whose referenced type is an object type and (possibly multi-dimensional) array types with such pointer types as element type shall not be restrict-quali

[clang] [Clang] allow restrict qualifier for array types with pointer types as element types (PR #120896)

2024-12-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/120896 Fixes #92847 --- > Types other than pointer types whose referenced type is an object type and > (possibly multi-dimensional) array types with such pointer types as element > type shall not be restrict-qual

[clang-tools-extra] [clang-tidy][NFC][doc] mention some range algorithms do not work for `vector` in C++20 (PR #120774)

2024-12-22 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp approved this pull request. https://github.com/llvm/llvm-project/pull/120774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] constexpr built-in reduce min/max function. (PR #120866)

2024-12-22 Thread via cfe-commits
@@ -838,3 +838,18 @@ static_assert(__builtin_elementwise_sub_sat((1 << 31), 42) == (1 << 31)); static_assert(__builtin_elementwise_sub_sat(0U, 1U) == 0U); static_assert(__builtin_bit_cast(unsigned, __builtin_elementwise_sub_sat((vector4char){5, 4, 3, 2}, (vector4char){1, 1, 1,

[clang] [clang] constexpr built-in reduce min/max function. (PR #120866)

2024-12-22 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/120866 >From 4e16d47641bd02203753752636f1fe90182552e9 Mon Sep 17 00:00:00 2001 From: c8ef Date: Sun, 22 Dec 2024 11:08:43 +0800 Subject: [PATCH 1/2] constexpr reduce min/max --- clang/docs/LanguageExtensions.rst

[clang] [clang] constexpr built-in reduce min/max function. (PR #120866)

2024-12-22 Thread Simon Pilgrim via cfe-commits
@@ -838,3 +838,18 @@ static_assert(__builtin_elementwise_sub_sat((1 << 31), 42) == (1 << 31)); static_assert(__builtin_elementwise_sub_sat(0U, 1U) == 0U); static_assert(__builtin_bit_cast(unsigned, __builtin_elementwise_sub_sat((vector4char){5, 4, 3, 2}, (vector4char){1, 1, 1,

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-22 Thread Chandler Carruth via cfe-commits
@@ -100,10 +244,17 @@ class Context { /// Return the identifier name for the specified builtin, /// e.g. "__builtin_abs". - llvm::StringRef getName(unsigned ID) const { return getRecord(ID).Name; } + std::string getName(unsigned ID) const; chandlerc wrot

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-22 Thread Chandler Carruth via cfe-commits
@@ -100,10 +244,17 @@ class Context { /// Return the identifier name for the specified builtin, /// e.g. "__builtin_abs". - llvm::StringRef getName(unsigned ID) const { return getRecord(ID).Name; } + std::string getName(unsigned ID) const; + + /// Return the identifier

[clang] Patch series to reapply #118734 and substantially improve it (PR #120534)

2024-12-22 Thread Chandler Carruth via cfe-commits
@@ -68,23 +70,144 @@ enum ID { FirstTSBuiltin }; +// The info used to represent each builtin. struct Info { - llvm::StringLiteral Name; - const char *Type, *Attributes; - const char *Features; + // Rather than store pointers to the string literals describing these four

  1   2   >