[clang] [clang][bytecode] Check composite bitcasts for indeterminate bits (PR #118988)

2024-12-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/118988 >From 7e723fd3ee3844ad83fa61118dd263a84a6145e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 6 Dec 2024 15:52:38 +0100 Subject: [PATCH] [clang][bytecode] Check composite bitcasts for i

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
@@ -433,37 +433,36 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { //already duplicated // - call both from Sema and from here - const auto *BaseDRE = - dyn_cast(Node.getBase()->IgnoreParenImpCasts()); - const auto *SLiteral = - dyn_cast(Node.ge

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/118249 >From c1f7c2b37948271ccc8de7910d2bab91dfb2f87e Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 29 Nov 2024 14:53:37 +0530 Subject: [PATCH] [-Wunsafe-buffer-usage] Suppress warning for multi-dimens

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7f19b1e49c172772390a3c2e71631115da80af4b e1eadf464509ab74ff4f097f92e7140f43c61262 --e

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/118249 >From e1eadf464509ab74ff4f097f92e7140f43c61262 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Fri, 29 Nov 2024 14:53:37 +0530 Subject: [PATCH] [-Wunsafe-buffer-usage] Suppress warning for multi-dimens

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak edited https://github.com/llvm/llvm-project/pull/118249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Add diagnostics for invalid binary arithmetic (PR #118475)

2024-12-06 Thread Shafik Yaghmour via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/shafik commented: Am I missing something, it seems like several of the new diagnostics don't have tests that cover them. https://github.com/llvm/llvm-project/pull/118475 __

[clang] [-Wunsafe-buffer-usage] Suppress warning for multi-dimensional constant arrays (PR #118249)

2024-12-06 Thread Malavika Samak via cfe-commits
@@ -433,37 +433,36 @@ AST_MATCHER(ArraySubscriptExpr, isSafeArraySubscript) { //already duplicated // - call both from Sema and from here - const auto *BaseDRE = - dyn_cast(Node.getBase()->IgnoreParenImpCasts()); - const auto *SLiteral = - dyn_cast(Node.ge

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
leijurv wrote: > I think you should add test cases with multiple `>>` closing, see > `UnderstandsTemplateParameters` for example. > > Consider trying the code snippet mentioned in #80049 as well. Thank you for the suggestion! I have integrated that test case. It indicated that I was being too

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From 1caf823165b16f6701993d586df51d5cdbf0885e Mon Sep 17 00:00:00 2001 From: Leijurv Date: Fri, 29 Nov 2024 21:54:36 -0600 Subject: [PATCH 1/2] [clang-format] Add BreakBeforeTemplateClose option --- clang/doc

[clang] bcf6f84 - Revert "[Clang] Deleting an incomplete enum type is not an error (#118455) (#118980)

2024-12-06 Thread via cfe-commits
Author: cor3ntin Date: 2024-12-07T04:22:47+01:00 New Revision: bcf6f84763ea01d0a22022d0d64442e774fe86ab URL: https://github.com/llvm/llvm-project/commit/bcf6f84763ea01d0a22022d0d64442e774fe86ab DIFF: https://github.com/llvm/llvm-project/commit/bcf6f84763ea01d0a22022d0d64442e774fe86ab.diff LOG:

[clang] Revert "[Clang] Deleting an incomplete enum type is not an error (#118455) (PR #118980)

2024-12-06 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh closed https://github.com/llvm/llvm-project/pull/118980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Deleting an incomplete enum type is not an error (#118455) (PR #118980)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: I've added a reduced test case to https://github.com/llvm/llvm-project/pull/118455. Merging this to unbreak clang. https://github.com/llvm/llvm-project/pull/118980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: The test case was reduced to this: ``` template struct a { union b {}; struct c { c() { delete d; } b *d; } f; }; a e; ``` https://gcc.godbolt.org/z/d5cP4McG3 https://github.com/llvm/llvm-project/pull/118455 ___ cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: I think you should add test cases with multiple `>>` closing, see `UnderstandsTemplateParameters` for example. Consider trying the code snippet mentioned in https://github.com/llvm/llvm-project/issues/80049 as well. https://github.com/llvm/llvm-project/pull/118046 _

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: > > Yes. I followed the code that implements `AlignAfterOpenBracket: > > BlockIndent`, except applying to ClosesTemplateDeclaration. I made it a new > > setting for backwards compatibility. 👍 > > Maybe we should make it a sub-option for `BlockIndent`. I'm seeing a possible > nee

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#119051 https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
tstellar wrote: /cherry-pick 18af3fc1bf8855e1e166e64a9210ed07d610aa54 https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 18af3fc - [Clang][perf-training] Fix clean command in perf-helper.py (#118978)

2024-12-06 Thread via cfe-commits
Author: Tom Stellard Date: 2024-12-06T18:34:59-08:00 New Revision: 18af3fc1bf8855e1e166e64a9210ed07d610aa54 URL: https://github.com/llvm/llvm-project/commit/18af3fc1bf8855e1e166e64a9210ed07d610aa54 DIFF: https://github.com/llvm/llvm-project/commit/18af3fc1bf8855e1e166e64a9210ed07d610aa54.diff

[clang] [Clang][perf-training] Fix clean command in perf-helper.py (PR #118978)

2024-12-06 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/118978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: > Yes. I followed the code that implements `AlignAfterOpenBracket: > BlockIndent`, except applying to ClosesTemplateDeclaration. I made it a new > setting for backwards compatibility. 👍 Maybe we should make it a sub-option for `BlockIndent`. I'm seeing a possible need for having

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
leijurv wrote: Yes. I followed the code that implements `AlignAfterOpenBracket: BlockIndent`, except applying to ClosesTemplateDeclaration. I made it a new setting for backwards compatibility. 👍 https://github.com/llvm/llvm-project/pull/118046 ___ cf

[clang] [clang][bytecode] Handle bitcasts involving bitfields (PR #116843)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64-aix` running on `aix-ppc64` while building `clang` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildb

[clang] [clang-cl][flang][dxc] Fix opts exposed to clang-cl/dxc by mistake (PR #118640)

2024-12-06 Thread Haohai Wen via cfe-commits
HaohaiWen wrote: > > Better to double check with author who specified those CLOption. > > Do you mean the person that added `CLOption` to these flags? That was > @tarunprabhu, but IIUC that was by mistake; his intention was to extend these > flags only to Flang. > > Otherwise `-Xlinker` has b

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. It would be better to use `GtestCmp` if you really want clang-tidy support gtest in this check. Here is an unfinished example which can match ```int v = 10; TEST(a, b) { std::optional a; if (v) { a = 1; } ASSERT_N

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2024-12-06 Thread Shafik Yaghmour via cfe-commits
@@ -3190,19 +3190,27 @@ static void GenerateHeaderSearchArgs(const HeaderSearchOptions &Opts, auto It = Opts.UserEntries.begin(); auto End = Opts.UserEntries.end(); - // Add -I... and -F... options in order. - for (; It < End && Matches(*It, {frontend::Angled}, std::nul

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2024-12-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: nitpick https://github.com/llvm/llvm-project/pull/105738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] Match MSVC handling of duplicate header search paths in Microsoft compatibility modes. (PR #105738)

2024-12-06 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/105738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Warning as error Array Comparisons from C++26 (PR #118872)

2024-12-06 Thread Yanzuo Liu via cfe-commits
@@ -10274,6 +10274,11 @@ def warn_array_comparison : Warning< "to compare array addresses, use unary '+' to decay operands to pointers">, InGroup>; +def warn_array_comparison_cxx26 : Warning< + "comparison between two arrays compare their addresses not their contents; " -

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: Would this also be equivalent to supporting `AlignAfterOpenBracket: BlockIndent` for angle brackets? https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot8` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/7267 Here is the relevant piece o

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Tex Riddell via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Zhengxing li via cfe-commits
https://github.com/lizhengxing edited https://github.com/llvm/llvm-project/pull/117781 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Zhengxing li via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread Saleem Abdulrasool via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] [clang-format] Add BreakBeforeTemplateClose option (PR #118046)

2024-12-06 Thread via cfe-commits
leijurv wrote: Ping :pray: https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: I am still confused why your team did not just disable this rule for test folder? It is normal cases that source code and test code have different quality metrics. https://github.com/llvm/llvm-project/pull/115051 ___

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
gedare wrote: Without this patch, the test case on `main`: ``` [ RUN ] FormatTest.AlignsAfterOpenBracket /home/gedare/rtems/llvm-project/clang/unittests/Format/FormatTestBase.h:90: Failure Expected equality of these values: ExpectedCode Which is: "void foo(\nvoid (*foobarpntr)(\n

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Tex Riddell via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/118990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] a07e8cd - [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (#118990)

2024-12-06 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-07T08:31:35+08:00 New Revision: a07e8cdae7727583e20c9dec632a376365a6e209 URL: https://github.com/llvm/llvm-project/commit/a07e8cdae7727583e20c9dec632a376365a6e209 DIFF: https://github.com/llvm/llvm-project/commit/a07e8cdae7727583e20c9dec632a376365a6e209.diff

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/119044 >From c6b628536daf5640c383fd7abe629e84d1505ae2 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Fri, 6 Dec 2024 16:52:35 -0700 Subject: [PATCH] [clang-format] Reorder TokenAnnotator::canBreakBefore Move the che

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/119044 >From bd86e432e8ef5bc960e2ccaeca77f3b7cf51333f Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Fri, 6 Dec 2024 16:52:35 -0700 Subject: [PATCH] [clang-format] Reorder TokenAnnotator::canBreakBefore Move the che

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Alexander Kornienko via cfe-commits
alexfh wrote: To avoid this I usually incorporate a validity check in my interestingness test, e.g. by running a known-good clang on the candidate input, e.g. currently I use: ``` $ cat bad-clang-crashes.sh #!/bin/bash -eux ARGS="-fdiagnostics-show-option -Wall -Werror -Wno-inconsistent-missin

[clang] afa2fbf - [Reland][clang][AArch64] Avoid a crash when a non-reserved register is used (#117419)

2024-12-06 Thread Igor Kudrin via cfe-commits
Author: Igor Kudrin Date: 2024-12-06T16:13:36-08:00 New Revision: afa2fbf87a8e3fff609fd325c938929c48e94280 URL: https://github.com/llvm/llvm-project/commit/afa2fbf87a8e3fff609fd325c938929c48e94280 DIFF: https://github.com/llvm/llvm-project/commit/afa2fbf87a8e3fff609fd325c938929c48e94280.diff L

[clang] [llvm] [HLSL] Implement SV_GroupThreadId semantic (PR #117781)

2024-12-06 Thread Tex Riddell via cfe-commits
@@ -3606,6 +3613,32 @@ bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, return Result && MIB.constrainAllUses(TII, TRI, RBI); } +bool SPIRVInstructionSelector::selectSpvThreadId(Register ResVReg, + const SPIR

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 516d6ede122086027baa2288623605a423375e87 6233d3dc731ae15368231b9e956379d71e905311 --e

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/119044 >From 6233d3dc731ae15368231b9e956379d71e905311 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Fri, 6 Dec 2024 16:52:35 -0700 Subject: [PATCH] [clang-format] Reorder TokenAnnotator::canBreakBefore Move the che

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Gedare Bloom (gedare) Changes Move the checks related to breaking before right braces and right parens earlier to avoid conflicting checks that prevent breaking based on the left-hand token. This allows properly formatting declara

[clang] [clang-format] Reorder TokenAnnotator::canBreakBefore (PR #119044)

2024-12-06 Thread Gedare Bloom via cfe-commits
https://github.com/gedare created https://github.com/llvm/llvm-project/pull/119044 Move the checks related to breaking before right braces and right parens earlier to avoid conflicting checks that prevent breaking based on the left-hand token. This allows properly formatting declarations with

[clang] [Clang] Deleting an incomplete enum type is not an error (PR #118455)

2024-12-06 Thread Mike Hommey via cfe-commits
glandium wrote: cvise has reduced my testcase to ``` union StyleColorFunctionStyleColorFunction *mRaw { delete mRaw ``` ... which is nowhere close to the real thing and nowhere close to legal C++ at all. Well, that definitely shouldn't trigger a crash, though. https://github.com/llvm/llvm-p

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Paul Kirth via cfe-commits
ilovepi wrote: @uweigand Thanks for the prompt revert. For reference the Fuchsia bot is just a normal Linux build configured for building Fuchsia in a debian container. The toolchain isn't novel in anyway, except it normally builds with a recent toolchain, and uses the full runtimes build. T

[clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/118990 >From d9f50466850ee966829ce80f273ad9a10aa24489 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Fri, 6 Dec 2024 23:45:56 +0800 Subject: [PATCH] [clang-tidy] fix false positive in lambda expr for return-con

[clang] 8787bc7 - Revert "[SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (#116642)"

2024-12-06 Thread Ulrich Weigand via cfe-commits
Author: Ulrich Weigand Date: 2024-12-07T00:55:54+01:00 New Revision: 8787bc72a61aa43a6e937647b6797ddb2ff287d2 URL: https://github.com/llvm/llvm-project/commit/8787bc72a61aa43a6e937647b6797ddb2ff287d2 DIFF: https://github.com/llvm/llvm-project/commit/8787bc72a61aa43a6e937647b6797ddb2ff287d2.diff

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Ulrich Weigand via cfe-commits
uweigand wrote: Hi @anoopkg6 , I had to revert this again as it was causing a number of issues: - An unused variable warning fixed here: https://github.com/llvm/llvm-project/commit/3c47e63723b1aa9e76f30fc8d1acef9caf4ea783 - The fuchsia build bot failure - I'm not completely sure what causes thi

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -27,19 +29,44 @@ class UncheckedOptionalAccessCheck : public ClangTidyCheck { UncheckedOptionalAccessCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), ModelOptions{ -Options.getLocalOrGlobal("IgnoreSmartPointerDeref

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/115051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/115051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -27,19 +29,44 @@ class UncheckedOptionalAccessCheck : public ClangTidyCheck { UncheckedOptionalAccessCheck(StringRef Name, ClangTidyContext *Context) : ClangTidyCheck(Name, Context), ModelOptions{ -Options.getLocalOrGlobal("IgnoreSmartPointerDeref

[clang-tools-extra] [clang-tidy][NFC] merge same part matchers in return-const-ref-from-parameter (PR #118985)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/118985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix false positive in lambda expr for return-const-ref-from-parameter (PR #118990)

2024-12-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/118990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
5chmidti wrote: Please also add an `ASSERT_FALSE` (or just `ASSERT_TRUE(!opt.has_value())`) with a dereference after, to show that there are false-negatives https://github.com/llvm/llvm-project/pull/115051 ___ cfe-co

[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > option that is off by default. For all other users the behavior is unchanged, > but we can opt in on our side. > Can we add the option to use in the meantime, while I work on the macro > handling in parallel? That sounds okay to me, even though the opti

[clang-tools-extra] 17a7f20 - [clang-tidy][NFC] merge same part matchers in return-const-ref-from-parameter (#118985)

2024-12-06 Thread via cfe-commits
Author: Congcong Cai Date: 2024-12-07T08:00:11+08:00 New Revision: 17a7f20685de2a275fc2e53a38c5818797fe8a44 URL: https://github.com/llvm/llvm-project/commit/17a7f20685de2a275fc2e53a38c5818797fe8a44 DIFF: https://github.com/llvm/llvm-project/commit/17a7f20685de2a275fc2e53a38c5818797fe8a44.diff

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/1

[clang] Bug/templated struct debug reference this (PR #119041)

2024-12-06 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/119041 >From f6a7af10669d71251c2235bef5b2625d88fa1d90 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 6 Dec 2024 01:27:24 + Subject: [PATCH 1/3] Apply DXC fix and add tests --- clang/lib/CodeGen/CGDebu

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Paul Kirth via cfe-commits
ilovepi wrote: This seems to have broken build bot and Fuchsia's Linux CI https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-host-linux-x64/b8729261510660874657/overview. Would you mind reverting until a fix is ready? https://github.com/llvm/llvm-project/pull/116642 _

[clang] Bug/templated struct debug reference this (PR #119041)

2024-12-06 Thread via cfe-commits
https://github.com/joaosaffran created https://github.com/llvm/llvm-project/pull/119041 None >From f6a7af10669d71251c2235bef5b2625d88fa1d90 Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Fri, 6 Dec 2024 01:27:24 + Subject: [PATCH 1/2] Apply DXC fix and add tests --- clang/lib/CodeGen/

[clang] da65fe1 - Revert "[clang][AArch64] Avoid a crash when a non-reserved register is used (#117419)"

2024-12-06 Thread Igor Kudrin via cfe-commits
Author: Igor Kudrin Date: 2024-12-06T15:10:40-08:00 New Revision: da65fe1c16308cdb71b2fd26aaedc0ce52521ab4 URL: https://github.com/llvm/llvm-project/commit/da65fe1c16308cdb71b2fd26aaedc0ce52521ab4 DIFF: https://github.com/llvm/llvm-project/commit/da65fe1c16308cdb71b2fd26aaedc0ce52521ab4.diff L

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/13353

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `clang,llvm` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/9334 Here is the relev

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-12-06 Thread Igor Kudrin via cfe-commits
https://github.com/igorkudrin closed https://github.com/llvm/llvm-project/pull/117419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8fc6fca - [clang][AArch64] Avoid a crash when a non-reserved register is used (#117419)

2024-12-06 Thread via cfe-commits
Author: Igor Kudrin Date: 2024-12-06T14:58:10-08:00 New Revision: 8fc6fca9f28ce20d76066be66fcc41aa38f7dc3d URL: https://github.com/llvm/llvm-project/commit/8fc6fca9f28ce20d76066be66fcc41aa38f7dc3d DIFF: https://github.com/llvm/llvm-project/commit/8fc6fca9f28ce20d76066be66fcc41aa38f7dc3d.diff L

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-06 Thread Adrian Prantl via cfe-commits
@@ -718,6 +738,29 @@ class MetadataLoader::MetadataLoaderImpl { upgradeCULocals(); } + void cloneLocalTypes() { +for (unsigned I = 0; I < MetadataList.size(); ++I) { adrian-prantl wrote: range-based for? https://github.com/llvm/llvm-project/pull

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-06 Thread Adrian Prantl via cfe-commits
@@ -546,55 +546,75 @@ class MetadataLoader::MetadataLoaderImpl { /// Move local imports from DICompileUnit's 'imports' field to /// DISubprogram's retainedNodes. + /// Move fucntion-local enums from DICompileUnit's enums adrian-prantl wrote: ```suggestio

[clang] Revert "Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585, #111173)" (#111852)" (PR #115159)

2024-12-06 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @zyn0217 Sorry, I've not had time to work on this recently. I have a branch ready which _should_ address the issues encountered thus far, but I haven't fully tested it yet. I should have time after the weekend. https://github.com/llvm/llvm-project/pull/115159

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #119001)

2024-12-06 Thread Adrian Prantl via cfe-commits
@@ -486,6 +486,8 @@ class CGDebugInfo { void EmitFunctionDecl(GlobalDecl GD, SourceLocation Loc, QualType FnType, llvm::Function *Fn = nullptr); + llvm::DIScope *PickCompositeTypeScope(llvm::DIScope *S, StringRef Identifier); adrian

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,96 @@ +//===--- UseSpanFirstLastCheck.cpp - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [CIR] Infrastructure: class CIRGenBuilderTy; cache CIR types (PR #119037)

2024-12-06 Thread David Olsen via cfe-commits
@@ -9,22 +9,32 @@ using namespace clang; using namespace clang::CIRGen; CIRGenTypes::CIRGenTypes(CIRGenModule &genModule) -: cgm(genModule), context(genModule.getASTContext()) {} +: cgm(genModule), context(genModule.getASTContext()), + builder(cgm.getBuilder()) {}

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: @anoopkg6 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand closed https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 030bbc9 - [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (#116642)

2024-12-06 Thread via cfe-commits
Author: anoopkg6 Date: 2024-12-06T23:33:33+01:00 New Revision: 030bbc92a705758f1131fb29cab5be6d6a27dd1f URL: https://github.com/llvm/llvm-project/commit/030bbc92a705758f1131fb29cab5be6d6a27dd1f DIFF: https://github.com/llvm/llvm-project/commit/030bbc92a705758f1131fb29cab5be6d6a27dd1f.diff LOG:

[clang] [llvm] [SystemZ] Add support for __builtin_setjmp and __builtin_longjmp (PR #116642)

2024-12-06 Thread Ulrich Weigand via cfe-commits
https://github.com/uweigand approved this pull request. LGTM now. Thanks for your contribution! https://github.com/llvm/llvm-project/pull/116642 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-12-06 Thread Vladislav Belov via cfe-commits
vbe-sc wrote: @glandium, I've provided the fix in this PR (https://github.com/llvm/llvm-project/pull/119024). https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/117573 >From c599850a039d407061fb6b20d7365184a68c9938 Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Mon, 25 Nov 2024 14:46:55 + Subject: [PATCH] [clang][driver] Use $ prefix with config file options to

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,96 @@ +//===--- UseSpanFirstLastCheck.cpp - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,96 @@ +//===--- UseSpanFirstLastCheck.cpp - clang-tidy -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > wasting effort would not be the problem (it never is; learning is the goal) - > right now i just dont understand the difference, and therefore dont see the > benefit, as far as i see it would introduce more complicated code to still > handle templates.

[clang-tools-extra] [clang-tidy] Add readability-use-span-first-last check (PR #118074)

2024-12-06 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/118074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Merging RISCVToolChain and BareMetal toolchains (PR #118809)

2024-12-06 Thread Petr Hosek via cfe-commits
petrhosek wrote: The `BareMetal` driver currently isn't very idiomatic (compared to other drivers like `Generic_GCC`) and duplicates a lot of the logic that has been already factored out in other drivers. I think this change could be made a lot smaller by doing a clean up first, bringing the `

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 691e55643daa3470ff19b02a55e3e2503d2de0c9 537a1c6529410d2a8411b39f0072ef5c60ee865d --e

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
pawosm-arm wrote: > The subject (linker flags) is no longer accurate. > > It's better to mention that Add $ for Reworded https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
@@ -1243,13 +1268,14 @@ Compilation *Driver::BuildCompilation(ArrayRef ArgList) { // Try parsing configuration file. if (!ContainsError) ContainsError = loadConfigFiles(); - bool HasConfigFile = !ContainsError && (CfgOptions.get() != nullptr); + bool HasConfigFileHead

[clang] [flang] [clang][driver] Use $ prefix with config file options to have them added after all of the command line options (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm edited https://github.com/llvm/llvm-project/pull/117573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [clang][driver] Special care for linker flags in config files (PR #117573)

2024-12-06 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm updated https://github.com/llvm/llvm-project/pull/117573 >From 537a1c6529410d2a8411b39f0072ef5c60ee865d Mon Sep 17 00:00:00 2001 From: Pawel Osmialowski Date: Mon, 25 Nov 2024 14:46:55 + Subject: [PATCH] [clang][driver] Use $ prefix with config file options to

[clang] [APINotes] Add SWIFT_RETURNS_(UN)RETAINED support (PR #118938)

2024-12-06 Thread Saleem Abdulrasool via cfe-commits
@@ -373,6 +373,13 @@ void ReadFunctionInfo(const uint8_t *&Data, FunctionInfo &Info) { endian::readNext(Data); Info.ResultType = std::string(Data, Data + ResultTypeLen); Data += ResultTypeLen; + + unsigned SwiftReturnOwnershipLength = + endian::readNext(Data);

[clang] clang/AMDGPU: Set amdgpu-max-num-workgroups to disable Y/Z by default (PR #119009)

2024-12-06 Thread Matt Arsenault via cfe-commits
arsenm wrote: So this is wrong. It was correct for openmp. Is there a language version we check can where 3d grids were introduced? https://github.com/llvm/llvm-project/pull/119009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

  1   2   3   4   5   >