[clang] [llvm] [InstCombine] Fold `X Pred C2 ? X BOp C1 : C2 BOp C1` to `min/max(X, C2) BOp C1` (PR #116888)

2024-11-28 Thread Yingwei Zheng via cfe-commits
@@ -1898,6 +1882,56 @@ static Instruction *foldSelectICmpEq(SelectInst &SI, ICmpInst *ICI, return nullptr; } +/// Fold `X Pred C2 ? X BOp C1 : C2 BOp C1` to `min/max(X, C2) BOp C1`. +/// This allows for better canonicalization. +static Value *foldSelectWithConstOpToBinOp(IC

[clang] [clang] Format bitfield width diagnostics with thousands-separators (PR #117763)

2024-11-28 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/117763 >From 07b326b59bf9a8e385840a590c5162b9d1914650 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 26 Nov 2024 19:26:32 +0100 Subject: [PAT

[clang-tools-extra] [clang-reorder-fields] Handle macros fields declarations. (PR #118005)

2024-11-28 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/118005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 91285e2 - [clang-reorder-fields] Handle macros fields declarations. (#118005)

2024-11-28 Thread via cfe-commits
Author: Clement Courbet Date: 2024-11-29T08:36:22+01:00 New Revision: 91285e26bf67179a6804c931203c93f07c08183d URL: https://github.com/llvm/llvm-project/commit/91285e26bf67179a6804c931203c93f07c08183d DIFF: https://github.com/llvm/llvm-project/commit/91285e26bf67179a6804c931203c93f07c08183d.dif

[clang] e034c4e - [analyzer] Modernize, improve and promote chroot checker (#117791)

2024-11-28 Thread via cfe-commits
Author: vabridgers Date: 2024-11-29T08:23:08+01:00 New Revision: e034c4ef7b52635bb9cc78b6d3f97a4af5002f92 URL: https://github.com/llvm/llvm-project/commit/e034c4ef7b52635bb9cc78b6d3f97a4af5002f92 DIFF: https://github.com/llvm/llvm-project/commit/e034c4ef7b52635bb9cc78b6d3f97a4af5002f92.diff LO

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/117791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/117791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/117791 >From ed174c8b52880d4f89415eb3a72da13f355438d7 Mon Sep 17 00:00:00 2001 From: einvbri Date: Mon, 25 Nov 2024 10:31:57 +0100 Subject: [PATCH 01/20] [analyzer] Modernize, improve and promote chroot checker This

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-11-28 Thread via cfe-commits
Zentrik wrote: @ldionne Do you mind merging this as I don't have commit rights. Thank you https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [Clang] Don't add top-level const qualifiers to captured function types (PR #118050)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This aligns with the logic in `TreeTransform::RebuildQualifiedType()` where we refrain from adding const qualifiers to function types. Previously, we seemed to overlook this edge case when copy-capturing a v

[clang] [Clang] Don't add top-level const qualifiers to captured function types (PR #118050)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/118050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][Haiku] Improve support (PR #115462)

2024-11-28 Thread Brad Smith via cfe-commits
@@ -2917,7 +2980,8 @@ template int UnwindCursor::step(bool stage2) { // Use unwinding info to modify register set as if function returned. int result; -#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) +#if defined(_LIBUNWIND_CHECK_LINUX_SIGRETURN) ||

[clang] [Clang][AST] Fix PackIndexingExpr AST printout (PR #117947)

2024-11-28 Thread via cfe-commits
github-actions[bot] wrote: @AlexErofeev Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [Clang][AST] Fix PackIndexingExpr AST printout (PR #117947)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/117947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 18760ce - [Clang][AST] Fix PackIndexingExpr AST printout (#117947)

2024-11-28 Thread via cfe-commits
Author: AlexErofeev Date: 2024-11-29T14:04:25+08:00 New Revision: 18760ce0fd811140fe6cb9a01b766d73bb50bf4d URL: https://github.com/llvm/llvm-project/commit/18760ce0fd811140fe6cb9a01b766d73bb50bf4d DIFF: https://github.com/llvm/llvm-project/commit/18760ce0fd811140fe6cb9a01b766d73bb50bf4d.diff L

[clang] [Clang][AST] Fix PackIndexingExpr AST printout (PR #117947)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks https://github.com/llvm/llvm-project/pull/117947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9b5b3ed - [clang-format][doc] Fix formatting, etc.

2024-11-28 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-11-28T22:00:23-08:00 New Revision: 9b5b3edd64e56af02295c0365269177443d4a64d URL: https://github.com/llvm/llvm-project/commit/9b5b3edd64e56af02295c0365269177443d4a64d DIFF: https://github.com/llvm/llvm-project/commit/9b5b3edd64e56af02295c0365269177443d4a64d.diff LOG:

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/118041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks, while I haven’t come up with a better solution to model this situation, I think this looks good for now. Please give @cor3ntin some time before merging, in case there are some better approaches that I might have overlooked. https:

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/117841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Younan Zhang via cfe-commits
@@ -1639,11 +1639,19 @@ SourceLocation CallExpr::getBeginLoc() const { if (const auto *OCE = dyn_cast(this)) return OCE->getBeginLoc(); + if (const auto *Method = + dyn_cast_if_present(getCalleeDecl()); zyn0217 wrote: nit: I presume the `const

[clang] [Clang] Don't add top-level const qualifiers to captured function types (PR #118050)

2024-11-28 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/118050 This aligns with the logic in `TreeTransform::RebuildQualifiedType()` where we refrain from adding const qualifiers to function types. Previously, we seemed to overlook this edge case when copy-capturing a vari

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: (Removed extraneous formatting changes) https://github.com/llvm/llvm-project/pull/117841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/117841 >From 3e5e55fa72c04996dfde1304662e9def6a1ef726 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Fri, 29 Nov 2024 00:08:40 -0500 Subject: [PATCH] [clang] Compute accurate begin location for CallExpr with

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9fde1a498f2dc97a737a3564cb427c6f2a7bfe6c 367a0cc6b3e1e1f67d023c96e06ae438f8f37f37 --e

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Updated to add a clangd test that fails with the previous fix approach. > A more general implementation of `CallExpr::getBeginLoc` that occurs to me > is: return the earlier of the callee's begin loc and the first argument's (if > present) begin loc. I did not do this be

[clang] [clang-tools-extra] [clang] Compute accurate begin location for CallExpr with explicit object parameter (PR #117841)

2024-11-28 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 updated https://github.com/llvm/llvm-project/pull/117841 >From 367a0cc6b3e1e1f67d023c96e06ae438f8f37f37 Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Tue, 26 Nov 2024 22:41:43 -0500 Subject: [PATCH] [clang] Compute accurate begin location for CallExpr with

[clang] 8fcbba8 - [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (#117987)

2024-11-28 Thread via cfe-commits
Author: Sudharsan Veeravalli Date: 2024-11-29T10:26:00+05:30 New Revision: 8fcbba82d6c8038c4a0c5859275523414107b198 URL: https://github.com/llvm/llvm-project/commit/8fcbba82d6c8038c4a0c5859275523414107b198 DIFF: https://github.com/llvm/llvm-project/commit/8fcbba82d6c8038c4a0c5859275523414107b19

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sudharsan Veeravalli via cfe-commits
https://github.com/svs-quic closed https://github.com/llvm/llvm-project/pull/117987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-28 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From daddb9e13db6ca8373dc7298d17aa36a03014aeb Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH 1/9] [a

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-28 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From daddb9e13db6ca8373dc7298d17aa36a03014aeb Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH 1/9] [a

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-28 Thread Anutosh Bhat via cfe-commits
@@ -109,12 +139,12 @@ llvm::Error WasmIncrementalExecutor::runCtors() const { return llvm::Error::success(); } -llvm::Error WasmIncrementalExecutor::cleanUp() const { anutosh491 wrote: I think we would need it. I see a build error otherwise ``` │ │ /home

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-28 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 updated https://github.com/llvm/llvm-project/pull/117978 >From 987f77db9d45dee264c60f434652131438784f6f Mon Sep 17 00:00:00 2001 From: anutosh491 Date: Thu, 28 Nov 2024 14:02:00 +0530 Subject: [PATCH 1/3] Fix generation of wasm binaries while running clang-repl in

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001 From: Leijurv Date: Thu, 28 Nov 2024 21:44:50 -0600 Subject: [PATCH 1/5] BreakBeforeTemplateClose --- clang/docs/ClangFormatStyleOptions.

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/117987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001 From: Leijurv Date: Thu, 28 Nov 2024 21:44:50 -0600 Subject: [PATCH 1/4] BreakBeforeTemplateClose --- clang/docs/ClangFormatStyleOptions.

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-fullbuild-dbg-asan` running on `libc-x86_64-debian-fullbuild` while building `clang,flang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/11289 H

[clang] [analyzer] Handle [[assume(cond)]] as __builtin_assume(cond) (PR #116462)

2024-11-28 Thread Vinay Deshmukh via cfe-commits
https://github.com/vinay-deshmukh updated https://github.com/llvm/llvm-project/pull/116462 >From daddb9e13db6ca8373dc7298d17aa36a03014aeb Mon Sep 17 00:00:00 2001 From: Vinay Deshmukh <32487576+vinay-deshm...@users.noreply.github.com> Date: Fri, 15 Nov 2024 07:37:17 -0500 Subject: [PATCH 1/9] [a

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001 From: Leijurv Date: Thu, 28 Nov 2024 21:44:50 -0600 Subject: [PATCH 1/3] BreakBeforeTemplateClose --- clang/docs/ClangFormatStyleOptions.

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv edited https://github.com/llvm/llvm-project/pull/118046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv updated https://github.com/llvm/llvm-project/pull/118046 >From b9886635c250fe765bf35c6b0e785f55b0749d52 Mon Sep 17 00:00:00 2001 From: Leijurv Date: Thu, 28 Nov 2024 21:44:50 -0600 Subject: [PATCH 1/2] BreakBeforeTemplateClose --- clang/docs/ClangFormatStyleOptions.

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] BreakBeforeTemplateClose (PR #118046)

2024-11-28 Thread via cfe-commits
https://github.com/leijurv created https://github.com/llvm/llvm-project/pull/118046 In clang-format, multiline templates have the `>` on the same line as the last parameter: ```c++ template< typename Foo, typename Bar, typename Baz> void foo() { ``` I would like to add an option t

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread Lu Weining via cfe-commits
https://github.com/SixWeining closed https://github.com/llvm/llvm-project/pull/117108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dab9fa2 - [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (#117108)

2024-11-28 Thread via cfe-commits
Author: Zhaoxin Yang Date: 2024-11-29T11:50:28+08:00 New Revision: dab9fa2d7f3b3092d4ab0c815868ec68a968a31a URL: https://github.com/llvm/llvm-project/commit/dab9fa2d7f3b3092d4ab0c815868ec68a968a31a DIFF: https://github.com/llvm/llvm-project/commit/dab9fa2d7f3b3092d4ab0c815868ec68a968a31a.diff

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. LGTM for the LoongArch bits. https://github.com/llvm/llvm-project/pull/117108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix incorrect inferred lifetime_capture_by attr on STL (PR #118013)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
@@ -37,67 +37,56 @@ struct vector { struct [[gsl::Pointer()]] View {}; std::vector views; // CHECK: ClassTemplateSpecializationDecl {{.*}} struct vector definition implicit_instantiation -// CHECK: TemplateArgument type 'View' -// CHECK-NOT: LifetimeCaptureByAttr

[clang] [clang] Fix incorrect inferred lifetime_capture_by attr on STL (PR #118013)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. Can you also add a lit test for: ```cpp std::vector getVector(); std::set s; s.insert(getVector().begin(), getVector().end()); // FIXME: taking iterator of a temporary container without immediate dereference is almost always wrong. ``` https:

[clang] [clang] Fix incorrect inferred lifetime_capture_by attr on STL (PR #118013)

2024-11-28 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/118013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstCombine] Fold `X Pred C2 ? X BOp C1 : C2 BOp C1` to `min/max(X, C2) BOp C1` (PR #116888)

2024-11-28 Thread via cfe-commits
https://github.com/veera-sivarajan updated https://github.com/llvm/llvm-project/pull/116888 >From 77c2b799a067270ba23dde2cd3b7324c9c26b362 Mon Sep 17 00:00:00 2001 From: Veera Date: Thu, 28 Nov 2024 18:07:30 + Subject: [PATCH 1/2] Add Test --- .../InstCombine/canonicalize-const-to-bop.ll

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sudharsan Veeravalli via cfe-commits
@@ -771,9 +772,11 @@ Error RISCVISAInfo::checkDependency() { return getIncompatibleError("xwchc", "zcb"); } - if (Exts.count("xqcicsr") != 0 && (XLen != 32)) { -return getError("'xqcicsr' is only supported for 'rv32'"); - } + for (auto Ext : XqciExts) +if (E

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Sudharsan Veeravalli via cfe-commits
https://github.com/svs-quic updated https://github.com/llvm/llvm-project/pull/117987 >From 3d7772894ae10d79570899dbdfb34fd4877a37e5 Mon Sep 17 00:00:00 2001 From: Sudharsan Veeravalli Date: Thu, 28 Nov 2024 15:11:57 +0530 Subject: [PATCH 1/3] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store)

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis approved this pull request. https://github.com/llvm/llvm-project/pull/118003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread via cfe-commits
vabridgers wrote: Hi @steakhal , no problem. Thanks for the proactive help! https://github.com/llvm/llvm-project/pull/117791 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread Zhaoxin Yang via cfe-commits
https://github.com/ylzsx updated https://github.com/llvm/llvm-project/pull/117108 >From 32e04b6538486006c98c6b805b1057110c3a2c1a Mon Sep 17 00:00:00 2001 From: yangzhaoxin Date: Wed, 20 Nov 2024 17:30:43 +0800 Subject: [PATCH 1/5] [Flang] LoongArch64 support for BIND(C) derived types. This pat

[clang] [flang] [Flang] LoongArch64 support for BIND(C) derived types in mabi=lp64d. (PR #117108)

2024-11-28 Thread Zhaoxin Yang via cfe-commits
https://github.com/ylzsx updated https://github.com/llvm/llvm-project/pull/117108 >From 32e04b6538486006c98c6b805b1057110c3a2c1a Mon Sep 17 00:00:00 2001 From: yangzhaoxin Date: Wed, 20 Nov 2024 17:30:43 +0800 Subject: [PATCH 1/5] [Flang] LoongArch64 support for BIND(C) derived types. This pat

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #113659 --- Full diff: https://github.com/llvm/llvm-project/pull/118041.diff 3 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1) - (modified) clang/lib/Sema/SemaTemplateDeduction.cpp

[clang] [Clang] fix crash due to incorrect argument position in merging deduced template arguments (PR #118041)

2024-11-28 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/118041 Fixes #113659 >From 59fa1de4e6638f1c8bba39e2e55c43cb3991fc3c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 29 Nov 2024 02:54:53 +0200 Subject: [PATCH] [Clang] fix crash due to incorrect argument pos

[clang] [Clang][AST] Fix MS Mangle concept uneval context template instantiation crash (PR #117845)

2024-11-28 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/117845 >From 58a26201c8582fc573aa681867d57c236e799acb Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Tue, 26 Nov 2024 19:45:10 -0800 Subject: [PATCH 1/2] Fix MS Mangle concept uneval context template instantiation cra

[clang-tools-extra] [clangd] Support symbolTags for document symbol (PR #113669)

2024-11-28 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > I tried to build clangd from [my github > action](https://github.com/chouzz/clangd/actions/workflows/autobuild.yaml), > but I failed, maybe @HighCommander4 could help point out how to build clangd > via github actions with specify branch? What is it that you're trying

[clang-tools-extra] [clang-reorder-fields] Handle macros fields declarations. (PR #118005)

2024-11-28 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov approved this pull request. LG https://github.com/llvm/llvm-project/pull/118005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AST] Fix PackIndexingExpr AST printout (PR #117947)

2024-11-28 Thread via cfe-commits
https://github.com/AlexErofeev updated https://github.com/llvm/llvm-project/pull/117947 >From b3f7e8bda1bd38ef9bf5794ed4a6cece2ef77621 Mon Sep 17 00:00:00 2001 From: Aleksandr Erofeev Date: Thu, 28 Nov 2024 00:19:06 + Subject: [PATCH 1/2] Fix PackIndexingExpr AST printout --- clang/lib/AS

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: For future reference, `modernize` is typically related to new features of new C++ standards, so this check wouldn't quite fit there. Great that you found an existing check that suits your needs! https://github.com/llvm/llvm-project/pull/118033 _

[clang] [Clang][AArch64]Refactor typespec handling in SveEmitter.cpp (PR #117717)

2024-11-28 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm edited https://github.com/llvm/llvm-project/pull/117717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64]Refactor typespec handling in SveEmitter.cpp (PR #117717)

2024-11-28 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm commented: One minor comment, but otherwise looks good! https://github.com/llvm/llvm-project/pull/117717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [Clang][AArch64]Refactor typespec handling in SveEmitter.cpp (PR #117717)

2024-11-28 Thread Sander de Smalen via cfe-commits
@@ -50,20 +50,30 @@ using TypeSpec = std::string; namespace { class SVEType { - bool Float, Signed, Immediate, Void, Constant, Pointer, BFloat, MFloat; - bool DefaultType, IsScalable, Predicate, PredicatePattern, PrefetchOp, - Svcount; + + enum TypeKind { +Void, +

[clang] [compiler-rt] [libcxx] [llvm] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice (PR #112978)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/112978 >From 3db70453e07f1378ed4d07023dc2a6cf2541b935 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Fri, 13 May 2022 09:26:01 -0400 Subject: [PATCH 1/4] [libc++] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka closed https://github.com/llvm/llvm-project/pull/118033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Helmut Januschka via cfe-commits
hjanuschka wrote: ohhh TIL! lets close this PR `readability-redundant-casting` with: `IgnoreTypeAliases` does what i was chasing! /close https://github.com/llvm/llvm-project/pull/118033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [llvm] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clang to OMPIRBuilder (PR #110001)

2024-11-28 Thread Akash Banerjee via cfe-commits
https://github.com/TIFitis updated https://github.com/llvm/llvm-project/pull/110001 >From 17ae5d768dc5ee113c4e859273706cb8e11f46e9 Mon Sep 17 00:00:00 2001 From: Akash Banerjee Date: Wed, 25 Sep 2024 16:06:36 +0100 Subject: [PATCH 1/3] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clan

[clang] [llvm] [OpenMP][Clang] Migrate OpenMP UserDefinedMapper from Clang to OMPIRBuilder (PR #110001)

2024-11-28 Thread Akash Banerjee via cfe-commits
@@ -9041,257 +9041,65 @@ void CGOpenMPRuntime::emitUserDefinedMapper(const OMPDeclareMapperDecl *D, return; ASTContext &C = CGM.getContext(); QualType Ty = D->getType(); - QualType PtrTy = C.getPointerType(Ty).withRestrict(); - QualType Int64Ty = C.getIntTypeForBitwi

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2024-11-28 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: >> Without vector support, it might make sense to have load/store pseudos with >> an extra GPR def operand, so that these loads/stores can be expanded as a >> PostRA pseudo. Then it would only need handling in one place, but OTOH >> having a second explicit def operand is als

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-11-28 Thread Louis Dionne via cfe-commits
ldionne wrote: Closing as stale, please reopen if you still want to pursue. https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxxabi] [libunwind] [libcxxabi][libunwind] Support for using LLVM libc (PR #101688)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/101688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

2024-11-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/6] Add support for '-Warray-compare' compiler flag --- cl

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Oliver Stöneberg via cfe-commits
firewave wrote: How is this different from `readability-redundant-casting`? https://github.com/llvm/llvm-project/pull/118033 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

2024-11-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/118031 >From 9451a1e4f5db18d579b5f7eb206482708c9adc70 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 26 Nov 2024 22:28:16 +0100 Subject: [PATCH 1/5] Add support for '-Warray-compare' compiler flag --- cl

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 866755f8da588ec2efbcac60679b9d9f5c4636a9 5ee115e7cd83fe5a59c0284e91893b71df79be0c --e

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Helmut Januschka (hjanuschka) Changes > Add a new check that detects and removes redundant static_cast operations where the source and target types are identical. This helps clean up code after type system changes, improving r

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Helmut Januschka (hjanuschka) Changes > Add a new check that detects and removes redundant static_cast operations where the source and target types are identical. This helps clean up code after type system changes, improving readabil

[clang-tools-extra] [clang-tidy] Add modernize-cleanup-static-cast check (PR #118033)

2024-11-28 Thread Helmut Januschka via cfe-commits
https://github.com/hjanuschka created https://github.com/llvm/llvm-project/pull/118033 > Add a new check that detects and removes redundant static_cast operations > where the source and target types are identical. This helps clean up code > after type system changes, improving readability and

[clang] [Clang] [NFC] Refactor more AST visitors (PR #116823)

2024-11-28 Thread via cfe-commits
@@ -266,7 +265,7 @@ class RenameLocFinder : public RecursiveASTVisitor { return true; } - bool VisitDeclRefExpr(const DeclRefExpr *Expr) { Sirraide wrote: > How hard do you think it would be to introduce something like > `MutableDynamicRecursiveASTVi

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Currently, we support `-wdeprecated-array-compare` for C++20 or above and don't report any warning for older versions, this PR supports `-Warray-compare` for older versions and for GCC compatibility. Fix

[clang] [Clang] Add '-Warray-compare' flag for C++ below version 20 (PR #118031)

2024-11-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/118031 Currently, we support `-wdeprecated-array-compare` for C++20 or above and don't report any warning for older versions, this PR supports `-Warray-compare` for older versions and for GCC compatibility. Fixe

[clang] [clang] Format bitfield width diagnostics with thousands-separators (PR #117763)

2024-11-28 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/Sirraide commented: I’m bad at naming, but maybe `%sep` would work; or maybe `%separated` or `%separators`, but those are a bit long. https://github.com/llvm/llvm-project/pull/117763 __

[clang] [clang][ARM] disable frame pointers by default for bare metal ARM targets (PR #117140)

2024-11-28 Thread Jon Roelofs via cfe-commits
@@ -151,6 +152,9 @@ static bool useFramePointerForTargetByDefault(const llvm::opt::ArgList &Args, } } + if (toolchains::isARMBareMetal(Triple)) jroelofs wrote: good idea re: `isArmEABIBareMetal` https://github.com/llvm/llvm-project/pull/117140 __

[clang] [libcxx] [libcxx] Support for using timespec_get (PR #117362)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. The libc++ part LGTM. I don't really understand the `Fuchsia-stage2.cmake` changes but I'm not sure I need to. However, please rebase this on top of `main` and make sure that the CI is green before you merge. https://github.com/llvm/llvm-

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread Vladislav Belov via cfe-commits
@@ -1178,17 +1178,61 @@ namespace cwg590 { // cwg590: yes template typename A::B::C A::B::C::f(A::B::C) {} } -namespace cwg591 { // cwg591: no +namespace cwg591 { // cwg591: yes vbe-sc wrote: Done https://github.com/llvm/llvm-project/pull/118003 __

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread Vladislav Belov via cfe-commits
@@ -3599,7 +3599,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/591.html";>591 CD4 When a dependent base class is the current instantiation -No +Yes vbe-sc wrote: Done https://github.com/llvm/llvm-proj

[clang] Reapply "[clang] Fix name lookup for dependent bases" (PR #118003)

2024-11-28 Thread Vladislav Belov via cfe-commits
https://github.com/vbe-sc updated https://github.com/llvm/llvm-project/pull/118003 >From 98583ff617a4d527041c683e98904ed063467c50 Mon Sep 17 00:00:00 2001 From: vb-sc Date: Tue, 5 Nov 2024 15:46:57 +0300 Subject: [PATCH] [clang] Fix name lookup for dependent bases --- clang/docs/ReleaseNotes.

[libunwind] [libunwind] Make sure `__STDC_FORMAT_MACROS` is defined to ensure `PRId64` is available (PR #117491)

2024-11-28 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/117491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcisls (Scaled Load Store) extension (PR #117987)

2024-11-28 Thread Craig Topper via cfe-commits
@@ -771,9 +772,11 @@ Error RISCVISAInfo::checkDependency() { return getIncompatibleError("xwchc", "zcb"); } - if (Exts.count("xqcicsr") != 0 && (XLen != 32)) { -return getError("'xqcicsr' is only supported for 'rv32'"); - } + for (auto Ext : XqciExts) +if (E

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread Balazs Benics via cfe-commits
steakhal wrote: Hi Vince, I figured it's easier if I just push to your branch with my recommendations. Let me know if you like it. Challenge it if not. https://github.com/llvm/llvm-project/pull/117791 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

2024-11-28 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/117791 >From ed174c8b52880d4f89415eb3a72da13f355438d7 Mon Sep 17 00:00:00 2001 From: einvbri Date: Mon, 25 Nov 2024 10:31:57 +0100 Subject: [PATCH 01/16] [analyzer] Modernize, improve and promote chroot checker This

[clang] [llvm] [PowerPC] Update data layout aligment of i128 to 16 (PR #118004)

2024-11-28 Thread Brad Smith via cfe-commits
brad0 wrote: cc @nikic https://github.com/llvm/llvm-project/pull/118004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][x86] Add initial constexpr support for VPOPCNTDQ intrinsics (PR #118017)

2024-11-28 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `libc-x86_64-debian-fullbuild-dbg-asan` running on `libc-x86_64-debian-fullbuild` while building `clang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/11280 Here is

[clang] [clang][x86] Add initial constexpr support for VPOPCNTDQ intrinsics (PR #118017)

2024-11-28 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon closed https://github.com/llvm/llvm-project/pull/118017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-11-28 Thread Alex Voicu via cfe-commits
@@ -91,6 +97,88 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] [llvm] [AArch64] Implement intrinsics for SME FP8 F1CVT/F2CVT and BF1CVT/BF2CVT (PR #118027)

2024-11-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: None (SpencerAbson) Changes This patch implements the following intrinsics: 8-bit floating-point convert to half-precision or BFloat16 (in-order). ``` c // Variant is also available for: _bf16[_mf8]_x2 svfloat16x2_t svcvt1_f1

  1   2   3   4   >