[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/106683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [modules] Avoid building duplicated modules at the same time (PR #114365)

2024-10-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ccdfd1a182fc718997f21583aea95d321f03c967 ed160e18b941bca16a87f0ea400aca2406967ae1 --e

[clang-tools-extra] [clangd] [modules] Avoid building duplicated modules at the same time (PR #114365)

2024-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: Chuanqi Xu (ChuanqiXu9) Changes Following of https://github.com/llvm/llvm-project/pull/106683 In that, if we open multiple tabs importing the same module, we're going to build the same in the corresponding threads. This is not good. This

[clang-tools-extra] [clangd] [modules] Avoid building duplicated modules at the same time (PR #114365)

2024-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Chuanqi Xu (ChuanqiXu9) Changes Following of https://github.com/llvm/llvm-project/pull/106683 In that, if we open multiple tabs importing the same module, we're going to build the same in the corresponding threads. This is not

[clang-tools-extra] [clangd] [modules] Avoid building duplicated modules at the same time (PR #114365)

2024-10-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/114365 Following of https://github.com/llvm/llvm-project/pull/106683 In that, if we open multiple tabs importing the same module, we're going to build the same in the corresponding threads. This is not good. This p

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-30 Thread Chuanqi Xu via cfe-commits
@@ -338,17 +460,129 @@ ModulesBuilder::buildPrerequisiteModulesFor(PathRef File, return std::move(RequiredModules); } -bool StandalonePrerequisiteModules::canReuse( +ReusableModulesBuilder::ModuleBuildingSharedOwner +ReusableModulesBuilder::getOrCreateModuleBuildingOwner(Str

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/106683 >From 15aa6af1f5d22e4b837e8e2fd49469310ffbe7f1 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 30 Aug 2024 15:11:07 +0800 Subject: [PATCH 1/2] [clangd] [Modules] Support Reusable Modules Builder --- cl

[clang] [llvm] [InstrPGO] Avoid using global variable to fix potential data race (PR #114364)

2024-10-30 Thread Lei Wang via cfe-commits
https://github.com/wlei-llvm created https://github.com/llvm/llvm-project/pull/114364 In https://github.com/llvm/llvm-project/pull/109837, it sets a global variable(`PGOInstrumentColdFunctionOnly`) in PassBuilderPipelines.cpp which introduced a data race detected by TSan. To fix this, I decoup

[clang] [llvm] [HLSL] Add `Increment`/`DecrementCounter` methods to structured buffers (PR #114148)

2024-10-30 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/114148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-30 Thread Aiden Grossman via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] [clang-format][CMake] Generate formatting options docs during build (PR #113739)

2024-10-30 Thread Aiden Grossman via cfe-commits
@@ -143,8 +143,17 @@ if (LLVM_ENABLE_SPHINX) gen_rst_file_from_td(DiagnosticsReference.rst -gen-diag-docs ../include/clang/Basic/Diagnostic.td "${docs_targets}") gen_rst_file_from_td(ClangCommandLineReference.rst -gen-opt-docs ../include/clang/Driver/ClangOptionDocs.td

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
JustinStitt wrote: @vitalybuka > Is "Test documentation build" error related? I am noticing this documentation build failing in other [un-related Clang patchsets](https://github.com/llvm/llvm-project/actions/runs/11598884769/job/32295763452?pr=114281) (related to `ClangFormattedStatus`?). I d

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
JustinStitt wrote: @melver > Oh nice. If you have that almost done, why do you still want the filterlist? > For the Linux kernel usecase, wouldn't the attribute be preferrable? My > intuition tells me that maintaining a filterlist detached from the code will > cause headaches, esp. during ref

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Driver] Remove ignored Flag form of -fauto-profile/-fprofile-sample-use (PR #113528)

2024-10-30 Thread Fangrui Song via cfe-commits
@@ -1729,8 +1729,6 @@ defm gnu_inline_asm : BoolFOption<"gnu-inline-asm", "Disable GNU style inline asm">, PosFlag>; -def fprofile_sample_use : Flag<["-"], "fprofile-sample-use">, Group, -Visibility<[ClangOption, CLOption]>; def fno_profile_sample_use : Flag<[

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-30 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/113845 >From 1524ca532c9c1ef015c162360d4e4688296bbc0d Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 27 Oct 2024 16:30:48 -0700 Subject: [PATCH 1/6] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functio

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -1,23 +0,0 @@ -// Verify ubsan vptr does not check down-casts on ignorelisted types. -// RUN: echo "type:_ZTI3Foo" > %t-type.ignorelist -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=vptr -fsanitize-recover=vptr -emit-llvm %s -o - | FileCheck %s --check-prefix=DEFAULT

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -0,0 +1,105 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t + +// Verify ubsan doesn't emit checks for ignorelisted types +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow,unsigned-integer-overflow -fsanitize-ignorelist=%t/int.ignorelist -emit-ll

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -15,8 +15,9 @@ file at compile-time. Goal and usage == -Users of sanitizer tools, such as :doc:`AddressSanitizer`, :doc:`ThreadSanitizer` -or :doc:`MemorySanitizer` may want to disable or alter some checks for +Users of sanitizer tools, such as :doc:`AddressSan

[clang] [clang-format] Add ConfigFile option (PR #113864)

2024-10-30 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/113864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add ConfigFile option (PR #113864)

2024-10-30 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/113864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add -ConfigFile option (PR #113864)

2024-10-30 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/113864 >From 85f78a4879a37fb367dccd5299b35d1c75c2b46f Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 27 Oct 2024 22:22:11 -0700 Subject: [PATCH] [clang-format] Add ConfigFile option Closes #107808. --- clang/docs/

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-30 Thread Chuanqi Xu via cfe-commits
@@ -85,19 +85,20 @@ class PrerequisiteModules { /// different versions and different source files. class ModulesBuilder { ChuanqiXu9 wrote: Done https://github.com/llvm/llvm-project/pull/106683 ___ cfe-commits mailin

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-30 Thread Chuanqi Xu via cfe-commits
@@ -85,19 +85,20 @@ class PrerequisiteModules { /// different versions and different source files. class ModulesBuilder { public: - ModulesBuilder(const GlobalCompilationDatabase &CDB) : CDB(CDB) {} + ModulesBuilder() = default; + virtual ~ModulesBuilder() = default; Mo

[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

2024-10-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/106683 >From 15aa6af1f5d22e4b837e8e2fd49469310ffbe7f1 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 30 Aug 2024 15:11:07 +0800 Subject: [PATCH] [clangd] [Modules] Support Reusable Modules Builder --- clang-

[clang] 9778808 - [ObjC] Insert method parameters in scope as they are parsed (#113745)

2024-10-30 Thread via cfe-commits
Author: apple-fcloutier Date: 2024-10-30T20:34:38-07:00 New Revision: 97788089988a2ace63d717cadbcfe3443f380f9c URL: https://github.com/llvm/llvm-project/commit/97788089988a2ace63d717cadbcfe3443f380f9c DIFF: https://github.com/llvm/llvm-project/commit/97788089988a2ace63d717cadbcfe3443f380f9c.dif

[clang] [ObjC] Insert method parameters in scope as they are parsed (PR #113745)

2024-10-30 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/113745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang-tools-extra] [clangd] Support symbolTags for document symbol (PR #113669)

2024-10-30 Thread via cfe-commits
chouzz wrote: > I thought about the _Constant_ tag. In Java for example, there is no `const` > keyword, instead the `final` keyword is used for variables to declare them as > read-only. The keyword `final` means something else for methods (they cannot > be overridden). The keywords and their m

[clang] [clang][Driver] Allow -fuse-lld=lld-link when lto is enabled on *windows-msvc targets (PR #113966)

2024-10-30 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,15 @@ +// REQUIRES: aarch64-registered-target +// +// RUN: echo "int main() {} " > %t.c MaskRay wrote: Just use `%s` and avoid this temporary .c file. https://github.com/llvm/llvm-project/pull/113966 ___ cfe

[clang] [clang][Driver] Allow -fuse-lld=lld-link when lto is enabled on *windows-msvc targets (PR #113966)

2024-10-30 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,15 @@ +// REQUIRES: aarch64-registered-target MaskRay wrote: "woa-" is not a clear filename prefix. Suggest `windows-lto.c` In general, only -### should be used in driver tests to suppress action running. We can then drop `REQUIRES: `. https://git

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt edited https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add -ConfigFile option (PR #113864)

2024-10-30 Thread Owen Pan via cfe-commits
@@ -2102,6 +2108,17 @@ std::error_code parseConfiguration(llvm::MemoryBufferRef Config, StyleSet.Add(std::move(DefaultStyle)); } *Style = *StyleSet.Get(Language); + std::string ConfigFile; + if (!Style->ConfigFile.empty()) { owenca wrote: ```suggest

[clang] [llvm] [X86][AMX] Support AMX-FP8 (PR #113850)

2024-10-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang,llvm` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/7800 Here is

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Justin Stitt via cfe-commits
@@ -197,6 +197,18 @@ static bool CanElideOverflowCheck(const ASTContext &Ctx, const BinOpInfo &Op) { if (!Op.mayHaveIntegerOverflow()) return true; + if (Op.Ty->isSignedIntegerType() && JustinStitt wrote: I'll add a comment, good idea :) https://gith

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka deleted https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,713 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/114331 >From 466b99a4d2f53daeecb4d0cfeb3ed5a05c2af03e Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Oct 2024 16:51:36 -0700 Subject: [PATCH 1/2] [NFC] Remove referenced to deleted `ClangFormattedStatus` fil

[clang] 8127162 - [X86][AMX] Support AMX-FP8 (#113850)

2024-10-30 Thread via cfe-commits
Author: Feng Zou Date: 2024-10-31T10:14:25+08:00 New Revision: 8127162427c5f8c28d6292e1d4b4ce8a00b2d5a2 URL: https://github.com/llvm/llvm-project/commit/8127162427c5f8c28d6292e1d4b4ce8a00b2d5a2 DIFF: https://github.com/llvm/llvm-project/commit/8127162427c5f8c28d6292e1d4b4ce8a00b2d5a2.diff LOG:

[clang-tools-extra] Add bugprone-sprintf-overlap (PR #114244)

2024-10-30 Thread Chris Cotter via cfe-commits
https://github.com/ccotter updated https://github.com/llvm/llvm-project/pull/114244 >From fd914cc82688b122654d2d7ada72007541b197c0 Mon Sep 17 00:00:00 2001 From: Chris Cotter Date: Wed, 30 Oct 2024 10:54:49 -0400 Subject: [PATCH] Add bugprone-sprintf-overlap --- .../bugprone/BugproneTidyModul

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/114331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AMX] Support AMX-FP8 (PR #113850)

2024-10-30 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/113850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Distinguish expanding-packs-in-place cases for SubstTemplateTypeParmTypes (PR #114220)

2024-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Younan Zhang (zyn0217) Changes In 50e5411e4, we preserved the pack substitution index within SubstTemplateTypeParmType nodes and performed in-place expansions of packs such that type constraints on a lam

[clang] [Clang] Distinguish expanding-packs-in-place cases for SubstTemplateTypeParmTypes (PR #114220)

2024-10-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 ready_for_review https://github.com/llvm/llvm-project/pull/114220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Distinguish expanding-packs-in-place cases for SubstTemplateTypeParmTypes (PR #114220)

2024-10-30 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/114220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] [Modules] Use ASTReader directly in IsModuleFileUpToDate (PR #113879)

2024-10-30 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Thanks : ) https://github.com/llvm/llvm-project/pull/113879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-30 Thread Ronan Keryell via cfe-commits
@@ -455,6 +455,174 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute facilitates the generation of a

[clang-tools-extra] e9b7fe8 - [clangd] [Modules] Use ASTReader directly in IsModuleFileUpToDate (#113879)

2024-10-30 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-10-31T09:32:01+08:00 New Revision: e9b7fe8e5a5819cb632d02529712535ca1b83f02 URL: https://github.com/llvm/llvm-project/commit/e9b7fe8e5a5819cb632d02529712535ca1b83f02 DIFF: https://github.com/llvm/llvm-project/commit/e9b7fe8e5a5819cb632d02529712535ca1b83f02.diff LO

[clang-tools-extra] [clangd] [Modules] Use ASTReader directly in IsModuleFileUpToDate (PR #113879)

2024-10-30 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/113879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
@@ -831,6 +831,28 @@ ASTContext::getCanonicalTemplateTemplateParmDecl( return CanonTTP; } +/// Check if a type can have its sanitizer instrumentation elided. +/// Determine this by its presence in a SCL alongside its specified categories. +/// For example: +/// ignorelist.tx

[clang] [libcxx] [libcxxabi] [Fuchsia][cmake] Allow using FatLTO when building runtimes (PR #112277)

2024-10-30 Thread Paul Kirth via cfe-commits
ilovepi wrote: I'm now getting an error w/ ToT. Not sure why I'm running into it now, but it happens with any clean build, so its deterministic. **The Relevant bits:** ``` console ld.lld: error: input file '/usr/local/google/home/paulkirth/fuchsia-idk/arch/arm64/sysroot/lib/libzircon.so' adde

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-30 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/113845 >From 1524ca532c9c1ef015c162360d4e4688296bbc0d Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 27 Oct 2024 16:30:48 -0700 Subject: [PATCH 1/5] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functio

[clang] dafb90d - [NFC] Call base class method in DarwinAArch64TargetInfo::getOSDefines (#114241)

2024-10-30 Thread via cfe-commits
Author: Akira Hatanaka Date: 2024-10-30T18:00:59-07:00 New Revision: dafb90dedcda1ad7b94b0bcdbbe7478f7d0f31f6 URL: https://github.com/llvm/llvm-project/commit/dafb90dedcda1ad7b94b0bcdbbe7478f7d0f31f6 DIFF: https://github.com/llvm/llvm-project/commit/dafb90dedcda1ad7b94b0bcdbbe7478f7d0f31f6.diff

[clang] [NFC] Call base class method in DarwinAArch64TargetInfo::getOSDefines (PR #114241)

2024-10-30 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/114241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang/AST] Make it possible to use SwiftAttr in type context (PR #108631)

2024-10-30 Thread Pavel Yaskevich via cfe-commits
xedin wrote: @erichkeane CI are green, could you please merge since I don't have permissions?... https://github.com/llvm/llvm-project/pull/108631 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-30 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,713 @@ +//===-- Mustache.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] [llvm] add support for mustache templating language (PR #105893)

2024-10-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi commented: I think this is almost there. It's probably about ready after you address the remaining comments. https://github.com/llvm/llvm-project/pull/105893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [clang][CodeGen] Emit improved memory effects and return status for AsmStmt (PR #110510)

2024-10-30 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > I could not find back if you are allowed to use an inline assembly memory > operand for such an instruction (*), but it certainly seems a real risk that > users are doing this. Tried some quick tests; in the following, gcc doesn't eliminate the load: ``` int f(int *rr)

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread Rahul Joshi via cfe-commits
jurahul wrote: > LGTM - thanks Thanks. Will merge once checks are green https://github.com/llvm/llvm-project/pull/114331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][fatlto] Drop any CFI related instrumentation after emitting bitcode (PR #112788)

2024-10-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/112788 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] add IsLineVectorLayoutCompatible type trait (PR #113730)

2024-10-30 Thread Joshua Batista via cfe-commits
@@ -2163,6 +2163,51 @@ static void BuildFlattenedTypeList(QualType BaseTy, } } +bool SemaHLSL::IsLineVectorLayoutCompatibleType(clang::QualType QT) { + if (QT.isNull()) +return false; + + llvm::SmallVector QTTypes; + BuildFlattenedTypeList(QT, QTTypes); --

[clang] [HLSL] add IsLineVectorLayoutCompatible type trait (PR #113730)

2024-10-30 Thread Helena Kotas via cfe-commits
hekota wrote: > If you are going to store `isHLSLLineVectorLayoutCompatibleType` on a > declaration you need to modify addMember to analyze newly added members. Then > move the IsLineVectorLayoutCompatibleType implementation from SemaHLSL to > Type and use the bit on the record type decl inste

[clang] [NFC] Remove referenced to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/114331 None >From 466b99a4d2f53daeecb4d0cfeb3ed5a05c2af03e Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Oct 2024 16:51:36 -0700 Subject: [PATCH] [NFC] Remove referenced to deleted `ClangFormattedStatus` f

[clang] [llvm] [llvm] Allow always dropping all llvm.type.test sequences (PR #112787)

2024-10-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/112787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/114331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] add IsLineVectorLayoutCompatible type trait (PR #113730)

2024-10-30 Thread Helena Kotas via cfe-commits
@@ -2163,6 +2163,51 @@ static void BuildFlattenedTypeList(QualType BaseTy, } } +bool SemaHLSL::IsLineVectorLayoutCompatibleType(clang::QualType QT) { + if (QT.isNull()) +return false; + + llvm::SmallVector QTTypes; + BuildFlattenedTypeList(QT, QTTypes); --

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/114331.diff 1 Files Affected: - (modified) clang/docs/ClangFormat.rst (-4) ``diff diff --git a/clang/docs/ClangFormat.rst b/clang/docs/Cl

[clang] [clang][modules] De-duplicate some logic in `HeaderFileInfoTrait` (PR #114330)

2024-10-30 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/114330 None >From c11ea47908e93fedf83021377f904d296802e627 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Wed, 30 Oct 2024 16:52:42 -0700 Subject: [PATCH] [clang][modules] De-duplicate some logic in `HeaderFil

[clang] [NFC] Remove references to deleted `ClangFormattedStatus` file (PR #114331)

2024-10-30 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/114331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang/AMDGPU] Zero sized arrays not allowed in HIP device code. (PR #113470)

2024-10-30 Thread Eli Friedman via cfe-commits
@@ -8714,6 +8714,21 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) { } } + // zero sized static arrays are not allowed in HIP device functions + if (LangOpts.CUDAIsDevice && LangOpts.HIP) { +if (FunctionDecl *FD = getCurFunctionDecl(); +FD && +

[clang] [Clang/AMDGPU] Zero sized arrays not allowed in HIP device code. (PR #113470)

2024-10-30 Thread Eli Friedman via cfe-commits
@@ -8714,6 +8714,21 @@ void Sema::CheckVariableDeclarationType(VarDecl *NewVD) { } } + // zero sized static arrays are not allowed in HIP device functions + if (LangOpts.CUDAIsDevice && LangOpts.HIP) { +if (FunctionDecl *FD = getCurFunctionDecl(); +FD && +

[clang] b01e2a8 - [llvm] Allow always dropping all llvm.type.test sequences

2024-10-30 Thread via cfe-commits
Author: Paul Kirth Date: 2024-10-30T16:56:30-07:00 New Revision: b01e2a8b5620466c3b80cc6f049efbc90b9d103a URL: https://github.com/llvm/llvm-project/commit/b01e2a8b5620466c3b80cc6f049efbc90b9d103a DIFF: https://github.com/llvm/llvm-project/commit/b01e2a8b5620466c3b80cc6f049efbc90b9d103a.diff LO

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

2024-10-30 Thread Rahul Joshi via cfe-commits
jurahul wrote: Started https://github.com/llvm/llvm-project/pull/114331 https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] De-duplicate some logic in `HeaderFileInfoTrait` (PR #114330)

2024-10-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Jan Svoboda (jansvoboda11) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/114330.diff 2 Files Affected: - (modified) clang/lib/Serialization/ASTReader.cpp (+11-18) - (modified) clang/lib/Serialization/ASTRead

[clang] [clang][modules] Avoid allocations when reading blob paths (PR #113984)

2024-10-30 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/113984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

2024-10-30 Thread Rahul Joshi via cfe-commits
jurahul wrote: Let me delete those references. The ones in generated_formatted_state.py are fine https://github.com/llvm/llvm-project/pull/109220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang][CodeGen][OpenCL] Fix `alloca` handling & `sret`when compiling for (PR #113930)

2024-10-30 Thread Matt Arsenault via cfe-commits
@@ -108,11 +108,15 @@ RawAddress CodeGenFunction::CreateTempAlloca(llvm::Type *Ty, CharUnits Align, if (AllocaAddr) *AllocaAddr = Alloca; llvm::Value *V = Alloca.getPointer(); + assert((!getLangOpts().OpenCL || + CGM.getTarget().getTargetAddressSpace(getASTAl

[clang] [NFC] Delete unused clang-formatted-file.txt/ClangFormattedStatus.rst files (PR #109220)

2024-10-30 Thread Chris Apple via cfe-commits
cjappl wrote: FYI @jurahul - having a build failure when I try to build docs after this change. I think a few little bits were missed. ``` Warning, treated as error: ./llvm-project/build/tools/clang/docs/ClangFormattedStatus.rst:document isn't included in any toctree ``` https://github.com/ll

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-30 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud approved this pull request. I have a couple of small nits that I left as comments. Otherwise LGTM! Also, thank you for writing detailed explanations in your PR descriptions, they help me catch up to your code quickly. https://github.com/llvm/llvm-project/pull/113845

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-30 Thread Rashmi Mudduluru via cfe-commits
https://github.com/t-rasmud edited https://github.com/llvm/llvm-project/pull/113845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-30 Thread Rashmi Mudduluru via cfe-commits
@@ -45,8 +49,62 @@ class UncountedLambdaCapturesChecker bool shouldVisitTemplateInstantiations() const { return true; } bool shouldVisitImplicitCode() const { return false; } - bool VisitLambdaExpr(LambdaExpr *L) { -Checker->visitLambdaExpr(L); +

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore trivial functions and [[clang::noescape]]. (PR #113845)

2024-10-30 Thread Rashmi Mudduluru via cfe-commits
@@ -45,8 +49,62 @@ class UncountedLambdaCapturesChecker bool shouldVisitTemplateInstantiations() const { return true; } bool shouldVisitImplicitCode() const { return false; } - bool VisitLambdaExpr(LambdaExpr *L) { -Checker->visitLambdaExpr(L); +

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. Actually LGTM, Request for doc and test is quite straightforward. No need to block on me. https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka requested changes to this pull request. Please don't forget to "re-request" after update, fell free to ping me in chat as well. https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lis

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
@@ -48,6 +49,59 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang] 6ffefbb - [LinkerWrapper] Remove handling of special bitcode flags (#114298)

2024-10-30 Thread via cfe-commits
Author: Joseph Huber Date: 2024-10-30T16:02:34-07:00 New Revision: 6ffefbbc2593d82117924c5c18d2a4ed7689ea3f URL: https://github.com/llvm/llvm-project/commit/6ffefbbc2593d82117924c5c18d2a4ed7689ea3f DIFF: https://github.com/llvm/llvm-project/commit/6ffefbbc2593d82117924c5c18d2a4ed7689ea3f.diff

[clang] [LinkerWrapper] Remove handling of special bitcode flags (PR #114298)

2024-10-30 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/114298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
@@ -48,6 +49,59 @@ Example $ clang -fsanitize=address -fsanitize-ignorelist=ignorelist.txt foo.c ; ./a.out # No error report here. +Usage with UndefinedBehaviorSanitizer += + +The arithmetic overflow sanitizers ``unsigned-integer-overfl

[clang-tools-extra] Extend bugprone-use-after-move check to handle std::optional::reset() and std::any::reset() (PR #114255)

2024-10-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a78861fc55d18046989ff4d624a037e9181da170 2d907aa6453b43a2bb537cf1eb32d7f3f8a850a7 --e

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-30 Thread Tom Honermann via cfe-commits
@@ -455,6 +455,64 @@ The SYCL kernel in the previous code sample meets these expectations. }]; } +def SYCLKernelEntryPointDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +The ``sycl_kernel_entry_point`` attribute specifies that a function defini

[clang] [llvm] Reland "[LLVM] Add IRNormalizer Pass" (PR #113780)

2024-10-30 Thread Arthur Eubanks via cfe-commits
aeubanks wrote: I believe the failure reported in the original bot is only under expensive checks (`-DLLVM_ENABLE_EXPENSIVE_CHECKS=ON`) https://github.com/llvm/llvm-project/pull/113780 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-30 Thread Tom Honermann via cfe-commits
@@ -198,3 +198,12 @@ void SemaSYCL::handleKernelAttr(Decl *D, const ParsedAttr &AL) { handleSimpleAttribute(*this, D, AL); } + +void SemaSYCL::handleKernelEntryPointAttr(Decl *D, const ParsedAttr &AL) { + ParsedType PT = AL.getTypeArg(); + TypeSourceInfo *TSI = nullptr; +

[clang] [Clang] Implement labelled type filtering for overflow/truncation sanitizers w/ SSCLs (PR #107332)

2024-10-30 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Is "Test documentation build" error related? https://github.com/llvm/llvm-project/pull/107332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent assertion failure from an invalid template instantiation pattern when adding instantiated params to the scope in friend functions with defaulted params (PR #113777)

2024-10-30 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/113777 >From 78019b9d9dc138f38bb5b32576b621351ae6427c Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 27 Oct 2024 01:07:57 +0300 Subject: [PATCH] [Clang] prevent assertion failure from an invalid template ins

  1   2   3   4   5   6   >