https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/113267
>From 781d226916e6bc477494f707085b9ccab72befb6 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Mon, 21 Oct 2024 23:24:11 -0700
Subject: [PATCH 1/2] CMake cache file for building Pico SDK toolchain
This cache
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/113268
Closes #113170.
>From 0d1c2446a225d73e014e711b0d74931bff9237bc Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 21 Oct 2024 23:27:35 -0700
Subject: [PATCH] [clang-format] Add KeepFormFeed option
Closes #11317
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Closes #113170.
---
Full diff: https://github.com/llvm/llvm-project/pull/113268.diff
10 Files Affected:
- (modified) clang/docs/ClangFormatStyleOptions.rst (+8)
- (modified) clang/docs/ReleaseNotes.rst
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Owen Pan (owenca)
Changes
Closes #113170.
---
Full diff: https://github.com/llvm/llvm-project/pull/113268.diff
10 Files Affected:
- (modified) clang/docs/ClangFormatStyleOptions.rst (+8)
- (modified) clang/docs/ReleaseNotes.rst (+1)
-
https://github.com/petrhosek created
https://github.com/llvm/llvm-project/pull/113267
This cache file demonstrates how to build a complete baremetal Clang/LLVM
toolchain that can be used to build the Pico SDK.
>From 781d226916e6bc477494f707085b9ccab72befb6 Mon Sep 17 00:00:00 2001
From: Petr H
jurahul wrote:
> > > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly
> > > are you trying to achieve and why? Is there an RFC for this given it
> > > seems to be having significant consequences across the tree?
>
> >
>
> > Yes, please see here:
> > https://discourse.l
jrtc27 wrote:
> > "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are
> > you trying to achieve and why? Is there an RFC for this given it seems to
> > be having significant consequences across the tree?
>
> Yes, please see here:
> https://discourse.llvm.org/t/rfc-compr
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/112791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrtc27 wrote:
"[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are you
trying to achieve and why? Is there an RFC for this given it seems to be having
significant consequences across the tree?
https://github.com/llvm/llvm-project/pull/112791
__
@@ -1,3 +1,4 @@
+// REQUIRES: directx-registered-target
jrtc27 wrote:
This seems wrong. Emitting LLVM from the Clang frontend should not require
anything about the set of targets enabled in LLVM itself.
https://github.com/llvm/llvm-project/pull/112791
_
jurahul wrote:
> "[LLVM] Trim intrinsics" is not a helpful commit message. What exactly are
> you trying to achieve and why? Is there an RFC for this given it seems to be
> having significant consequences across the tree?
Yes, please see here:
https://discourse.llvm.org/t/rfc-compress-intrins
https://github.com/jrtc27 edited
https://github.com/llvm/llvm-project/pull/112791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlexMaclean updated
https://github.com/llvm/llvm-project/pull/112834
>From 3c21269ad0b7be617b06cde5debe405f99ef17ef Mon Sep 17 00:00:00 2001
From: Alex Maclean
Date: Thu, 17 Oct 2024 16:49:24 +
Subject: [PATCH 1/2] [NVPTX] Remove nvvm.ldg.global.* intrinsics
---
clang/l
https://github.com/jurahul converted_to_draft
https://github.com/llvm/llvm-project/pull/112791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
---
Patch is 174.94 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/112791.diff
167 Files Affected:
- (modified) clang/test/CodeGenHLSL/GlobalConstructorFunctio
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: Rahul Joshi (jurahul)
Changes
---
Patch is 174.94 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/112791.diff
167 Files Affected:
- (modified) clang/test/CodeGenHLSL/GlobalConstruc
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/112791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
haoNoQ wrote:
Please look at the dates.
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while
building `llvm` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/16/builds/7518
@@ -18952,6 +18955,142 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: {
CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0},
nullptr, "hlsl.radians");
}
+ case Builtin::BI__builtin_hlsl_splitdouble: {
+
+assert((E->getArg(0)->getType()->hasFlo
https://github.com/bhandarkar-pranav commented:
Thank you for this PR, @skatrak, a very useful change. I have minor nits but
other than that, LGTM.
https://github.com/llvm/llvm-project/pull/112533
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
@@ -5928,8 +5931,10 @@ void CGOpenMPRuntime::emitTargetOutlinedFunctionHelper(
return CGF.GenerateOpenMPCapturedStmtFunction(CS, D.getBeginLoc());
};
- OMPBuilder.emitTargetRegionFunction(EntryInfo, GenerateOutlinedFunction,
-
@@ -2331,8 +2332,10 @@ void CGOpenMPRuntime::emitBarrierCall(CodeGenFunction
&CGF, SourceLocation Loc,
auto *OMPRegionInfo =
dyn_cast_or_null(CGF.CapturedStmtInfo);
if (CGF.CGM.getLangOpts().OpenMPIRBuilder) {
-CGF.Builder.restoreIP(OMPBuilder.createBarrier(
-
https://github.com/bhandarkar-pranav edited
https://github.com/llvm/llvm-project/pull/112533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-salinas closed
https://github.com/llvm/llvm-project/pull/113225
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
> We already do this during legalisation / legacy ISEL; there might be merit
> into doing it as early as possible though.
Yes, we definitely need to start folding this out much earlier.
https://github.com/llvm/llvm-project/pull/112849
_
https://github.com/mylai-mtk edited
https://github.com/llvm/llvm-project/pull/112477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mylai-mtk edited
https://github.com/llvm/llvm-project/pull/112477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -899,6 +899,10 @@ void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
if (CodeGenOpts.PointerAuth.IndirectGotos)
Fn->addFnAttr("ptrauth-indirect-gotos");
+ // Add return control flow integrity attributes.
+ if (CodeGenOpts.CFProtectionReturn)
+Fn
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
…tyle
---
Full diff: https://github.com/llvm/llvm-project/pull/113260.diff
1 Files Affected:
- (modified) clang/lib/Format/Format.cpp (+1)
``diff
diff --git a/clang/lib/Format/Format.cpp b/cla
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/113260
…tyle
>From 572848cfbed9273c0087f691bbc336af8e9a34e6 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 21 Oct 2024 20:30:28 -0700
Subject: [PATCH] [clang-format] Use RemoveEmptyLinesInUnwrappedLines in
clang-f
ksromanov wrote:
> EDIT: Turns out I can just do it, never knew I could press that button on the
> PR. Anyway should re-trigger things :).
Thank you!
https://github.com/llvm/llvm-project/pull/104540
___
cfe-commits mailing list
cfe-commits@lists.llv
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #113256.
---
Full diff: https://github.com/llvm/llvm-project/pull/113257.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+5)
- (modified) clang/unittests/Format/Forma
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/113257
Fixes #113256.
>From ae702403b55b23074dd881ef7735bfbe0a3c8eab Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 21 Oct 2024 20:18:43 -0700
Subject: [PATCH] [clang-format] Handle C# `goto case` constructs
Fixes
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/110386
>From e1dc2f848ee74fbd2775c4943c6bf03990f7c164 Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sun, 29 Sep 2024 14:05:33 -0400
Subject: [PATCH] [clang-tidy][readability-container-contains] Fix matching
vvereschaka wrote:
Looks like these failed tests on
[llvm-clang-x86_64-expensive-checks-ubuntu](https://lab.llvm.org/buildbot/#/builders/187)
builder are related with this PR:
```
LLVM ERROR: Function @test changed by IRNormalizerPass without invalidating
analyses
PLEASE submit a bug report to
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/113133
>From ec7d885a7bc89fcb35c08890fde2f07da1e61984 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Mon, 21 Oct 2024 15:18:38 +0800
Subject: [PATCH 1/5] Clang: emit llvm.minnum and llvm.maxnum with nsz always
See:
https://github.com/tangaac updated
https://github.com/llvm/llvm-project/pull/113255
>From 9628b7d031032cf73bce3921620bf0bc992ddd38 Mon Sep 17 00:00:00 2001
From: tangaac
Date: Fri, 11 Oct 2024 14:16:53 +0800
Subject: [PATCH] support amswap[__db].{b/h} and amadd[__db].{b/h} instructions
for Loo
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6360652e9f5b5975d71c619abd981f102eeccec8
51c4019cf9cf6eed49e4bd24e04c350c0cef645c --e
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (tangaac)
Changes
Two options for clang: -mlam-bh & -mno-lam-bh.
Enable or disable amswap[__db].{b/h} and amadd[__db].{b/h} instructions.
The default is -mno-lam-bh.
Only works on LoongArch64.
---
Patch is 76.68 KiB, truncated to 20.
https://github.com/tangaac created
https://github.com/llvm/llvm-project/pull/113255
Two options for clang: -mlam-bh & -mno-lam-bh.
Enable or disable amswap[__db].{b/h} and amadd[__db].{b/h} instructions.
The default is -mno-lam-bh.
Only works on LoongArch64.
>From 51c4019cf9cf6eed49e4bd24e04c35
llvmbot wrote:
@llvm/pr-subscribers-backend-systemz
Author: Kai Nacke (redstar)
Changes
With the support for xray for SystemZ in place, the option can now be enabled
in clang.
---
Full diff: https://github.com/llvm/llvm-project/pull/113254.diff
2 Files Affected:
- (modified) clang/lib
https://github.com/redstar created
https://github.com/llvm/llvm-project/pull/113254
With the support for xray for SystemZ in place, the option can now be enabled
in clang.
>From 3b41d3a4771b4213c5fec786cd4bd15880519e0d Mon Sep 17 00:00:00 2001
From: Kai Nacke
Date: Mon, 21 Oct 2024 22:39:57 -
@@ -0,0 +1,15 @@
+; RUN: opt -S -scalarizer -dxil-op-lower
-mtriple=dxil-pc-shadermodel6.3-library %s 2>&1 | FileCheck %s
+
+; DXIL operation splitdouble doesn't support vector types.
+; XFAIL: *
+
+define noundef <3 x i32> @test_vector_double_split(<3 x double> noundef %D)
loc
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/113133
>From ec7d885a7bc89fcb35c08890fde2f07da1e61984 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Mon, 21 Oct 2024 15:18:38 +0800
Subject: [PATCH 1/3] Clang: emit llvm.minnum and llvm.maxnum with nsz always
See:
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/104540
>From 31ed1cf97be643b3a6c9a05d4e461789c37e2408 Mon Sep 17 00:00:00 2001
From: Konstantin Romanov
Date: Fri, 9 Aug 2024 23:40:07 -0400
Subject: [PATCH 1/7] Workaround for cppcoreguidelines-pro-type-union-access
nicovank wrote:
There's a CI failure but looks unrelated. If you have a minute please
rebase/merge main to trigger the checks again and hopefully the problem
disappears. We can also just keep an eye on the buildbots post-merge tomorrow.
https://github.com/llvm/llvm-project/pull/104540
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/113133
>From ec7d885a7bc89fcb35c08890fde2f07da1e61984 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Mon, 21 Oct 2024 15:18:38 +0800
Subject: [PATCH 1/2] Clang: emit llvm.minnum and llvm.maxnum with nsz always
See:
https://github.com/owenca closed
https://github.com/llvm/llvm-project/pull/113056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2024-10-21T18:50:13-07:00
New Revision: b5bcdb5cfae452da30a699d7967cc1e0800ca997
URL:
https://github.com/llvm/llvm-project/commit/b5bcdb5cfae452da30a699d7967cc1e0800ca997
DIFF:
https://github.com/llvm/llvm-project/commit/b5bcdb5cfae452da30a699d7967cc1e0800ca997.diff
LOG:
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/110942
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,33 @@
+// RUN: %clang_cc1 -triple x86_64 %s -emit-llvm -o - 2>&1 | FileCheck %s
--check-prefix=CHECK
+
+float fminf (float, float);
+double fmin (double, double);
+long double fminl (long double, long double);
+float fmaxf (float, float);
+double fmax (double, double);
https://github.com/justinfargnoli closed
https://github.com/llvm/llvm-project/pull/68176
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/110695
>From 758fb6e28844d89031b5497d651cb2a9b71b6a0e Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Tue, 1 Oct 2024 17:10:50 +0100
Subject: [PATCH 1/3] Explicitly encode native integer widths for SPIR-V.
---
clang/
jsji wrote:
@Sirraide @cor3ntin Updated, can you please have another look? Thanks.
https://github.com/llvm/llvm-project/pull/112816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -337,9 +337,12 @@ void AMDGPUTargetInfo::getTargetDefines(const LangOptions
&Opts,
if (hasFastFMA())
Builder.defineMacro("FP_FAST_FMA");
- Builder.defineMacro("__AMDGCN_WAVEFRONT_SIZE__", Twine(WavefrontSize));
- // ToDo: deprecate this macro for naming consistency
https://github.com/jinge90 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/73750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thetruestblue updated
https://github.com/llvm/llvm-project/pull/113227
>From 43a204a92eab0d4f7b34adf5971e74e3798a3fbd Mon Sep 17 00:00:00 2001
From: thetruestblue <92476612+thetruestb...@users.noreply.github.com>
Date: Mon, 21 Oct 2024 11:06:02 -0700
Subject: [PATCH] [Sanitize
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/113186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/113186
>From 938de3d98db4b8e784cb7ec12b940e686ba1f304 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Mon, 21 Oct 2024 23:49:04 +0800
Subject: [PATCH 1/2] [clang] use ArrayTypeTraitExpr::getType as value type
Fi
github-actions[bot] wrote:
@falbrechtskirchinger Congratulations on having your first Pull Request (PR)
merged into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/113137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Florian Albrechtskirchinger
Date: 2024-10-22T07:43:00+08:00
New Revision: 31dd03cb3ee73e20b8220c2bf991c1afcba923c5
URL:
https://github.com/llvm/llvm-project/commit/31dd03cb3ee73e20b8220c2bf991c1afcba923c5
DIFF:
https://github.com/llvm/llvm-project/commit/31dd03cb3ee73e20b8220c2bf991c1af
jkorous-apple wrote:
Sorry, I should've asked - do you intend to review the changes that followed
your comment?
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/110695
>From 758fb6e28844d89031b5497d651cb2a9b71b6a0e Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Tue, 1 Oct 2024 17:10:50 +0100
Subject: [PATCH 1/2] Explicitly encode native integer widths for SPIR-V.
---
clang/
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
pcc wrote:
Bu
goldsteinn wrote:
@dtcxzyw do you still support riscv codegen diffs?
https://github.com/llvm/llvm-project/pull/113212
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jediry wrote:
Ping @mydeveloperday @owenca
https://github.com/llvm/llvm-project/pull/110634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kpet closed https://github.com/llvm/llvm-project/pull/113145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sven van Haastregt
Date: 2024-10-21T23:55:19+01:00
New Revision: 6201bcc3b5ed8c2dab39b8365cee09018eee8110
URL:
https://github.com/llvm/llvm-project/commit/6201bcc3b5ed8c2dab39b8365cee09018eee8110
DIFF:
https://github.com/llvm/llvm-project/commit/6201bcc3b5ed8c2dab39b8365cee09018eee8110.
kpet wrote:
AFAICT, the new tests ran and the failed tests are completely unrelated to this
change. Merging.
https://github.com/llvm/llvm-project/pull/113145
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
fmayer wrote:
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
// If the alignment is spe
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
pcc wrote:
Wo
arsenm wrote:
> So your solution here is to simply "infect" every language with full address
> space awareness?
It's similar to, but a simpler version of the ABI emission problem. The
frontend has to know properties of the target to emit the IR for it. It's
infeasible to encode all of the po
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
// If the alignment is spe
haoNoQ wrote:
I did. The latest comment is
https://github.com/llvm/llvm-project/pull/91991#discussion_r1643433741
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -764,11 +764,18 @@ void AsmPrinter::emitGlobalVariable(const GlobalVariable
*GV) {
const DataLayout &DL = GV->getDataLayout();
uint64_t Size = DL.getTypeAllocSize(GV->getValueType());
+ if (GV->isTagged())
+Size = alignTo(Size, 16);
// If the alignment is spe
jkorous-apple wrote:
@haoNoQ Do you intend to review the patch?
https://github.com/llvm/llvm-project/pull/91991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/lenary edited
https://github.com/llvm/llvm-project/pull/112983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lenary wrote:
I think the first thing I might do tomorrow is some of the NFC cleanups and
commenting that is in this PR.
I'm not sure the register class renaming can happen quite yet.
https://github.com/llvm/llvm-project/pull/112983
___
cfe-commits m
lenary wrote:
So, I've just pushed an update:
- This now adds the two new MVTs, as suggested by Craig. I'm a little concerned
if this causes a problem of using too much space in SelectionDAG tables. It's
definitely a concern.
- I'm using them from `getAsmOperandValueType`, which is the right pl
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/113155
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> LGTM - would love some eyes from more established folks to make sure we are
> not breaking any bw-compatability foo, and seeing as this spans the tree a
> bit.
>
> Definitely I am for this change, I think the attr is more clear this way, and
> we caught it before LLVM 20 w
haoNoQ wrote:
This overlaps with #91991 which should probably be landed in its entirety. (It
looks like it's about attributes but in fact it isn't. It's about finding *all*
gadgets in all those new places.) I think that patch was almost ready and it
was a matter of considering my fix in
https
tstellar wrote:
Any other comments on this one? If not, I think I'll merge it after the dev
meeting.
https://github.com/llvm/llvm-project/pull/111625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
rnk wrote:
I would stick with `fms-compatibility` being the setting here rather than
plumbing the driver mode through. Over the years, many build systems have been
adapted to work with `clang[++]` and `cl` without going through clang-cl.
https://github.com/llvm/llvm-project/pull/105738
___
https://github.com/thetruestblue updated
https://github.com/llvm/llvm-project/pull/113227
>From dd972e68de679332dc7c6061592a02452f2fbd06 Mon Sep 17 00:00:00 2001
From: thetruestblue <92476612+thetruestb...@users.noreply.github.com>
Date: Mon, 21 Oct 2024 11:06:02 -0700
Subject: [PATCH] [Sanitize
ziqingluo-90 wrote:
Worth to mention that there could be "false positives" introduced to those
std::span calls in C'tor initializers because the safe-pattern matching is
syntactic only, which doesn't know there can be "call stacks" involved in
those recursive cases.
https://github.com/llvm/l
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 845dee36ba4161df153ba05009cea615e20eda5a
01fa7e4ea72b96735d85ed0511d44ca4df106e41 --e
https://github.com/ziqingluo-90 updated
https://github.com/llvm/llvm-project/pull/113226
>From e27fccf11bb750e32453be923f6925abd4cfda31 Mon Sep 17 00:00:00 2001
From: Ziqing Luo
Date: Mon, 21 Oct 2024 14:12:12 -0700
Subject: [PATCH 1/2] [-Wunsafe-buffer-usage] Fix false negatives of missing
2-
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
Author: None (thetruestblue)
Changes
The option -sanitizer-coverage-gated-trace-callbacks gates the invocation of
the trace-pc-guard callbacks based on the value of a global variable, which is
stored in a specific section.
In this commi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (thetruestblue)
Changes
The option -sanitizer-coverage-gated-trace-callbacks gates the invocation of
the trace-pc-guard callbacks based on the value of a global variable, which is
stored in a specific section.
In this commit, we exte
https://github.com/thetruestblue created
https://github.com/llvm/llvm-project/pull/113227
The option -sanitizer-coverage-gated-trace-callbacks gates the invocation of
the trace-pc-guard callbacks based on the value of a global variable, which is
stored in a specific section.
In this commit, we
https://github.com/lenary edited
https://github.com/llvm/llvm-project/pull/112983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 40ea92c859234d536553cf26650e89d6e52071c6
e27fccf11bb750e32453be923f6925abd4cfda31 --e
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Author: Ziqing Luo (ziqingluo-90)
Changes
The analysis now searches for every descendant stmt of constructor initializers
and recurses if the descendant is another constructor call.
(rdar://137999201)
---
Full diff: https://github.com/l
https://github.com/ziqingluo-90 created
https://github.com/llvm/llvm-project/pull/113226
The analysis now searches for every descendant stmt of constructor initializers
and recurses if the descendant is another constructor call.
(rdar://137999201)
>From e27fccf11bb750e32453be923f6925abd4cfda3
https://github.com/eugenis approved this pull request.
This seems fine to me. We are giving up some IR optimization opportunities, but
gain correctness.
Is it fair to say that mixed-sanitized binaries are now fully supported?
https://github.com/llvm/llvm-project/pull/111918
__
1 - 100 of 441 matches
Mail list logo
