[clang] [clang] Ignore inline namespace for `hasName` (PR #109147)

2024-10-09 Thread Alejandro Álvarez Ayllón via cfe-commits
https://github.com/alejandro-alvarez-sonarsource updated https://github.com/llvm/llvm-project/pull/109147 From d369d26aad940299eb98ff0c322614043144c558 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alejandro=20=C3=81lvarez=20Ayll=C3=B3n?= Date: Mon, 24 Jul 2023 13:56:29 +0200 Subject: [PATCH 1/2] [

[clang] [clang] Implement constexpr __builtin_bit_cast for complex types (PR #109981)

2024-10-09 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/109981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f93258e - [clang][bytecode] Diagnose class-specific operator delete calls (#111700)

2024-10-09 Thread via cfe-commits
Author: Timm Baeder Date: 2024-10-10T08:40:14+02:00 New Revision: f93258e4aca518cba3d48db59ed6143ca19ca99b URL: https://github.com/llvm/llvm-project/commit/f93258e4aca518cba3d48db59ed6143ca19ca99b DIFF: https://github.com/llvm/llvm-project/commit/f93258e4aca518cba3d48db59ed6143ca19ca99b.diff L

[clang] [clang][bytecode] Diagnose class-specific operator delete calls (PR #111700)

2024-10-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/111700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-09 Thread Donát Nagy via cfe-commits
NagyDonat wrote: Thanks for the explanation, I agree with your POV and I don't think that we need a drastic change like renaming or reordering everything. However, in this case I think it would be good to remove the type based section headers, which are no longer accurate. When someone adds a

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-09 Thread Balazs Benics via cfe-commits
steakhal wrote: > @steakhal As I was browsing the list of analyzer options, I was surprised to > see that the numerical unsigned options added by this commit are placed in > the "Boolean analyzer options" section of AnalyzerOptions.def. I understand that it's natural to group them together with

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-09 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: Thanks @sdkrystian for pushing the revert - now my nightly tests this night were back to green :-) https://github.com/llvm/llvm-project/pull/73 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] Reland "[analyzer] Harden safeguards for Z3 query times" (PR #97298)

2024-10-09 Thread Donát Nagy via cfe-commits
NagyDonat wrote: @steakhal As I was browsing the list of analyzer options, I was surprised to see that the numerical `unsigned` options added by this commit are placed in the "Boolean analyzer options" section of `AnalyzerOptions.def`. I understand that it's natural to group them together with

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-10-09 Thread Owen Pan via cfe-commits
owenca wrote: @ichaer I forgot to mention that you would need to update `docs/ReleaseNotes.rst`. https://github.com/llvm/llvm-project/pull/96804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-09 Thread Thomas Fransham via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-09 Thread Owen Pan via cfe-commits
owenca wrote: > @owenca, see what you think. IMO it would be more helpful to add the build target to `lib/Format/CMakeLists.txt` instead. For example, ``` $ ninja FormatTests [1/1] cd /Users/Owen/llvm-project/clang12/bin/python3.12 dump_format_style.p $ ``` https://github.com/llvm/llvm-pr

[clang] [SPIR-V] strengthen some lit tests (PR #111636)

2024-10-09 Thread Sameer Sahasrabuddhe via cfe-commits
https://github.com/ssahasra closed https://github.com/llvm/llvm-project/pull/111636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c86edd0 - [SPIR-V] strengthen some lit tests (#111636)

2024-10-09 Thread via cfe-commits
Author: Sameer Sahasrabuddhe Date: 2024-10-10T10:48:40+05:30 New Revision: c86edd03adaaa49b70af8d74ab5e2a09c9daab37 URL: https://github.com/llvm/llvm-project/commit/c86edd03adaaa49b70af8d74ab5e2a09c9daab37 DIFF: https://github.com/llvm/llvm-project/commit/c86edd03adaaa49b70af8d74ab5e2a09c9daab3

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-10-09 Thread Matheus Izvekov via cfe-commits
@@ -1109,12 +1109,50 @@ bool Sema::EnsureTemplateArgumentListConstraints( return false; } -bool Sema::CheckInstantiatedFunctionTemplateConstraints( +static bool CheckFunctionConstraintsWithoutInstantiation( +Sema &SemaRef, SourceLocation PointOfInstantiation, +Functi

[clang-tools-extra] [clang-tidy] Portability Template Virtual Member Function Check (PR #110099)

2024-10-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. Looks good to me as well. https://github.com/llvm/llvm-project/pull/110099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[Clang][Sema] Refactor collection of multi-level template argument lists (#106585)" (PR #111173)

2024-10-09 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: I am not sure I can offer a better option here. The global change seems odd, and I think it may run into other problems. One option would be to do the big hammer approach as you suggest, but then afterwards back out and then try to nail the places where the most recent declara

[clang] [llvm] [clang-format] Add CI check confirming ClangFormatStyleOptions.rst is up-to-date. (PR #111513)

2024-10-09 Thread Owen Pan via cfe-commits
owenca wrote: > Also, why can't we just run the python script as part of building the docs > instead of committing the result of the script to the repository? Because only part of the doc is generated by `dump_format_style.py`. See https://github.com/llvm/llvm-project/blob/1809d0fa1c15b16ca943

[clang] [clang] assume_aligned incorrectly diagnoses a dependent return type (PR #111573)

2024-10-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/111573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 562999a - [clang] assume_aligned incorrectly diagnoses a dependent return type (#111573)

2024-10-09 Thread via cfe-commits
Author: Amr Hesham Date: 2024-10-10T06:47:48+02:00 New Revision: 562999a9f32779c7017235969ec62d99e51a7865 URL: https://github.com/llvm/llvm-project/commit/562999a9f32779c7017235969ec62d99e51a7865 DIFF: https://github.com/llvm/llvm-project/commit/562999a9f32779c7017235969ec62d99e51a7865.diff LO

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-10-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [Fuchsia][CMake] Set output name for libc++ shared library (PR #111791)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes This is a dependency of #80007. --- Full diff: https://github.com/llvm/llvm-project/pull/111791.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+2) ``diff diff --git

[libcxx] [libcxxabi] [libunwind] [runtimes] Always define cxx_shared, cxx_static & other targets (PR #80007)

2024-10-09 Thread Petr Hosek via cfe-commits
petrhosek wrote: > @petrhosek Where is the cache generating that build? > > The fix for this is: > > ``` > # On embedded platforms that don't support shared library targets, CMake > implicitly changes shared > # library targets to be static library targets. This results in duplicate > definit

[clang] [Fuchsia][CMake] Set output name for libc++ shared library (PR #111791)

2024-10-09 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/111791 This is a dependency of #80007. >From f9087b9d82954af96c80a41527dbe33e8d987086 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Thu, 10 Oct 2024 04:24:01 + Subject: [PATCH] [Fuchsia][CMake] Set output name

[clang] [llvm] [RISCV] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Pengcheng Wang via cfe-commits
@@ -276,6 +276,14 @@ foreach i = 0...15 in { foreach i = 0...63 in def : SysReg<"pmpaddr"#i, !add(0x3B0, i)>; +//===--===// +// Machine Non-Maskable Interrupt Handling +//===-

[clang] [llvm] [RISCV] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Craig Topper via cfe-commits
@@ -1913,6 +1913,66 @@ csrrs t1, mhpmcounter31, zero csrrs t2, 0xB1F, zero +## +# Machine Counter Setup topperc wrote: Section title is incorrect. The registers are already tested in rv32-machine-csr-names.s but they shou

[clang] [llvm] [RISCV] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Craig Topper via cfe-commits
@@ -276,6 +276,14 @@ foreach i = 0...15 in { foreach i = 0...63 in def : SysReg<"pmpaddr"#i, !add(0x3B0, i)>; +//===--===// +// Machine Non-Maskable Interrupt Handling +//===-

[clang] [llvm] [RISCV] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Craig Topper via cfe-commits
https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/111668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Coroutines] Transform "coro_elide_safe" calls to switch ABI coroutines to the `noalloc` variant (PR #99285)

2024-10-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `llvm` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/398 Here is the relevant piece of

[clang] [llvm] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp edited https://github.com/llvm/llvm-project/pull/111668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Pengcheng Wang via cfe-commits
@@ -276,6 +276,14 @@ foreach i = 0...15 in { foreach i = 0...63 in def : SysReg<"pmpaddr"#i, !add(0x3B0, i)>; +//===--===// +// Machine Non-Maskable Interrupt Handling +//===-

[clang] [llvm] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Pengcheng Wang via cfe-commits
@@ -66,6 +66,8 @@ def riscv_sret_glue : SDNode<"RISCVISD::SRET_GLUE", SDTNone, [SDNPHasChain, SDNPOptInGlue]>; def riscv_mret_glue : SDNode<"RISCVISD::MRET_GLUE", SDTNone, [SDNPHasChain, SDNPOptInGlue]>; +def riscv_mnret

[clang] [PAC] Re-sign a pointer to a noexcept member function when it is converted to a pointer to a member function without noexcept (PR #109056)

2024-10-09 Thread Pranav Kant via cfe-commits
@@ -924,17 +924,20 @@ ItaniumCXXABI::EmitMemberPointerConversion(CodeGenFunction &CGF, if (isa(src)) return EmitMemberPointerConversion(E, cast(src)); + QualType DstType = E->getType(), SrcType = E->getSubExpr()->getType(); pranavk wrote: `SrcType` is

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #111785)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111785.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp (+3-2)

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #111785)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111785.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp (+3-2) ``

[clang-tools-extra] [clang-tidy] Avoid repeated hash lookups (NFC) (PR #111785)

2024-10-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/111785 None >From 14e7f5dd2176e4fbde0fd699e5a7088239d8faf0 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 9 Oct 2024 06:52:33 -0700 Subject: [PATCH] [clang-tidy] Avoid repeated hash lookups (NFC) --- .

[clang-tools-extra] [clang-change-namespace] Avoid repeated hash lookups (NFC) (PR #111784)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111784.diff 1 Files Affected: - (modified) clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp (+1-2) ``diff

[clang-tools-extra] [clang-change-namespace] Avoid repeated hash lookups (NFC) (PR #111784)

2024-10-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/111784 None >From faf633c5d8a3f255aca95d80bbc4e4e2eede84e3 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 9 Oct 2024 06:51:41 -0700 Subject: [PATCH] [clang-change-namespace] Avoid repeated hash lookups (

[clang-tools-extra] [clang-apply-replacements] Avoid repeated hash lookups (NFC) (PR #111783)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/111783.diff 1 Files Affected: - (modified) clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp (+2-5)

[clang-tools-extra] [clang-apply-replacements] Avoid repeated hash lookups (NFC) (PR #111783)

2024-10-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/111783 None >From f64ab109642e2fa26b6fc58bb84416787996c685 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Wed, 9 Oct 2024 06:51:06 -0700 Subject: [PATCH] [clang-apply-replacements] Avoid repeated hash lookups

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [Clang] prevent recovery call expression from proceeding with explicit attributes and undeclared templates (PR #107786)

2024-10-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/107786 >From e9948a1004cc2b486a0422d83e88392754e9f7e9 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 23 Sep 2024 17:17:30 +0300 Subject: [PATCH 1/2] [Clang] prevent recovery call expression from proceeding w

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-09 Thread Brad Richardson via cfe-commits
everythingfunctional wrote: @kiranchandramohan , I don't have commit access, so could you merge for me? https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,44 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s -fnative-half-type -emit-llvm -O1 -o - | FileCheck %s +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple spirv-vulkan-library %s -fnative-half-type -emit-ll

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -18901,6 +18901,159 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -18901,6 +18901,159 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -461,6 +479,27 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerSplitDouble(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPoint(CI); + + Value *Arg0 = CI->getArgOper

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -47,6 +47,7 @@ def ResRetInt32Ty : DXILOpParamType; def HandleTy : DXILOpParamType; def ResBindTy : DXILOpParamType; def ResPropsTy : DXILOpParamType; +def ResSplitDoubleTy : DXILOpParamType; bogner wrote: This should just be "SplitDoubleTy". The types that

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -264,6 +264,24 @@ class OpLowerer { return lowerToBindAndAnnotateHandle(F); } + Error replaceSplitDoubleCallUsages(CallInst *Intrin, CallInst *Op) { +IRBuilder<> &IRB = OpBuilder.getIRB(); + +for (Use &U : make_early_inc_range(Intrin->uses())) { + if (au

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -4681,6 +4682,14 @@ void CallArg::copyInto(CodeGenFunction &CGF, Address Addr) const { IsUsed = true; } +void CodeGenFunction::EmitWritebacks(CodeGenFunction &CGF, + const CallArgList &Args) { + if (getTarget().getCXXABI().areArgsDest

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Justin Bogner via cfe-commits
@@ -18901,6 +18901,159 @@ case Builtin::BI__builtin_hlsl_elementwise_isinf: { CGM.getHLSLRuntime().getRadiansIntrinsic(), ArrayRef{Op0}, nullptr, "hlsl.radians"); } + case Builtin::BI__builtin_hlsl_splitdouble: { + +assert((E->getArg(0)->getType()->hasFlo

[clang-tools-extra] [clangd] Let DefineOutline tweak handle member functions (PR #95235)

2024-10-09 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: @5chmidti since you've already looked at this, I'd be happy for you to approve this if you're comfortable doing so. https://github.com/llvm/llvm-project/pull/95235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [llvm] [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (PR #108636)

2024-10-09 Thread via cfe-commits
4ast wrote: > BPF_ATOMIC | BPF_DW | BPF_LDX I'd rather not. See my earlier comment. Existing *fetch* flavors return the value. https://github.com/llvm/llvm-project/pull/108636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [C++20][Modules] Allow import for a header unit after #pragma (PR #111662)

2024-10-09 Thread Chuanqi Xu via cfe-commits
@@ -951,9 +951,16 @@ void Preprocessor::Lex(Token &Result) { break; [[fallthrough]]; default: - TrackGMFState.handleMisc(); - StdCXXImportSeqState.handleMisc(); - ModuleDeclState.handleMisc(); + if (tok::isPragmaAnnotation(Result.getKind())

[clang] [Clang][Parser] Don't evaluate concept when its definition is invalid (PR #111179)

2024-10-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/79 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 03229e7 - [Clang][Parser] Don't evaluate concept when its definition is invalid (#111179)

2024-10-09 Thread via cfe-commits
Author: Younan Zhang Date: 2024-10-10T09:36:00+08:00 New Revision: 03229e7c0b1f28b01a75d2d258b16b37c2d2e9b9 URL: https://github.com/llvm/llvm-project/commit/03229e7c0b1f28b01a75d2d258b16b37c2d2e9b9 DIFF: https://github.com/llvm/llvm-project/commit/03229e7c0b1f28b01a75d2d258b16b37c2d2e9b9.diff

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-09 Thread Dean Michael Berris via cfe-commits
@@ -97,27 +97,50 @@ enum XRayPatchingStatus { /// for possible result values. extern XRayPatchingStatus __xray_patch(); +extern XRayPatchingStatus __xray_patch_object(int32_t ObjId); deanberris wrote: Non-blocking: Is it possible to provide documentation to t

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-09 Thread Dean Michael Berris via cfe-commits
@@ -97,27 +97,50 @@ enum XRayPatchingStatus { /// for possible result values. extern XRayPatchingStatus __xray_patch(); +extern XRayPatchingStatus __xray_patch_object(int32_t ObjId); + /// Reverses the effect of __xray_patch(). See XRayPatchingStatus for possible /// result

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-09 Thread Dean Michael Berris via cfe-commits
https://github.com/deanberris approved this pull request. This is very exciting stuff, thank you for this patch! https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-10-09 Thread Dean Michael Berris via cfe-commits
https://github.com/deanberris edited https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/111203 >From f545a14e11556c91d10b14617e3588fe5eae6d42 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Fri, 4 Oct 2024 12:21:51 -0700 Subject: [PATCH 1/4] [HLSL] Collect explicit resource binding information (part 1)

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel` running on `ppc64le-clang-rhel-test` while building `clang,llvm` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/2381 Here is the releva

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota ready_for_review https://github.com/llvm/llvm-project/pull/111203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
@@ -115,12 +114,14 @@ struct Eg13{ MySRV s1; MySRV s2; }; -// expected-warning@+4{{binding type 'u' only applies to types containing UAV resources}} // expected-warning@+3{{binding type 'u' only applies to types containing UAV resources}} -// expected-warning@+2{{binding

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
@@ -1135,21 +1147,19 @@ static void ValidateMultipleRegisterAnnotations(Sema &S, Decl *TheDecl, RegisterType otherRegType = getRegisterType(attr->getSlot()); if (RegisterTypesDetected[static_cast(otherRegType)]) { -if (PreviousConflicts[TheDecl].count(othe

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
@@ -4588,6 +4588,35 @@ def HLSLResourceBinding: InheritableAttr { let LangOpts = [HLSL]; let Args = [StringArgument<"Slot">, StringArgument<"Space", 1>]; let Documentation = [HLSLResourceBindingDocs]; + let AdditionalMembers = [{ + enum class RegisterType : unsigned

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
@@ -2228,3 +2242,62 @@ QualType SemaHLSL::getInoutParameterType(QualType Ty) { Ty.addRestrict(); return Ty; } + +// Walks though existing explicit bindings, finds the actual resource class +// decl the binding applies to and sets it to attr->ResourceField. +// Additional pr

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
@@ -985,44 +983,43 @@ SemaHLSL::TakeLocForHLSLAttribute(const HLSLAttributedResourceType *RT) { return LocInfo; } -// get the record decl from a var decl that we expect -// represents a resource -static CXXRecordDecl *getRecordDeclFromVarDecl(VarDecl *VD) { - const Type *T

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
@@ -2228,3 +2242,62 @@ QualType SemaHLSL::getInoutParameterType(QualType Ty) { Ty.addRestrict(); return Ty; } + +// Walks though existing explicit bindings, finds the actual resource class +// decl the binding applies to and sets it to attr->ResourceField. +// Additional pr

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/111203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/3073 Here is the r

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-lld-multistage-test` running on `ppc64le-lld-multistage-test` while building `clang,llvm` at step 12 "build-stage2-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/4263

[clang] [HLSL] Collect explicit resource binding information (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/111203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Collect explicit resource binding information (part 1) (PR #111203)

2024-10-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/111203 >From f545a14e11556c91d10b14617e3588fe5eae6d42 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Fri, 4 Oct 2024 12:21:51 -0700 Subject: [PATCH 1/3] [HLSL] Collect explicit resource binding information (part 1)

[clang] isUncountedPtr should take QualType as an argument. (PR #110213)

2024-10-09 Thread Artem Dergachev via cfe-commits
@@ -190,11 +190,7 @@ class UncountedLocalVarsChecker if (shouldSkipVarDecl(V)) return; -const auto *ArgType = V->getType().getTypePtr(); -if (!ArgType) haoNoQ wrote: Fair enough! https://github.com/llvm/llvm-project/pull/110213

[clang] isUncountedPtr should take QualType as an argument. (PR #110213)

2024-10-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/110213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Add the support for trivial CXXInheritedCtorInitExpr. (PR #111198)

2024-10-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. Yes makes sense! I've no idea why this is a special case anyway. https://github.com/llvm/llvm-project/pull/98 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [alpha.webkit.UncountedCallArgsChecker] Skip std::forward in tryToFindPtrOrigin. (PR #111222)

2024-10-09 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. Aha LGTM! https://github.com/llvm/llvm-project/pull/111222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-fuzzer` running on `sanitizer-buildbot11` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/159/builds/7851 Here is the relevan

[clang] [Clang] Fix __builtin_dynamic_object_size off by 4 (PR #111015)

2024-10-09 Thread Jan Hendrik Farr via cfe-commits
Cydox wrote: Changing the `struct_size` macro in the kernel [1] would likely be an unreasonable amount of work. To quote Kees from the kernel mailing list [2]: > [...] if we want to change struct_size(), then we must (via allmodconfig builds) determine all the places in the kernel where the cal

[clang] [-Wunsafe-buffer-usage] Add user documentation. (PR #111624)

2024-10-09 Thread via cfe-commits
https://github.com/jkorous-apple approved this pull request. LGTM. Thank you! https://github.com/llvm/llvm-project/pull/111624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Rahul Joshi (jurahul) Changes Rename the function to reflect its correct behavior and to be consistent with `Module::getOrInsertFunction`. This is also in preparation of adding a new `Intrinsic::getDeclaration` that will have beh

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Rahul Joshi (jurahul) Changes Rename the function to reflect its correct behavior and to be consistent with `Module::getOrInsertFunction`. This is also in preparation of adding a new `Intrinsic::getDeclaration` that will have be

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Rename the function to reflect its correct behavior and to be consistent with `Module::getOrInsertFunction`. This is also in preparation of adding a new `Intrinsic::getDeclarati

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly Author: Rahul Joshi (jurahul) Changes Rename the function to reflect its correct behavior and to be consistent with `Module::getOrInsertFunction`. This is also in preparation of adding a new `Intrinsic::getDeclaration` that will hav

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Rahul Joshi (jurahul) Changes Rename the function to reflect its correct behavior and to be consistent with `Module::getOrInsertFunction`. This is also in preparation of adding a new `Intrinsic::getDeclaration` that will have beh

[clang] [llvm] [mlir] [polly] [NFC] Rename `Intrinsic::getDeclaration` to `getOrInsertDeclaration` (PR #111752)

2024-10-09 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/111752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-09 Thread Greg Roth via cfe-commits
@@ -4492,6 +4492,37 @@ void CXXNameMangler::mangleType(const ArrayParameterType *T) { mangleType(cast(T)); } +void CXXNameMangler::mangleType(const HLSLAttributedResourceType *T) { + llvm::SmallString<64> Str("_Res"); + const HLSLAttributedResourceType::Attributes &Attrs

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-09 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/110327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-09 Thread Greg Roth via cfe-commits
@@ -11533,6 +11539,18 @@ QualType ASTContext::mergeTypes(QualType LHS, QualType RHS, bool OfBlockPointer, return {}; return LHS; } + case Type::HLSLAttributedResource: { +const HLSLAttributedResourceType *LHSTy = +LHS->castAs(); +const HLSLAttribut

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-09 Thread Greg Roth via cfe-commits
@@ -4493,28 +4493,34 @@ void CXXNameMangler::mangleType(const ArrayParameterType *T) { } void CXXNameMangler::mangleType(const HLSLAttributedResourceType *T) { - mangleType(T->getWrappedType()); + llvm::SmallString<64> Str("_Res"); const HLSLAttributedResourceType::Attri

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-09 Thread Greg Roth via cfe-commits
@@ -4493,28 +4493,34 @@ void CXXNameMangler::mangleType(const ArrayParameterType *T) { } void CXXNameMangler::mangleType(const HLSLAttributedResourceType *T) { - mangleType(T->getWrappedType()); + llvm::SmallString<64> Str("_Res"); const HLSLAttributedResourceType::Attri

[clang] [HLSL] Make HLSLAttributedResourceType canonical and add code paths to convert HLSL types to DirectX target types (PR #110327)

2024-10-09 Thread Greg Roth via cfe-commits
https://github.com/pow2clk commented: I'm a bit out of my depth here, but I've been trying to understand Itanium mangling better and I think my suggestion to coalesce the vendor mangled portions is valid at least. https://github.com/llvm/llvm-project/pull/110327 ___

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-ppc64le-linux` running on `ppc64le-sanitizer` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/4173 Here is the relevant piece of t

[clang] [Clang] fix overload resolution for object parameters with top-level cv-qualifiers in member functions (PR #110435)

2024-10-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110435 >From c52634882631a71fad956a70179b480abf13006a Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Sun, 29 Sep 2024 22:01:38 +0300 Subject: [PATCH 1/3] [Clang] fix overload resolution for object parameters with

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/109331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Adding splitdouble HLSL function (PR #109331)

2024-10-09 Thread Farzon Lotfi via cfe-commits
@@ -461,6 +479,27 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerSplitDouble(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPoint(CI); + + Value *Arg0 = CI->getArgOper

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com closed https://github.com/llvm/llvm-project/pull/90933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dc85d52 - [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (#90933)

2024-10-09 Thread via cfe-commits
Author: Kyungwoo Lee Date: 2024-10-09T15:37:41-07:00 New Revision: dc85d5263ed5e416cb4ddf405611472f4ef12fd3 URL: https://github.com/llvm/llvm-project/commit/dc85d5263ed5e416cb4ddf405611472f4ef12fd3 DIFF: https://github.com/llvm/llvm-project/commit/dc85d5263ed5e416cb4ddf405611472f4ef12fd3.diff

[clang] [llvm] [CGData][ThinLTO] Global Outlining with Two-CodeGen Rounds (PR #90933)

2024-10-09 Thread Kyungwoo Lee via cfe-commits
kyulee-com wrote: @teresajohnson Thank you for your review and valuable feedback! https://github.com/llvm/llvm-project/pull/90933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   6   >