[clang] [Clang] Fix handling of brace ellison when building deduction guides (PR #94889)

2024-06-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/94889 >From 217c00f47aaa65b113d1c1cfd93a9c4e1d235c1a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 9 Jun 2024 11:49:18 +0800 Subject: [PATCH 1/6] [Clang] Fix two issues of CTAD for aggregates --- clang/lib/S

[clang] [llvm] [analyzer][NFC] Reorganize Z3 report refutation (PR #95128)

2024-06-11 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/95128 >From 6b9a5a6902c3efca6ac7d6a5dabc8950767560cc Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Tue, 11 Jun 2024 16:53:46 +0200 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [Clang] Fix handling of brace ellison when building deduction guides (PR #94889)

2024-06-11 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @hokein I realized the entire patch could be significantly simplified, in which we just don't need to perform the brace elision on a braced initializer. Can you take a second look at it? https://github.com/llvm/llvm-project/pull/94889

[clang] [Clang] Fix handling of brace ellison when building deduction guides (PR #94889)

2024-06-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/94889 >From 217c00f47aaa65b113d1c1cfd93a9c4e1d235c1a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sun, 9 Jun 2024 11:49:18 +0800 Subject: [PATCH 1/5] [Clang] Fix two issues of CTAD for aggregates --- clang/lib/S

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2fe7238 - [RISCV] Add Smcsrind and Sscsrind extension (#93952)

2024-06-11 Thread via cfe-commits
Author: Monad Date: 2024-06-12T14:33:12+08:00 New Revision: 2fe72385a4964f80e7a1c5abcd426455e4127c03 URL: https://github.com/llvm/llvm-project/commit/2fe72385a4964f80e7a1c5abcd426455e4127c03 DIFF: https://github.com/llvm/llvm-project/commit/2fe72385a4964f80e7a1c5abcd426455e4127c03.diff LOG: [R

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() (PR #95195)

2024-06-11 Thread via cfe-commits
cor3ntin wrote: as @mizvekov said, there is no UB here. A better improvement would be to let `runWithSufficientStackSpace` return a value, so we can write ```cpp bool AtLeastAsSpecialized = runWithSufficientStackSpace(/*...*/); ``` https://github.com/llvm/llvm-project/pull/95195 _

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-11 Thread via cfe-commits
PeterChou1 wrote: > Do we really need a full CSS when we're only checking the HTML? Could we just > include a super minimal (or even empty) CSS? I just realize we probably don't need any css or js we just need the files https://github.com/llvm/llvm-project/pull/93928

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
YanWQ-monad wrote: > Conflicting files rebased. https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
https://github.com/YanWQ-monad updated https://github.com/llvm/llvm-project/pull/93952 >From afd92de1d6a04144110eaf358117a0ad3b37343b Mon Sep 17 00:00:00 2001 From: YanWQ-monad Date: Fri, 31 May 2024 16:11:43 +0800 Subject: [PATCH 1/4] [RISCV] Add smcsrind and sscsrind extension --- .../test/

[clang] 93d4fb0 - [clang][Interp] Support floats in APValues

2024-06-11 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-12T08:15:36+02:00 New Revision: 93d4fb032ec1e069cfa5b800f3ca1c807f0d87ac URL: https://github.com/llvm/llvm-project/commit/93d4fb032ec1e069cfa5b800f3ca1c807f0d87ac DIFF: https://github.com/llvm/llvm-project/commit/93d4fb032ec1e069cfa5b800f3ca1c807f0d87ac.diff LO

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Converted to a draft because, as mentioned in https://github.com/clangd/clangd/issues/337#issuecomment-2162175454, the patch doesn't seem to actually fix the issue it's supposed to fix. https://github.com/llvm/llvm-project/pull/95200 __

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 converted_to_draft https://github.com/llvm/llvm-project/pull/95200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: @Sirraide Can you land this for me? https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: The title of the PR can probably be improved. The current title describes the symptom the patch fixes rather than the change it makes (which I don't understand well). (I changed it from the Phabricator revision's title, which was "[clangd] WIP: fix several bugs relating

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: This is @sam-mccall's patch from https://reviews.llvm.org/D78038, rebased and posted as a Github PR https://github.com/llvm/llvm-project/pull/95200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nathan Ridge (HighCommander4) Changes Fixes https://github.com/clangd/clangd/issues/337 --- Full diff: https://github.com/llvm/llvm-project/pull/95200.diff 4 Files Affected: - (modified) clang-tools-extra/clangd/unittests/Sy

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-support Author: Nathan Ridge (HighCommander4) Changes Fixes https://github.com/clangd/clangd/issues/337 --- Full diff: https://github.com/llvm/llvm-project/pull/95200.diff 4 Files Affected: - (modified) clang-tools-ext

[clang] [clang-tools-extra] [llvm] [clangd] Avoid bogus error about recursive inclusion (PR #95200)

2024-06-11 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 created https://github.com/llvm/llvm-project/pull/95200 Fixes https://github.com/clangd/clangd/issues/337 >From 063d7f4977f0d75f88484c1110ca465aa50fc90a Mon Sep 17 00:00:00 2001 From: Nathan Ridge Date: Wed, 12 Jun 2024 01:20:15 -0400 Subject: [PATCH] [clangd]

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2024-06-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/73611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1b66306 - [KMSAN] Enable on PowerPC64 (#73611)

2024-06-11 Thread via cfe-commits
Author: NMiehlbradt Date: 2024-06-12T13:32:39+08:00 New Revision: 1b66306c9c1adce20e2f3cfb1df0af2fb6a10318 URL: https://github.com/llvm/llvm-project/commit/1b66306c9c1adce20e2f3cfb1df0af2fb6a10318 DIFF: https://github.com/llvm/llvm-project/commit/1b66306c9c1adce20e2f3cfb1df0af2fb6a10318.diff L

[clang] [llvm] [KMSAN] Enable on PowerPC64 (PR #73611)

2024-06-11 Thread via cfe-commits
NMiehlbradt wrote: Apologies, this fell off my radar. Thanks for your review @MaskRay. I don’t have commit access, can you merge this PR for me? https://github.com/llvm/llvm-project/pull/73611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() (PR #95195)

2024-06-11 Thread Matheus Izvekov via cfe-commits
@@ -6447,7 +6447,7 @@ bool Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs( if (Inst.isInvalid()) return false; - bool AtLeastAsSpecialized; + bool AtLeastAsSpecialized = false; runWithSufficientStackSpace(Info.getLocation(), [&] { mizvekov

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() (PR #95195)

2024-06-11 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: There is no potential UB, this is a false positive: this lambda will always be executed before runWithSufficientStackSpace returns. https://github.com/llvm/llvm-project/pull/95195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [ARM][clang] Fix warning for VFP function calls from interrupts. (PR #91870)

2024-06-11 Thread Chris Copeland via cfe-commits
chrisnc wrote: Ping @DavidSpickett @jthackray https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add smcdeleg and ssccfg extensions (PR #95163)

2024-06-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/95163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 307d91e - [RISCV] Add smcdeleg and ssccfg extensions (#95163)

2024-06-11 Thread via cfe-commits
Author: Monad Date: 2024-06-12T12:43:39+08:00 New Revision: 307d91ee62f27e8f1c6ac27fdf014001ab1f4484 URL: https://github.com/llvm/llvm-project/commit/307d91ee62f27e8f1c6ac27fdf014001ab1f4484 DIFF: https://github.com/llvm/llvm-project/commit/307d91ee62f27e8f1c6ac27fdf014001ab1f4484.diff LOG: [R

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() (PR #95195)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/95195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior… (PR #95195)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/95195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior… (PR #95195)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes … in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() This patch fixes a static analyzer bug where the boolean variable `AtLeastAsSpecialized` was used uninitialized. The variable is now explicitly initia

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Conflicting files > llvm/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior… (PR #95195)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/95195 … in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() This patch fixes a static analyzer bug where the boolean variable `AtLeastAsSpecialized` was used uninitialized. The variable is now explicitly in

[clang] [Clang] Fix potential null pointer dereferences in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/95192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/95192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/95192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/95192 >From 6852bd6773c13dd9e573df460e74e2b7306c63f0 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Tue, 11 Jun 2024 19:52:03 -0700 Subject: [PATCH 1/3] [Clang] Fix potential null pointer dereference in retain c

[clang] [llvm] [RISCV] Add riscv_atomic.h and Zawrs/Zalrsc builtins (PR #94578)

2024-06-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > I don't know much about there intrinsics on ARM, what are the stronger > guarantees? The Arm specifies that there's a memory reservation, and you can write whatever operations you want as long as you don't break that reservation. And the reservation is usually only a f

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/94267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
@@ -10211,8 +10211,8 @@ Value *CodeGenFunction::EmitSVETupleSetOrGet(const SVETypeFlags &TypeFlags, "Expects TypleFlag isTupleSet or TypeFlags.isTupleSet()"); unsigned I = cast(Ops[1])->getSExtValue(); - auto *SingleVecTy = dyn_cast( - TypeFla

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/94267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/94267 >From 14e4f23d90d3a1590de5b9a1350ecf56aa89cc17 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 3 Jun 2024 11:17:33 -0700 Subject: [PATCH 1/4] [Clang] Prevent null pointer dereferencein SVE tuple functi

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/94267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/94267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereferences in SVE tuple functions (PR #94267)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/94267 >From 14e4f23d90d3a1590de5b9a1350ecf56aa89cc17 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Mon, 3 Jun 2024 11:17:33 -0700 Subject: [PATCH 1/3] [Clang] Prevent null pointer dereferencein SVE tuple functi

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -6853,6 +6853,13 @@ void CodeGenModule::EmitTopLevelDecl(Decl *D) { if (ES->hasExternalDefinitions(D) == ExternalASTSource::EK_Never) DI->completeUnusedClass(*CRD); } +// If we're emitting a dynamic class from the importable module we're +// emi

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -1227,7 +1241,8 @@ void CodeGenModule::EmitDeferredVTables() { #endif for (const CXXRecordDecl *RD : DeferredVTables) -if (shouldEmitVTableAtEndOfTranslationUnit(*this, RD)) +if (shouldEmitVTableAtEndOfTranslationUnit(*this, RD) && +!RD->shouldEmitInExtern

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-11 Thread via cfe-commits
https://github.com/Andarwinux updated https://github.com/llvm/llvm-project/pull/94731 >From f44404f33675f4e72157c270954a1bf65881079c Mon Sep 17 00:00:00 2001 From: Andarwinux <144242044+andarwi...@users.noreply.github.com> Date: Fri, 7 Jun 2024 07:07:40 + Subject: [PATCH] [Driver] Add winsys

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/95192 >From 6852bd6773c13dd9e573df460e74e2b7306c63f0 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Tue, 11 Jun 2024 19:52:03 -0700 Subject: [PATCH 1/2] [Clang] Fix potential null pointer dereference in retain c

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes This patch resolves a static analyzer bug where `S.getCurMethodDecl()` could return `nullptr` when calling `getSelfDecl(()` and was being dereferenced without a null check. The fix introduces a check for a non-null

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/95192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix potential null pointer dereference in retain cycle detection (PR #95192)

2024-06-11 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/95192 This patch resolves a static analyzer bug where `S.getCurMethodDecl()` could return `nullptr` when calling getSelfDecl(() and was being dereferenced without a null check. The fix introduces a check for a non-nu

[clang] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr comparison (PR #95190)

2024-06-11 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/95190 >From ba081d51a0cc803188760eec2847bfc73d2192b8 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 12 Jun 2024 09:47:16 +0800 Subject: [PATCH] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr co

[clang] [lld] [llvm] [RISCV] Make M imply Zmmul (PR #95070)

2024-06-11 Thread Jianjian Guan via cfe-commits
jacquesguan wrote: > We intentionally didn't do this because it makes LLVM not work with binutils > that doesn't know about Zmmul. Maybe enough time has passed that it is no > longer an issue? Since Zmmul was ratified at june 2022, I think it's OK to update it now. https://github.com/llvm/ll

[clang] [clang-format] Fix a bug in annotating lambda l_square (PR #95084)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -1591,6 +1591,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsLambdas) { EXPECT_TOKEN(Tokens[15], tok::arrow, TT_TrailingReturnArrow); EXPECT_TOKEN(Tokens[17], tok::l_brace, TT_LambdaLBrace); + Tokens = annotate("auto l = [] -> struct S { return {}; };");

[clang] [clang-format] Fix a bug in annotating lambda l_square (PR #95084)

2024-06-11 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/95084 >From b89f8a5bcbf525d779565219951359162655929e Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Tue, 11 Jun 2024 01:32:32 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating lambda l_square Fixes #9507

[clang] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr comparison (PR #95190)

2024-06-11 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/95190 >From 157f664408062da41f4d82d20ddc06e0e563fe31 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 12 Jun 2024 09:47:16 +0800 Subject: [PATCH] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr co

[clang] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr comparison (PR #95190)

2024-06-11 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM, Thanks! https://github.com/llvm/llvm-project/pull/95190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr comparison (PR #95190)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Qizhi Hu (jcsxky) Changes improve `ASTStructuralEquivalenceTest`: 1. compare the depth and index of NTTP 2. provide comparison of `CXXDependentScopeMemberExpr` to `StmtCompare`. --- Full diff: https://github.com/llvm/llvm-project/pull/951

[clang] [StructuralEquivalence] improve NTTP and CXXDependentScopeMemberExpr comparison (PR #95190)

2024-06-11 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky created https://github.com/llvm/llvm-project/pull/95190 improve `ASTStructuralEquivalenceTest`: 1. compare the depth and index of NTTP 2. provide comparison of `CXXDependentScopeMemberExpr` to `StmtCompare`. >From 644c6e8499285e5b3ab17193ec63eed051dae583 Mon Sep 17 00

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
https://github.com/owenca deleted https://github.com/llvm/llvm-project/pull/95025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -584,6 +584,23 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) { EXPECT_TOKEN(Tokens[20], tok::greater, TT_BinaryOperator); } +TEST_F(TokenAnnotatorTest, UnderstandsTemplateTemplateParameters) { + auto Tokens = annotate("template typename X,\n" +

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -584,6 +584,23 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) { EXPECT_TOKEN(Tokens[20], tok::greater, TT_BinaryOperator); } +TEST_F(TokenAnnotatorTest, UnderstandsTemplateTemplateParameters) { + auto Tokens = annotate("template typename X,\n" +

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -584,6 +584,23 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) { EXPECT_TOKEN(Tokens[20], tok::greater, TT_BinaryOperator); } +TEST_F(TokenAnnotatorTest, UnderstandsTemplateTemplateParameters) { + auto Tokens = annotate("template typename X,\n" +

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -1269,10 +1269,17 @@ class AnnotatingParser { if (CurrentToken && CurrentToken->is(tok::less)) { CurrentToken->setType(TT_TemplateOpener); next(); - if (!parseAngle()) + TemplateDeclarationDepth++; + if (!parseAngle()) { +TemplateDeclar

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -1269,10 +1269,17 @@ class AnnotatingParser { if (CurrentToken && CurrentToken->is(tok::less)) { CurrentToken->setType(TT_TemplateOpener); next(); - if (!parseAngle()) + TemplateDeclarationDepth++; + if (!parseAngle()) { +TemplateDeclar

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -127,7 +127,7 @@ class AnnotatingParser { SmallVector &Scopes) : Style(Style), Line(Line), CurrentToken(Line.First), AutoFound(false), IsCpp(Style.isCpp()), LangOpts(getFormattingLangOpts(Style)), -Keywords(Keywords), Scopes(Scopes) {

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Owen Pan via cfe-commits
@@ -584,6 +584,23 @@ TEST_F(TokenAnnotatorTest, UnderstandsNonTemplateAngleBrackets) { EXPECT_TOKEN(Tokens[20], tok::greater, TT_BinaryOperator); } +TEST_F(TokenAnnotatorTest, UnderstandsTemplateTemplateParameters) { + auto Tokens = annotate("template typename X,\n" +

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-11 Thread Owen Pan via cfe-commits
owenca wrote: @mydeveloperday requested it. See https://github.com/llvm/llvm-project/pull/91317#pullrequestreview-2095010527. There are calls to `getStyle()` in `ConfigParseTest.cpp`. Maybe add a test there? https://github.com/llvm/llvm-project/pull/91317 _

[clang-tools-extra] [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments. (PR #93623)

2024-06-11 Thread Kefu Chai via cfe-commits
@@ -110,15 +117,32 @@ bool UseAfterMoveFinder::find(Stmt *CodeBlock, const Expr *MovingCall, BlockMap = std::make_unique(TheCFG.get(), Context); Visited.clear(); - const CFGBlock *Block = BlockMap->blockContainingStmt(MovingCall); - if (!Block) { + const CFGBlock *Move

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-11 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Oh, this is surprising. Are arm CPUs 32 bit? And how much do these tests get slowed down? https://github.com/llvm/llvm-project/pull/92083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clang-doc][cmake] Copy assets to build directory (PR #95187)

2024-06-11 Thread Paul Kirth via cfe-commits
ilovepi wrote: @petrhosek I'm pretty sure there's a better way to spell this, but I think we need something similar to properly test clang-doc w/o an install step. cc: @PeterChou1 https://github.com/llvm/llvm-project/pull/95187 ___ cfe-commits mailin

[clang-tools-extra] [clang-doc][cmake] Copy assets to build directory (PR #95187)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Paul Kirth (ilovepi) Changes While we copy the asset files, like index.js, into the correct location in the install step, tests do not have access to those resources in the build directory. This patch copies the contents of t

[clang-tools-extra] [clang-doc][cmake] Copy assets to build directory (PR #95187)

2024-06-11 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/95187 While we copy the asset files, like index.js, into the correct location in the install step, tests do not have access to those resources in the build directory. This patch copies the contents of the clang-doc/a

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-11 Thread Petr Hosek via cfe-commits
petrhosek wrote: Do we really need a full CSS when we're only checking the HTML? Could we just include a super minimal (or even empty) CSS? https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [clang-tools-extra] [llvm] [clang-doc][cmake] Copy assets to build directory (PR #95185)

2024-06-11 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/95185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang-doc][cmake] Copy assets to build directory (PR #95185)

2024-06-11 Thread Paul Kirth via cfe-commits
ilovepi wrote: Jeez. IDK what I've done w/ SPR to do this, but I apologize. https://github.com/llvm/llvm-project/pull/95185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [clang-doc][cmake] Copy assets to build directory (PR #95185)

2024-06-11 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/95185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Implement CWG2398 provisional TTP matching to class templates (PR #94981)

2024-06-11 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/94981 >From d12c7d50b67cd669f09b3701ccf34154876786c9 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 20 May 2024 01:15:03 -0300 Subject: [PATCH] [clang] Implement CWG2398 provisional TTP matching to class t

[clang] [HLSL] Strict Availability Diagnostics (PR #93860)

2024-06-11 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/93860 >From 532f10f77c862f6d429366f0d6903773da8fa79b Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Thu, 30 May 2024 11:40:27 -0700 Subject: [PATCH 1/3] Implement HLSL strict diagnostic mode --- clang/include/clang

[clang] [CMake][Fuchsia] Enable libc++ in the baremetal build (PR #95017)

2024-06-11 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/95017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d9012d8 - [CMake][Fuchsia] Enable libc++ in the baremetal build (#95017)

2024-06-11 Thread via cfe-commits
Author: Petr Hosek Date: 2024-06-11T17:00:15-07:00 New Revision: d9012d8775b45e3edc33394684050cf06b394fb0 URL: https://github.com/llvm/llvm-project/commit/d9012d8775b45e3edc33394684050cf06b394fb0 DIFF: https://github.com/llvm/llvm-project/commit/d9012d8775b45e3edc33394684050cf06b394fb0.diff LO

[clang] [InstallAPI] Pick up input headers by directory traversal (PR #94508)

2024-06-11 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/94508 >From 95cc0c9a2b135706e80a5e73ef5e4257aa89984c Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Fri, 10 May 2024 09:19:22 -0700 Subject: [PATCH] [InstallAPI] Pick up input headers by directory traversal Mat

[clang] [llvm] [WebAssembly] Implement f16x8 madd and nmadd instructions. (PR #95151)

2024-06-11 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl closed https://github.com/llvm/llvm-project/pull/95151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3ab6d12 - [WebAssembly] Implement f16x8 madd and nmadd instructions. (#95151)

2024-06-11 Thread via cfe-commits
Author: Brendan Dahl Date: 2024-06-11T16:10:00-07:00 New Revision: 3ab6d126250f03982d3110517d407f7e951133f6 URL: https://github.com/llvm/llvm-project/commit/3ab6d126250f03982d3110517d407f7e951133f6 DIFF: https://github.com/llvm/llvm-project/commit/3ab6d126250f03982d3110517d407f7e951133f6.diff

[clang] [libcxxabi] [llvm] Add support for WASI builds (PR #91051)

2024-06-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. FWIW I am happy with the one line change in `libcxxabi/`. For libc++ to officially support this beyond just a fun proof of concept, we'd need a story for running the tests and set up a pre-commit CI for it though. I'm approving just to get

[clang] [llvm] [CLANG][LLVM][AArch64]Add SME2.1 intrinsics for MOVAZ tile to vector,… (PR #88499)

2024-06-11 Thread Amara Emerson via cfe-commits
aemerson wrote: Can #88901 #88710 and this be merged? https://github.com/llvm/llvm-project/pull/88499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2137 (list-initialization from objects of the same type) (PR #94355)

2024-06-11 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. Thanks for fixing the libc++ tests. That part of the patch LGTM. https://github.com/llvm/llvm-project/pull/94355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread Paul Kirth via cfe-commits
@@ -127,16 +133,85 @@ std::string getFormatString() { // GetMainExecutable (since some platforms don't support taking the // address of main, and some platforms can't implement GetMainExecutable // without being given the address of a function in the main executable). -std::str

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread Paul Kirth via cfe-commits
@@ -127,16 +133,85 @@ std::string getFormatString() { // GetMainExecutable (since some platforms don't support taking the // address of main, and some platforms can't implement GetMainExecutable // without being given the address of a function in the main executable). -std::str

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM, modulo the one nit, and premerge checks passing. https://github.com/llvm/llvm-project/pull/94717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/94717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Add option to generate additional debug info for expression dereferencing pointer to pointers. #94100" (PR #95174)

2024-06-11 Thread William Junda Huang via cfe-commits
https://github.com/huangjd closed https://github.com/llvm/llvm-project/pull/95174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3fce145 - Revert "Add option to generate additional debug info for expression dereferencing pointer to pointers. #94100" (#95174)

2024-06-11 Thread via cfe-commits
Author: William Junda Huang Date: 2024-06-11T17:33:20-04:00 New Revision: 3fce14569fc3611eddca41db055143285244736a URL: https://github.com/llvm/llvm-project/commit/3fce14569fc3611eddca41db055143285244736a DIFF: https://github.com/llvm/llvm-project/commit/3fce14569fc3611eddca41db055143285244736a

[clang] Revert "Add option to generate additional debug info for expression dereferencing pointer to pointers. #94100" (PR #95174)

2024-06-11 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/95174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Add option to generate additional debug info for expression dereferencing pointer to pointers. #94100" (PR #95174)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: William Junda Huang (huangjd) Changes The option is causing the binary output to be different when compiled under `-O0`, because it introduce dbg.declare on pseudovariables. Going to change this implementation to use dbg.value i

[clang] Revert "Add option to generate additional debug info for expression dereferencing pointer to pointers. #94100" (PR #95174)

2024-06-11 Thread William Junda Huang via cfe-commits
https://github.com/huangjd created https://github.com/llvm/llvm-project/pull/95174 The option is causing the binary output to be different when compiled under `-O0`, because it introduce dbg.declare on pseudovariables. Going to change this implementation to use dbg.value instead. >From c7

[clang] [HLSL] Fix FileCheck annotation typos (PR #95155)

2024-06-11 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/95155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #94100)

2024-06-11 Thread William Junda Huang via cfe-commits
huangjd wrote: Ok lets revert this first, and I will work on the dbg.value implementation https://github.com/llvm/llvm-project/pull/94100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] c6ee562 - [HLSL] Fix FileCheck annotation typos (#95155)

2024-06-11 Thread via cfe-commits
Author: Justin Bogner Date: 2024-06-11T14:16:11-07:00 New Revision: c6ee5628a75feeb4fccc8272a68eb8303fb1734b URL: https://github.com/llvm/llvm-project/commit/c6ee5628a75feeb4fccc8272a68eb8303fb1734b DIFF: https://github.com/llvm/llvm-project/commit/c6ee5628a75feeb4fccc8272a68eb8303fb1734b.diff

[clang] [clang-tools-extra] [clangd] Show struct fields and enum members in hovers (PR #89557)

2024-06-11 Thread Tom Praschan via cfe-commits
https://github.com/tom-anders edited https://github.com/llvm/llvm-project/pull/89557 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >