[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3577 // containing all of the arguments up to the first deducible argument. + // Or, if this isn't a call, emit all the template arguments + // to disambiguate the (potential) overload

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan updated this revision to Diff 556358. zyounan marked an inline comment as done. zyounan added a comment. Address a nit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/ https://reviews.llvm.org/D158926 Files: clang-tools-

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan marked 2 inline comments as done. zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:626 + Method && Method->isInstance()) +Args = Args.drop_front(1); +processCall(Callee, Args); nridge wrote: > Huh, th

[clang] 89bacc0 - [clang] NFCI: Use `FileEntryRef` in `CreateHeaderMap()`

Author: Jan Svoboda Date: 2023-09-09T21:51:04-07:00 New Revision: 89bacc0bb9f6aa66ca1951ec5c0e4c38cc661160 URL: https://github.com/llvm/llvm-project/commit/89bacc0bb9f6aa66ca1951ec5c0e4c38cc661160 DIFF: https://github.com/llvm/llvm-project/commit/89bacc0bb9f6aa66ca1951ec5c0e4c38cc661160.diff L

[clang] 14498a4 - [clang] NFCI: Use `FileEntryRef` in `GlobalModuleIndex`

Author: Jan Svoboda Date: 2023-09-09T21:51:03-07:00 New Revision: 14498a477ee9e00dc462779cee8cbc5846ca6d3a URL: https://github.com/llvm/llvm-project/commit/14498a477ee9e00dc462779cee8cbc5846ca6d3a DIFF: https://github.com/llvm/llvm-project/commit/14498a477ee9e00dc462779cee8cbc5846ca6d3a.diff L

[clang] e644f59 - [clang] NFCI: Use `FileEntryRef` in `ModuleMapCallbacks`

Author: Jan Svoboda Date: 2023-09-09T21:51:04-07:00 New Revision: e644f5973b0b71baadc6d7b64596527a1dc49d17 URL: https://github.com/llvm/llvm-project/commit/e644f5973b0b71baadc6d7b64596527a1dc49d17 DIFF: https://github.com/llvm/llvm-project/commit/e644f5973b0b71baadc6d7b64596527a1dc49d17.diff L

[clang] bc933c9 - [clang] NFCI: Use `FileEntryRef` in `ModuleManager`

Author: Jan Svoboda Date: 2023-09-09T21:50:38-07:00 New Revision: bc933c904704f747fb63f6c93d09c6759936e255 URL: https://github.com/llvm/llvm-project/commit/bc933c904704f747fb63f6c93d09c6759936e255 DIFF: https://github.com/llvm/llvm-project/commit/bc933c904704f747fb63f6c93d09c6759936e255.diff L

[clang] e483a6e - [clang] NFCI: Use `FileEntryRef` in `LookupSubframeworkHeader()`

Author: Jan Svoboda Date: 2023-09-09T21:50:38-07:00 New Revision: e483a6e174f5e06ae46d870c5263b489db4b9e65 URL: https://github.com/llvm/llvm-project/commit/e483a6e174f5e06ae46d870c5263b489db4b9e65 DIFF: https://github.com/llvm/llvm-project/commit/e483a6e174f5e06ae46d870c5263b489db4b9e65.diff L

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

https://github.com/abrachet closed https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 33f19a6 - [Haiku] Don't assume clang was build with libstdc++ as default (#65871)

Author: Alex Brachet Date: 2023-09-10T00:00:08-04:00 New Revision: 33f19a6f1c279f5f77a577fae41f13133522497b URL: https://github.com/llvm/llvm-project/commit/33f19a6f1c279f5f77a577fae41f13133522497b DIFF: https://github.com/llvm/llvm-project/commit/33f19a6f1c279f5f77a577fae41f13133522497b.diff

[clang] 715257e - [clang] NFCI: Use `FileEntryRef` in `Sarif.cpp`

Author: Jan Svoboda Date: 2023-09-09T20:56:46-07:00 New Revision: 715257eac76cafef483014e01c3b4abed964815f URL: https://github.com/llvm/llvm-project/commit/715257eac76cafef483014e01c3b4abed964815f DIFF: https://github.com/llvm/llvm-project/commit/715257eac76cafef483014e01c3b4abed964815f.diff L

[clang] 6966c06 - [clang] NFCI: Use `FileEntryRef` in `suggestPathToFileForDiagnostics()`

Author: Jan Svoboda Date: 2023-09-09T20:29:04-07:00 New Revision: 6966c06bedd0639169ad82cf17ded235d0acb850 URL: https://github.com/llvm/llvm-project/commit/6966c06bedd0639169ad82cf17ded235d0acb850 DIFF: https://github.com/llvm/llvm-project/commit/6966c06bedd0639169ad82cf17ded235d0acb850.diff L

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

https://github.com/brad0 approved this pull request. https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This test fails with `CLANG_DEFAULT_CXX_STDLIB=libc++` -- Full diff: https://github.com/llvm/llvm-project/pull/65871.diff 1 Files Affected: - (modified) clang/test/Driver/haiku.cpp (+1-1) diff --git a/clang/test/Driver/haiku.cpp b/clang/t

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

abrachet added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ brad wrote: > abrachet wrote: > >

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/65871: This test fails with `CLANG_DEFAULT_CXX_STDLIB=libc++` >From 01607fcb02df7e9f91f39c01938c8b67247703bd Mon Sep 17 00:00:00 2001 From: Alex Brachet Date: Sat, 9 Sep 2023 23:27:33 -0400 Subject: [PATCH] [Haiku] D

[clang] [Haiku] Don't assume clang was build with libstdc++ as default (PR #65871)

https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

brad added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ abrachet wrote: > This test is broken

[PATCH] D159414: [Driver] Fixes for header / library paths on Haiku

abrachet added inline comments. Comment at: clang/test/Driver/haiku.cpp:2 +// Check the C++ header path (libstdc++) +// RUN: %clang++ --target=x86_64-unknown-haiku -### %s 2>&1 \ +// RUN: --sysroot=%S/Inputs/haiku_x86_64_tree \ This test is broken for people wh

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

llvmbot wrote: @llvm/pr-subscribers-clang Changes tzdb is currently broken when cross compiling from non Linux to Linux. Lets just disable it totally in our toolchain for now. We should remove this when #65859 lands. -- Full diff: https://github.com/llvm/llvm-project/pull/65870.diff 1 Files

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

https://github.com/abrachet review_requested https://github.com/llvm/llvm-project/pull/65870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Fuchsia] Disable libcxx timezone database (PR #65870)

https://github.com/abrachet created https://github.com/llvm/llvm-project/pull/65870: tzdb is currently broken when cross compiling from non Linux to Linux. Lets just disable it totally in our toolchain for now. We should remove this when #65859 lands. >From b75d844d09076f2a7f170454782662cfebd

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/65842: >From 80c558e007dc7424b31402909700bb558e3a8704 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sat, 9 Sep 2023 03:43:57 -0400 Subject: [PATCH] [Driver] Replace usage of -Bshareable linker flag with -shared The t

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/65861: >From c1982d451e6ca8e3cf1269677aabe984000f6801 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Sat, 9 Sep 2023 20:35:33 + Subject: [PATCH 1/2] [clang-format] Properly indent lines inside Verilog case structure

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

llvmbot wrote: @llvm/pr-subscribers-clang Changes 62281227bf7ca48d0101e4c9d11f71600208c7df was commited, but I noticed one spot was missed in the DragonFly Driver. -- Full diff: https://github.com/llvm/llvm-project/pull/65867.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/D

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove duplicate -e on DragonFly (PR #65867)

https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/65867: 62281227bf7ca48d0101e4c9d11f71600208c7df was commited, but I noticed one spot was missed in the DragonFly Driver. >From 112b5c951afc9144271d77380c1c26cc5a6e0e24 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sa

[clang] [Clang][OpenMP] Emit unroll directive w/o captured stmt (PR #65862)

https://github.com/shiltian closed https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 52b4bec - [Clang][OpenMP] Emit unroll directive w/o captured stmt (#65862)

Author: Shilei Tian Date: 2023-09-09T18:51:58-04:00 New Revision: 52b4bec9395703d4757c065649fa43a93e19b7b2 URL: https://github.com/llvm/llvm-project/commit/52b4bec9395703d4757c065649fa43a93e19b7b2 DIFF: https://github.com/llvm/llvm-project/commit/52b4bec9395703d4757c065649fa43a93e19b7b2.diff L

[clang] [Clang][OpenMP] Emit unroll directive w/o captured stmt (PR #65862)

https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

@@ -1599,6 +1600,15 @@ unsigned ContinuationIndenter::moveStateToNextToken(LineState &State, State.Column += Current.ColumnWidth; State.NextToken = State.NextToken->Next; + // Verilog case labels are are on the same unwrapped lines as the statements + // that follow. T

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Also use --no-as-needed when linking libatomic on Linux/Sparc (PR #65827)

@@ -618,6 +618,7 @@ void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back("--push-state"); MaskRay wrote: Is Issue #41880 and D118021 still relevant? If not, the description needs to describe why the change i

[clang] Update GoogleTest to v1.14.0 (PR #65823)

@@ -1,22 +1,21 @@ LLVM notes -- -This directory contains Google Test 1.10.0, with all elements removed except for -the actual source code, to minimize the addition to the LLVM distribution. +This directory contains Google Test 1.14.0, +revision `f8d7d77c06936315286eb5

[clang] Update GoogleTest to v1.14.0 (PR #65823)

@@ -77,18 +77,18 @@ endif () target_include_directories(llvm_gtest PUBLIC $ $ - $ - $ + $ + $ PRIVATE googletest googlemock ) add_subdirectory(UnitTestMain) if (LLVM_INSTALL_GTEST) install(TARGETS llvm_gtest llvm_gtest_m

[clang] Update GoogleTest to v1.14.0 (PR #65823)

@@ -77,18 +77,18 @@ endif () target_include_directories(llvm_gtest PUBLIC $ $ - $ - $ + $ + $ petrhosek wrote: This is undoing a change made recently in https://github.com/llvm/llvm-project/commit/91b3ca39667b6341a8c

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

cor3ntin wrote: We should consider whether we want to support __msvc_no_unique_address__ or similar https://github.com/llvm/llvm-project/issues/61196 https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [Clang][OpenMP] Emit unroll directive w/o captured stmt (PR #65862)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The front end doesn't create captured region for unroll directive. This leads to a crash when `-fopenmp-simd` is used, as reported in #63570. Fix #63570. -- Full diff: https://github.com/llvm/llvm-project/pull/65862.diff 2 Files Affected: -

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/65862: The front end doesn't create captured region for unroll directive. This leads to a crash when `-fopenmp-simd` is used, as reported in #63570. Fix #63570. >From 7ba55161a5d24e9d67c00696bca9e4d06b907689 Mon Sep

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/joker-eph approved this pull request. Agree with @MaskRay for the style: we should minimize the diff with upstream as much as possible! https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

llvmbot wrote: @llvm/pr-subscribers-clang-format Changes When a statement following a case label had to be broken into multiple lines, the continuation parts were not indented correctly. Old: ```Verilog case (data) 16'd0: result = // break here 10'b01; endcase ``` New: `

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

llvmbot wrote: @llvm/pr-subscribers-clang Changes When a statement following a case label had to be broken into multiple lines, the continuation parts were not indented correctly. Old: ```Verilog case (data) 16'd0: result = // break here 10'b01; endcase ``` New: ```Veril

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/sstwcw review_requested https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/sstwcw created https://github.com/llvm/llvm-project/pull/65861: When a statement following a case label had to be broken into multiple lines, the continuation parts were not indented correctly. Old: ```Verilog case (data) 16'd0: result = // break here 10'b0111

[clang] Extension: allow recursive macros (PR #65851)

kelbon wrote: > How would you deal with the issue of infinite loops? The following program: > > ```c++ > #define2 boom(X) boom(X) > > boom(0) > ``` > > Will continue to infinitely(?) consume memory until it is killed, either by > the user or due to running out of memory on the system As fo o

[clang] [clang][TSA] Consider cleanup functions for thread safety analysis (PR #65462)

Timm =?utf-8?q?Bäder?= aaronpuchert wrote: We still have until the end of September to finish the review on Phabricator. I would suggest that we keep the review there until we have to move. Here I can't see the difference to the last version that I reviewed. https://github.com/llvm/llvm-proj

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 84e3fdf - [clang-format] BreakBeforeNoexceptSpecifier option added (#65808)

Author: Björn Schäpers Date: 2023-09-09T22:31:58+02:00 New Revision: 84e3fdfc65232a4c940c2c3c9a2a8fe6c9b7806d URL: https://github.com/llvm/llvm-project/commit/84e3fdfc65232a4c940c2c3c9a2a8fe6c9b7806d DIFF: https://github.com/llvm/llvm-project/commit/84e3fdfc65232a4c940c2c3c9a2a8fe6c9b7806d.diff

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/65808: From 3d3b20f66212f86bd46853432f1be31e5977df83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Fri, 8 Sep 2023 13:07:09 +0200 Subject: [PATCH] [clang-format] BreakBeforeNoex

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

arsenm closed this revision. arsenm added a comment. 6a08cf12d9cbc960159bf40e47078a882ca510ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 __

[clang] 6a08cf1 - clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

Author: Matt Arsenault Date: 2023-09-09T23:14:12+03:00 New Revision: 6a08cf12d9cbc960159bf40e47078a882ca510ce URL: https://github.com/llvm/llvm-project/commit/6a08cf12d9cbc960159bf40e47078a882ca510ce DIFF: https://github.com/llvm/llvm-project/commit/6a08cf12d9cbc960159bf40e47078a882ca510ce.diff

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

jrtc27 wrote: > ", where the aka will be skipped" in the commit message still doesn't make > sense to me , otherwise lgtm Comments in Clang's ASTDiagnostic use "aka" and "aka clause" synonymously, referring to the parenthesised clause in `'foo' (aka 'bar')` that is sometimes printed in diagno

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

https://github.com/cor3ntin approved this pull request. ", where the aka will be skipped" in the commit message still doesn't make sense to me , otherwise lgtm https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@li

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

https://github.com/jrtc27 review_requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556356. iana added a comment. - Drop the -verify off the stddef tests so that I can get the full errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/li

[clang] Extension: allow recursive macros (PR #65851)

rymiel wrote: How would you deal with the issue of infinite loops? The following program: ```cpp #define2 boom(X) boom(X) boom(0) ``` Will continue to infinitely(?) consume memory until it is killed, either by the user or due to running out of memory on the system https://github.com/llvm/llv

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

iana updated this revision to Diff 556355. iana added a comment. - Drop the -verify off the new tests so that I can get the full errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/B

[clang-tools-extra] eea232d - [clang][tools] Remove path separator assumption

Author: Jan Svoboda Date: 2023-09-09T11:38:32-07:00 New Revision: eea232da827abae1a4fd71a0fb1f4d239d7b2f6a URL: https://github.com/llvm/llvm-project/commit/eea232da827abae1a4fd71a0fb1f4d239d7b2f6a DIFF: https://github.com/llvm/llvm-project/commit/eea232da827abae1a4fd71a0fb1f4d239d7b2f6a.diff L

[clang] Update GoogleTest to v1.14.0 (PR #65823)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

MaskRay wrote: Thank you for the change! `ninja check-llvm check-clang check-clang-tools check-flang check-mlir check-lld check-polly` parses. > The GoogleTest code also uses a different code style (Google C++ style > instead of LLVM style). Shall I reformat the entire GoogleTest code base? I

[clang-tools-extra] 98e6deb - [clang][tools] Use `FileEntryRef` in `include_cleaner::Header`

Author: Jan Svoboda Date: 2023-09-09T09:54:13-07:00 New Revision: 98e6deb62cefaa7d5c67081bd5b72ad26bada46e URL: https://github.com/llvm/llvm-project/commit/98e6deb62cefaa7d5c67081bd5b72ad26bada46e DIFF: https://github.com/llvm/llvm-project/commit/98e6deb62cefaa7d5c67081bd5b72ad26bada46e.diff L

[clang] Extension: allow recursive macros (PR #65851)

kelbon wrote: > There are questions about the name, theorically this is an identifier that c > and c++ committees may want to use in the future. Yes, the name define2 is a placeholder, but the more I look at it, the more it looks appropriate > Is this something you plan to propose to other

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti marked an inline comment as done. 5chmidti added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:187 +// Allow expressions, but only allow completely selected lambda +// expressions or unselected lambda expression

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 ___ cfe-commits mailing list cfe-co

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti updated this revision to Diff 556349. 5chmidti added a comment. Fixup to last revision change: - do not block the partial selection of lambdas There is no reason to block the partial selection of lambdas. Other expressions can be partially selected as well and still offer an extraction

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

5chmidti updated this revision to Diff 556348. 5chmidti added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVariabl

[clang] ef99617 - [clang] NFCI: Use `FileEntryRef` in `diagnoseFrameworkInclude()`

Author: Jan Svoboda Date: 2023-09-09T09:12:35-07:00 New Revision: ef996175a7d38f7b4a0b60264dc861ab36376a47 URL: https://github.com/llvm/llvm-project/commit/ef996175a7d38f7b4a0b60264dc861ab36376a47 DIFF: https://github.com/llvm/llvm-project/commit/ef996175a7d38f7b4a0b60264dc861ab36376a47.diff L

[clang] 37b0889 - [clang] NFCI: Use `FileEntryRef` in `ModuleMap`

Author: Jan Svoboda Date: 2023-09-09T09:12:35-07:00 New Revision: 37b08892fc1ada83f09b4630190f8fb7346923cd URL: https://github.com/llvm/llvm-project/commit/37b08892fc1ada83f09b4630190f8fb7346923cd DIFF: https://github.com/llvm/llvm-project/commit/37b08892fc1ada83f09b4630190f8fb7346923cd.diff L

[clang] c23d65b - [clang] NFCI: Use `FileEntryRef` in `ModuleMapParser`

Author: Jan Svoboda Date: 2023-09-09T09:12:35-07:00 New Revision: c23d65b90fb7fb07cb12e2d70d0c34376b8fcdad URL: https://github.com/llvm/llvm-project/commit/c23d65b90fb7fb07cb12e2d70d0c34376b8fcdad DIFF: https://github.com/llvm/llvm-project/commit/c23d65b90fb7fb07cb12e2d70d0c34376b8fcdad.diff L

[clang] Extension: allow recursive macros (PR #65851)

cor3ntin wrote: Compiler extensions are best proposed through a RFC, ie a discourse post here: https://discourse.llvm.org/c/clang/6 Explaining the motivation for the feature, which the pr description already does a good job. There are questions about the name, theorically this is an identifie

[clang] Extension: allow recursive macros (PR #65851)

https://github.com/kelbon edited https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

eopXD wrote: @jrtc27 Anymore comments before merging this? https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

https://github.com/kelbon created https://github.com/llvm/llvm-project/pull/65851: Add 'define2' directive, which works as 'define', but allows recursive macros Motivation: * There are huge amount of code, which uses code generation/ boiler plate macros /misused terrible templates which is b

[clang] add define2 pp directive (PR #65851)

https://github.com/kelbon review_requested https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

https://github.com/kelbon review_requested https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

@@ -117,7 +118,8 @@ std::optional Context::classify(QualType T) const { case 8: return PT_Uint8; default: - return std::nullopt; + return PT_IntAP; + // return std::nullopt; tbaederr wrote: Yes. There are a few such comments left

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

@@ -117,7 +118,8 @@ std::optional Context::classify(QualType T) const { case 8: return PT_Uint8; default: - return std::nullopt; + return PT_IntAP; + // return std::nullopt; yronglin wrote: Can this comment be remove? https://git

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

=?utf-8?q?Björn_Schäpers?= llvmbot wrote: @llvm/pr-subscribers-clang-format Changes It really bugs me that it breaks to ``` c++ ...) noexcept( noexcept(condition)... ``` This is a fix for people like me. -- Full diff: https://github.com/llvm/llvm-project/pull/65808.diff 7 Files Affecte

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

=?utf-8?q?Björn_Schäpers?= llvmbot wrote: @llvm/pr-subscribers-clang Changes It really bugs me that it breaks to ``` c++ ...) noexcept( noexcept(condition)... ``` This is a fix for people like me. -- Full diff: https://github.com/llvm/llvm-project/pull/65808.diff 7 Files Affected: - (

  1   2   >