[PATCH] D150645: [Driver] Support multi /guard: options

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f366dcd85c: Reland "[Driver] Support multi /guard: options" (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://revie

[clang] a4f366d - Reland "[Driver] Support multi /guard: options"

Author: Phoebe Wang Date: 2023-05-20T14:44:05+08:00 New Revision: a4f366dcd85c440a611bbc82f1d24c2d9a735251 URL: https://github.com/llvm/llvm-project/commit/a4f366dcd85c440a611bbc82f1d24c2d9a735251 DIFF: https://github.com/llvm/llvm-project/commit/a4f366dcd85c440a611bbc82f1d24c2d9a735251.diff L

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:381 HasBFloat16 = SSELevel >= SSE2; codemzs wrote: > rjmccall wrote: > > pengfei wrote: > > > I'm not sure if I understand the meaning of `HasFullBFloat16`. If it is > > > used f

[PATCH] D149612: [Sema] avoid merge error type

hokein accepted this revision. hokein added a comment. thanks, looks good to me. Comment at: clang/test/Sema/merge-decls.c:96 +char d; +char x[sizeof(d.data) == 8]; // expected-error {{member reference base type 'char' is not a structure or union}} +char x[sizeof(d.data) == 4]

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1 peter.smith wrote: > MaskRay wr

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna updated this revision to Diff 523986. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 Files: clang/lib/ARCMigrate/ObjCMT.cpp Index: clang/lib/ARCMigrate/ObjCMT.cpp === ---

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 523984. MaskRay marked 2 inline comments as done. MaskRay added a comment. fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Undefined

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna updated this revision to Diff 523983. Manna added a comment. Fix Clang-format error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 Files: clang/lib/ARCMigrate/ObjCMT.cpp Index: clang/lib/ARCMigrate/ObjCMT.cpp ===

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG34d8cd153812: [NFC][CLANG] Fix issue with dereference null return value found by Coverity… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 34d8cd1 - [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Author: Manna, Soumi Date: 2023-05-19T19:41:38-07:00 New Revision: 34d8cd153812c3e5e2db1a1e27f057db33b07b6e URL: https://github.com/llvm/llvm-project/commit/34d8cd153812c3e5e2db1a1e27f057db33b07b6e DIFF: https://github.com/llvm/llvm-project/commit/34d8cd153812c3e5e2db1a1e27f057db33b07b6e.diff

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Coverity

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4357517 , @dblaikie wrote: > Looks like this series got approved - is it waiting on any particular > feedback, or do you need someone to commit it for you? I had been waiting for approval for the change of https:

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna marked 2 inline comments as done. Manna added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:323-324 + // The copy assignment operator is defined as deleted pending further + // motivation. + SExpr &operator=(const SExpr &) = delet

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523957. Manna added a comment. I have addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h clang/include/clang/StaticA

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 __

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/ https://reviews.llvm.org/D150504 __

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. I see. Yes, in that case I think you're right that we can't test this yet — only base-subobject ctors and dtors get VTT parameters, we only emit calls to those from other ctors and dtors, and those ctors and dtors will always have their own stores to the v-table slot

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4357443 , @rjmccall wrote: > It's well-formed as IR, just not semantically valid, right? As long as it's > not actually crashing in the verifier, please test as much as you reasonably > can that's correct, like that

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e935240f02: [clang][AST] Propagate the value-dependent bit for VAArgExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] d4e9352 - [clang][AST] Propagate the value-dependent bit for VAArgExpr.

Author: Haojian Wu Date: 2023-05-19T23:43:46+02:00 New Revision: d4e935240f0223cdf2270dde587960d3d3868c6f URL: https://github.com/llvm/llvm-project/commit/d4e935240f0223cdf2270dde587960d3d3868c6f DIFF: https://github.com/llvm/llvm-project/commit/d4e935240f0223cdf2270dde587960d3d3868c6f.diff LO

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

nikic added a comment. Any reason why this hasn't been landed yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4357360 , @arsenm wrote: > I also think we need to revert or disable > https://github.com/llvm/llvm-project/commit/cead4eceb01b935fae07bf4a7e91911b344d2fec > > The symbolizer is unusably slow with it I believe that i

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf60cc01e9e75: [clang][CodeGen] Break up TargetInfo.cpp [5/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a86e05d1da0: [clang][CodeGen] Break up TargetInfo.cpp [4/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG940b02095bf9: [clang][CodeGen] Break up TargetInfo.cpp [3/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a646ed6835f: [clang][CodeGen] Break up TargetInfo.cpp [2/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2492f7cf0b1: [clang][CodeGen] Break up TargetInfo.cpp [1/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 940b020 - [clang][CodeGen] Break up TargetInfo.cpp [3/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:08+03:00 New Revision: 940b02095bf986b5bcc365dc97667a27176c3b13 URL: https://github.com/llvm/llvm-project/commit/940b02095bf986b5bcc365dc97667a27176c3b13 DIFF: https://github.com/llvm/llvm-project/commit/940b02095bf986b5bcc365dc97667a27176c3b13.d

[clang] f60cc01 - [clang][CodeGen] Break up TargetInfo.cpp [5/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:21+03:00 New Revision: f60cc01e9e75785dd2476c7e05da689be5a99839 URL: https://github.com/llvm/llvm-project/commit/f60cc01e9e75785dd2476c7e05da689be5a99839 DIFF: https://github.com/llvm/llvm-project/commit/f60cc01e9e75785dd2476c7e05da689be5a99839.d

[clang] 0a86e05 - [clang][CodeGen] Break up TargetInfo.cpp [4/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:15+03:00 New Revision: 0a86e05d1da0f544920b1eff6656c5577fb6562f URL: https://github.com/llvm/llvm-project/commit/0a86e05d1da0f544920b1eff6656c5577fb6562f DIFF: https://github.com/llvm/llvm-project/commit/0a86e05d1da0f544920b1eff6656c5577fb6562f.d

[clang] 5a646ed - [clang][CodeGen] Break up TargetInfo.cpp [2/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:02+03:00 New Revision: 5a646ed6835f2686cc0574047ce3c9bbaf323ea3 URL: https://github.com/llvm/llvm-project/commit/5a646ed6835f2686cc0574047ce3c9bbaf323ea3 DIFF: https://github.com/llvm/llvm-project/commit/5a646ed6835f2686cc0574047ce3c9bbaf323ea3.d

[clang] f2492f7 - [clang][CodeGen] Break up TargetInfo.cpp [1/8]

Author: Sergei Barannikov Date: 2023-05-19T23:54:55+03:00 New Revision: f2492f7cf0b175d5d9403cbfc970a521adbde659 URL: https://github.com/llvm/llvm-project/commit/f2492f7cf0b175d5d9403cbfc970a521adbde659 DIFF: https://github.com/llvm/llvm-project/commit/f2492f7cf0b175d5d9403cbfc970a521adbde659.d

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, carlo.bertolli, yaxunl, saiislam. Herald added subscribers: sunshaoce, kerbowa, guansong, tpr, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sst

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

aaronpuchert added a comment. Can only comment on `ThreadSafetyTIL.h`. Thanks for addressing this, I agree that these expressions should not be assignable. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:323-324 + // The copy assignment operator is defin

[PATCH] D148387: remove Demangle/StringView.h

nickdesaulniers updated this revision to Diff 523923. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148387/new/ https://reviews.llvm.org/D148387 Files: clang/docs/tools/clang-formatted-files.txt libcxx

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4285705 , @dblaikie wrote: >> I think we probably should add LLVM_DISABLE_SYMBOLIZATION=1 to the lit >> level, not in individual tests. > > Though I'm not sure how to do that in a way that it doesn't apply to test >

[PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

craig.topper created this revision. craig.topper added a reviewer: MaskRay. Herald added subscribers: ThomasRaoux, kbarton, hiraditya, nemanjai. Herald added a project: All. craig.topper requested review of this revision. Herald added a reviewer: zuban32. Herald added subscribers: lldb-commits, cfe

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. Looks like this series got approved - is it waiting on any particular feedback, or do you need someone to commit it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. It's well-formed as IR, just not semantically valid, right? As long as it's not actually crashing in the verifier, please test as much as you reasonably can that's correct, like that the constructor and destructor functions take something in the right address space, a

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" NoQ wrote: > malavikasamak wrote: > > NoQ wrote: > > > The f

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4354742 , @rjmccall wrote: > Can you add a test? I think we have some in-tree targets which put globals > in a non-default address space. I've added the test (think we, i.e. AMDGPU, are the only ones doing this at th

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523902. AlexVlx added a comment. Use `GetGlobalVarAddressSpace` everywhere. Added test, which I'm marking `XFAIL` for now since it turns out I'll need to fix the remaining vptr / vtable handling parts, yay. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM after addressing Aaron's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150435/new/ https://reviews.llvm.org/D150435 __

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 523899. keith added a comment. Improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driv

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

arsenm added a comment. I also think we need to revert or disable https://github.com/llvm/llvm-project/commit/cead4eceb01b935fae07bf4a7e91911b344d2fec The symbolizer is unusably slow with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith created this revision. Herald added a project: All. keith requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Starting with the SDKs provided with Xcode 14.3, this library no longer exists. Before this change this results in an op

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

aeubanks added a comment. `not` will set `LLVM_DISABLE_SYMBOLIZATION` if we use `not --crash` are these tests supposed to crash or gracefully fail? if they're supposed to crash then we should use `not --crash` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs marked an inline comment as done. codemzs added a comment. I believe I had updated the `__bf16` documentation in `/llvm-project/clang/docs/LanguageExtensions.rst`, but it appears to have been omitted in this patch. I assure you, I'll rectify this in the next iteration. ===

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; tahonermann wrote: > shafik wrote: > > @tahonermann I feel like we should have a default member initializ

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

erichkeane added a comment. In D146358#4357106 , @hazohelet wrote: > In D146358#4352792 , @erichkeane > wrote: > >> In D146358#4351787 , @hazohelet >> wrote: >> >>> In D

[PATCH] D150894: [CUDA] provide wrapper functions for new NVCC builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4450285bd740: [CUDA] provide wrapper functions for new NVCC builtins. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 4450285 - [CUDA] provide wrapper functions for new NVCC builtins.

Author: Artem Belevich Date: 2023-05-19T11:48:08-07:00 New Revision: 4450285bd74079bf87ba7b824a8dec8dcfb586ef URL: https://github.com/llvm/llvm-project/commit/4450285bd74079bf87ba7b824a8dec8dcfb586ef DIFF: https://github.com/llvm/llvm-project/commit/4450285bd74079bf87ba7b824a8dec8dcfb586ef.diff

[PATCH] D137872: Implement lambdas with inalloca parameters by forwarding to function without inalloca calling convention.

efriedma added a comment. In D137872#4348314 , @akhuang wrote: > In D137872#4327615 , @efriedma > wrote: > >> I'm having a bit of trouble following how exactly the thunk creation is >> working here... do we gene

[PATCH] D150894: [CUDA] provide wrapper functions for new NVCC builtins.

tra updated this revision to Diff 523881. tra added a comment. typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150894/new/ https://reviews.llvm.org/D150894 Files: clang/lib/Headers/__clang_cuda_intrinsics.h Index: clang/lib/Headers/__c

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 added a comment. In D148089#4357219 , @rjmccall wrote: > Sergei, feel free to start landing patches like this one that were already > approved. You don't need the entire sequence to be approved first. Ah, OK! I thought it is required. Re

[PATCH] D150894: [CUDA] provide wrapper functions for new NVCC builtins.

tra updated this revision to Diff 523879. tra added a comment. Added __nv_associate_access_property_impl() stub. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150894/new/ https://reviews.llvm.org/D150894 Files: clang/lib/Headers/__clang_cuda_int

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

hokein added a comment. Thanks for the review. In D150955#4356580 , @aaron.ballman wrote: > LGTM assuming CI is okay with it -- the patch did not apply so precommit CI > never ran. I'm surprised no tests break as a result of this because it > changes

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

hokein updated this revision to Diff 523875. hokein added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150955/new/ https://reviews.llvm.org/D150955 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ComputeDependence

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new/ https://reviews.llvm.org/D148851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D150965: [HIP] Allow std::malloc in device function

tra added inline comments. Comment at: clang/test/Headers/Inputs/include/math.h:108-109 long lroundf(float __a); -int max(int __a, int __b); -int min(int __a, int __b); double modf(double __a, double *__b); yaxunl wrote: > tra wrote: > > Why were these function

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

rjmccall added a comment. Sergei, feel free to start landing patches like this one that were already approved. You don't need the entire sequence to be approved first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

tra added a comment. The code changes look OK to me. Whether allowing FP for clang builtins is OK -- I have no idea, especially for the c11 ones. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150985/new/ https://reviews.llvm.org/D150985 ___

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa62e205254c0: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code… (authored by hokein). Repository: rG LLVM Github Mon

[clang] a62e205 - [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

Author: Haojian Wu Date: 2023-05-19T20:24:54+02:00 New Revision: a62e205254c0f482ba38bacc1f7f6927e6bc6375 URL: https://github.com/llvm/llvm-project/commit/a62e205254c0f482ba38bacc1f7f6927e6bc6375 DIFF: https://github.com/llvm/llvm-project/commit/a62e205254c0f482ba38bacc1f7f6927e6bc6375.diff LO

[PATCH] D149612: [Sema] avoid merge error type

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think this is looking fine to me. Thanks for your patience on this, I know it was a tough review. Comment at: clang/lib/Sema/SemaDecl.cpp:4399

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D150212: [clang][Sema] Improve diagnostics for auto return type

yaxunl added a comment. ping The pre-merge check failure seems not related to the patch. Other patches also fail the same way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150212/new/ https://reviews.llvm.org/D150212 ___ cfe-commits mailin

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 updated this revision to Diff 523870. HerrCai0907 added a comment. revert untill first version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 Files: clang/docs/ReleaseNotes.rst clang/lib/

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

hokein added a comment. Thanks for the fast review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150948/new/ https://reviews.llvm.org/D150948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

hokein updated this revision to Diff 523868. hokein added a comment. add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150948/new/ https://reviews.llvm.org/D150948 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDecl.cpp

[PATCH] D150985: [clang] Allow fp in atomic fetch max/min builtins

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra. Herald added subscribers: kerbowa, jvesely. Herald added a project: All. yaxunl requested review of this revision. LLVM IR already allows floating point type in atomicrmw. Update clang atomic fetch max/min builtins to accept floa

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523867. eopXD added a comment. Add unsigned cast to eliminate compile warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 523865. eopXD added a comment. Add unsigned cast to eliminate compile warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files: clang/include/clang/Basic/riscv_

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

rjmccall added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:316 + unsigned getInterestingIdentifierID() { +if (ObjCOrBuiltinID >= 1341 && ObjCOrBuiltinID < 1343) + return ObjCOrBuiltinID; This is closer to the right approach

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

dblaikie added a comment. In D149677#4356863 , @aaron.ballman wrote: > In D149677#4350337 , @li.zhe.hua > wrote: > >> In D149677#4349523 , >> @aaron.ballman wrote: >> >

[PATCH] D150965: [HIP] Allow std::malloc in device function

yaxunl added inline comments. Comment at: clang/test/Headers/Inputs/include/math.h:108-109 long lroundf(float __a); -int max(int __a, int __b); -int min(int __a, int __b); double modf(double __a, double *__b); tra wrote: > Why were these functions removed? It d

[clang] 6963c61 - [NVPTX/CUDA] added an optional src_size argument to __nvvm_cp_async*

Author: Artem Belevich Date: 2023-05-19T10:59:36-07:00 New Revision: 6963c61f0f6e4be2039cb45e824ea1e83a8f1526 URL: https://github.com/llvm/llvm-project/commit/6963c61f0f6e4be2039cb45e824ea1e83a8f1526 DIFF: https://github.com/llvm/llvm-project/commit/6963c61f0f6e4be2039cb45e824ea1e83a8f1526.diff

[PATCH] D150820: [NVPTX, CUDA] added optional src_size argument to __nvvm_cp_async*

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6963c61f0f6e: [NVPTX/CUDA] added an optional src_size argument to __nvvm_cp_async* (authored by tra). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 523862. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 523861. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ https://reviews.llvm.org/D147916 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/Sema/SemaChecking.

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

hazohelet added a comment. In D146358#4352792 , @erichkeane wrote: > In D146358#4351787 , @hazohelet > wrote: > >> In D146358#4350810 , @erichkeane >> wrote: >> >>> Our

[PATCH] D148505: Allow `__attribute__((warn_unused))` on individual constructors

aaron.ballman added a comment. In D148505#4356951 , @erichkeane wrote: > I'm still on the fence. I think properly documenting all of this entire > attribute would make me more comfortable here, particularly since it will > allow GCC to follow us easil

[PATCH] D150752: [BOLT][CMake] Use correct output paths and passthrough necessary options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6e3375f12e: [BOLT][CMake] Use correct output paths and passthrough necessary options (authored by phosek). Repository: rG LLVM Github Monorepo

[clang] 9e6e337 - [BOLT][CMake] Use correct output paths and passthrough necessary options

Author: Petr Hosek Date: 2023-05-19T17:43:27Z New Revision: 9e6e3375f12e5e61dd2e371d94c263e3862f58a1 URL: https://github.com/llvm/llvm-project/commit/9e6e3375f12e5e61dd2e371d94c263e3862f58a1 DIFF: https://github.com/llvm/llvm-project/commit/9e6e3375f12e5e61dd2e371d94c263e3862f58a1.diff LOG: [B

[PATCH] D150752: [BOLT][CMake] Use correct output paths and passthrough necessary options

phosek added inline comments. Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() michaelplatings wrote: > phosek wrote: > > michaelplatings wrote: > > > michaelplatings wrote: > > > > T

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

zequanwu added a comment. In D150817#4356305 , @TWeaver wrote: > Hello and good afternoon from the UK, > > I believe this patch has caused failures on the following buildbot: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21493 > > are you able t

[clang] fe69bb6 - Fix tests failure on 75993812d5c1f269b781c34987748f2a792a579d

Author: Zequan Wu Date: 2023-05-19T13:34:40-04:00 New Revision: fe69bb64415ef6fe01ebbb1d1a801e85bd6bd879 URL: https://github.com/llvm/llvm-project/commit/fe69bb64415ef6fe01ebbb1d1a801e85bd6bd879 DIFF: https://github.com/llvm/llvm-project/commit/fe69bb64415ef6fe01ebbb1d1a801e85bd6bd879.diff LOG

[PATCH] D148723: [clang] Fix comdat for InlineBuiltin declarations

efriedma added a comment. I spoke a little loosely when I said "C++ code". I meant "code using C++ 'inline' semantics", which includes C code on Windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148723/new/ https://reviews.llvm.org/D148723 ___

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD updated this revision to Diff 523853. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD updated this revision to Diff 523852. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

eopXD updated this revision to Diff 523851. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

eopXD updated this revision to Diff 523850. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147912/new/ https://reviews.llvm.org/D147912 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

eopXD updated this revision to Diff 523849. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147911/new/ https://reviews.llvm.org/D147911 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

eopXD updated this revision to Diff 523848. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774 Files: clang/include/clang/Basic/riscv_vector.td clang/lib/CodeGen/CGBuiltin.

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 523847. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/riscv_v

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523846. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatt

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 523845. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

barannikov88 updated this revision to Diff 523844. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150178/new/ https://reviews.llvm.org/D150178 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523843. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/TargetInfo.

  1   2   3   >