erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
I think this is looking fine to me. Thanks for your patience on this, I know
it was a tough review.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:4399
bool MergeTypeWithOld) {
- if (New->isInvalidDecl() || Old->isInvalidDecl())
+ if (New->isInvalidDecl() || Old->isInvalidDecl() ||
New->getType()->containsErrors() || Old->getType()->containsErrors())
return;
----------------
NIT: 80 line character limit per line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149612/new/
https://reviews.llvm.org/D149612
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
