[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7d2409bac7f: [clang] [Driver] Do not transform explicit --config filename (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] a7d2409 - [clang] [Driver] Do not transform explicit --config filename

Author: Michał Górny Date: 2022-09-20T07:58:27+02:00 New Revision: a7d2409bac7fd9ef6b8c362f1ab54a9b6339a69a URL: https://github.com/llvm/llvm-project/commit/a7d2409bac7fd9ef6b8c362f1ab54a9b6339a69a DIFF: https://github.com/llvm/llvm-project/commit/a7d2409bac7fd9ef6b8c362f1ab54a9b6339a69a.diff

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

asb added a comment. It looks like they're still missing in this updated version of the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

sepavloff accepted this revision. sepavloff added a comment. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134208/new/ https://reviews.llvm.org/D134208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D133574: [C2x] reject type definitions in offsetof

inclyc updated this revision to Diff 461463. inclyc added a comment. Switch back to RAIIObject. Currently clang could not generate diagnostic messages for nested definitions in C++. I believe using RAIIObject here is logically correct, but in C++ mode, `ActOnTag` returns `nullptr`, and the commen

[PATCH] D133468: [clang] Implement divergence for TypedefType and UsingType

davrec added a comment. If I understand this correctly: whenever isDivergent() is true, `getDecl()` or `getFoundDecl()` is an arbitrary choice between multiple candidate (re)declarations of a typedef or using decl. In particular it will be the first redeclaration, //even though each different

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

rjmccall accepted this revision. rjmccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133583/new/ https://reviews.llvm.org/D133583 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

jpenix-quic added inline comments. Comment at: flang/test/Driver/emit-mlir.f90:16 ! CHECK-NEXT: } +! CHECK-NEXT: fir.global @_QQEnvironmentDefaults constant : !fir.ref, !fir.ref> { +! CHECK-NEXT: %[[VAL_0:.*]] = fir.zero_bits !fir.ref, !fir.ref> peixi

[PATCH] D134249: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

ChuanqiXu accepted this revision. ChuanqiXu added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Serialization/ModuleManager.cpp:284-286 for (ModuleIterator victim = First; victim != Last; ++victim) { Modules.erase(victim->File);

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

This revision was automatically updated to reflect the committed changes. Closed by commit rG46bb4b99ae9f: [X86][fastcall][vectorcall] Move capability check before free register update (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 46bb4b9 - [X86][fastcall][vectorcall] Move capability check before free register update

Author: Phoebe Wang Date: 2022-09-20T09:18:23+08:00 New Revision: 46bb4b99ae9f7b043c58d0b17df031bd02ccfd01 URL: https://github.com/llvm/llvm-project/commit/46bb4b99ae9f7b043c58d0b17df031bd02ccfd01 DIFF: https://github.com/llvm/llvm-project/commit/46bb4b99ae9f7b043c58d0b17df031bd02ccfd01.diff L

[PATCH] D134249: [modules] Fix error "malformed or corrupted AST file: 'SourceLocation remap refers to unknown module...'".

vsapsai created this revision. vsapsai added reviewers: bnbarham, ChuanqiXu. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a framework can be found at a new lo

[PATCH] D134248: [clang][modules][deps] Preserve module map load order

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added subscribers: ributzka, arphaman. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In `ASTWriter`

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

jansvoboda11 updated this revision to Diff 461432. jansvoboda11 added a comment. Fix failing test by undoing some API changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134224/new/ https://reviews.llvm.org/D134224 Files: clang/include/clang/L

[PATCH] D134222: [clang][deps] Report module map describing compiled module

jansvoboda11 updated this revision to Diff 461431. jansvoboda11 added a comment. Implement suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134222/new/ https://reviews.llvm.org/D134222 Files: clang/include/clang/Basic/LangOptions.h cl

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

abhinavgaba added inline comments. Comment at: clang/test/OpenMP/target_has_device_addr_codegen.cpp:317 +// CHECK-NEXT:store [10 x i32]* [[AA]], [10 x i32]** [[RAA]], align 8 +// CHECK-NEXT:[[TMP2:%.*]] = load i32*, i32** [[K]], align 8 +// CHECK-NEXT:[[TMP3:%.*]] = g

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

efriedma added a comment. These patches are hard to review, yes; the reviewer has to go through and verify for each function that the substitutes you've written actually match the C library semantics. (It's very easy to make mistakes with that sort of thing.) On that front, I'm pretty sure the

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

sammccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:4591 Actions.CodeCompleteTag(getCurScope(), DeclSpec::TST_enum); +DS.SetTypeSpecError(); return; this is a bit unusual, usually parse() functions just stop after hitting CC,

[PATCH] D134222: [clang][deps] Report module map describing compiled module

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:194 +const FileEntry *CurrentModMap = +PP.getHeaderSearchInfo().getModuleMap().getModuleMapFileForUniquing( +CurrentModule); I think

[PATCH] D134243: Don't crash when code completing `using enum ^Foo`.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a subscriber: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/clangd/clangd/i

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

ronlieb added a comment. seeing a buildbot failure on amdgpu bot https://lab.llvm.org/buildbot/#/builders/193/builds/18788 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134186/new/ https://reviews.llvm.org/D134186 _

[PATCH] D132711: [HLSL] add sqrt library function

bob80905 updated this revision to Diff 461405. bob80905 added a comment. rebase rebasing review to latest origin/main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132711/new/ https://reviews.llvm.org/D132711 Files: clang/test/CodeGenHLSL/built

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 461403. ayzhao added a comment. remove extra blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw created this revision. Herald added a project: All. brettw requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The *Info object (for the copy of the AST") constructors had many duplicated variants. Many of the variants seeme

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

ayzhao updated this revision to Diff 461401. ayzhao added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

brettw updated this revision to Diff 461397. brettw marked an inline comment as done. brettw added a comment. Comment addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134225/new/ https://reviews.llvm.org/D134225 Files: clang-tools-extra/clang-doc/Representation.h clang-tools

[PATCH] D134233: [clang-format] Wrap inserted braces only if preceded by comments

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, curdeius. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D134231: [clang][C++20] p0960 Allow initializing aggregates from a parenthesized list of values

ecatmur created this revision. ecatmur added a reviewer: clang-language-wg. Herald added subscribers: ChuanqiXu, JDevlieghere. Herald added a project: All. ecatmur requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - p0960 Allow initializing a

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

paulkirth added a comment. Also, can you take a look at the premerge check failure? it looks like it had trouble applying your patch, so you may need to rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134225/new/ https://reviews.llvm.org/D13

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. Thanks for the code cleanup. The patch is LGTM, with some small nits. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:240 +TypeInfo getTypeInfoForType(const QualT

[clang] 7349084 - [clang-format] Update removed brace's next token's WhitespaceRange

Author: owenca Date: 2022-09-19T15:02:08-07:00 New Revision: 7349084e7afc55fc734922a9facd76316f2977b1 URL: https://github.com/llvm/llvm-project/commit/7349084e7afc55fc734922a9facd76316f2977b1 DIFF: https://github.com/llvm/llvm-project/commit/7349084e7afc55fc734922a9facd76316f2977b1.diff LOG: [

[PATCH] D134146: [clang-format] Update removed brace's next token's WhitespaceRange

This revision was automatically updated to reflect the committed changes. Closed by commit rG7349084e7afc: [clang-format] Update removed brace's next token's WhitespaceRange (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134146/

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeaa7b324d5a2: [clang-doc] Add support for explicitly typed enums (authored by brettw, committed by paulkirth). Repository: rG LLVM Github Monorepo

[clang-tools-extra] eaa7b32 - [clang-doc] Add support for explicitly typed enums

Author: Brett Wilson Date: 2022-09-19T21:54:41Z New Revision: eaa7b324d5a272dc640cfc4162b746ac5341ccbd URL: https://github.com/llvm/llvm-project/commit/eaa7b324d5a272dc640cfc4162b746ac5341ccbd DIFF: https://github.com/llvm/llvm-project/commit/eaa7b324d5a272dc640cfc4162b746ac5341ccbd.diff LOG:

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134208/new/ https://reviews.llvm.org/D134208 ___ cfe-commits mailing list cfe-comm

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461366. brettw added a comment. Clang-formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Several different places in the code had similar computations for the paramet

[PATCH] D134224: [clang][modules][deps] Report modulemaps describing excluded headers

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese, rsmith. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Module map file

[PATCH] D130130: [clang-tidy] Add an IgnoreMacros option to readability-avoid-const-params-in-decls

thomasetter added a comment. Friendly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130130/new/ https://reviews.llvm.org/D130130 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. One test that i need to have (that might actually end up conflicting with the above mentioned), is a reproducer that has a `ClassTemplateDecl` that is its own friend. So something like: template class C requires ...> struct S { template class C requires ..

[clang] 368b683 - [Clang] Implement fix for DR2628

Author: Roy Jacobson Date: 2022-09-20T00:07:41+03:00 New Revision: 368b6832de33b366d4eb155f940e7476daace6a8 URL: https://github.com/llvm/llvm-project/commit/368b6832de33b366d4eb155f940e7476daace6a8 DIFF: https://github.com/llvm/llvm-project/commit/368b6832de33b366d4eb155f940e7476daace6a8.diff

[PATCH] D134145: [Clang] Implement fix for DR2628

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG368b6832de33: [Clang] Implement fix for DR2628 (authored by royjacobson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson updated this revision to Diff 461352. royjacobson added a comment. rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134145/new/ https://reviews.llvm.org/D134145 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaTemp

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson added inline comments. Comment at: clang/test/CXX/drs/dr26xx.cpp:12 +void f() { + foo fooable; // expected-error {{call to deleted}} +} erichkeane wrote: > That does look much nicer, thanks! I qualified it with DR2628 because the DR tests can get p

[PATCH] D134145: [Clang] Implement fix for DR2628

royjacobson updated this revision to Diff 461351. royjacobson edited the summary of this revision. royjacobson added a comment. Add release note, slightly nicer test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134145/new/ https://reviews.llvm.org

[PATCH] D134222: [clang][deps] Report module map describing compiled module

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes compil

[PATCH] D134186: [Clang][OpenMP] Codegen generation for has_device_addr claues.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134186/new/ https://reviews.llvm.org/D134186 ___

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

Izaron updated this revision to Diff 461347. Izaron added a comment. Fix corresponding FixIt clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134207/new/ https://reviews.llvm.org/D134207 Files: clang/include/clang/Basic/DiagnosticParseKi

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames updated this revision to Diff 461345. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133443/new/ https://reviews.llvm.org/D133443 Files: clang/test/Preprocessor/riscv-target-features.c llvm/docs/RISCVUsage.rst llvm/lib/Support/RISCVISAInfo.cpp llvm/lib/Target/RISCV/RISCV.td

[PATCH] D133443: [RISCV][MC] Add support for experimental Zawrs extension

reames added a comment. In D133443#3795603 , @asb wrote: > Everything that's in this patch looks good to me - it's just missing some > simple round-trip tests in the style of rv32zicboz-valid.s (and perhaps an > -invalid.s that shows a sensible error me

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

paulkirth added a comment. Sorry, it looks like a pre-submit formatting check failed. can you `git clang-format HEAD~` and re-upload? I can land your change after that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 _

[clang] 955d7c3 - [clang] Add support for #pragma strict_gs_check

Author: David Majnemer Date: 2022-09-19T20:07:14Z New Revision: 955d7c39ff74868a28c848a0462ff41be972043e URL: https://github.com/llvm/llvm-project/commit/955d7c39ff74868a28c848a0462ff41be972043e DIFF: https://github.com/llvm/llvm-project/commit/955d7c39ff74868a28c848a0462ff41be972043e.diff LOG

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added a comment. LGTM, but please wait a bit to land for the codegen reviewers to weigh in on those tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 __

[PATCH] D134136: [Clang] Support constexpr for builtin fmax, fmin, ilogb, logb, scalbn

Izaron updated this revision to Diff 461312. Izaron added a comment. Removed whitespaces in comments. P.S. I wonder if smaller review requests will make things better? Say a review request for `fmax`+`fmin`, then a new one for `ilogb`+`logb`, then for `scalbn`. This may lead to a more understand

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGb647f13226b4: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D134189?vs=461286&id=461310#toc Repository:

[clang] b647f13 - [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

Author: Joseph Huber Date: 2022-09-19T14:38:44-05:00 New Revision: b647f13226b4b30b8b0cb6e9baebc7a01558cde4 URL: https://github.com/llvm/llvm-project/commit/b647f13226b4b30b8b0cb6e9baebc7a01558cde4 DIFF: https://github.com/llvm/llvm-project/commit/b647f13226b4b30b8b0cb6e9baebc7a01558cde4.diff

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae updated this revision to Diff 461308. python3kgae added a comment. Limit max bitint width to 64 for HLSL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/lib/Basic/Targets/Direc

[PATCH] D134208: [clang] [Driver] Do not transform explicit --config filename

mgorny created this revision. mgorny added reviewers: sepavloff, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. mgorny requested review of this revision. Disable transformations (e.g. attempting to replace target architecture) in the config filename that is passed exp

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added a comment. In D128465#3800479 , @andrewrk wrote: > if(LLVM_ENABLE_ZSTD) > list(APPEND imported_libs zstd::libzstd_shared) > endif() > > This hard codes shared linking which breaks the use case of static linking > LLVM. This was addr

[PATCH] D133583: [clang][ubsan] Fix __builtin_assume_aligned incorrect type descriptor and C++ object polymorphic address

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please give @rjmccall another day to chime in with any concerns he has. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133583/

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

Izaron added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:298-299 "and have an empty entry in the selector">; -def err_switch_label_end_of_compound_statement : Error< - "label at end of switch compound statement: expected statement">; def ex

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. Compiler infrastructure should not assume the existence of a Linux distribution. The portable way is simple and can easily be supported. One should be able to install `$prefix/lib/libzstd.a` and `$prefix/include/zstd.h`, then have that prefix searched as part of the st

[PATCH] D134207: [Clang] Support case and default labels at end of compound statement

Izaron created this revision. Izaron added reviewers: clang-language-wg, aaron.ballman, cor3ntin. Herald added a project: All. Izaron requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Direct continuation of https://reviews.llvm.org/D133887

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. zstd provides GNU Makefile, CMake, and Meson. The CMake files are only installed when configured with CMake. Debian and Ubuntu lack such files. The pkg-config file libzstd.pc is probably the most portable file. (I have also used it for a binutils-gdb patch.) I think we

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Adding some codegen reviewers for awareness. Comment at: clang/lib/Basic/Targets/DirectX.h:66 + bool hasBitIntType() const override { return true; } bool hasFeature(StringRef Feature) const

[clang] 88210b8 - [clang][dataflow] Refactor `clang/Analysis/FlowSensitive/MatchSwitchTest.cpp`.

Author: Wei Yi Tee Date: 2022-09-19T19:10:41Z New Revision: 88210b81eed803598afeeaa2a60eb26ddbb65435 URL: https://github.com/llvm/llvm-project/commit/88210b81eed803598afeeaa2a60eb26ddbb65435 DIFF: https://github.com/llvm/llvm-project/commit/88210b81eed803598afeeaa2a60eb26ddbb65435.diff LOG: [c

[PATCH] D133935: [clang][dataflow] Refactor `clang/Analysis/FlowSensitive/MatchSwitchTest.cpp`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG88210b81eed8: [clang][dataflow] Refactor `clang/Analysis/FlowSensitive/MatchSwitchTest.cpp`. (authored by wyt). Changed prior to commit: https://r

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. if(LLVM_ENABLE_ZSTD) list(APPEND imported_libs zstd::libzstd_shared) endif() This hard codes shared linking which breaks the use case of static linking LLVM. Also LLVM needs to now include a Findzstd.cmake file or else we get this error: CMake Error at cmake/

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 marked 3 inline comments as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Action.cpp:320 +if (OKind & Mask) + DeviceOffloadKinds.push_back(OKind); +} tra wrote: > It would be good to clear processed bits in `Mask` and then ass

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a few nits. Comment at: clang/include/clang/Driver/Action.h:304 +/// Add a action along with the associated toolchain, bound arch, and +/// offload kinds. -

[clang] 41d52c5 - [clang][dataflow] Modify `transfer` in `DataflowModel` to take `CFGElement` as input instead of `Stmt`.

Author: Wei Yi Tee Date: 2022-09-19T18:40:29Z New Revision: 41d52c5a7f7ad1acf8e84ad6d7f04813c1a5a7ec URL: https://github.com/llvm/llvm-project/commit/41d52c5a7f7ad1acf8e84ad6d7f04813c1a5a7ec DIFF: https://github.com/llvm/llvm-project/commit/41d52c5a7f7ad1acf8e84ad6d7f04813c1a5a7ec.diff LOG: [c

[PATCH] D133933: [clang][dataflow] Modify `transfer` in `DataflowModel` to take `CFGElement` as input instead of `Stmt`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG41d52c5a7f7a: [clang][dataflow] Modify `transfer` in `DataflowModel` to take `CFGElement` as… (authored by wyt). Repository: rG LLVM Github Monore

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4391 DDep.add(*PackagerAction, *C.getSingleOffloadToolChain(), - nullptr, Action::OFK_None); + nullptr, C.getActiveOffloadKinds()); } -

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

jhuber6 updated this revision to Diff 461286. jhuber6 added a comment. Mixing the concept of the mask passing via an `unsigned` and a single enum value was incorrect. Add a new interface that accepts a mask and adds all active values instead. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D133931: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `clang/Analysis/FlowSensitive`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf94c52e35f2: [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const… (authored by wyt). Changed prior to commit: https://re

[clang] cf94c52 - [clang][dataflow] Replace `transfer(const Stmt *, ...)` with `transfer(const CFGElement *, ...)` in `clang/Analysis/FlowSensitive`.

Author: Wei Yi Tee Date: 2022-09-19T18:06:57Z New Revision: cf94c52e35f2daf4e4caaeb93648f4b5413b557a URL: https://github.com/llvm/llvm-project/commit/cf94c52e35f2daf4e4caaeb93648f4b5413b557a DIFF: https://github.com/llvm/llvm-project/commit/cf94c52e35f2daf4e4caaeb93648f4b5413b557a.diff LOG: [c

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

compnerd added a comment. I don't see anything wrong with this change per se, but I'm conflicted on the name of the variable. These are not standard variables but are encroaching on the CMake namespace. What happens if upstream decides to use these names? I think that we should keep the name

[PATCH] D133993: [HLSL] Remove global ctor/dtor variable for non-lib profile.

python3kgae updated this revision to Diff 461271. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Add test for dtor in lib. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133993/new/ https://reviews.llvm.org/D133993 Files: cl

[PATCH] D134189: [CUDA][HIP] Fix new driver crashing when using -save-temps in RDC-mode

tra added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4391 DDep.add(*PackagerAction, *C.getSingleOffloadToolChain(), - nullptr, Action::OFK_None); + nullptr, C.getActiveOffloadKinds()); } `getActiveOffloadKinds` return

[clang] 7538b36 - [clang][dataflow] Replace usage of deprecated functions with the optional check

Author: Wei Yi Tee Date: 2022-09-19T17:33:25Z New Revision: 7538b3604519b03d32221cdcc346cc1c181b50fb URL: https://github.com/llvm/llvm-project/commit/7538b3604519b03d32221cdcc346cc1c181b50fb DIFF: https://github.com/llvm/llvm-project/commit/7538b3604519b03d32221cdcc346cc1c181b50fb.diff LOG: [c

[PATCH] D133930: [clang][dataflow] Replace usage of deprecated functions with the optional check

This revision was automatically updated to reflect the committed changes. Closed by commit rG7538b3604519: [clang][dataflow] Replace usage of deprecated functions with the optional check (authored by wyt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

paulkirth accepted this revision. paulkirth added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 ___ cfe-commits mailing list cfe-co

[clang] e782d9a - [clang] Fix a nullptr-access crash in CheckTemplateArgument.

Author: Haojian Wu Date: 2022-09-19T19:18:50+02:00 New Revision: e782d9a4a49c8aaf65bea4209cb6a8e7739526ac URL: https://github.com/llvm/llvm-project/commit/e782d9a4a49c8aaf65bea4209cb6a8e7739526ac DIFF: https://github.com/llvm/llvm-project/commit/e782d9a4a49c8aaf65bea4209cb6a8e7739526ac.diff LO

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe782d9a4a49c: [clang] Fix a nullptr-access crash in CheckTemplateArgument. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

hokein added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:6960 +if (ParamType.isNull()) + return ExprError(); // CheckNonTypeTemplateParameterType will produce a diagnostic if there's adamcz wrote: > So this can only happen when Resu

[PATCH] D134180: [clang] Fix a nullptr-access crash in CheckTemplateArgument.

hokein updated this revision to Diff 461260. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134180/new/ https://reviews.llvm.org/D134180 Files: clang/lib/Sem

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record &R, llvm::APSInt &Field, llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > brettw wrote: > > paulkirth wrote: >

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461259. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-

[PATCH] D134127: [ARM] Check target feature support for __builtin_arm_crc*

MaskRay added a comment. In D134127#3798442 , @dmgreen wrote: > This looks like a subset of D133359 ? D133359 looks like it is for AArch64 and may change the diagnostic in a more aggre

[clang-tools-extra] 8edce2f - [test][clangd] Join back -Xclang and -undef

Author: Vitaly Buka Date: 2022-09-19T10:11:37-07:00 New Revision: 8edce2ff049d2fc635fc20c658daa283661a9958 URL: https://github.com/llvm/llvm-project/commit/8edce2ff049d2fc635fc20c658daa283661a9958 DIFF: https://github.com/llvm/llvm-project/commit/8edce2ff049d2fc635fc20c658daa283661a9958.diff L

[PATCH] D133668: [HLSL] Use _BitInt(16) for int16_t to avoid promote to int.

python3kgae updated this revision to Diff 461251. python3kgae added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133668/new/ https://reviews.llvm.org/D133668 Files: clang/lib/Basic/Targets/DirectX.h clang/li

[PATCH] D134191: [clang] Make config-related options CoreOptions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdaebf2c13ce2: [clang] Make config-related options CoreOptions (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Mono

[clang] daebf2c - [clang] Make config-related options CoreOptions

Author: Michał Górny Date: 2022-09-19T18:58:09+02:00 New Revision: daebf2c13ce27ac6a7403525cc7fcbc063eb892e URL: https://github.com/llvm/llvm-project/commit/daebf2c13ce27ac6a7403525cc7fcbc063eb892e DIFF: https://github.com/llvm/llvm-project/commit/daebf2c13ce27ac6a7403525cc7fcbc063eb892e.diff

[PATCH] D134191: [clang] Make config-related options CoreOptions

mgorny added a comment. In D134191#3799841 , @MaskRay wrote: > They don't need to be `NoXarchOption` if I am not mistaken. I don't know about that. The comment on top says "The option is a "driver"-only option, and should not be forwarded to other tools

[clang] 95b3947 - [clang-format] JSON formatting add new option for controlling newlines in json arrays

Author: mydeveloperday Date: 2022-09-19T17:54:39+01:00 New Revision: 95b39471110680f609cf56f5babf031a1c855d64 URL: https://github.com/llvm/llvm-project/commit/95b39471110680f609cf56f5babf031a1c855d64 DIFF: https://github.com/llvm/llvm-project/commit/95b39471110680f609cf56f5babf031a1c855d64.diff

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rG95b394711106: [clang-format] JSON formatting add new option for controlling newlines in json… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 649a597 - [clang] Allow vector of BitInt

Author: Xiang Li Date: 2022-09-19T09:26:56-07:00 New Revision: 649a59712ffbc937174268d04ee9a8885f572e2a URL: https://github.com/llvm/llvm-project/commit/649a59712ffbc937174268d04ee9a8885f572e2a DIFF: https://github.com/llvm/llvm-project/commit/649a59712ffbc937174268d04ee9a8885f572e2a.diff LOG:

[PATCH] D133634: [clang] Allow vector of BitInt

This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG649a59712ffb: [clang] Allow vector of BitInt (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D133920: [X86][fastcall][vectorcall] Move capability check before free register update

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133920/new/ https://reviews.llvm.org/D133920

[PATCH] D133711: [Sema] Reject array element types whose sizes aren't a multiple of their alignments

rnk accepted this revision. rnk added a comment. Sound like a good plan. 👍 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133711/new/ https://reviews.llvm.org/D133711 ___ cfe-commits mailing list cfe-comm

  1   2   >