[PATCH] D126291: [flang][Driver] Update link job on windows

mstorsjo added a comment. In D126291#3562471 , @mmuetzel wrote: > Found why I thought building on Windows wasn't supported: > https://github.com/llvm/llvm-project/blob/main/flang/README.md?plain=1#L153 > >> The code does not compile with Windows and a com

[PATCH] D126878: [analyzer] Remove NotifyAssumeClients

martong added a comment. In D126878#3553184 , @steakhal wrote: > Measure if it changes any reports. Results did not change, we had equal number of reports in all projects. Other stat numbers are also very close. F23339654: stats.html

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf66f4d3b07b2: [analyzer] Track assume call stack to detect fixpoint (authored by martong). Changed prior to commit: https://reviews.llvm.org/D1265

[clang] f66f4d3 - [analyzer] Track assume call stack to detect fixpoint

Author: Gabor Marton Date: 2022-06-07T08:36:11+02:00 New Revision: f66f4d3b07b2226cf14bd7a0f2056dfb2d26a89f URL: https://github.com/llvm/llvm-project/commit/f66f4d3b07b2226cf14bd7a0f2056dfb2d26a89f DIFF: https://github.com/llvm/llvm-project/commit/f66f4d3b07b2226cf14bd7a0f2056dfb2d26a89f.diff

[PATCH] D127184: [clangd] Add to header map

falbrechtskirchinger created this revision. falbrechtskirchinger added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. falbrechtskirchinger requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D127183: [clang-format] Skip parsing a block if it's nested too deep

owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't parse bl

[PATCH] D126560: [analyzer] Track assume call stack to detect fixpoint

martong added a comment. Measurement results on the last diff looks good. F23339447: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126560/new/ https://reviews.llvm.org/D126560 ___

[PATCH] D125742: Minor refactor of CanonicalIncludes::addSystemHeadersMapping.

ilya-biryukov added a comment. Sorry about the delay. Thanks for the cleanup! I only have a few minor comments here. Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.cpp:762 + static const auto *SystemHeaderMap = [] { +const int Size = sizeof(IncludeMappings)

[PATCH] D126291: [flang][Driver] Update link job on windows

mmuetzel added a comment. In D126291#3561854 , @Meinersbur wrote: > In D126291#3555639 , @awarzynski > wrote: > >> In D126291#391 , @mmuetzel >> wrote: >> >>> ISTR,

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

Bigcheese created this revision. Bigcheese added reviewers: vsapsai, bruno. Bigcheese added a project: clang-modules. Herald added a project: All. Bigcheese requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently we do not in general merg

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

aheejin added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:190 +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_s_i16x8, "V8sV16ScV16Sc", "nc", "relaxed-simd") +TARGET_BUILTIN(__builtin_wasm_dot_i8x16_i7x16_add_s_i32x4, "V4iV16ScV16Sc", "nc", "re

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

pcwang-thead added a comment. Ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D119296: KCFI sanitizer

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Please don't land the patch this state. There are several questions which should be sorted out first. a) Naming About the 'k' prefix: this is generic and does not need to be coupl

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars

PRESIDENT810 updated this revision to Diff 434691. PRESIDENT810 retitled this revision from "[clang-diff] Fix getStmtValue when dealing with wide chars" to "[clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars". PRESIDENT810 edited the summary of this revision. CHANGES SINCE L

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

PRESIDENT810 updated this revision to Diff 434690. PRESIDENT810 added a comment. More refactoring following Johannes's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126651/new/ https://reviews.llvm.org/D126651 Files: clang/lib/Tooling/ASTDiff/ASTDiff.cpp clang/test/Tooli

[PATCH] D126818: Itanium ABI: Implement mangling for constrained friends

tahonermann added a comment. > Note we might be confused, the parens there aren't completely clear as to > what your intent is. Well, I know that I'm confused and not clear what my intent is :) I asked the question because there appears to be an asymmetry between (temp.friend)p9 sentence 1

[PATCH] D127177: Add checks for -lresolv to sanitizer-ld test. These were missed in https://reviews.llvm.org/D127145.

kda created this revision. kda added a reviewer: vitalybuka. Herald added a subscriber: cryptoad. Herald added a project: All. kda requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 marked an inline comment as done. benshi001 added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:507 +// Add user specified linker script. +const Arg *LDS = Args.getLastArg(options::OPT_T); +if (LDS) { MaskRay wrote: > Just

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 434684. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Driver/avr-toolchain.c Index: clang/t

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

kaz7 added a comment. Thank you, @chapuni and @ahatanak, for quick fixing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125839/new/ https://reviews.llvm.org/D125839 ___ cfe-commits mailing list cfe-comm

[clang] a4f8590 - [clang] Allow consteval functions in default arguments

Author: Evgeny Shulgin Date: 2022-06-07T10:54:37+08:00 New Revision: a4f8590247264b9c3121f48dd5b3db707c934ba2 URL: https://github.com/llvm/llvm-project/commit/a4f8590247264b9c3121f48dd5b3db707c934ba2 DIFF: https://github.com/llvm/llvm-project/commit/a4f8590247264b9c3121f48dd5b3db707c934ba2.diff

[PATCH] D119646: [clang] Allow consteval functions in default arguments

ChuanqiXu updated this revision to Diff 434680. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119646/new/ https://reviews.llvm.org/D119646 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Decl.cpp clang/lib/Sema/SemaExpr.cpp clang/te

[PATCH] D126192: [Driver] Improve linking options for target AVR

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AVR.cpp:507 +// Add user specified linker script. +const Arg *LDS = Args.getLastArg(options::OPT_T); +if (LDS) { Just do Args.AddAllArgs. Please check how Gnu.cpp passes `-T` CH

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/GlobalValue.h:329 +} +void deserialize(unsigned V) { + if (V & (1 << 0)) NoSanitize = true; vitalybuka wrote: > serialization should not be in this header, this bit stuff is /Bitcode/

[clang] 3ba6ace - [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in

Author: Akira Hatanaka Date: 2022-06-06T19:12:26-07:00 New Revision: 3ba6ace3cc507c241225d6ce92768a9aef417d45 URL: https://github.com/llvm/llvm-project/commit/3ba6ace3cc507c241225d6ce92768a9aef417d45 DIFF: https://github.com/llvm/llvm-project/commit/3ba6ace3cc507c241225d6ce92768a9aef417d45.diff

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

ahatanak added inline comments. Comment at: clang/test/Modules/gmodules-deduction-guide.cpp:3 +// RUN: -o %t.pch %S/Inputs/gmodules-deduction-guide.h \ +// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll +// RUN: cat %t-pch.ll | FileCheck %s chapuni wrote: >

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. ping I have simplified my patch. Only support `-T` and `-fuse-ld=lld` according to user specification. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commit

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

chapuni added inline comments. Comment at: clang/test/Modules/gmodules-deduction-guide.cpp:3 +// RUN: -o %t.pch %S/Inputs/gmodules-deduction-guide.h \ +// RUN: -mllvm -debug-only=pchcontainer &>%t-pch.ll +// RUN: cat %t-pch.ll | FileCheck %s FYI, it is unavai

[clang] 834e5d1 - Revert "[gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in"

Author: Akira Hatanaka Date: 2022-06-06T18:48:24-07:00 New Revision: 834e5d12c77eaa4ac1f7fa9512bc7a71470318c7 URL: https://github.com/llvm/llvm-project/commit/834e5d12c77eaa4ac1f7fa9512bc7a71470318c7 DIFF: https://github.com/llvm/llvm-project/commit/834e5d12c77eaa4ac1f7fa9512bc7a71470318c7.diff

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

kaz7 added a comment. Hi, after this patch, our buildbot for VE having errors like https://lab.llvm.org/buildbot/#/builders/91/builds/9984. When I run a test script by hand, it shows following errors. Please investigate them. Thank you. $ cd build $ /home/marukawa/llvm-upstream/build/bin

[PATCH] D109977: LLVM Driver Multicall tool

thakis added inline comments. Comment at: llvm/test/lit.cfg.py:142 tools = [ +ToolSubst('%llvm', FindTool('llvm')), ToolSubst('%lli', FindTool('lli'), post='.', extra_args=lli_args), abrachet wrote: > thakis wrote: > > This causes `llvm-lit: > > /Users

[PATCH] D127170: [WebAssembly] Implement remaining relaxed SIMD instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added

[PATCH] D109977: LLVM Driver Multicall tool

chapuni added a comment. An interesting improvement. Thanks. Comment at: llvm/cmake/modules/AddLLVM.cmake:890 +configure_file( + ${LLVM_MAIN_SRC_DIR}/cmake/driver-template.cpp.in + ${CMAKE_CURRENT_BINARY_DIR}/${name}-driver.cpp) Do you have a plan

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4841-4850 + StringRef Level; + // Check if argument is prefixed with "-O" or "O" + if (Arg.str().rfind("-O", 0) == 0) +Level = Arg.substr(2); + else if (Arg.str().rfind("O", 0) == 0) +Level =

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

steplong updated this revision to Diff 434639. steplong added a comment. - Added docs for attribute - Changed attribute to use Enum - Optsize includes -Og, -Oz, and -Ofast - Change to warning instead of error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D126291: [flang][Driver] Update link job on windows

Meinersbur added a comment. I looked into Google Benchmark because it also has its main in a .lib library and how it handles it. Turns out it is using cmake which by default always adds `/subsystem:console` unless setting WIN32_EXECUTABLE

[PATCH] D127145: [Driver] add -lresolv for all but Android.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6dce56b2a308: [Driver] add -lresolv for all but Android. (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang] 6dce56b - [Driver] add -lresolv for all but Android.

Author: Kevin Athey Date: 2022-06-06T15:49:42-07:00 New Revision: 6dce56b2a3082191aa3d26abd4f05cf518d98356 URL: https://github.com/llvm/llvm-project/commit/6dce56b2a3082191aa3d26abd4f05cf518d98356 DIFF: https://github.com/llvm/llvm-project/commit/6dce56b2a3082191aa3d26abd4f05cf518d98356.diff L

Re: [clang] f06abbb - LLVM Driver Multicall tool

Hmm, I'm not able to reproduce this with upstream. Sorry for the noise. - Michael Spencer On Mon, Jun 6, 2022 at 2:44 PM Michael Spencer wrote: > I believe this broke the shared library build. CMake complains with a > cycle: > > CMake Error: The inter-target dependency graph contains the follo

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

hctim created this revision. hctim added a reviewer: eugenis. Herald added a reviewer: aaron.ballman. Herald added a project: All. hctim requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds the -fsanitize plumbing for memtag-globals

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda updated this revision to Diff 434634. kda marked an inline comment as done. kda added a comment. removed braces on single statement from conditional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 Fil

[PATCH] D127145: [Driver] add -lresolv for all but Android.

eugenis accepted this revision. eugenis added a comment. Typo: "runttime" LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 ___ cfe-commits mailing list cfe

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda added a comment. In D127145#3561519 , @eugenis wrote: > The interceptor (dn_expand) is only defined on linux && !android, while this > code links libresolv on *bsd and others, too. I think it's ok, as long as all > platforms with the interceptor are

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers added a comment. I was able to find and add a covering test case. I understand the fix may not be "correct", but it does avoid the crash demonstrated by the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://re

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers updated this revision to Diff 434628. vabridgers added a comment. add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://reviews.llvm.org/D127105 Files: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

mizvekov marked an inline comment as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:848 (Scope::FnScope | Scope::ClassScope | Scope::BlockScope | - Scope::FunctionPrototypeScope | Scope::ObjCMethodScope | -

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

This revision was automatically updated to reflect the committed changes. Closed by commit rG43ef17cac172: [clang] P2266: apply move elision rules on throw expr nested in function… (authored by mizvekov). Changed prior to commit: https://reviews.llvm.org/D127075?vs=434351&id=434623#toc Reposit

[clang] 43ef17c - [clang] P2266: apply move elision rules on throw expr nested in function prototypes

Author: Matheus Izvekov Date: 2022-06-07T00:08:24+02:00 New Revision: 43ef17cac172229f8b176b42cf0e5ae6c82adbde URL: https://github.com/llvm/llvm-project/commit/43ef17cac172229f8b176b42cf0e5ae6c82adbde DIFF: https://github.com/llvm/llvm-project/commit/43ef17cac172229f8b176b42cf0e5ae6c82adbde.dif

Re: [clang] f06abbb - LLVM Driver Multicall tool

I believe this broke the shared library build. CMake complains with a cycle: CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle): I'm verifying that this occurs with a clean upstream build. - Michael Spencer On Sun, Jun 5, 2022 at 9:28 PM

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim added inline comments. Comment at: llvm/include/llvm/AsmParser/LLToken.h:181 #define GET_ATTR_NAMES #define ATTRIBUTE_ENUM(ENUM_NAME, DISPLAY_NAME) \ kw_##DISPLAY_NAME, vitalybuka wrote: > Have you considered in Attributes.inc ? > > /// Can be used as

[PATCH] D126100: Add sanitizer-specific GlobalValue attributes.

hctim updated this revision to Diff 434618. hctim marked 5 inline comments as done. hctim added a comment. Update w/ Vitaly's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126100/new/ https://reviews.llvm.org/D126100 Files: llvm/includ

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 434615. python3kgae added a comment. Fix test fail after rebased on llvm/main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basic/

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

dodohand updated this revision to Diff 434610. dodohand added a comment. renamed from misc-assignment-in-if-clause to bugprone-assignment-in-if-condition per review input Adjusted documentation per review input. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews

[PATCH] D127150: [doc] Add release notes about SEH unwind information on ARM

mstorsjo updated this revision to Diff 434611. mstorsjo added a comment. Capitalize DWARF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127150/new/ https://reviews.llvm.org/D127150 Files: clang/docs/ReleaseNotes.rst llvm/docs/ReleaseNotes.rst

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47039a1a4b29: [WebAssembly] Remove restriction on main name mangling (authored by sbc100). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 47039a1 - [WebAssembly] Remove restriction on main name mangling

Author: Sam Clegg Date: 2022-06-06T14:04:27-07:00 New Revision: 47039a1a4b299c01dfa0ec531fbc0d24718bb8eb URL: https://github.com/llvm/llvm-project/commit/47039a1a4b299c01dfa0ec531fbc0d24718bb8eb DIFF: https://github.com/llvm/llvm-project/commit/47039a1a4b299c01dfa0ec531fbc0d24718bb8eb.diff LOG

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6360 + auto *GA = llvm::GlobalAlias::create("__main_void", F); + GA->setVisibility(F->getVisibility()); +} sbc100 wrote: > sunfish wrote: > > sbc100 wrote: > > > sunfish w

[PATCH] D127150: [doc] Add release notes about SEH unwind information on ARM

MaskRay added inline comments. Comment at: clang/docs/ReleaseNotes.rst:357 + +- Switched MinGW mode on ARM to use SEH instead of Dwarf for unwind information. + The official spelling is `DWARF`. The official way to name the version is `DWARF version 5`. If abbr

[PATCH] D75277: [WebAssembly] Remove restriction on main name mangling

sbc100 updated this revision to Diff 434605. sbc100 added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75277/new/ https://reviews.llvm.org/D75277 Files: clang/lib/AST/Mangle.cpp clang/lib/CodeGen/CodeGenModule.cpp Index:

[PATCH] D127145: [Driver] add -lresolv for all but Android.

eugenis added a comment. The interceptor (dn_expand) is only defined on linux && !android, while this code links libresolv on *bsd and others, too. I think it's ok, as long as all platforms with the interceptor are covered. It would be great to mention the actual reason we do this in the commit

[PATCH] D127150: [doc] Add release notes about SEH unwind information on ARM

mstorsjo created this revision. mstorsjo added reviewers: efriedma, MaskRay. Herald added subscribers: StephenFan, kristof.beyls. Herald added a project: All. mstorsjo requested review of this revision. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D127145: [Driver] add -lresolv for all but Android.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:843 + if (!TC.getTriple().isAndroid()) { +CmdArgs.push_back("-lresolv

[PATCH] D127145: [Driver] add -lresolv for all but Android.

vitalybuka added a comment. yes, however I have no idea if we need !TC.getTriple().isOSFreeBSD() !TC.getTriple().isOSNetBSD() !TC.getTriple().isOSOpenBSD()) etc. I guess if make mistake it will be noticed and fixed. Please update clang/test/Driver/sanitizer-ld.c Repository: rG LLVM Gi

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfcb784db4961: [clang] [MinGW] Default to WinEH (SEH) exception handling instead of Dwarf (authored by mstorsjo). Changed prior to commit: https://

[clang] fcb784d - [clang] [MinGW] Default to WinEH (SEH) exception handling instead of Dwarf

Author: Martin Storsjö Date: 2022-06-06T23:27:31+03:00 New Revision: fcb784db496137fa29a11b7e106efe89c7550e11 URL: https://github.com/llvm/llvm-project/commit/fcb784db496137fa29a11b7e106efe89c7550e11 DIFF: https://github.com/llvm/llvm-project/commit/fcb784db496137fa29a11b7e106efe89c7550e11.diff

[libunwind] 08d30c6 - [libunwind] Don't store a predecremented PC when using SEH

Author: Martin Storsjö Date: 2022-06-06T23:25:24+03:00 New Revision: 08d30c602bcf3bc25a02938f2663a1b9e96a7cbe URL: https://github.com/llvm/llvm-project/commit/08d30c602bcf3bc25a02938f2663a1b9e96a7cbe DIFF: https://github.com/llvm/llvm-project/commit/08d30c602bcf3bc25a02938f2663a1b9e96a7cbe.diff

[PATCH] D126865: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2293d46a0175: [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied (authored by mstorsjo). Repository: rG LLVM Github Monorepo

[libunwind] 64778c0 - [libunwind] Remove unused ARM SEH placeholder code

Author: Martin Storsjö Date: 2022-06-06T23:24:22+03:00 New Revision: 64778c002a77046e15a7ce7a7206f5c15355fc26 URL: https://github.com/llvm/llvm-project/commit/64778c002a77046e15a7ce7a7206f5c15355fc26 DIFF: https://github.com/llvm/llvm-project/commit/64778c002a77046e15a7ce7a7206f5c15355fc26.diff

[libunwind] 7c0e93c - [libunwind] Fix SEH unwinding on ARM

Author: Martin Storsjö Date: 2022-06-06T23:23:35+03:00 New Revision: 7c0e93cb89e6aa74881411213abf83faae7c58ee URL: https://github.com/llvm/llvm-project/commit/7c0e93cb89e6aa74881411213abf83faae7c58ee DIFF: https://github.com/llvm/llvm-project/commit/7c0e93cb89e6aa74881411213abf83faae7c58ee.diff

[clang] 2293d46 - [clang] [Headers] Check __SEH__, when checking if ARM EHABI is implied

Author: Martin Storsjö Date: 2022-06-06T23:21:05+03:00 New Revision: 2293d46a01752e312a0796d044a25a49b2fd17f5 URL: https://github.com/llvm/llvm-project/commit/2293d46a01752e312a0796d044a25a49b2fd17f5 DIFF: https://github.com/llvm/llvm-project/commit/2293d46a01752e312a0796d044a25a49b2fd17f5.diff

[PATCH] D127145: [Driver] add -lresolv for all but Android.

MaskRay added a comment. The description needs to mention the motivation. Is this meant for `isOSLinux() && isGNUEnvironment()` targets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127145/new/ https://reviews.llvm.org/D127145 __

[PATCH] D127145: [Driver] add -lresolv for all but Android.

kda created this revision. kda added reviewers: vitalybuka, eugenis. Herald added subscribers: Enna1, danielkiss. Herald added a project: All. kda requested review of this revision. Herald added subscribers: Sanitizers, cfe-commits, MaskRay. Herald added projects: clang, Sanitizers. Repository:

[PATCH] D125839: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in DebugTypeVisitor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1346e2ee274: [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in (authored by ahatanak). Repository: rG LLVM Github Monorepo C

[clang] d1346e2 - [gmodules] Skip CXXDeductionGuideDecls when visiting FunctionDecls in

Author: Akira Hatanaka Date: 2022-06-06T12:51:36-07:00 New Revision: d1346e2ee2741919a8cc1b1ffe41e76a6d06 URL: https://github.com/llvm/llvm-project/commit/d1346e2ee2741919a8cc1b1ffe41e76a6d06 DIFF: https://github.com/llvm/llvm-project/commit/d1346e2ee2741919a8cc1b1ffe41e76a6d06.diff

[PATCH] D127142: [HIP] Link with clang_rt.builtins

tra added a reviewer: MaskRay. tra added a comment. Herald added a subscriber: StephenFan. Looks OK syntax-wise. Library path should probably be fixed, though it appears to be a somewhat separate issue and could be done in its own patch, if the required change is not trivial. ==

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains added a comment. so standard 10.4 ex 2 gives the expected output with this patch stack note that there's a query to core about whether that example is fully correct (but that does not affect the skeleton of these implements - only the detail of what is included / excluded in the `markReac

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma added a comment. Funclets are necessary for both C++ and SEH exception handling, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 ___ cfe-commits m

[PATCH] D126694: [C++20][Modules] Initial implementation of GMF decl elision.

iains updated this revision to Diff 434563. iains added a comment. reworked to use D113545 as a parent revision which resolves the issue of needing to make module ownership 'visible' to satisfy lookup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

mstorsjo added a comment. In D126871#3561243 , @efriedma wrote: >> But for MSVC style (C++ exceptions and __try/__except) there's still a >> couple backend things that need to be implemented. Do you happen to know >> roughly how much effort that is? > >

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma added a comment. > Btw, thanks a lot for your reviews, you've spent a lot of time on them! You're welcome. > But for MSVC style (C++ exceptions and __try/__except) there's still a couple > backend things that need to be implemented. Do you happen to know roughly how > much effort that

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:485 "amdhip64.lib"}); + CmdArgs.push_back(Args.MakeArgString("clang_rt.builtins-" + + getTriple().getArchName() + ".lib")); N

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); sepavloff wrote:

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. HIP supports _Float16 by default in host programs, which may cause calls of conversion functions for _Float16 emitted e.g. `__trunc

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); efriedma wrote:

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:622 setFPContractMode(LangOptions::FPM_Off); setRoundingMode(static_cast(LangOptions::FPR_ToNearest)); setFPExceptionMode(LangOptions::FPE_Ignore); I'm suggesting t

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

mstorsjo added a comment. In D126871#3560924 , @efriedma wrote: > Oh, just remembered, we should probably release-note this. (You can post > that as a followup.) Sure, can do. Btw, thanks a lot for your reviews, you've spent a lot of time on them! The

[PATCH] D127105: [analyzer] Fix null pointer deref in CastValueChecker

vabridgers planned changes to this revision. vabridgers added a comment. I know this will need a reproducer, and I'm working on that. That work is still in progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127105/new/ https://reviews.llvm.or

[PATCH] D126929: Add sanitizer metadata attributes to clang IR gen.

hctim updated this revision to Diff 434546. hctim added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126929/new/ https://reviews.llvm.org/D126929 Files: clang/lib/CodeGen/CGDecl.cpp clang/lib/CodeGen/CodeGenModule.cpp cl

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3560997 , @efriedma wrote: > In D126364#3560984 , @sepavloff > wrote: > >> In D126364#3560877 , @efriedma >> wrote: >> >>> Shouldn'

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. In D126364#3560984 , @sepavloff wrote: > In D126364#3560877 , @efriedma > wrote: > >> Shouldn't the rounding mode be FE_DYNAMIC by default? > > According to the standard it must be FE_TO

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

sepavloff added a comment. In D126364#3560877 , @efriedma wrote: > Shouldn't the rounding mode be FE_DYNAMIC by default? According to the standard it must be FE_TONEAREST: F.8.3p1: At program startup the dynamic floating-point environment is initial

[PATCH] D125695: [clang][DebugInfo] Allow function-local type-like entities to be scoped within a lexical block (5/5)

krisb updated this revision to Diff 434541. krisb marked an inline comment as done. krisb added a comment. Applied review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125695/new/ https://reviews.llvm.org/D125695 Files: clang/lib/CodeG

[PATCH] D126651: [clang-diff] Fix getStmtValue when dealing with wide chars

johannes requested changes to this revision. johannes added a comment. This revision now requires changes to proceed. I've suggested some more refactorings but otherwise this should be good to go Comment at: clang/lib/Tooling/ASTDiff/ASTDiff.cpp:497 + return str; +}

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

iains added a comment. I'm going to try rebasing my GMF elision code on top of this. the test-suite changes could be made easier to read by using the file-split stuff we've been using for recent changes (I guess this is an older patch)? Comment at: clang/include/clang/AST/Dec

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma added a comment. Oh, just remembered, we should probably release-note this. (You can post that as a followup.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 __

[PATCH] D126364: Fix interaction of pragma FENV_ACCESS with other pragmas

efriedma added a comment. Shouldn't the rounding mode be FE_DYNAMIC by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126364/new/ https://reviews.llvm.org/D126364 ___ cfe-commits mailing list cfe

[PATCH] D126871: [clang] [MinGW] Use SEH for unwind info on ARM by default

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126871/new/ https://reviews.llvm.org/D126871 ___

[PATCH] D127075: [clang] P2266: apply move elision rules on throw expr nested in function prototypes

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExprCXX.cpp:848 (Scope::FnScope | Scope::ClassScope | Scope::BlockScope | - Scope::FunctionPrototypeScope

[PATCH] D126183: Implement soft reset of the diagnostics engine.

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/IncrementalParser.cpp:200 // FIXME: Do not reset the pragma handlers. +Diags.Reset(true); We should remove this fixme, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

  1   2   >