thakis added inline comments.

================
Comment at: llvm/test/lit.cfg.py:142
 tools = [
+    ToolSubst('%llvm', FindTool('llvm')),
     ToolSubst('%lli', FindTool('lli'), post='.', extra_args=lli_args),
----------------
abrachet wrote:
> thakis wrote:
> > This causes `llvm-lit: 
> > /Users/thakis/src/llvm-project/llvm/utils/lit/lit/llvm/subst.py:126: note: 
> > Did not find llvm in /Users/thakis/src/llvm-build-2/bin` if llvm-driver 
> > isn't enabled (which it isn't by default). Any reason not to add this one 
> > only `if config.have_llvm_driver`?
> Fixed in rG553c2af5360b993376d3c000cf53850605940307
Thank you!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109977/new/

https://reviews.llvm.org/D109977

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to