[PATCH] D120511: [clang-format] Allow to set token types final

owenpan added inline comments. Comment at: clang/lib/Format/FormatToken.h:394 + } + bool typeIsFinalized() const { return TypeIsFinalized; } curdeius wrote: > Nit, to make everyone happy, the function could be called `isTypeFinalized`. +1. CHANGES SINCE LAS

[PATCH] D120511: [clang-format] Allow to set token types final

curdeius added inline comments. Comment at: clang/lib/Format/FormatToken.h:394 + } + bool typeIsFinalized() const { return TypeIsFinalized; } Nit, to make everyone happy, the function could be called `isTypeFinalized`. CHANGES SINCE LAST ACTION https://re

[PATCH] D120512: [clang-format] Fix requires related crash

HazardyKnusperkeks updated this revision to Diff 411658. HazardyKnusperkeks added a comment. Changed test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120512/new/ https://reviews.llvm.org/D120512 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cp

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411652. phyBrackets added a comment. fix some alignment issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/in

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

leoetlino added a comment. ping (as per the contributing guidelines) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113694/new/ https://reviews.llvm.org/D113694 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D120511: [clang-format] Allow to set token types final

HazardyKnusperkeks updated this revision to Diff 411643. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Format - Add Assert - And some stuff to deal with the assert - Should be removed in the long run - Add some documentation CHANGES SINCE LAST ACTION

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Great! Please fix formatting before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120621/new/ https://reviews.llvm.org/D120621 ___

[clang] cbe9911 - [clang] MarkVarDeclODRUsed - remove redundant nullptr check. NFCI.

Author: Simon Pilgrim Date: 2022-02-26T21:24:26Z New Revision: cbe9911845eed262b265d2c6b5f600825145330b URL: https://github.com/llvm/llvm-project/commit/cbe9911845eed262b265d2c6b5f600825145330b DIFF: https://github.com/llvm/llvm-project/commit/cbe9911845eed262b265d2c6b5f600825145330b.diff LOG:

[PATCH] D120618: [clang-format][docs] Fix a bad comment

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Will do with my next push batch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120618/new/ https://reviews.llvm.org/D120

[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.

sammccall updated this revision to Diff 411640. sammccall added a comment. Move the description of shouldVisitTemplateInstantiations() to RAV. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120498/new/ https://reviews.llvm.org/D120498 Files: clan

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3344938 , @nikic wrote: > Hm, it looks like enabling PIE has a pretty big negative compile-time impact, > with a 20% regression on sqlite3: > http://llvm-compile-time-tracker.com/compare.php?from=611122892e6d5813444bd

[clang-tools-extra] 42cb812 - [clangd] Test fixes missing from 257559ed9

Author: Sam McCall Date: 2022-02-26T21:38:25+01:00 New Revision: 42cb812da707e7092aa3c030a44b739bbaf36b98 URL: https://github.com/llvm/llvm-project/commit/42cb812da707e7092aa3c030a44b739bbaf36b98 DIFF: https://github.com/llvm/llvm-project/commit/42cb812da707e7092aa3c030a44b739bbaf36b98.diff LO

[clang-tools-extra] 257559e - [clangd] Function return type hints: support lambdas, don't duplicate "->"

Author: Sam McCall Date: 2022-02-26T21:28:09+01:00 New Revision: 257559ed9ab74c2dd3882075c45b4ae002256425 URL: https://github.com/llvm/llvm-project/commit/257559ed9ab74c2dd3882075c45b4ae002256425 DIFF: https://github.com/llvm/llvm-project/commit/257559ed9ab74c2dd3882075c45b4ae002256425.diff LO

[PATCH] D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->"

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG257559ed9ab7: [clangd] Function return type hints: support lambdas, don't duplicate "->" (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D120416: [clangd] Function return type hints: support lambdas, don't duplicate "->"

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:626 +auto f4() -> auto* { return "foo"; } + // `auto` conversion operator Trass3r wrote: > Should there be a te

[PATCH] D120401: [clang-format][NFC] Rename test and remove comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa74ff3ac2edc: [clang-format][NFC] Rename test and remove comments (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D120359: [clang-format][NFC] Remove redundant semi

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d03548f63ad: [clang-format][NFC] Remove redundant semi (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] a74ff3a - [clang-format][NFC] Rename test and remove comments

Author: Björn Schäpers Date: 2022-02-26T21:22:37+01:00 New Revision: a74ff3ac2edcb631ef78d41c12da7c2641ff2e15 URL: https://github.com/llvm/llvm-project/commit/a74ff3ac2edcb631ef78d41c12da7c2641ff2e15 DIFF: https://github.com/llvm/llvm-project/commit/a74ff3ac2edcb631ef78d41c12da7c2641ff2e15.diff

[clang] 1d03548 - [clang-format][NFC] Remove redundant semi

Author: Björn Schäpers Date: 2022-02-26T21:22:36+01:00 New Revision: 1d03548f63add672b4adf03360e396eba852bce5 URL: https://github.com/llvm/llvm-project/commit/1d03548f63add672b4adf03360e396eba852bce5 DIFF: https://github.com/llvm/llvm-project/commit/1d03548f63add672b4adf03360e396eba852bce5.diff

[PATCH] D120621: [clang-format] Fix BreakBeforeBinaryOperators with TemplateCloser on the lhs

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check

[PATCH] D120619: [clangd] Support include-fixer inside macro arguments.

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Motivating case: EXPE

[PATCH] D120618: [clang-format][docs] Fix a bad comment

kuzkry added a comment. Hey @HazardyKnusperkeks, I've just noticed that the suggestion from your inline comment in D119682 is slightly incorrect. The first commit that introduced `IndentRequires` was 840e651dc6d7fe652667eb8b4d04ef4daf4769df

[PATCH] D120618: [clang-format][docs] Fix a bad comment

kuzkry created this revision. kuzkry added a reviewer: HazardyKnusperkeks. kuzkry added a project: clang-format. kuzkry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow up to 8f310d1967c20d348c617af3a30999031c71fee0

[PATCH] D120616: [clangd] IncludeFixer: resolve Class in ns::Class::method();

sammccall created this revision. sammccall added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We distinguish by case, assum

[clang-tools-extra] 671eab2 - [clangd] Support IncludeFixer or base specifiers

Author: Sam McCall Date: 2022-02-26T15:45:59+01:00 New Revision: 671eab254a7fc912857b697d5b6e414b71b75a60 URL: https://github.com/llvm/llvm-project/commit/671eab254a7fc912857b697d5b6e414b71b75a60 DIFF: https://github.com/llvm/llvm-project/commit/671eab254a7fc912857b697d5b6e414b71b75a60.diff LO

[PATCH] D119481: run-clang-tidy: Fix infinite loop on windows

Febbe added a comment. @salman-javed-nz you're welcome, I only fixed it because I saw the bug in the trace directly. Normally, I would only fix C/C++ stuff :D. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119481/new/ https://reviews.llvm.org/D119481 __

[PATCH] D119481: run-clang-tidy: Fix infinite loop on windows

Febbe added a comment. @JonasToth yes, it would be nice, to test this and then push it for me. Also a backport to 14.0 would be good :). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119481/new/ https://reviews.llvm.org/D119481 ___ cfe-commi

[PATCH] D119481: run-clang-tidy: Fix infinite loop on windows

Febbe updated this revision to Diff 411606. Febbe added a comment. Applied the feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119481/new/ https://reviews.llvm.org/D119481 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index: clang-tools-extra/clang-tidy/tool/run

[clang-tools-extra] b09c12c - [clangd] Fix wrong included header. NFC

Author: Sam McCall Date: 2022-02-26T14:21:52+01:00 New Revision: b09c12c4b9767e97ce8b02c707eb0dd3272e6de3 URL: https://github.com/llvm/llvm-project/commit/b09c12c4b9767e97ce8b02c707eb0dd3272e6de3 DIFF: https://github.com/llvm/llvm-project/commit/b09c12c4b9767e97ce8b02c707eb0dd3272e6de3.diff LO

[clang-tools-extra] e63d7bd - [clangd] Fix include-cleaner false-positive bug

Author: Sam McCall Date: 2022-02-26T14:11:48+01:00 New Revision: e63d7bdc28e42b537ba29708e7db9f5d1dedefc0 URL: https://github.com/llvm/llvm-project/commit/e63d7bdc28e42b537ba29708e7db9f5d1dedefc0 DIFF: https://github.com/llvm/llvm-project/commit/e63d7bdc28e42b537ba29708e7db9f5d1dedefc0.diff LO

[PATCH] D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

phyBrackets updated this revision to Diff 411601. phyBrackets added a comment. aligned the indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120489/new/ https://reviews.llvm.org/D120489 Files: clang/docs/analyzer/checkers.rst clang/inc

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 411600. philnik marked an inline comment as done. philnik added a comment. - Fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 Files: clang/docs/ReleaseNot

[clang-tools-extra] 6c72a97 - [clangd] Qualify calls to std::move to silence -Wunqualified-std-cast-call. NFC.

Author: Benjamin Kramer Date: 2022-02-26T13:36:14+01:00 New Revision: 6c72a97c0e2d9dd884d67315629be1c219da3b34 URL: https://github.com/llvm/llvm-project/commit/6c72a97c0e2d9dd884d67315629be1c219da3b34 DIFF: https://github.com/llvm/llvm-project/commit/6c72a97c0e2d9dd884d67315629be1c219da3b34.dif

[clang-tools-extra] dfed8f5 - [clangd] Add a missing include. NFC.

Author: Benjamin Kramer Date: 2022-02-26T13:23:06+01:00 New Revision: dfed8f556d270cec0ac849ce1208671f33454534 URL: https://github.com/llvm/llvm-project/commit/dfed8f556d270cec0ac849ce1208671f33454534 DIFF: https://github.com/llvm/llvm-project/commit/dfed8f556d270cec0ac849ce1208671f33454534.dif

[PATCH] D116577: [clang-tidy] Added "boost-use-range-based-for-loop" check

denzor200 planned changes to this revision. denzor200 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/boost-use-range-based-for-loop.cpp:22 + +#define BOOST_FOREACH(VAR, COL) for(VAR;(COL, false);) +#define IDENTITY_TYPE(...) __VA_ARGS__ ---

[PATCH] D118588: [C++20][Modules]5/8] Diagnose wrong import/export for partition CMIs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a76d2563940: [C++20][Modules][5/8] Diagnose wrong import/export for partition CMIs. (authored by iains). Repository: rG LLVM Github Monorepo CHA

[clang] 1a76d25 - [C++20][Modules][5/8] Diagnose wrong import/export for partition CMIs.

Author: Iain Sandoe Date: 2022-02-26T11:27:08Z New Revision: 1a76d2563940e6b4bfcb9e77b8a4d1d3f0cc7d30 URL: https://github.com/llvm/llvm-project/commit/1a76d2563940e6b4bfcb9e77b8a4d1d3f0cc7d30 DIFF: https://github.com/llvm/llvm-project/commit/1a76d2563940e6b4bfcb9e77b8a4d1d3f0cc7d30.diff LOG: [

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347194 , @MaskRay wrote: > In D120305#3347193 , @nikic wrote: > >> In D120305#3347192 , @tstellar >> wrote: >> >>> In D120305#3347177

[PATCH] D119061: [Clang] noinline call site attribute

xbolva00 updated this revision to Diff 411589. xbolva00 added a comment. Fixed failing Parser test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119061/new/ https://reviews.llvm.org/D119061 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/incl

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347193 , @nikic wrote: > In D120305#3347192 , @tstellar > wrote: > >> In D120305#3347177 , @nikic wrote: >> >>> Yes, because you reve

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. In D120305#3347192 , @tstellar wrote: > In D120305#3347177 , @nikic wrote: > >> Yes, because you reverted the change for that one buildbot, of course it is >> green now. You could have also

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347177 , @nikic wrote: > Yes, because you reverted the change for that one buildbot, of course it is > green now. You could have also made the buildbot green by disabling tests on > that bot. Or disabling sanitizers

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347177 , @nikic wrote: > Yes, because you reverted the change for that one buildbot, of course it is > green now. You could have also made the buildbot green by disabling tests on > that bot. Or disabling sanitizers

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347161 , @MaskRay wrote: > In D120305#3347160 , @nikic wrote: > >> @MaskRay Please revert the change and all dependent changes you have made. A >> revert is not a personal af

[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3480390be61: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers (authored by ibookstein). Repository: rG LLVM Github Monorepo CHANG

[clang] f348039 - [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

Author: Itay Bookstein Date: 2022-02-26T11:17:49+02:00 New Revision: f3480390be614604907be447afa3f5ab10b97d04 URL: https://github.com/llvm/llvm-project/commit/f3480390be614604907be447afa3f5ab10b97d04 DIFF: https://github.com/llvm/llvm-project/commit/f3480390be614604907be447afa3f5ab10b97d04.diff

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. Yes, because you reverted the change for that one buildbot, of course it is green now. You could have also made the buildbot green by disabling tests on that bot. Or disabling sanitizers on it. Doesn't change the fact that the configuration it was originally testing is st

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347150 , @tstellar wrote: > [...] > >>> It's not acceptable, because buildbots are meant to represent a specific >>> configuration that the buildbot owner cares about. Changing the buildbot >>> configuration makes t

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347160 , @nikic wrote: > @MaskRay Please revert the change and all dependent changes you have made. A > revert is not a personal affront to you. It's not a judgement that you or > your change are bad. It's a simple m

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

nikic added a comment. @MaskRay Please revert the change and all dependent changes you have made. A revert is not a personal affront to you. It's not a judgement that you or your change are bad. It's a simple matter of policy and standard procedure. There's a good chance that next week you'll g

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347152 , @tstellar wrote: > In D120305#3347151 , @xbolva00 > wrote: > Given that the bot does not have a high success rate (track record) for at least the past mont

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347151 , @xbolva00 wrote: >>> Given that the bot does not have a high success rate (track record) for at >>> least the past month, I am unsure I am supposed to revert my change. > > What is interesting that always th

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

xbolva00 added a comment. >> Given that the bot does not have a high success rate (track record) for at >> least the past month, I am unsure I am supposed to revert my change. What is interesting that always the patch author is the person to be blamed even when there are situations where it is

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347148 , @MaskRay wrote: > In D120305#3347145 , @tstellar > wrote: > >> In D120305#3347143 , @MaskRay >> wrote: >> >>> In D120305#3

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. https://lab.llvm.org/buildbot/#/builders/57 is green Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.org/D120305 ___ cfe-commits mailing list cfe-c

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

MaskRay added a comment. In D120305#3347145 , @tstellar wrote: > In D120305#3347143 , @MaskRay wrote: > >> In D120305#3347142 , @tstellar >> wrote: >> >>> In D120305#3347

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. In D120305#3347143 , @MaskRay wrote: > In D120305#3347142 , @tstellar > wrote: > >> In D120305#3347139 , @MaskRay >> wrote: >> >>> In D120305#3