Author: Björn Schäpers Date: 2022-02-26T21:22:37+01:00 New Revision: a74ff3ac2edcb631ef78d41c12da7c2641ff2e15
URL: https://github.com/llvm/llvm-project/commit/a74ff3ac2edcb631ef78d41c12da7c2641ff2e15 DIFF: https://github.com/llvm/llvm-project/commit/a74ff3ac2edcb631ef78d41c12da7c2641ff2e15.diff LOG: [clang-format][NFC] Rename test and remove comments Why put "InMacros" in the name? We test other things to, and I will add more, withut macros. Also all our tests are regression tests. Differential Revision: https://reviews.llvm.org/D120401 Added: Modified: clang/unittests/Format/TokenAnnotatorTest.cpp Removed: ################################################################################ diff --git a/clang/unittests/Format/TokenAnnotatorTest.cpp b/clang/unittests/Format/TokenAnnotatorTest.cpp index 60137b8a23c6..4c59bef4004d 100644 --- a/clang/unittests/Format/TokenAnnotatorTest.cpp +++ b/clang/unittests/Format/TokenAnnotatorTest.cpp @@ -44,9 +44,7 @@ class TokenAnnotatorTest : public ::testing::Test { EXPECT_TOKEN_TYPE(FormatTok, Type); \ } while (false) -TEST_F(TokenAnnotatorTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { - // This is a regression test for mis-parsing the & after decltype as a binary - // operator instead of a reference (when inside a macro definition). +TEST_F(TokenAnnotatorTest, UnderstandsUsesOfStarAndAmp) { auto Tokens = annotate("auto x = [](const decltype(x) &ptr) {};"); EXPECT_EQ(Tokens.size(), 18u) << Tokens; EXPECT_TOKEN(Tokens[7], tok::kw_decltype, TT_Unknown); @@ -54,13 +52,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { EXPECT_TOKEN(Tokens[9], tok::identifier, TT_Unknown); EXPECT_TOKEN(Tokens[10], tok::r_paren, TT_TypeDeclarationParen); EXPECT_TOKEN(Tokens[11], tok::amp, TT_PointerOrReference); - // Same again with * instead of &: + Tokens = annotate("auto x = [](const decltype(x) *ptr) {};"); EXPECT_EQ(Tokens.size(), 18u) << Tokens; EXPECT_TOKEN(Tokens[10], tok::r_paren, TT_TypeDeclarationParen); EXPECT_TOKEN(Tokens[11], tok::star, TT_PointerOrReference); - // Also check that we parse correctly within a macro definition: Tokens = annotate("#define lambda [](const decltype(x) &ptr) {}"); EXPECT_EQ(Tokens.size(), 17u) << Tokens; EXPECT_TOKEN(Tokens[7], tok::kw_decltype, TT_Unknown); @@ -68,7 +65,7 @@ TEST_F(TokenAnnotatorTest, UnderstandsUsesOfStarAndAmpInMacroDefinition) { EXPECT_TOKEN(Tokens[9], tok::identifier, TT_Unknown); EXPECT_TOKEN(Tokens[10], tok::r_paren, TT_TypeDeclarationParen); EXPECT_TOKEN(Tokens[11], tok::amp, TT_PointerOrReference); - // Same again with * instead of &: + Tokens = annotate("#define lambda [](const decltype(x) *ptr) {}"); EXPECT_EQ(Tokens.size(), 17u) << Tokens; EXPECT_TOKEN(Tokens[10], tok::r_paren, TT_TypeDeclarationParen); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
