[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 400253. Ericson2314 added a comment. Try again, with more `include(GNUInstallDirs)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/CMake

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 reopened this revision. Ericson2314 added a comment. This revision is now accepted and ready to land. Found two more `include(GNUInstallDirs)` I should include which will hopefully fix the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 added a comment. Sorry about that. I think the issue was just one more `include(GNUInstallDirs)` for compiler-rt for the standalone build, but I am going to bed so just reverted for now to try again later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[libunwind] 6e52bfe - Revert "[cmake] Use `GNUInstallDirs` to support custom installation dirs."

Author: John Ericson Date: 2022-01-15T07:35:02Z New Revision: 6e52bfe09d3ab3ae6c43c079d06ebeb7bb241dec URL: https://github.com/llvm/llvm-project/commit/6e52bfe09d3ab3ae6c43c079d06ebeb7bb241dec DIFF: https://github.com/llvm/llvm-project/commit/6e52bfe09d3ab3ae6c43c079d06ebeb7bb241dec.diff LOG:

[PATCH] D117388: [Driver][FreeBSD] -r: imply -nostdlib like GCC

MaskRay created this revision. MaskRay added a reviewer: dim. Herald added a subscriber: emaste. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to D116843 . Repository: rG LLVM Github M

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26bb1b1dab8b: [RISCV] Add the zvl extension according to the v1.0 spec (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 26bb1b1 - [RISCV] Add the zvl extension according to the v1.0 spec

Author: eopXD Date: 2022-01-14T23:01:48-08:00 New Revision: 26bb1b1dab8bc0646073e762a9f75f2dbcd18857 URL: https://github.com/llvm/llvm-project/commit/26bb1b1dab8bc0646073e762a9f75f2dbcd18857 DIFF: https://github.com/llvm/llvm-project/commit/26bb1b1dab8bc0646073e762a9f75f2dbcd18857.diff LOG: [R

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

vitalybuka added a comment. It breaks multiple bots. https://lab.llvm.org/buildbot/#/builders/37/builds/9960 https://lab.llvm.org/buildbot/#/builders/77/builds/13245 https://lab.llvm.org/buildbot/#/builders/169/builds/5409 https://lab.llvm.org/buildbot/#/builders/105/builds/19941 Can you please f

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400238. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/ris

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted at 9 PM PST. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei updated this revision to Diff 400231. pengfei added a comment. Fix AutoUpgrade bug catched by buildbot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 Files: clang/lib/Basic/Targets/X86.h cla

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood added a comment. OK, I'm going to migrate this to a private matcher in the check that needs it. A related question is if it is possible to register private matchers with the parsing framework? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116518/new/ https://reviews.l

[clang] f63a805 - Revert "[X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC"

Author: Phoebe Wang Date: 2022-01-15T10:54:38+08:00 New Revision: f63a805a4e9924002a9533b335ab29a8b5c7a9ac URL: https://github.com/llvm/llvm-project/commit/f63a805a4e9924002a9533b335ab29a8b5c7a9ac DIFF: https://github.com/llvm/llvm-project/commit/f63a805a4e9924002a9533b335ab29a8b5c7a9ac.diff L

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D117380: [RISCV] [Clang] Add attra for crc32_d/crc32c_d

Chenbing.Zheng created this revision. Chenbing.Zheng added reviewers: craig.topper, LevyHsu, benshi001. Chenbing.Zheng added a project: clang. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, J

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

kda added inline comments. Comment at: clang/test/Driver/fsanitize-memory-param-retval.c:8-9 + +// RUN: %clang -target aarch64-linux-gnu -fsyntax-only %s -fsanitize=memory -fsanitize-memory-param-retval -c -### 2>&1 | FileCheck --check-prefix=11 %s +// 11: "-fsanitize-memory-par

[PATCH] D117376: Remove reference type when checking const structs

rtrieu created this revision. rtrieu added reviewers: rsmith, cfe-commits. rtrieu requested review of this revision. Herald added a project: clang. ConstStructBuilder::Finalize in CGExprConstant.ccp assumes that the passed in QualType is a RecordType. In some instances, the type is a reference t

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f93448235fe: enable noundef analysis with -fsanitize-memory-param-retval (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/ https

[clang] 0f93448 - enable noundef analysis with -fsanitize-memory-param-retval

Author: Kevin Athey Date: 2022-01-14T17:18:29-08:00 New Revision: 0f93448235fe9727251fad6d170fb7d47a5f44cd URL: https://github.com/llvm/llvm-project/commit/0f93448235fe9727251fad6d170fb7d47a5f44cd DIFF: https://github.com/llvm/llvm-project/commit/0f93448235fe9727251fad6d170fb7d47a5f44cd.diff L

[PATCH] D117098: [RISCV] update zfh and zfhmin extention to v1.0

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117098/new/ https://reviews.llvm.org/D117098 ___

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Ericson2314 marked an inline comment as done. Closed by commit rGefeb50197091: [cmake] Use `GNUInstallDirs` to support custom installation dirs. (authored by Ericson231

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked 3 inline comments as done. Ericson2314 added inline comments. Comment at: polly/cmake/CMakeLists.txt:85 +set(POLLY_CONFIG_CMAKE_DIR "${POLLY_INSTALL_PREFIX}${CMAKE_INSTALL_PREFIX}/${POLLY_INSTALL_PACKAGE_DIR}") +set(POLLY_CONFIG_LIBRARY_DIRS "${POLLY_INSTALL_

[PATCH] D99484: [cmake] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 marked 10 inline comments as done. Ericson2314 added a comment. The approval on this patch is quite old, but nothing much interesting has happened in it since then --- if anything, it has gotten more trivial as I created patches "under" it and landed them which cleared the way for th

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

thakis added a comment. Breaks a few tests on windows too: http://45.33.8.238/win/52616/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm.org/D113620 ___ cfe-commi

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

thakis added a comment. This breaks a bunch of tests on Mac: http://45.33.8.238/macm1/25623/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm

[PATCH] D115153: clang/AMDGPU: Don't set implicit arg attribute to default size

arsenm closed this revision. arsenm added a comment. 33315ef3216be6edcfb4a6577150682b80a18766 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115153/new/ https://reviews.llvm.org/D115153 __

[clang] 33315ef - clang/AMDGPU: Don't set implicit arg attribute to default size

Author: Matt Arsenault Date: 2022-01-14T18:43:30-05:00 New Revision: 33315ef3216be6edcfb4a6577150682b80a18766 URL: https://github.com/llvm/llvm-project/commit/33315ef3216be6edcfb4a6577150682b80a18766 DIFF: https://github.com/llvm/llvm-project/commit/33315ef3216be6edcfb4a6577150682b80a18766.diff

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

vitalybuka added a comment. Is this from the patch https://lab.llvm.org/buildbot/#/builders/127/builds/22789/steps/8/logs/stdio FAILED: projects/compiler-rt/lib/sanitizer_common/tests/SANITIZER_TEST_OBJECTS.sanitizer_leb128_test.cpp.x86_64.o cmd.exe /C "cd /D C:\b\slave\sanitizer-windows

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. To clarify: LGTM as-is, I don't expect any changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117293/new/ https://reviews.llvm.org/D117293 ___ cfe-commits mailing list cfe

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:90 void VisitDeclStmt(const DeclStmt *S) { -// FIXME: Add support for group decls, e.g: `int a, b;`

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

This revision was automatically updated to reflect the committed changes. Closed by commit rG533fbae8d8d8: [clang-format] Add experimental option to remove LLVM braces (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/

[clang] 533fbae - [clang-format] Add experimental option to remove LLVM braces

Author: Owen Pan Date: 2022-01-14T15:10:17-08:00 New Revision: 533fbae8d8d87fb151f852b5273e6e1626321567 URL: https://github.com/llvm/llvm-project/commit/533fbae8d8d87fb151f852b5273e6e1626321567 DIFF: https://github.com/llvm/llvm-project/commit/533fbae8d8d87fb151f852b5273e6e1626321567.diff LOG:

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:90 void VisitDeclStmt(const DeclStmt *S) { -// FIXME: Add support for group decls, e.g: `int a, b;` -if (S->isSingleDecl()) { - if (con

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117348/new/ https://reviews.llvm.org/D117348 ___ cfe-commits mailing list cfe-commi

[PATCH] D117362: [OpenMP] Remove hidden visibility for declare target variables

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch changes the visiblity of variables de

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:290-292 +// Do not warn on naked functions. +[[gnu::naked]] int nakedFunction(int a, float b, const char *c) { ; } +__attribute__((naked)) void nakedFunct

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 400143. MuAlphaOmegaEpsilon added a comment. Update warning amount on CHECK-unused check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/ https://reviews.llvm.org/D116778 Files: clang-to

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked 3 inline comments as done. Closed by commit rG9f0fa6544012: Comment parsing: Don't recognize commands in single-line double quotation (authored by a

[PATCH] D116186: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd0a970f5341: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo

[PATCH] D117320: [OpenMP] Mark device RTL variables as hidden

jhuber6 updated this revision to Diff 400137. jhuber6 added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test and add the fact that its hidden to the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117

[clang] 9f0fa65 - Comment parsing: Don't recognize commands in single-line double quotation

Author: Aaron Puchert Date: 2022-01-14T22:46:07+01:00 New Revision: 9f0fa6544012ed8f7b6b3d72fce6535bf4430e40 URL: https://github.com/llvm/llvm-project/commit/9f0fa6544012ed8f7b6b3d72fce6535bf4430e40 DIFF: https://github.com/llvm/llvm-project/commit/9f0fa6544012ed8f7b6b3d72fce6535bf4430e40.diff

[clang] bd0a970 - Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC)

Author: Aaron Puchert Date: 2022-01-14T22:45:10+01:00 New Revision: bd0a970f5341f9981a9ad33fdfda99f8ff7348b3 URL: https://github.com/llvm/llvm-project/commit/bd0a970f5341f9981a9ad33fdfda99f8ff7348b3 DIFF: https://github.com/llvm/llvm-project/commit/bd0a970f5341f9981a9ad33fdfda99f8ff7348b3.diff

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda added a comment. In D117293#3243986 , @vitalybuka wrote: > In D117293#3243772 , @vitalybuka > wrote: > >> Just noticed, -enable-noundef-analysis is missing tests undef >> llvm/llvm-project/clang/test/Driver

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. The warning would be correct if the compiler could actually tell the parameter is unused, but at the moment it cannot, as far as I know. I stumbled upon this thing myself, and there are a few ways to silence the warning: -removing names -marking every single

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. In D117293#3244668 , @kda wrote: > In D117293#3243735 , @vitalybuka > wrote: > >> Nice! >> This completes the work found in: >> >> It's too late for this set of patches, but phabr

[PATCH] D117296: Document several clang-supported builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cacd420a1d7: Document several clang-supported builtins (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D117296

[clang] 6cacd42 - Document several clang-supported builtins

Author: serge-sans-paille Date: 2022-01-14T22:03:56+01:00 New Revision: 6cacd420a1d72bca7809e6b516fb1e18ac6056c8 URL: https://github.com/llvm/llvm-project/commit/6cacd420a1d72bca7809e6b516fb1e18ac6056c8 DIFF: https://github.com/llvm/llvm-project/commit/6cacd420a1d72bca7809e6b516fb1e18ac6056c8.d

[PATCH] D117355: [PowerPC] Fix the undef virtual register reading failure for PPC backend trap optimization

NeHuang created this revision. NeHuang added reviewers: nemanjai, stefanp, amyk, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. This patch adds the fix for undef virtual register reading failure when trap o

[PATCH] D117142: [clang-format] Fix short functions being considered as inline inside an indented namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7af11989be21: [clang-format] Fix short functions being considered as inline inside an… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 7af1198 - [clang-format] Fix short functions being considered as inline inside an indented namespace.

Author: Marek Kurdej Date: 2022-01-14T21:57:02+01:00 New Revision: 7af11989be21df00ad6a510a831ea2425e48fa90 URL: https://github.com/llvm/llvm-project/commit/7af11989be21df00ad6a510a831ea2425e48fa90 DIFF: https://github.com/llvm/llvm-project/commit/7af11989be21df00ad6a510a831ea2425e48fa90.diff

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400111. eopXD added a comment. Rebase to latest main. Resolve test case conflicts due to Zvamo removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/l

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea3d9efc536: [clang-format] Fix CompactNamespaces corner case when… (authored by curdeius). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99031/new/ https:

[clang] 6ea3d9e - [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

Author: Marek Kurdej Date: 2022-01-14T21:47:16+01:00 New Revision: 6ea3d9efc53641d930e9176916ff09ca6f73aef2 URL: https://github.com/llvm/llvm-project/commit/6ea3d9efc53641d930e9176916ff09ca6f73aef2 DIFF: https://github.com/llvm/llvm-project/commit/6ea3d9efc53641d930e9176916ff09ca6f73aef2.diff

[PATCH] D117098: [RISCV] update zfh and zfhmin extention to v1.0

craig.topper added a comment. A new test `inline-asm-zfh-constraint-f.ll` was added today that needs it's RUN line updated. Comment at: clang/test/Preprocessor/riscv-target-features.c:231 // RUN: %clang -target riscv32-unknown-linux-gnu -menable-experimental-extensions \ +

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

kda added a comment. In D117293#3243735 , @vitalybuka wrote: > Nice! > >>> This completes the work found in: > > It's too late for this set of patches, but phabricator supports "Depends on" > comments (I guess only of the first patch upload), and manua

[PATCH] D117296: Document several clang-supported builtins

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit with duplicate punctuation. Comment at: clang/docs/LanguageExtensions.rst:2653 +data is going to be reused a lot once in cache. ``1`

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman added a comment. CI still seems unhappy: Failed Tests (1): Clang :: Sema/warn-unused-parameters.c Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:290-292 +// Do not warn on naked functions. +[[gnu::naked]] int nakedFun

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

nathanchance added a subscriber: nickdesaulniers. nathanchance added a comment. In D105169#3242949 , @hyeongyukim wrote: > @nathanchance Hi, I analyzed all four warnings. Thanks a lot for doing this! > Warning #1: can be handled by x86-backend. filled

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 400102. rmaz added a comment. Update VirtualFileSystemTest to validate relative root paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Input

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 ___

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187 +def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen", "ExtZvl::Zvl64b", + "'Zvl' (Minimum Vector Length) 64", + [FeatureStdExtZvl32b

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

eopXD updated this revision to Diff 400098. eopXD marked 8 inline comments as done. eopXD added a comment. Address comments. Thanks for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files:

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

bmahjour added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/PowerPC/optimal-epilog-vectorization.ll:273-276 -; VF-TWO-CHECK-DAG: [[LOOPID_MV]] = distinct !{[[LOOPID_MV]], [[LOOPID_DISABLE_VECT:!.*]]} -; VF-TWO-CHECK-DAG: [[LOOPID_EV]] = distinct !{[[LOOPID_EV

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3242274 , @fdwr wrote: >> I think no one just had thought about it. :) > > @HazardyKnusperkeks Happy new year. Just in case it gets forgotten, I'm > squeaking on behalf of a few stackoverflowers 😁 (#52158077

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unused-parameters.cpp:290-292 +// Do not warn on naked functions. +[[gnu::naked]] int nakedFunction(int a, float b, const char *c) { ; } +__attribute__((naked)) void nakedFunction(int

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:90 void VisitDeclStmt(const DeclStmt *S) { -// FIXME: Add support for group decls, e.g: `int a, b;` -if (S->isSingleDecl()) { - if (const auto *D = dyn_cast(S->getSingleDecl

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

efriedma added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/PowerPC/optimal-epilog-vectorization.ll:273-276 -; VF-TWO-CHECK-DAG: [[LOOPID_MV]] = distinct !{[[LOOPID_MV]], [[LOOPID_DISABLE_VECT:!.*]]} -; VF-TWO-CHECK-DAG: [[LOOPID_EV]] = distinct !{[[LOOPID_EV

[PATCH] D117172: [OpenMP] Fix problems with the declare variant append_args clause

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d5b9fb3e3cd: [OpenMP] Fix problems with the declare variant append_args clause (authored by mikerice). Herald added a project: clang. Herald added a

[clang] 3d5b9fb - [OpenMP] Fix problems with the declare variant append_args clause

Author: Mike Rice Date: 2022-01-14T11:09:27-08:00 New Revision: 3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580 URL: https://github.com/llvm/llvm-project/commit/3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580 DIFF: https://github.com/llvm/llvm-project/commit/3d5b9fb3e3cd60d3bb755e43c1abdea42d2e7580.diff LOG

[PATCH] D117348: [Preprocessor] Reduce the memory overhead of `#define` directives

arphaman created this revision. arphaman added reviewers: ravikandhadai, egorzhdan, aaron.ballman, rsmith. Herald added subscribers: ributzka, kristof.beyls, mgorny. arphaman requested review of this revision. Recently we observed high memory pressure caused by clang during some parallel builds.

[PATCH] D117296: Document several clang-supported builtins

serge-sans-paille updated this revision to Diff 400080. serge-sans-paille marked 8 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117296/new/ https://reviews.llvm.org/D117296 Files: clang/docs/LanguageExtensions.rst Index: clang/docs/LanguageExtensions.rst

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon updated this revision to Diff 400078. MuAlphaOmegaEpsilon added a comment. Fix failing test by updating clang/test/Sema/warn-unused-parameters.c expected warnings amount Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116778/new/

[PATCH] D93793: [IR] Let IRBuilder's CreateVectorSplat/CreateShuffleVector use poison as placeholder

bmahjour added inline comments. Comment at: llvm/test/Transforms/LoopVectorize/PowerPC/optimal-epilog-vectorization.ll:273-276 -; VF-TWO-CHECK-DAG: [[LOOPID_MV]] = distinct !{[[LOOPID_MV]], [[LOOPID_DISABLE_VECT:!.*]]} -; VF-TWO-CHECK-DAG: [[LOOPID_EV]] = distinct !{[[LOOPID_EV

[clang] 2bcba21 - [CPU-Dispatch] Make sure Dispatch names get updated if previously mangled

Author: Erich Keane Date: 2022-01-14T10:45:55-08:00 New Revision: 2bcba21c8ba95de866ed6333fa5cd29d5d232afe URL: https://github.com/llvm/llvm-project/commit/2bcba21c8ba95de866ed6333fa5cd29d5d232afe DIFF: https://github.com/llvm/llvm-project/commit/2bcba21c8ba95de866ed6333fa5cd29d5d232afe.diff L

[PATCH] D116595: [clang][sema] Add missing diagnostic parameter

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think the test behavior is pretty mysterious and there's likely some other bug happening, but this is incremental progress and definitely fixes an issue, so LGTM! ==

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

MuAlphaOmegaEpsilon added a comment. In D116778#3244233 , @aaron.ballman wrote: > The changes look good aside from the precommit CI failing. Can you > investigate? Absolutely, I'm already giving a look at it! :) Repository: rG LLVM Github Monorepo

[PATCH] D117339: [clang][dataflow] Add transfer functions for bind temporary and static cast

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added a subscriber: rnkovacs. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow analysis

[PATCH] D116778: [clang-tidy][clang] Don't trigger unused-parameter warnings on naked functions

aaron.ballman added a comment. The changes look good aside from the precommit CI failing. Can you investigate? Comment at: clang/test/Sema/warn-unused-parameters.c:27-29 // CHECK-everything: 6 warnings generated // CHECK-everything-error: 5 errors generated // CHECK-everythi

[PATCH] D117312: [clang][lex] NFC: Simplify calls to `LookupFile`

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117312/new/ https://reviews.llvm.org/D117312

[PATCH] D117309: [clang] NFC: Remove unused `DirectoryLookup`

ahoppen accepted this revision. ahoppen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117309/new/ https://reviews.llvm.org/D117309

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. @rjmccall @pengfei @andrew.w.kaylor review please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D116174: [clang] support relative roots to vfs overlays

benlangmuir added a comment. Make sure the test failure gets fixed, but otherwise LGTM. > x64 debian > LLVM-Unit.Support/_/SupportTests::VFSFromYAMLTest.RelativePaths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.o

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. @Fznamznon @bader @Naghasan reviews please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D117296: Document several clang-supported builtins

aaron.ballman added a comment. Thanks for this new documentation! I'm by no means an expert in these builtins, so I had some questions on places we might want to expand things a bit more. Comment at: clang/docs/LanguageExtensions.rst:2183 +n * sizeof(fl

[PATCH] D116186: Comment parsing: Simplify Lexer::skipLineStartingDecorations (NFC)

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice simplification, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116186/new/ https://reviews.llvm.org/D116186

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

erichkeane added a comment. Right, yeah, so there are a couple of problems with AttributedType. First, it gets lost almost as soon as you get out of SemaType about 90% of the time. Anything that does some level of canonicalization ends up losing it, so the AttributedType information is lost a

[PATCH] D116190: Comment parsing: Don't recognize commands in single-line double quotation

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/CommentLexer.cpp:278 + +again: + size_t End = aaronpuchert wrote: > gribozavr2 wrote: > > I'd suggest refactoring to a

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D114235#3243429 , @mboehme wrote: > Thanks for the feedback! And no worries about the delay -- I know you've got > a lot on your p

[PATCH] D116633: Add -fsanitize-address-param-retval to clang.

vitalybuka added inline comments. Comment at: clang/test/Driver/fsanitize-memory-param-retval.c:8-9 + +// RUN: %clang -target aarch64-linux-gnu -fsyntax-only %s -fsanitize=memory -fsanitize-memory-param-retval -c -### 2>&1 | FileCheck --check-prefix=11 %s +// 11: "-fsanitize-mem

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

mprobst added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3522 + if ((Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier()) || + (Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && + Right.is(TT_JsTypeOperator)) ---

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. In D117293#3243772 , @vitalybuka wrote: > Just noticed, -enable-noundef-analysis is missing tests undef > llvm/llvm-project/clang/test/Driver/ > Can you add few near maybe before > llvm-project/clang/test/Driver/clang_f_opts

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM go for it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D111400: [Clang] Implement P2242R3

aaron.ballman added a comment. In D111400#3172097 , @cor3ntin wrote: > Regression compared to the status quo: > This code no longer warns (as noted by Hubert above) > > auto f = [](bool b) { > if (b) return 42; > static int x = 0; > return x

[PATCH] D116713: [clangd] Support configuration of inlay hints.

jackoalan added a comment. Assuming origin/maain is a branch typo and is no longer being tracked, would you please delete the upstream one in https://github.com/llvm/llvm-project/branches? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116713/new/

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Looks ok from my side. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117197/new/ https://reviews.llvm.org/D117197 ___ cfe-commits mail

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 48. rmaz added a comment. Add comment to describe relative root path behaviour Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsover

[PATCH] D117293: enable noundef analysis with -fsanitize-memory-param-retval

vitalybuka added a comment. Just noticed, -enable-noundef-analysis is missing tests undef llvm/llvm-project/clang/test/Driver/ Can you add few near maybe before llvm-project/clang/test/Driver/clang_f_opts.c:531 (just before discard-value-names tests) Repository: rG LLVM Github Monorepo CHA

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3522 + if ((Left.is(TT_JsTypeOperator) && Right.isTypeOrIdentifier()) || + (Left.isTypeOrIdentifier() || Left.is(TT_TemplateCloser)) && + Right.is(TT_JsTypeOperator))

[PATCH] D117321: [clang] Remap file path in __PRETTY_FUNCTION__

jyyou.tw created this revision. jyyou.tw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. __PRETTY_FUNCTION__ may have file path in template argument but -fmacro-prefix-map can't remap it. This patch tries to fix the problem. Repository:

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94955/new/ https://reviews.llvm.org/D94955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

  1   2   >