gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/AST/CommentLexer.cpp:278 + +again: + size_t End = ---------------- aaronpuchert wrote: > gribozavr2 wrote: > > I'd suggest refactoring to a `while (true)` if you don't mind. > I was imitating `lexVerbatimBlockFirstLine`, but I don't mind either way. I see. No worries then. ================ Comment at: clang/lib/AST/CommentLexer.cpp:290 + if (End != StringRef::npos && *(TokenPtr + End) == '\"') + TokenPtr += End + 1; + goto again; ---------------- aaronpuchert wrote: > gribozavr2 wrote: > > Does Doxygen understand escaped quotes? > > > > ``` > > /// "@hello\"@hello" > > ``` > Vim syntax highlighting suggests it does, but at least my version actually > doesn't: `"@c a \" @c b"` is translated to `"@c a \" <code>b"</code>`. So the > escaped quote seems to end the quotation. Got it, thanks for checking! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116190/new/ https://reviews.llvm.org/D116190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
