[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114396/new/ https://reviews.llvm.org/D114396 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Ok now I'm a little puzzled, shouldn't this be covered by `AllowShortIfStatementsOnASingleLine`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 __

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. For that example, yes, approach #3 would result in that exact same IR on targets that lack direct hardware support for `_Float16` operations. But getting that behavior right in general requires a different implementation than is provided by this patch, which is implem

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/Float16-aritmetic.c:8-9 + // CHECK: alloca half + // CHECK: store half {{.*}}, half* + // CHECK: store half {{.*}}, half* + // CHECK: load half, half* zahiraam wrote: > pengfei wrote: > > This

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added a comment. > Should also generate this same IR right? For `a + b + c`, yes, they are the same. For `a + b`, no. That's the difference between approaches #3 and #4, which I didn't emphasize before :) https://godbolt.org/z/onbGeqdYv CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114082: [WIP] Normalize String Attributes

mehdi_amini added a comment. The patch is pretty large, any chance you could split in two? First the change introducing the AttributeKey and changing the API, and then updating all the callees separately as a follow up? Comment at: llvm/include/llvm/IR/Attributes.h:84 + } +}

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks added a comment. In D22505#3147501 , @MyDeveloperDay wrote: > I think so, it came to the top because someone subscribed to it, I was > wondering if this was something that is still needed or if our existing > options cover this. > > I

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for helping to complete the OpenMPIRBuilder implementation! Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSi

[PATCH] D114408: Fold a lot of ffixed_x if judgments

achieveartificialintelligence updated this revision to Diff 389091. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114408/new/ https://reviews.llvm.org/D114408 Files: clang/lib/Driver/ToolChains/

[PATCH] D114411: [WIP][modules] Avoid deserializing Decls from hidden (sub)modules.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. The test case is for Objective-C but it is likely other languages like C++ are affected as well, just haven't created appropriate test cases. The test case

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

owenpan accepted this revision. owenpan added a comment. Should we add an if-else example to the documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320

[PATCH] D114082: [WIP] Normalize String Attributes

Nuu added a comment. Thanks for this. I planned something similar to turn string literal typo errors into compile errors as well. The typos are really hard to identify :-P Some suggestions on using tablegen. Comment at: llvm/include/llvm/IR/Attributes.h:977-1133 +constexp

[PATCH] D114408: Fold a lot of ffixed_x if judgments

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: simoncook, asb, lenary, luismarques. Herald added subscribers: frasercrmck, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D114407: [CUDA][SPIRV] Use OpenCLKernel CC for CUDA -> SPIRV

dcastagna created this revision. Herald added subscribers: carlosgalvezp, Naghasan, ldrumm, ThomasRaoux, Anastasia, yaxunl. dcastagna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Select the OpenCLKernel calling convention for kernels wh

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

lkail added a comment. Looks a more general way should be implemented in tailduplicator to avoid adding quadratic edges in CFGs. BRANCHES EmptyLineAfterFunctionDefinition, fix_asan, main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2 ___

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

stevewan added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114381/new/ https://reviews.llvm.org/D114381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases the likelihood of data to be a

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: clang/examples/CallSuperAttribute/CallSuperAttrInfo.cpp:150 + if (args[0] == "help") { +llvm::errs() << "Help for the CallSuperAttr plugin goes

[PATCH] D114213: Compilation Database: Point Bazel users to a solution

cpsauer added a comment. Good call, @nridge. Will do as soon as we land this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114213/new/ https://reviews.llvm.org/D114213 ___ cfe-commits mailing list c

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

alexfh added a comment. Reduced the problematic file to this: F20567816: test2.cc $ time ./clang-before -O3 -c test2.cc real 0m0.242s user 0m0.178s sys 0m0.064s $ time ./clang-after -O3 -c test2.cc real 0m41.063s user 0m40.971s sys 0m0.0

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1055-1077 + while (FormatTok) { +if (FormatTok->is(tok::colon)) { + FormatTok->setType(TT_ModulePartitionColon); +} +// Handle import as we would an include statement +

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1055-1077 + while (FormatTok) { +if (FormatTok->is(tok::colon)) { + FormatTok->setType(TT_ModulePartitionColon); +} +// Ha

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I agree I think this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commits

[PATCH] D80528: [clang-format][WIP] Run more stability FormatTests

MyDeveloperDay added a comment. @JakeMerdichAMD are you still interested in landing this, if not I'm happy to NFC it in over the next couple of weeks, if others agree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80528/new/ https://reviews.llvm.o

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

MyDeveloperDay added a comment. I think so, it came to the top because someone subscribed to it, I was wondering if this was something that is still needed or if our existing options cover this. I recently came across a style like this. I don't know if there is still interest. Repository:

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Request changes according to the outstanding comment "But in general I'm not in favor of adding a dependence on having the LTO plugin available to all non-lld links by default." A

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

emaste added a subscriber: myfreeweb. emaste added a comment. Similar idea to D6 (libc++ default if major not specified) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114396/new/ https://reviews.llvm.org/D114396 ___

[PATCH] D114396: [Driver] Default to current FreeBSD profiling behaviour

emaste created this revision. emaste added a reviewer: dim. Herald added subscribers: krytarowski, arichardson. emaste requested review of this revision. FreeBSD provided special _p.a libraries for use with -pg prior to FreeBSD 14. They are no longer used or provided. If the target does not spe

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

echristo added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases the likelihood of data to be

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2dec2aa3ad08: [Driver] Default to libc++ on FreeBSD (authored by jbeich, committed by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 2dec2aa - [Driver] Default to libc++ on FreeBSD

Author: Jan Beich Date: 2021-11-22T16:47:03-05:00 New Revision: 2dec2aa3ad083dbde838809f0e8c7ae31110e111 URL: https://github.com/llvm/llvm-project/commit/2dec2aa3ad083dbde838809f0e8c7ae31110e111 DIFF: https://github.com/llvm/llvm-project/commit/2dec2aa3ad083dbde838809f0e8c7ae31110e111.diff LOG

[PATCH] D80528: [clang-format][WIP] Run more stability FormatTests

HazardyKnusperkeks added a comment. It says tests are failing. But generally this seems to be a good idea. So one should take the tests one by one. I would do it, but currently I'm trying to wrap my head around some of the internals, to get my requires clauses correctly formatted. ;) Reposito

[PATCH] D114394: Compile-time computation of string attribute hashes

serge-sans-paille created this revision. serge-sans-paille added reviewers: dblaikie, nikic. Herald added subscribers: ormris, dexonsmith, wenlei, okura, jdoerfert, kuter, haicheng, hiraditya, eraman. serge-sans-paille requested review of this revision. Herald added a reviewer: jdoerfert. Herald a

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks added a comment. This is dead, isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22505/new/ https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D110549: [HIPSPV][1/4] Refactor HIP tool chain

tra added a subscriber: echristo. tra added inline comments. Comment at: clang/lib/Driver/ToolChains/HIPUtility.cpp:119-133 + // Add MC directives to embed target binaries. We ensure that each + // section and image is 16-byte aligned. This is not mandatory, but + // increases

[PATCH] D110618: [HIPSPV][2/4] Add HIPSPV tool chain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general, modulo push_back/append nits. Comment at: clang/include/clang/Driver/Options.td:3701 " do not include the default CUDA/HIP wrapper headers">; +def nohipwrapperi

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e2fd879e6f9: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD (authored by adalava, committed by jsji). Changed prior to commit: https://reviews.llvm.org/D113451?vs=385985&id=389001#toc Re

[clang] 8e2fd87 - [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

Author: Alfredo Dal'\''Ava Junior Date: 2021-11-22T20:42:10Z New Revision: 8e2fd879e6f91b1e4fdf6217a667079aaeaece99 URL: https://github.com/llvm/llvm-project/commit/8e2fd879e6f91b1e4fdf6217a667079aaeaece99 DIFF: https://github.com/llvm/llvm-project/commit/8e2fd879e6f91b1e4fdf6217a667079aaeaece9

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

jsji added inline comments. Comment at: clang/test/CodeGen/ppc-mm-malloc-le.c:10 // RUN: %clang -target powerpc64le-unknown-linux-gnu -S -emit-llvm %s -fno-discard-value-names -mllvm -disable-llvm-optzns -o - | llvm-cxxfilt | FileCheck %s +// RUN: %clang -target powerpc64le-un

[PATCH] D112913: Misleading bidirectional detection

serge-sans-paille added a comment. Gentle ping @MaskRay and/or @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112913/new/ https://reviews.llvm.org/D112913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114229: [clang][driver] Always add LTO options when using GNU toolchain

serge-sans-paille added subscribers: rsmith, serge-sans-paille. serge-sans-paille added a comment. Gentle ping @MaskRay and/or @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114229/new/ https://reviews.llvm.org/D114229 _

[PATCH] D114326: Update the list of CUDA versions up to 11.5

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; mojca wrote

[PATCH] D114108: [NFC][clang] Inclusive language: rename master variable to controller in debug-info tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad501054f1b5: [NFC][clang] Inclusive language: rename master variable to controller in debug… (authored by quinnp). Repository: rG LLVM Github Mon

[clang] ad50105 - [NFC][clang] Inclusive language: rename master variable to controller in debug-info tests

Author: Quinn Pham Date: 2021-11-22T14:02:54-06:00 New Revision: ad501054f1b5ce0aca47c931aa03a22706e4ff8d URL: https://github.com/llvm/llvm-project/commit/ad501054f1b5ce0aca47c931aa03a22706e4ff8d DIFF: https://github.com/llvm/llvm-project/commit/ad501054f1b5ce0aca47c931aa03a22706e4ff8d.diff LO

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

Re: [PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

On Mon, Nov 22, 2021 at 2:28 PM John McCall wrote: > On Mon, Nov 22, 2021 at 1:08 PM David Goldblatt via Phabricator < > revi...@reviews.llvm.org> wrote: > >> and related projects avoid relying on alignment guarantees (e.g. >> libstdc++ at one point considered assuming that 8-byte allocs were 16-

[clang] a40dcd0 - [Driver] correct typo in FreeBSD 14 test

Author: Ed Maste Date: 2021-11-22T14:37:27-05:00 New Revision: a40dcd060e9d374d68df53b881d62e4de2bc310a URL: https://github.com/llvm/llvm-project/commit/a40dcd060e9d374d68df53b881d62e4de2bc310a DIFF: https://github.com/llvm/llvm-project/commit/a40dcd060e9d374d68df53b881d62e4de2bc310a.diff LOG:

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

comanea added a comment. I believe there is an issue that this change introduced. It is described here. https://bugs.llvm.org/show_bug.cgi?id=52473 If anyone could provide some insight, it would be much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D111457: [clang][test] Add lit helper for windows paths

rnk added a comment. These seem like generic substitutions that would be useful to anyone writing lit tests. We already have `%{pathsep}`: https://llvm.org/docs/CommandGuide/lit.html#substitutions These should live there as well, and be documented similarly, I think. Repository: rG LLVM Gith

Re: [PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

On Mon, Nov 22, 2021 at 1:08 PM David Goldblatt via Phabricator < revi...@reviews.llvm.org> wrote: > davidtgoldblatt added a comment. > > (For background: I'm a jemalloc maintainer and wrote N2293). > > In D100879#3145361 , @rjmccall > wrote: > > > Platfor

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. Question about this comment: 3. “ Approaches #1 and #2 require a lot of intermediate conversions when hardware isn't available. In our example, a + b + c has to be calculated as (_Float16) ((float) (_Float16) ((float) a + (float) b) + (float) c), where the result of o

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

adalava added a comment. In D113451#3124461 , @jsji wrote: > LGTM. Thanks for enabling this for FreeBSD. Thanks for reviewing it. If you and others with merge permissions think it's ready, please merge it (I don't have the permissions) Thanks!! Repo

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson added a comment. Thank you all for the feedback! Would it be ok to proceed with removing the `nullptr` checking for `basic_string_view` in `bugprone-string-constructor`, as Alex indicated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 388973. CJ-Johnson added a comment. Rebase on head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModul

[PATCH] D113148: Add new clang-tidy check for string_view(nullptr)

CJ-Johnson updated this revision to Diff 388972. CJ-Johnson marked 6 inline comments as done. CJ-Johnson added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113148/new/ https://reviews.llvm.org/D113148 Files:

[PATCH] D114312: libfuzzer: Disable broken tests for arm

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e67276d984d: libfuzzer: Disable broken tests for arm (authored by manojgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114312/new/ https://reviews.ll

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/Modules/odr_hash.cpp:4288 S s; +// expected-error@first.h:* {{'ParameterTest::S::Foo' has different definitions in different modules; definition in module 'FirstModule' first difference is 1st parameter with name ''}} +//

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb created this revision. krisb added reviewers: thakis, rtrieu, rsmith. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partially fixes PR24883. The patch sets Reference bit while instantiating a typedef if it previously was foun

[PATCH] D114381: [AIX] Disable unsupported offloading gpu tests

Jake-Egan created this revision. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114381 Files: clang/test/Driver/clang-offload-bundler-asserts-on.c clang/test/D

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna updated this revision to Diff 388961. jessesna added a comment. use the more dense "verifyFormat(after,Style)" calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 Files: clang/lib/Format/Unwr

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

davidtgoldblatt added a comment. (For background: I'm a jemalloc maintainer and wrote N2293). In D100879#3145361 , @rjmccall wrote: > Platforms are permitted to make stronger guarantees than the C standard > requires, and it is totally reasonable for co

[PATCH] D114209: [flang] Add -fno-automatic, refine IsSaved()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG996ef895cd3d: [flang] Add -fno-automatic, refine IsSaved() (authored by klausler). Herald added a project: clang. Herald added a subscriber: cfe-comm

[clang] 996ef89 - [flang] Add -fno-automatic, refine IsSaved()

Author: Peter Klausler Date: 2021-11-22T10:06:38-08:00 New Revision: 996ef895cd3d1313665a42fc8e20d1d4e1cf2a28 URL: https://github.com/llvm/llvm-project/commit/996ef895cd3d1313665a42fc8e20d1d4e1cf2a28 DIFF: https://github.com/llvm/llvm-project/commit/996ef895cd3d1313665a42fc8e20d1d4e1cf2a28.diff

[PATCH] D80528: [clang-format][WIP] Run more stability FormatTests

MyDeveloperDay added subscribers: HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added a comment. @HazardyKnusperkeks, @curdeius, @owenpan I feel we should try and get this committed, people tend to follow the adjacent style of the unit tests, and I sort of feel we keep having to ask peop

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

tschuett added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:2121 +static void addSIMDMetadata(BasicBlock *block, +ArrayRef Properties) { + for (auto &I : *block) { Properties is unused in the function? Repo

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5406 + "{ }", + format("if(a){}else if(b){}else{}", Style), Style); + Style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_Never; you ca

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

tschuett added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:520 + /// Add metadata to simd-ise a loop. + /// I believe LLVM uses American English. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

arnamoy10 created this revision. arnamoy10 added reviewers: kiranchandramohan, peixin, bryanpkc, Meinersbur. Herald added a subscriber: hiraditya. arnamoy10 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald a

[PATCH] D114088: [PowerPC] Add BCD add/sub/cmp builtins

nemanjai added inline comments. Comment at: clang/lib/Headers/altivec.h:19050 +} + +static __inline__ long __bcdcmpeq(vector unsigned char __a, NeHuang wrote: > Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not > used. I added it for

[PATCH] D114326: Update the list of CUDA versions up to 11.5

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; kadircet

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

alexfh added a comment. In rGc93f93b2e3f28997f794265089fb8138dd5b5f13#1039669 , @bgraur wrote: > Early heads up that this revision causes a large regression in compilation > time for some of our internal source files:

[Diffusion] rGc93f93b2e3f2: Revert "Revert "Recommit "Revert "[CVP] processSwitch: Remove default case when…

alexfh added a subscriber: junparser. BRANCHES fix_asan, main Users: junparser (Author) https://reviews.llvm.org/rGc93f93b2e3f2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste added inline comments. Comment at: clang/test/Driver/freebsd.cpp:13-14 +// RUN: | FileCheck --check-prefix=CHECK-PG-DEFAULT %s // RUN: %clangxx %s -### -pg -o %t.o -target amd64-unknown-freebsd14.0 -stdlib=platform 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-PG-

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

emaste updated this revision to Diff 388931. emaste added a comment. rebase tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/test/Driver/freebsd.cpp Index: clang/test/Driver/freebsd

[PATCH] D113754: [Analyzer][Core] Simplify IntSym in SValBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rGffc32efd1cd6: [Analyzer][Core] Simplify IntSym in SValBuilder (authored by martong). Changed prior to commit: https://reviews.llvm.org/D113754?vs=386800&id=388927#toc Repository: rG LLVM Github Monor

[clang] ffc32ef - [Analyzer][Core] Simplify IntSym in SValBuilder

Author: Gabor Marton Date: 2021-11-22T17:33:43+01:00 New Revision: ffc32efd1cd6a34659e2c559e9ba6ee923b1637a URL: https://github.com/llvm/llvm-project/commit/ffc32efd1cd6a34659e2c559e9ba6ee923b1637a DIFF: https://github.com/llvm/llvm-project/commit/ffc32efd1cd6a34659e2c559e9ba6ee923b1637a.diff

[clang] bf20a3b - Use std::string::substr (NFC)

Author: Kazu Hirata Date: 2021-11-22T08:21:09-08:00 New Revision: bf20a3b9b94a5b6fc97fdba4546391c30ad26a22 URL: https://github.com/llvm/llvm-project/commit/bf20a3b9b94a5b6fc97fdba4546391c30ad26a22 DIFF: https://github.com/llvm/llvm-project/commit/bf20a3b9b94a5b6fc97fdba4546391c30ad26a22.diff L

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

jessesna updated this revision to Diff 388924. jessesna added a comment. use verifyFormat instead of EXPECT_EQ (as this does some extra stuff to ensure its stable) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1055-1077 + while (FormatTok) { +if (FormatTok->is(tok::colon)) { + FormatTok->setType(TT_ModulePartitionColon); +} +// Handle import as we would an include statement +else

[PATCH] D113490: [NFC] Let Microsoft mangler accept GlobalDecl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/lib/AST/MicrosoftMangle.cpp:47 + if (auto *CD = dyn_cast(DC)) +GD = GlobalDecl(CD, Ctor_Complete); + else if (auto *DD = dyn_cast(DC))

[PATCH] D114370: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When a symbol comes from the non

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

jyknight added a comment. I think this patch was wrong -- we should not be assuming 16-byte alignment for an allocation smaller than 16 bytes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100879/new/ https://reviews.llvm.org/D100879

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Nothing majorly wrong here, its looks pretty good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114320/new/ https://reviews.llvm.org/D114320 ___ cfe-commits mailing list

[PATCH] D114320: [clang-format] Extend AllowShortBlocksOnASingleLine for else blocks

MyDeveloperDay added a comment. Could you add the case where the else is not empty. Comment at: clang/unittests/Format/FormatTest.cpp:5400 + Style.BraceWrapping.AfterControlStatement = FormatStyle::BWACS_Always; + EXPECT_EQ("if (a)\n" +"{\n" Can

[PATCH] D113490: [NFC] Let Microsoft mangler accept GlobalDecl

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:47 + if (auto *CD = dyn_cast(DC)) +GD = GlobalDecl(CD, Ctor_Complete); + else if (auto *DD = dyn_cast(DC)) rnk wrote: > I would prefer if yo

[PATCH] D114312: libfuzzer: Disable broken tests for arm

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114312/new/ https://reviews.llvm.org/D114312 _

[PATCH] D112427: [ARM] Implement setjmp BTI placement for PACBTI-M

stuij updated this revision to Diff 388891. stuij added a comment. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. addressed review comments, namely adding a commandline argument, `-mno-bti-at-return-twice`, to not place a bti instruction after a setjmp call. Reposit

[PATCH] D111617: [RISCV] Lazily add RVV C intrinsics.

HsiangKai updated this revision to Diff 31. HsiangKai added a comment. Update the implementation of getMangledName(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111617/new/ https://reviews.llvm.org/D111617 Files: clang/include/clang/Basic

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo added a comment. Sorry for taking so long to get back to you on this matter... In D113268#3112026 , @sammccall wrote: >> For someone unfamiliar with the tool, is there a simple "smoke test >> procedure" I could try out with it to kick the tyres

[PATCH] D113268: [clangd] Fix tests with forward slash as separator on windows

mstorsjo updated this revision to Diff 388857. mstorsjo added a comment. Added a comment about the surprising change where the order of append and native is switched. Made the modification to `testRoot()` less hacky. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D113250: [clang][driver] Add -fplugin-arg- to pass arguments to plugins

tbaeder updated this revision to Diff 388853. tbaeder added a comment. Added two new warning types and used them for diagnosing malformed `-fplugin-arg` options. Also added tests for that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113250/new/ https://reviews.llvm.org/D113250 Files

[PATCH] D114254: [libtooling][clang-tidy] Fix crashing on rendering invalid SourceRanges

steakhal updated this revision to Diff 388850. steakhal marked an inline comment as done. steakhal added a comment. - prefer `empty()` over `size() == 0` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114254/new/ https://reviews.llvm.org/D114254 Files: clang-tools-extra/clang-tidy/Cla

[PATCH] D114326: Update the list of CUDA versions up to 11.5

kadircet added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:131 + std::initializer_list Versions = { + "11.5", "11.4", "11.3", "11.2", "11.1", "11.0", "10.2", "10.1", + "10.0", "9.2", "9.1", "9.0", "8.0", "7.5", "7.0"}; looks

[clang] 84bf5e3 - Fix various problems found by fuzzing.

Author: Manuel Klimek Date: 2021-11-22T11:08:38+01:00 New Revision: 84bf5e328664db2e744c4651c52d2460b1733d09 URL: https://github.com/llvm/llvm-project/commit/84bf5e328664db2e744c4651c52d2460b1733d09 DIFF: https://github.com/llvm/llvm-project/commit/84bf5e328664db2e744c4651c52d2460b1733d09.diff

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet updated this revision to Diff 388821. courbet added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114249/new/ https://reviews.llvm.org/D114249 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitializatio

[PATCH] D114249: [clang-tidy] performance-unnecessary-copy-initialization: Fix false negative.

courbet added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:97 + cxxOperatorCallExpr(callee(MethodDecl), hasArgument(0, ReceiverExpr), + hasArgument(0, hasType(recordType(hasDeclaration( +

[clang-tools-extra] a82942d - Add missing clang-tidy args in index.rst (NFC)

Author: Salman Javed Date: 2021-11-22T22:50:05+13:00 New Revision: a82942dd07ea652081f8f293b73801323a4dbbe9 URL: https://github.com/llvm/llvm-project/commit/a82942dd07ea652081f8f293b73801323a4dbbe9 DIFF: https://github.com/llvm/llvm-project/commit/a82942dd07ea652081f8f293b73801323a4dbbe9.diff

  1   2   >