nemanjai added inline comments.
================ Comment at: clang/lib/Headers/altivec.h:19050 +} + +static __inline__ long __bcdcmpeq(vector unsigned char __a, ---------------- NeHuang wrote: > Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not > used. I added it for completeness, but there is currently no need to use it for any builtin. ================ Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5096 + SubReg = PPC::sub_un; + ShiftVal = 0; + break; ---------------- NeHuang wrote: > can we remove this as default is 0? Sounds good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114088/new/ https://reviews.llvm.org/D114088 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits