[clang] a9d1970 - Revert "[clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs"

Author: Petr Hosek Date: 2021-07-30T18:56:51-07:00 New Revision: a9d1970384aa3908adbf6f50f110c375def58947 URL: https://github.com/llvm/llvm-project/commit/a9d1970384aa3908adbf6f50f110c375def58947 DIFF: https://github.com/llvm/llvm-project/commit/a9d1970384aa3908adbf6f50f110c375def58947.diff LO

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:234 + set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS OFF CACHE BOOL "") + set(RUNTIMES_aarch64-unknown-fuchsia+hwasan_CMAKE_CXX_FLAGS "${RUNTIMES_aarch64-unkno

[PATCH] D106755: Extended format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 363245. MarcusJohnson91 added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106755/new/ https://reviews.llvm.org/D106755 Files: clang-tools-extra/clang-tidy/boost/UseToStringCheck.cpp clang-tools-extra/clang-tidy/misc

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

MarcusJohnson91 updated this revision to Diff 363244. MarcusJohnson91 added a comment. Rebased on Main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106756/new/ https://reviews.llvm.org/D106756 Files: clang/include/clang/AST/FormatString.h clang/lib/AST/FormatString.cpp clang/tes

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

efriedma added a comment. If you're having trouble making Arcanist work correctly, you can always just upload "git diff" or "git show" output at https://reviews.llvm.org/differential/diff/create/ . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

alexfh added a comment. In D104601#2916973 , @Meinersbur wrote: > @romanovvlad This is due to -fms-extensions. It Expands `__Pragma` to > `#pragma` instead of keeping it a `__Pragma`. This is a one-line fix. > > @alexfh This was fixed by D106924

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107139/new/ https://reviews.llvm.org/D107139 ___

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

dblaikie added a comment. In D107155#2917400 , @dexonsmith wrote: > In D107155#2916664 , @dblaikie > wrote: > >> Hmm, don't we have some other substitution feature that avoids the need to >> add the %? (like, I

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

HsiangKai updated this revision to Diff 363241. HsiangKai added a comment. Use '^' instead of '@2'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107139/new/ https://reviews.llvm.org/D107139 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/

[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

NoQ added a comment. Y'all writing really good patches lately. The updates on the C++ tests look spot on to me. I'm not sure if these tests contain any actual UB but the checker was anyway designed to be a bit more aggressive than that and that's exactly the kind of stuff we wanted it to warn

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG with a nit. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18446 bool FullCheck = true) { - NamedDecl *ND; - if (QTy->isIncompleteType(&ND))

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 added a comment. There is only one function in ConvertUTFWrapper.cpp: convertUTF32ToUTF8String idk wtf is going on, maybe the ammending the commit is breaking something? the diff I see here is correct... Maybe I should just make a new diff here entirely? CHANGES SINCE LAST ACT

[PATCH] D107200: Stop emit incomplete type error for a variable in an omp map clause where should not.

jyu2 created this revision. jyu2 added reviewers: jdoerfert, ABataev, mikerice, cfe-commits. jyu2 added a project: OpenMP. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Stop emit incomplete type error for a variable in a map clause wher

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

efriedma added a comment. As far as I can tell, the lastest version of the diff you uploaded still has the following issues that haven't been addressed: 1. The BOM handling is actually actively a problem if you're planning to use the interface to interpret wprintf format strings. We don't want

[PATCH] D106727: [flang] Produce proper "preprocessor output" for -E option

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3338ef93b028: [flang] Produce proper "preprocessor output" for -E option (authored by klausler). Herald added a project: clang. Herald added a subscr

[clang] 3338ef9 - [flang] Produce proper "preprocessor output" for -E option

Author: peter klausler Date: 2021-07-30T15:13:56-07:00 New Revision: 3338ef93b02837edf69abc203e15a42fa55aa1b3 URL: https://github.com/llvm/llvm-project/commit/3338ef93b02837edf69abc203e15a42fa55aa1b3 DIFF: https://github.com/llvm/llvm-project/commit/3338ef93b02837edf69abc203e15a42fa55aa1b3.diff

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 363216. MarcusJohnson91 added a comment. It seems like this diff keeps getting reverted? I've fixed all the issues mentioned, and the tests work now, everything is formatted correctly too. I've set git up to do full context diffs, but it's not worki

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

amyk added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1436 + +def int_ppc_ftdivdp : Intrinsic<[llvm_i32_ty], [llvm_double_ty, llvm_double_ty], [IntrNoMem]>; } Line too long? Comment at: llvm/include/llvm/IR/Intrins

[PATCH] D107125: [Diagnostic] Split 'qualifier on reference type has no effect' out into a new flag

lunasorcery added a comment. Sure thing - would the suite in /clang/test/SemaCXX/ be the right place to put that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107125/new/ https://reviews.llvm.org/D107125 _

[PATCH] D106755: Extended format string checking to wprintf/wscanf

efriedma added subscribers: tahonermann, cor3ntin. efriedma added inline comments. Comment at: clang/lib/AST/Expr.cpp:1081 +ArrayRef AR(getTrailingObjects(), + getTrailingObjects() + getByteLength()); +if (llvm::convertUTF16ToUTF8String(AR, Output)) {

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

efriedma added inline comments. Comment at: llvm/lib/Support/ConvertUTFWrapper.cpp:176 + // enough that we can fit a null terminator without reallocating. + Out.resize(SrcBytes.size() * UNI_MAX_UTF8_BYTES_PER_CODE_POINT + 1); + UTF8 *Dst = reinterpret_cast(&Out[0]); --

[PATCH] D107026: [Clang] Add support for attribute 'escape'

NoQ added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:260 +``escape`` placed on a function parameter of a pointer type is used to indicate +that the pointer can escape the function. This means that a reference to the object +the pointer points to that is d

[PATCH] D107139: [RISCV] Rename vector inline constraint from 'v' to 'vr' and 'vm' in IR.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:108 case 'v': -R = std::string("v"); +R = std::string("@2") + std::string(Constraint, 2); Constraint += 1; I believe most targets use `std::string("^") + std::string

[clang] 7f97dda - Revert "[OpenMP][AMDGCN] Initial math headers support"

Author: Jon Chesterfield Date: 2021-07-30T22:07:00+01:00 New Revision: 7f97ddaf8aa0062393e866b63e68c9f74da375fb URL: https://github.com/llvm/llvm-project/commit/7f97ddaf8aa0062393e866b63e68c9f74da375fb DIFF: https://github.com/llvm/llvm-project/commit/7f97ddaf8aa0062393e866b63e68c9f74da375fb.di

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. In D104904#2916943 , @ye-luo wrote: > Unforuantely I hit error on my ubuntu 20.04 system. > > #include > int main() > { } Given that ^ in fail.cpp and an invocation on a machine that doesn't have cuda or an nvidia

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

efriedma added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label %swdiv_MERGE quinnp wrote: >

[PATCH] D107190: [AMDGPU][HIP] Switch default DWARF version to 5

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107190/new/ https://reviews.llvm.org/D107190 ___ c

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:35 + // CHECK-NEXT: %1 = load ppc_fp128, ppc_fp128* @ldb + // CHECK-NEXT: %.fca.0.insert = insertvalue { ppc_fp128, ppc_fp128 } undef, ppc_fp128 %0, 0 + // CHECK-NEXT: %.fca.1.insert =

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp marked an inline comment as done. quinnp added inline comments. Comment at: llvm/test/CodeGen/PowerPC/LowerCheckedFPArith.ll:36 +; CHECK-NEXT: %2 = fdiv fast float %0, %1 +; CHECK-NEXT: %3 = fcmp une float %2, %2 +; CHECK-NEXT: br i1 %3, label %swdiv_HWDIV, label %swdiv

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. > Well some of them are exactly the same type as the `Lame` class example > above. Like: > `simbody/report-TestArray.cpp-testMoveConstructionAndAssignment-27-1.html#EndPath`. > (So the incomplete modelling of the destructor is at least one cause. The > other reason that yo

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

quinnp updated this revision to Diff 363189. quinnp added a comment. Addressing review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106959/new/ https://reviews.llvm.org/D106959 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/

[PATCH] D105909: [clang][CallGraphSection] Add type id metadata to indirect call and targets

MaskRay added a comment. (Two comments I forgot to push yesterday.) Comment at: clang/test/CodeGen/call-graph-section-1.cpp:39 + void f6(const Cls1 *a) {} + + // FT-DAG: define {{.*}} void @_ZN4Cls22f7ER4Cls1({{.*}} !type [[F_TCLS2F7:![0-9]+]] needs a test f

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

rnk added a comment. In D94639#2917340 , @SeTSeR wrote: > Hello! As far as I understand, Clang does not preserve info about namespace > for functions declared in namespaces with `-gline-numbers-only` flag. Is > there any way to retrieve this info for DWA

[PATCH] D107189: [z/OS]Remove overriding default attribute aligned value

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf4c7b738ee: [z/OS]Remove overriding default attribute aligned value (authored by fanbo-meng). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] bdf4c7b - [z/OS]Remove overriding default attribute aligned value

Author: Fanbo Meng Date: 2021-07-30T15:51:40-04:00 New Revision: bdf4c7b738ee3dfbcd468ec347beec58b6e43a5a URL: https://github.com/llvm/llvm-project/commit/bdf4c7b738ee3dfbcd468ec347beec58b6e43a5a DIFF: https://github.com/llvm/llvm-project/commit/bdf4c7b738ee3dfbcd468ec347beec58b6e43a5a.diff LO

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:45 + } + return true; +} samitolvanen wrote: > nickdesaulniers wrote: > > samitolvanen wrote: > > > nickdesaulniers wrote: > > > > Can llvm::any_of or llvm::none

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

rnk added a comment. I think the new approach of skipping non C-ish identifier names is reasonable. Looks good to me, but wait for the more active reviewers to stamp it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llv

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1783 +if (FieldPacked) { + FieldAlign = UnpackedFieldAlign = 1; +} else if (!MaxFieldAlignment.isZero()) { `UnpackedFieldAlign` is used to check if the packed attribute

[PATCH] D107189: [z/OS]Remove overriding default attribute aligned value

abhina.sreeskantharajan accepted this revision. abhina.sreeskantharajan added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107189/new/ https://reviews.llvm.org/D107189 ___ cfe-commits ma

[clang] 9019b55 - [PowerPC] Fix byte ordering of ld/st with length on BE

Author: Nemanja Ivanovic Date: 2021-07-30T14:37:24-05:00 New Revision: 9019b55b605a26cb5389399eceb34fa9ea0f URL: https://github.com/llvm/llvm-project/commit/9019b55b605a26cb5389399eceb34fa9ea0f DIFF: https://github.com/llvm/llvm-project/commit/9019b55b605a26cb5389399eceb34fa9ea0f.di

[PATCH] D107155: [clang][deps] Substitute clang-scan-deps executable in lit tests

dexonsmith added a comment. In D107155#2916664 , @dblaikie wrote: > Hmm, don't we have some other substitution feature that avoids the need to > add the %? (like, I think LLVM's tests don't usually use the % for many tool > names - but they still make f

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#2917357 , @haowei wrote: > We are seeing float related unit tests failing in Fuchsia after this patch. > What flags should we add to our build to match llvm's previous float point > behavior? This option: ffp-contract=

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

v.g.vassilev added inline comments. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:64 +// address of main, and some platforms can't implement GetMainExecutable +// without being given the address of a function in the main executable). +std::string GetExecutablePath(c

[PATCH] D107049: [clang-repl] Re-implement clang-interpreter as a test case.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:64 +// address of main, and some platforms can't implement GetMainExecutable +// without being given the addre

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:45 + } + return true; +} nickdesaulniers wrote: > samitolvanen wrote: > > nickdesaulniers wrote: > > > Can llvm::any_of or llvm::none_of be used here? > > > llvm/AD

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

haowei added a comment. We are seeing float related unit tests failing in Fuchsia after this patch. What flags should we add to our build to match llvm's previous float point behavior? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ http

[PATCH] D107190: [AMDGPU][HIP] Switch default DWARF version to 5

scott.linder created this revision. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. scott.linder requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Another attempt at changing this default,

[PATCH] D94639: [DebugInfo][CodeView] Change in line tables only mode to emit parent/context scopes for functions, using declarations for types

SeTSeR added a comment. Hello! As far as I understand, Clang does not preserve info about namespace for functions declared in namespaces with `-gline-numbers-only` flag. Is there any way to retrieve this info for DWARF? I thought FIXME at line 261 in CGDebugInfo was addressing exactly this issu

[PATCH] D107189: [z/OS]Remove overriding default attribute aligned value

fanbo-meng created this revision. fanbo-meng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make DefaultAlignForAttributeAligned consistent with SystemZ. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107189 Files: c

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD added a comment. Well some of them are exactly the same type as the `Lame` class example above. Like: `simbody/report-TestArray.cpp-testMoveConstructionAndAssignment-27-1.html#EndPath`. (So the incomplete modelling of the destructor is at least one cause. The other reason that you sug

[PATCH] D99364: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb438f6cbfc0: [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs (authored by leonardchan). Changed prior to commit: https://reviews.llvm.org/D99364?vs=349700&id=363173#toc Repositor

[clang] bb438f6 - [clang][cache] Update Fuchsia-stage2.cmake to create hwasan multilibs

Author: Leonard Chan Date: 2021-07-30T11:53:21-07:00 New Revision: bb438f6cbfc08eaa2cd9124a0ad581dd29f819b4 URL: https://github.com/llvm/llvm-project/commit/bb438f6cbfc08eaa2cd9124a0ad581dd29f819b4 DIFF: https://github.com/llvm/llvm-project/commit/bb438f6cbfc08eaa2cd9124a0ad581dd29f819b4.diff

[clang] a1532ed - [InstrProfiling] Make CountersPtr in __profd_ relative

Author: Fangrui Song Date: 2021-07-30T11:52:18-07:00 New Revision: a1532ed27582038e2d9588108ba0fe8237f01844 URL: https://github.com/llvm/llvm-project/commit/a1532ed27582038e2d9588108ba0fe8237f01844 DIFF: https://github.com/llvm/llvm-project/commit/a1532ed27582038e2d9588108ba0fe8237f01844.diff

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/O3-pipeline.ll:211 ret void -} \ No newline at end of file +} unrelated change? Comment at: llvm/test/CodeGen/PowerPC/int-ppc-ftdivdp.ll:7 +; RUN: llc -verify-machineinstrs

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

NeHuang added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-complex.c:1 +// RUN: %clang_cc1 -O2 -triple powerpc64-unknown-unknown \ +// RUN: -emit-llvm %s -o - -target-cpu pwr7 | FileCheck %s `// REQUIRES: powerpc-registered-target` ==

[PATCH] D107002: [PowerPC] Implement XL compatibility builtin __addex

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3426 + case PPC::BI__builtin_ppc_addex: { +if (SemaFeatureCheck(*this, TheCall, "power9-vector", + diag::err_ppc_builtin_only_on_arch, "9") || I think we start

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e124ff25681: [OpenCL] Replace test for pipe struct to test it with fixed triple (authored by azabaznov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10717

[clang] 4e124ff - [OpenCL] Replace test for pipe struct to test it with fixed triple

Author: Anton Zabaznov Date: 2021-07-30T21:49:20+03:00 New Revision: 4e124ff256813f060efd2cc307358b1f7bf962c4 URL: https://github.com/llvm/llvm-project/commit/4e124ff256813f060efd2cc307358b1f7bf962c4 DIFF: https://github.com/llvm/llvm-project/commit/4e124ff256813f060efd2cc307358b1f7bf962c4.diff

[PATCH] D103543: [compiler-rt][Fuchsia] Support HWASan on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG606ca48d79f3: [compiler-rt][Fuchsia] Support HWASan on Fuchsia (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103543/new/ https://

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:45 + } + return true; +} samitolvanen wrote: > nickdesaulniers wrote: > > Can llvm::any_of or llvm::none_of be used here? > > llvm/ADT/STLExtras.h > Maybe, but I

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 363166. samitolvanen added a comment. Also skip functions with names incompatible with XCOFF. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files: llvm/lib/T

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4c00b388285: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan… (authored by leonardchan). Repository: rG LLVM Github Mon

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:39 + // Promotion aliases are used only in inline assembly. It's safe to + // simply skip unusual names. Matches MCAsmInfo::isAcceptableChar(). + for (const char &C : Name) { -

[PATCH] D107024: [DIBuilder] Do not replace empty enum types

aprantl added a comment. I think that looks fine — I wonder if we should change the IR pretty printer to display empty arrays inline as `elements: !{}`, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107024/new/ https://reviews.llvm.org/D10702

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

gandhi21299 marked 7 inline comments as done. gandhi21299 added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fa

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:39 + // Promotion aliases are used only in inline assembly. It's safe to + // simply skip unusual names. Matches MCAsmInfo::isAcceptableChar(). + for (const char &C : Name) { --

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. This patch didn't change complex so I'm struggling to make sense of the backtrace. Something in libstdc++ needs memory but doesn't include it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://revie

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

azabaznov updated this revision to Diff 363155. azabaznov added a comment. Restore original test name which was changed in D106748 , use check-prefixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107176/new/ htt

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1781 - // pragma align(packed). - if (isAIXLayout(Context) && !MaxFieldAlignment.isZero() && !FieldSize) -FieldAlign = std::min(FieldAlign, MaxFieldAlignmentInBits); sfertile

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. > Correct -- that would be unfortunate as I believe you were hoping for this to > be in Clang 13 for ccache support. Yes, that would have been the ideal outcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/

[clang] 31d408f - Trim failing test

Author: Paul Robinson Date: 2021-07-30T10:51:08-07:00 New Revision: 31d408f9f94f3b97366d49c342734c195a343579 URL: https://github.com/llvm/llvm-project/commit/31d408f9f94f3b97366d49c342734c195a343579 DIFF: https://github.com/llvm/llvm-project/commit/31d408f9f94f3b97366d49c342734c195a343579.diff

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

NoQ added a comment. In D105821#2914082 , @RedDocMD wrote: > On running this patch on the `projects` directory, a bunch of projects emit > false-positives: mostly of the form `Potential memory leak`. This points to > the fact that without calling the de

[PATCH] D106900: [PowerPC][AIX] Packed zero-width bitfields do not affect alignment.

sfertile updated this revision to Diff 363147. sfertile added a comment. Fixed spelling and added a 'long long' zero width bitfield to the testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106900/new/ https://reviews.llvm.org/D106900 Files:

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur updated this revision to Diff 363146. Meinersbur added a comment. Refine test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107183/new/ https://reviews.llvm.org/D107183 Files: clang/lib/Frontend/PrintPreprocessedOutput.cpp clan

RE: [clang] 9ca905b - XFAIL a test on ppc64

H yeah, just because your compiler has both ppc and x86 targets doesn’t mean your system assembler is willing to target x86. I think it can keep the -integrated-as steps that verify the warning does what’s expected, and abandon actually running the external assembler. The -target options for

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Patch uploaded here: D107183 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mail

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, dblaikie, mstorsjo, romanovvlad, alexfh. Meinersbur added a project: clang. Meinersbur requested review of this revision. The -fms-extensions converts __pragma (and _Pragma) into a #pragma that has to occur at the begin

Re: [clang] 9ca905b - XFAIL a test on ppc64

On Fri, Jul 30, 2021 at 12:59 PM wrote: > Do you have a suggestion for how to fix it? This isn’t actually my test, > I tripped over it and it seemed like it would be easy to get it to work. > ☹ > I think removing all of the `-target` options might help. Alternatively, I don't see why the test s

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD updated this revision to Diff 363138. RedDocMD added a comment. Invalidating using inner pointer destructor call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105821/new/ https://reviews.llvm.org/D105821 Files: clang/lib/StaticAnalyzer/

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

aaron.ballman added a comment. In D104601#2916986 , @Meinersbur wrote: > In D104601#2916897 , @aaron.ballman > wrote: > >> In D104601#2916887 , @Meinersbur >> wrote: >>

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

Charusso resigned from this revision. Charusso added a comment. @NoQ, what do you think? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97699/new/ https://reviews.llvm.org/D97699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2916897 , @aaron.ballman wrote: > In D104601#2916887 , @Meinersbur > wrote: > >> I am working on a fix, but I wouldn't mind reverting. > > I would be comfortable reverting

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. @romanovvlad This is due to -fms-extensions. It Expands `__Pragma` to `#pragma` instead of keeping it a `__Pragma`. This is a one-line fix. @alexfh This was fixed by D106924 I would suggest to not revert. Will upload a patch for `-f

RE: [clang] 9ca905b - XFAIL a test on ppc64

Do you have a suggestion for how to fix it? This isn’t actually my test, I tripped over it and it seemed like it would be easy to get it to work. ☹ Thanks, --paulr From: Hubert Tong Sent: Friday, July 30, 2021 12:43 PM To: Robinson, Paul ; Paul Robinson Cc: cfe-commits Subject: Re: [clang]

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

ye-luo added a comment. Unforuantely I hit error #include int main() { } ~/opt/llvm-clang/build_mirror_offload_main/bin/clang++ -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa -Xopenmp-target=amdgcn-amd-amdhsa -march=gfx906 main.cpp -c works fine ~/opt/llvm-clang/build_mirror_offload_main/

Re: [clang] 9ca905b - XFAIL a test on ppc64

On Fri, Jul 30, 2021 at 12:05 PM Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Paul Robinson > Date: 2021-07-30T09:05:14-07:00 > New Revision: 9ca905b52d53c46aceb4d28e44dfbf4a815d0c68 > > URL: > https://github.com/llvm/llvm-project/commit/9ca905b52d53c46aceb4d28e44

[clang] c15d982 - XFAIL ppc => powerpc

Author: Paul Robinson Date: 2021-07-30T09:39:51-07:00 New Revision: c15d9822b3ab767d744e93d7d9c25d5f7d2faac8 URL: https://github.com/llvm/llvm-project/commit/c15d9822b3ab767d744e93d7d9c25d5f7d2faac8 DIFF: https://github.com/llvm/llvm-project/commit/c15d9822b3ab767d744e93d7d9c25d5f7d2faac8.diff

[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

rnk added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1712 + COFF::IMAGE_SCN_MEM_READ | COFF::IMAGE_SCN_LNK_COMDAT, + SectionKind::getText(), COMDATSymName, + COFF::IMAGE_COMDAT_SELECT_NODUPLICATES, UniqueID);

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

aaron.ballman added a comment. In D104601#2916887 , @Meinersbur wrote: > I am working on a fix, but I wouldn't mind reverting. I would be comfortable reverting the feature for Clang 13 and fixing forward on trunk (unless there's a need to revert from t

[PATCH] D106262: [clang][analyzer] Use generic note tag in alpha.unix.Stream .

Szelethus added a comment. In D106262#2915764 , @balazske wrote: > The bug type is passed to `constructNoteTag` only to identify what message > will be displayed. The bug types that are related to the current function (a > message should be here if the

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. I am working on a fix, but I wouldn't mind reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list c

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107176/new/ https://reviews.llvm.org/D107176

[PATCH] D106431: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum FixIt, and add support for initialization check of scoped enum.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a097efe7784: [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum (authored by Sockke, committed by whisperity). Changed prior t

[clang-tools-extra] 4a097ef - [clang-tidy] Fix cppcoreguidelines-init-variables by removing the enum

Author: Liuke Gehry Date: 2021-07-30T18:24:47+02:00 New Revision: 4a097efe7784767b7d12ffcb8f2b22b9f4d045e2 URL: https://github.com/llvm/llvm-project/commit/4a097efe7784767b7d12ffcb8f2b22b9f4d045e2 DIFF: https://github.com/llvm/llvm-project/commit/4a097efe7784767b7d12ffcb8f2b22b9f4d045e2.diff L

[PATCH] D107176: [OpenCL] Replace test for pipe struct to test it with fixed triple

azabaznov created this revision. azabaznov added a reviewer: Anastasia. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D107

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 marked an inline comment as done. gandhi21299 added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12086 + TargetLowering::AtomicExpansionKind Kind, bool UnsafeFlag) { + ORE = new OptimizationRemarkEmitter(RMW->getFunction())

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12090 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "An FP atomic instruction was expanded into a CAS loop."; + return Remark;

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

arsenm added a comment. Needs an IR only test too Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12086 + TargetLowering::AtomicExpansionKind Kind, bool UnsafeFlag) { + ORE = new OptimizationRemarkEmitter(RMW->getFunction()); + if (Kind == TargetLoweri

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

arsenm added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1fi", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_2f16, "hh*1hi", "t", "gfx90a-insts") +TARGET_BU

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

gandhi21299 added a comment. Passed PSDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

  1   2   >