nickdesaulniers added inline comments.
================
Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:45
+ }
+ return true;
+}
----------------
samitolvanen wrote:
> nickdesaulniers wrote:
> > Can llvm::any_of or llvm::none_of be used here?
> > llvm/ADT/STLExtras.h
> Maybe, but I don't see how they would make this function any cleaner. Did you
> have something specific in mind?
Something like?
return any_of(Name, [](const char &C) { return isAlnum(C) || C == '_' || C ==
'.'; }
or maybe we need !none_of(...)? (not sure if characters of a string can be
enumerated this way)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104058/new/
https://reviews.llvm.org/D104058
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
