[PATCH] D103319: [analyzer] Use Optional as a return type of StoreManager::castRegion

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks great, thanks! I guess another option is to put `loc::MemRegionVal()` inside `castRegion()`. This way the return type `Optional` unambigously tells that the region is always non-null if prese

[PATCH] D103131: support debug info for alias variable

kamleshbhalui added a comment. $cat test.h int oldname; $cat test.c #include "test.h" int oldname; __asm__ ( "movq oldname, %rsp\n\t" ); extern int newname __attribute__((alias("oldname"))); debug info from gcc: test.o: file format elf64-x86-64 .debug_info contents: 0x: Compile

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:38 bool HasStdExtM = false; + bool HasStdExtZmmul = false; bool HasStdExtA = false; ksyx wrote: > jrtc27 wrote: > > Ditto > The pattern here seems to be that Z* extensions is fo

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx added a comment. I have took a look into `ELFObjectFile.cpp` but I am not sure what work I need to do there since it seems other Z* extensions are not being handled there. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:38 bool HasStdExtM = false; + bool HasStdExtZ

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx updated this revision to Diff 348608. ksyx marked an inline comment as done. ksyx added a comment. - Move down zmmul lines to fit the ordering - Add Zmmul into parseDirectiveAttribute CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files:

[PATCH] D103131: support debug info for alias variable

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4957 + auto Loc = getLineNumber(D->getLocation()); + DBuilder.createGlobalVariableExpression( + DContext, Name, StringRef(), Unit, Loc, Ty, probinson wrote: > I wasn't saying tha

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09b75f480d1d: [clang-format] New BreakInheritanceList style AfterComma (authored by lichray). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 09b75f4 - [clang-format] New BreakInheritanceList style AfterComma

Author: Zhihao Yuan Date: 2021-05-28T18:24:00-05:00 New Revision: 09b75f480d1d578d48307fd7f3b024b66a75712f URL: https://github.com/llvm/llvm-project/commit/09b75f480d1d578d48307fd7f3b024b66a75712f DIFF: https://github.com/llvm/llvm-project/commit/09b75f480d1d578d48307fd7f3b024b66a75712f.diff L

[clang] 577fea4 - [CGAtomic] Delete outdated code comparing success/failure ordering for cmpxchg.

Author: Eli Friedman Date: 2021-05-28T15:36:01-07:00 New Revision: 577fea4e1a13319adf2b660f57bf570195a7f78d URL: https://github.com/llvm/llvm-project/commit/577fea4e1a13319adf2b660f57bf570195a7f78d DIFF: https://github.com/llvm/llvm-project/commit/577fea4e1a13319adf2b660f57bf570195a7f78d.diff

[PATCH] D101630: [HIP] Fix device-only compilation

yaxunl added a comment. In D101630#202 , @tra wrote: > In D101630#2777346 , @yaxunl wrote: > >> In D101630#2748513 , @tra wrote: >> >>> How about this: >>> If the user

[PATCH] D102923: [clang][lex] Remark for used header search paths

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Thanks for your patience! I thought I already looked at this last week. This is looking close. Comments mostly inline, but a high level point: I think this should report syst

[PATCH] D102730: [clang-format] Support custom If macros

curdeius added a comment. Thanks for working on this! Looks pretty nice, but please clang-format the changes and add some more test cases (cf. inline comment). Concerning the lexer part, I wouldn't do anything cleaner. Comment at: clang/unittests/Format/FormatTest.cpp:19719 +

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

curdeius accepted this revision. curdeius added a comment. LGTM. Comment at: clang/lib/Format/TokenAnnotator.cpp:3529 + return true; +// Break between ] and [ but only when its really 2 attributes. +if (Left.is(TT_AttributeSquare) && Right.is(TT_AttributeSquare) &&

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

curdeius added a comment. Seems really nice. Just some nits & question. Thanks for resuscitating the other review! Please mention https://llvm.org/PR27353 in the description and update it after landing. Comment at: clang/lib/Format/WhitespaceManager.cpp:379 +Changes[i

[PATCH] D101344: [clang-format] Add `SpacesInAngles: Leave` option to keep spacing inside angle brackets as is.

curdeius added a comment. In D101344#2775517 , @MyDeveloperDay wrote: > Whoops, We forgot to regenerate ClangFormatStyleOptions.rst here following > the change to Format.h Thansks for noticing. Just fixed this and D100727

[clang] 8702c6d - [clang-format] [docs] Regenerate style options documentation.

Author: Marek Kurdej Date: 2021-05-28T21:48:36+02:00 New Revision: 8702c6da162b6db962c8155195d79f1e002bc481 URL: https://github.com/llvm/llvm-project/commit/8702c6da162b6db962c8155195d79f1e002bc481 DIFF: https://github.com/llvm/llvm-project/commit/8702c6da162b6db962c8155195d79f1e002bc481.diff

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

HazardyKnusperkeks added a comment. Looks quite solid for me. Comment at: clang/lib/Format/WhitespaceManager.cpp:265 static void -AlignTokenSequence(unsigned Start, unsigned End, unsigned Column, F &&Matches, +AlignTokenSequence(const FormatStyle &Style, unsigned Start, unsign

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. LGTM, but please wait for more responses. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 _

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ormris added a comment. This is also failing on several build bots: https://lab.llvm.org/buildbot/#/builders/139/builds/4812 Since it's been failing for a few hours, I'd like to revert this in the near future to unclog our internal CI and the buildbots. Repository: rG LLVM Github Monorepo

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348563. rsanthir.quic added a comment. Updated test and aligned negative flag with gcc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/cl

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

thakis added a comment. This is breaking check-clang everywhere, eg https://lab.llvm.org/buildbot/#/builders/109/builds/15757 Please run tests before landing, or failing that watch the bots after committing. Reverted in f63adf5b67f7a25b15f81d3a1a207aba4f226dc4 for now. Repository: rG LLVM

[clang] f63adf5 - Revert "[clang][Parse] Add parsing support for C++ attributes on using-declarations"

Author: Nico Weber Date: 2021-05-28T14:49:18-04:00 New Revision: f63adf5b67f7a25b15f81d3a1a207aba4f226dc4 URL: https://github.com/llvm/llvm-project/commit/f63adf5b67f7a25b15f81d3a1a207aba4f226dc4 DIFF: https://github.com/llvm/llvm-project/commit/f63adf5b67f7a25b15f81d3a1a207aba4f226dc4.diff LO

[PATCH] D103131: support debug info for alias variable

probinson added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4957 + auto Loc = getLineNumber(D->getLocation()); + DBuilder.createGlobalVariableExpression( + DContext, Name, StringRef(), Unit, Loc, Ty, I wasn't saying that gcc did the righ

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348555. rsanthir.quic added a comment. Updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/clang/Driver/Options.td clang/lib/D

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:2359 - if (SrcType == DestType) { + if (SrcType == Self.Context.removeAddrSpaceQualType(DestType)) { // C++ 5.2.10p2 has a note that mentions that, subject to all other I think the u

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

jrtc27 added a comment. In D103313#2787326 , @jrtc27 wrote: > In D103313#2787316 , @craig.topper > wrote: > >> Do we need to add this to RISCVTargetStreamer::emitTargetAttributes? > > Yes, that, but also RISCVAsm

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

jrtc27 added a comment. In D103313#2787316 , @craig.topper wrote: > Do we need to add this to RISCVTargetStreamer::emitTargetAttributes? Yes, that, but also RISCVAsmParser::parseDirectiveAttribute and ELFObjectFileBase::getRISCVFeatures, though it seem

[PATCH] D103319: [analyzer] Use Optional as a return type of StoreManager::castRegion

ASDenysPetrov updated this revision to Diff 348554. ASDenysPetrov added a comment. Fixed syntax complains which caused a test fail. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103319/new/ https://reviews.llvm.org/D103319 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

craig.topper added a comment. Do we need to add this to RISCVTargetStreamer::emitTargetAttributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 ___ cfe-commi

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

thakis added a comment. Looks like this breaks tests http://45.33.8.238/linux/47752/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 ___ cfe-commits mai

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc672999a9b1: [clang][Parse] Add parsing support for C++ attributes on using-declarations (authored by erik.pilkington, committed by ldionne). Repo

[clang] dc67299 - [clang][Parse] Add parsing support for C++ attributes on using-declarations

Author: Erik Pilkington Date: 2021-05-28T12:00:33-04:00 New Revision: dc672999a9b12a156991891dc400308b52d569ba URL: https://github.com/llvm/llvm-project/commit/dc672999a9b12a156991891dc400308b52d569ba DIFF: https://github.com/llvm/llvm-project/commit/dc672999a9b12a156991891dc400308b52d569ba.dif

[PATCH] D91630: [Parse] Add parsing support for C++ attributes on using-declarations

ldionne updated this revision to Diff 348547. ldionne marked 3 inline comments as done. ldionne added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91630/new/ https://reviews.llvm.org/D91630 Files: clang/docs/La

[PATCH] D99901: [Driver][test] Test intended target only

hubert.reinterpretcast added inline comments. Comment at: clang/test/Driver/nostdincxx.cpp:4 // RUN: not %clangxx -nostdlibinc %s 2>&1 | FileCheck %s -// RUN: not %clangxx -fsyntax-only -nostdinc -nostdinc++ %s 2>&1 | FileCheck /dev/null --implicit-check-not=-Wunused-command-li

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

rsanthir.quic updated this revision to Diff 348531. rsanthir.quic added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/

[PATCH] D99901: [Driver][test] Test intended target only

jsji added a comment. In D99901#2787034 , @ted wrote: > Why would we not want to support this on other targets, like Arm? Fixes for > AIX shouldn't impact other things. Feel free to update the triple to include arm , as long as the tests focus on gnu to

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1561 + return nullptr; + +ConstraintMap CM = getConstraintMap(State); Also I think we can introduce a simple, but efficient optimization of kicking of

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx updated this revision to Diff 348525. ksyx added a comment. split `Zmmul` implementation and `-mno-div` implementation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102839/new/ https://reviews.llvm.org/D102839 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolC

[PATCH] D99901: [Driver][test] Test intended target only

ted added a comment. Why would we not want to support this on other targets, like Arm? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org/D99901 ___ cfe-commits mailing lis

[PATCH] D103319: [analyzer] Use Optional as a return type of StoreManager::castRegion

ASDenysPetrov updated this revision to Diff 348524. ASDenysPetrov added a comment. Added a simplified test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103319/new/ https://reviews.llvm.org/D103319 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/Store.h clang/lib

[PATCH] D101635: [analyzer] Fix assertion in SVals.h

ASDenysPetrov added a comment. Herald added a subscriber: manas. @steakhal, @NoQ Thanks for your replies. I've made a patch according your suggestions D103319 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101635

[PATCH] D103319: [analyzer] Use Optional as a return type of StoreManager::castRegion

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, NoQ. ASDenysPetrov added a project: clang. Herald added subscribers: manas, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. ASDenysPetrov requested review of thi

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

vsavchenko added a comment. I just noticed that I simply forgot to click submit yesterday 😩 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102696/new/ https://reviews.llvm.org/D102696 ___ cfe-commits mail

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

vsavchenko added a comment. Oh, wow. Great plan! I'd like to participate. 😊 I have a few comments: > Alright, I see your point. I agree that solving the problem of "$a +$b +$c > constrained and then $a + $c got constrained" requires canonicalization. That was actually not an example for canonica

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 added a comment. In D102923#2781386 , @Bigcheese wrote: > I also wonder how we should handle other things that are found via include > paths such as module maps. That's a good point. The logic for module map lookup is more complex than hea

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

vsavchenko added a comment. Looking great, thanks! I have a couple of notes below. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1155-1156 -// TODO: Support SymbolCast. Support IntSymExpr when/if we actually -// start producing them. --

[PATCH] D102923: [clang][lex] Remark for used header search paths

jansvoboda11 updated this revision to Diff 348518. jansvoboda11 added a comment. Fix naming of new functions/variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102923/new/ https://reviews.llvm.org/D102923 Files: clang/include/clang/Basic/Di

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong added a comment. Thanks Valeriy for the quick review and guidance! I am planning to do the changes and continue next week :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103314/new/ https://reviews.llvm.org/D103314 __

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

vsavchenko requested changes to this revision. vsavchenko added a comment. This revision now requires changes to proceed. Hey, great job! This is really something that we need, but it's implemented not really correctly. I tried to cover it in the inline comment. Comment at: cl

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong abandoned this revision. martong added a comment. Abandoning in favor of https://reviews.llvm.org/D103314 https://reviews.llvm.org/D103317 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102696/new/ https://reviews.llvm.org/D102696 _

[PATCH] D103317: [Analyzer][engine][solver] Simplify complex constraints

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus.

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

jrtc27 added a comment. In D101140#2786844 , @wingo wrote: > In D101140#2786777 , @jrtc27 wrote: > >> Is it just me or does having a backend-specific type in target-independent >> code feel wrong? It feels like t

[PATCH] D103314: [Analyzer][solver] Simplify existing constraints when a new constraint is added

martong created this revision. martong added reviewers: vsavchenko, NoQ, steakhal. Herald added subscribers: ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. marton

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added a comment. In D101140#2786777 , @jrtc27 wrote: > Is it just me or does having a backend-specific type in target-independent > code feel wrong? It feels like there should be a space for target-specific > TargetStackIDs... Hoo, good question.

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

ksyx created this revision. ksyx added reviewers: asb, craig.topper, luismarques, jrtc27, kito-cheng, rsmith, shiva0217. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

nemanjai abandoned this revision. nemanjai added a comment. Thanks everyone for providing feedback on this. I posted this to gauge interest in the community for such a change. As it appears, the consensus seems to be that this isn't desired so I will abandon this change and vendors will continue

[PATCH] D101921: [MC] Make it possible for targets to define their own MCObjectFileInfo

MaskRay added subscribers: compnerd, dblaikie. MaskRay added a comment. Because of `new MCObjectFileInfo`, we cannot use a forward declaration (incomplete class) to replace `#include "llvm/MC/MCObjectFileInfo.h"` in `TargetRegistry.h`. I thought about moving `TargetRegistry.{h,cpp}` from Suppor

[PATCH] D103131: support debug info for alias variable

kamleshbhalui updated this revision to Diff 348501. kamleshbhalui added a comment. matching gcc behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103131/new/ https://reviews.llvm.org/D103131 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/

[PATCH] D91628: [SystemZ][NFC] Group SystemZ tests in SystemZ folder

abhina.sreeskantharajan added a comment. In D91628#2762190 , @MaskRay wrote: > .ll -> .s tests should be placed in llvm/test/CodeGen/SystemZ, not in clang Sorry for the late reply, I was on vacation. Is there a specific test you are referring to? All the

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

jrtc27 added a comment. Is it just me or does having a backend-specific type in target-independent code feel wrong? It feels like there should be a space for target-specific TargetStackIDs... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/ne

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103204/new/ https://reviews.llvm.org/D103204 ___

[PATCH] D102924: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch

This revision was automatically updated to reflect the committed changes. Closed by commit rGb76df3235cd0: [clang] NFC: Replace std::pair by a struct in InitHeaderSearch (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D102924?vs=347045&id=348498#toc Repository:

[clang] b76df32 - [clang] NFC: Replace std::pair by a struct in InitHeaderSearch

Author: Jan Svoboda Date: 2021-05-28T14:06:25+02:00 New Revision: b76df3235cd05d11baea67ae684f9f1fd883b76d URL: https://github.com/llvm/llvm-project/commit/b76df3235cd05d11baea67ae684f9f1fd883b76d DIFF: https://github.com/llvm/llvm-project/commit/b76df3235cd05d11baea67ae684f9f1fd883b76d.diff L

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

MyDeveloperDay updated this revision to Diff 348495. MyDeveloperDay added a comment. Add additional unit test, and an additional check to ensure multiple attributes are broken, while @jbcoe this looks very similar to the original rule, the original rule actually had an || in the expression and n

[PATCH] D103163: [Matrix] Skip matrix casts checks for class or struct types in C++.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bccdde070d2: [Matrix] Move C++ matrix cast checks to TryStaticCast. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D10316

[clang] 5bccdde - [Matrix] Move C++ matrix cast checks to TryStaticCast.

Author: Florian Hahn Date: 2021-05-28T13:00:28+01:00 New Revision: 5bccdde070d29fb83aec69c498285b4c8914f8d1 URL: https://github.com/llvm/llvm-project/commit/5bccdde070d29fb83aec69c498285b4c8914f8d1 DIFF: https://github.com/llvm/llvm-project/commit/5bccdde070d29fb83aec69c498285b4c8914f8d1.diff

[PATCH] D95228: Add swift_async_context parameter attribute mapping to IR equivalent

t.p.northover closed this revision. t.p.northover marked an inline comment as done. t.p.northover added a comment. Thanks, committed as e94fada045fe with the extra tests. Comment at: clang/include/clang/Bas

[clang] e94fada - SwiftAsync: add Clang attribute to apply the LLVM `swiftasync` one.

Author: Tim Northover Date: 2021-05-28T12:31:12+01:00 New Revision: e94fada045fe88787a414e3307412c1cc3a1b259 URL: https://github.com/llvm/llvm-project/commit/e94fada045fe88787a414e3307412c1cc3a1b259 DIFF: https://github.com/llvm/llvm-project/commit/e94fada045fe88787a414e3307412c1cc3a1b259.diff

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348493. wingo added a comment. Herald added subscribers: foad, frasercrmck, kerbowa, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, simonc

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

MyDeveloperDay added a comment. In D103307#2786645 , @jbcoe wrote: > Thanks for this! I tried to handle the multiple attributes using the "parsing technique" you used, instead of the "mustBreaking technique" but every time I do this I end up putting a

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2786648 , @ASDenysPetrov wrote: > OK, then. Let's land it! Can you please take a look at D92928 as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov accepted this revision. ASDenysPetrov added a comment. This revision is now accepted and ready to land. OK, then. Let's land it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 ___

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. Thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103307/new/ https://reviews.llvm.org/D103307 _

[PATCH] D74265: [clang-format] Improve handling of C# attributes

MyDeveloperDay added a comment. The second property in a class is putting the property on the same line [XmlIgnore] public string property1 { get; set; } [XmlIgnore] public string property2{ get; set; } as are all successive properties Multiple properites are also not getting broken u

[PATCH] D103307: [clang-format] successive C# attributes cause line breaking issues

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: jbcoe, krasimir, HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. D74265: [clang-format] Improve handling of C# attributes

[PATCH] D74265: [clang-format] Improve handling of C# attributes

MyDeveloperDay added a comment. This issue seems to have caused a regression https://bugs.llvm.org/show_bug.cgi?id=50515, I understand we removed the rule because it was too aggressive, now its not aggressive enough. I'm going to try and find some sort of compromise so we can gravitate to a so

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko added a comment. In D92639#2785057 , @ASDenysPetrov wrote: > @vsavchenko How about this? Yep, thanks for reminding! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm

[PATCH] D92928: [analyzer] Highlight arrows for currently selected event

vsavchenko updated this revision to Diff 348480. vsavchenko added a comment. Herald added a subscriber: manas. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92928/new/ https://reviews.llvm.org/D92928 Files: clang/lib/Rewrite/HTMLRewrite.c

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

vsavchenko updated this revision to Diff 348479. vsavchenko added a comment. Fix IE issue and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 Files: clang/include/clang/Analysis/PathDiagnostic.h

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00ecf18979e3: [WebAssembly][CodeGen] IR support for WebAssembly local variables (authored by wingo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo updated this revision to Diff 348467. wingo added a comment. Adapt test to insert compiler barrier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101140/new/ https://reviews.llvm.org/D101140 Files: llvm/include/llvm/CodeGen/MIRYamlMapping.

[PATCH] D101140: [WebAssembly][CodeGen] IR support for WebAssembly local variables

wingo added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/ir-locals.ll:17-20 + ; The DAG combiner infers that %reloaded is the same as %arg and + ; ultimately causes "local.get 0" to be emitted instead of + ; "local.get 1". + ; CHECK-NEXT: local.get 0 ---

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

This revision was automatically updated to reflect the committed changes. Closed by commit rGf59cd8a4a606: [clang] [MinGW] Fix gcc version detection/picking (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D102873?vs=346850&id=348464#toc Repository: rG LLVM Github Mo

[clang] f59cd8a - [clang] [MinGW] Fix gcc version detection/picking

Author: Martin Storsjö Date: 2021-05-28T11:44:20+03:00 New Revision: f59cd8a4a606643e7248cecc239e0d229feb3320 URL: https://github.com/llvm/llvm-project/commit/f59cd8a4a606643e7248cecc239e0d229feb3320 DIFF: https://github.com/llvm/llvm-project/commit/f59cd8a4a606643e7248cecc239e0d229feb3320.diff

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mati865 added a comment. Ah, so that explains why everyone sends LGTM text. I'll try to remember it next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102873/new/ https://reviews.llvm.org/D102873 _

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348463. gergap added a comment. rebased on latest main and squashed the two commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/lib/Format/Whitespac

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo added a comment. Also @mati865 FYI, phabricator has this odd behaviour, that if you press "accept" but don't write a textual message, the notification mail only gets sent to the person receivers but not to the mailing list - so readers of the list will only see the original messages an

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

AbbasSabra added a comment. Thanks for the review! Can you take care of merging the patch? I don't have access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___

[PATCH] D103286: [clang-format] Add PPIndentWidth option

gergap updated this revision to Diff 348453. gergap added a comment. fixing test issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103286/new/ https://reviews.llvm.org/D103286 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clan