[PATCH] D101387: remove single quotes around sugguestion diagnostic

rsmith added a comment. Note that, per https://clang.llvm.org/docs/InternalsManual.html#the-format-string, > Diagnostics should never take random English strings as arguments: you > shouldn’t use “you have a problem with %0” and pass in things like “your > argument” or “your return value” as a

[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:84 + // In these cases we need to remove all typedefs one by one to check this. + const auto VaListKind = Context.getTargetInfo().getBuiltinVaListKind(); + using

[clang] 36430d4 - [Driver] Use normalized triples for per-target runtimes

Author: Petr Hosek Date: 2021-04-27T22:31:36-07:00 New Revision: 36430d44edba9063a08493c89864edf5f071d08c URL: https://github.com/llvm/llvm-project/commit/36430d44edba9063a08493c89864edf5f071d08c DIFF: https://github.com/llvm/llvm-project/commit/36430d44edba9063a08493c89864edf5f071d08c.diff LO

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. In D91054#2711654 , @fghanim wrote: >> This is generally fine with me, @fghanim @Meinersbur any concerns? > > I have none. All good for me Then L

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 341071. Ericson2314 added a comment. Herald added subscribers: openmp-commits, lldb-commits, cfe-commits, jvesely. Herald added projects: clang, LLDB, OpenMP. Quote variable usages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

jdoerfert added a comment. The cast was never the problem but the fact that the `$ref` lives in the global address space while the global value might be in the shared one. D101030 gives a way out here by not creating `$ref` variables if there is no host version

[PATCH] D99530: [OPENMP]Fix PR49098: respect firstprivate of declare target variable.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99530/new/ https://reviews.llvm.org/D99530 _

[PATCH] D99762: [OPENMP]Fix PR49777: Clang should not try to specialize orphaned directives in device codegen.

jdoerfert added a comment. The bug has been fixed by D95976 already, I'll update the bug report now. Also, the tracking of Generic/SPMD mode in clang is about to be finally removed, new code depending on that is short-lived. Repository: rG LLVM Github Monore

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

dbabokin added a comment. One more false-positive: void foo() { extern int yydebug; yydebug = 1; } It was triggered in ISPC build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. In D101194#2721682 , @phosek wrote: > In D101194#2721643 , @MaskRay wrote: > >> multiarch is not consistent within GCC, either (also note that not all GCC >> installations are configured

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2721643 , @MaskRay wrote: > multiarch is not consistent within GCC, either (also note that not all GCC > installations are configured with multiarch. `--print-multiarch` prints an > empty line). > I have tried various

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

craig.topper added a comment. In D99741#2721596 , @thakis wrote: > In D99741#2721235 , @craig.topper > wrote: > >> I believe we had reductions at builds 7601 and 8175. >> >> It looks like there may have been an inc

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rupprecht added a comment. Landed 44e2247dcd04f3421164b085094eb575270564ba to fix LLDB. If you decide to go in a different direction again, please adjust that fix accordingly. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. In D101194#2721597 , @phosek wrote: > In D101194#2721390 , @MaskRay wrote: > >> I thought this was NFC:( >> >> Yeah, personally I think the previous behavior >> (`lib/clang/13.0.0/lib/x86

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

phosek added a comment. What I think @vitalybuka meant is keeping `sanitizer_platform_limits_fuchsia.h` as you had it, but including it unconditionally. Since the entire file is wrapped in `#if SANITIZER_FUCHSIA ... #endif`, the inclusion would be a no-op on platforms other than Fuchsia so no n

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f1137ba79c0: [clang/Basic] Make TargetInfo.h not use DataLayout again (authored by thakis). Herald added a project: clang. Changed prior to commit:

[clang] 0f1137b - [clang/Basic] Make TargetInfo.h not use DataLayout again

Author: Nico Weber Date: 2021-04-27T22:26:10-04:00 New Revision: 0f1137ba79c0b3f1ca638e01082443ba5ccde03c URL: https://github.com/llvm/llvm-project/commit/0f1137ba79c0b3f1ca638e01082443ba5ccde03c DIFF: https://github.com/llvm/llvm-project/commit/0f1137ba79c0b3f1ca638e01082443ba5ccde03c.diff LO

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2721390 , @MaskRay wrote: > I thought this was NFC:( > > Yeah, personally I think the previous behavior > (`lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.a`) is > slightly better than the new > `lib/c

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. In D99741#2721235 , @craig.topper wrote: > I believe we had reductions at builds 7601 and 8175. > > It looks like there may have been an increase between builds 7979 and 7991 > the build failed for a while there. I suspect "e951b0

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl updated this revision to Diff 341054. yaxunl added a comment. fix invalid bitcast due to sret pointer passed to ctor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101389/new/ https://reviews.llvm.org/D101389 Files: clang/lib/CodeGen/CGCall.cpp clang/test/CodeGenCUDA/amdgpu-s

[PATCH] D101387: remove single quotes around sugguestion diagnostic

rtrieu added a comment. In D101387#2720500 , @MaskRay wrote: > @rtrieu Do we have a way appending arbitrary messages to a diagnostic > template? Not an arbitrary number. The diagnostic format string is indexed, so it diagnostic string needs to know ah

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. Huh, maybe not: https://godbolt.org/z/PnE1fMGWo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581 ___ cfe-commits mailing list cf

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

nickdesaulniers added a comment. I think this is triggering some false positives in builds of the Linux kernel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100581/new/ https://reviews.llvm.org/D100581

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. I thought this was NFC:( Yeah, personally I think the previous behavior (`lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.asan.a`) is slightly better than the new `lib/clang/13.0.0/lib/x86_64-linux-gnu/libclang_rt.asan.a`. multiarch paths are suitable for GCC

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

aqjune added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { nikic wrote: > spatel wrote: > > aqjune wrote:

[PATCH] D101017: [NewPM] Make GlobalsAA available earlier in the pipeline

aeubanks abandoned this revision. aeubanks added a comment. turns out it was an issue with GlobalsAA not being recalculated and being too conservative anyway, I don't think adding GlobalsAA early on really does much, adding it to the inliner pipeline seems good enough https://reviews.llvm.org/D

[clang] 06d06f2 - [CMake][llvm] avoid conflict w/ (and use when available) new builtin check_linker_flag

Author: Jim Radford Date: 2021-04-27T16:41:28-07:00 New Revision: 06d06f2f6403066415df7b8854e6aff7586a92df URL: https://github.com/llvm/llvm-project/commit/06d06f2f6403066415df7b8854e6aff7586a92df DIFF: https://github.com/llvm/llvm-project/commit/06d06f2f6403066415df7b8854e6aff7586a92df.diff L

[PATCH] D100901: [CMake][llvm] avoid conflict w/ (and use when available) new builtin check_linker_flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG06d06f2f6403: [CMake][llvm] avoid conflict w/ (and use when available) new builtin… (authored by radford, committed by thegameg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

craig.topper added a comment. I believe we had reductions at builds 7601 and 8175. It looks like there may have been an increase between builds 7979 and 7991 the build failed for a while there. I suspect "e951b04 [AArch64][S

[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

njames93 added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:312 + desc("Enable preview of InlayHints feature"), init(false), + Hidden}; + Does it make sense to hide this flag? This is a feature

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

NoQ added a comment. > when the visitor encounters an `ExplodedNode` Weird. `finalizeVisitor()` accepts not any node but the error node. Your screenshot suggests that the error node is not in the standard library but in user code. Might it be that there are multiple error nodes and you're looki

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

njames93 updated this revision to Diff 341021. njames93 added a comment. Nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101365/new/ https://reviews.llvm.org/D101365 Files: clang-tools-extra/clang-query/Query.h clang-tools-extra/clang-query

Re: [PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Sounds good. It's a soft objection, mostly because if nothing else it puts us back where we were subject to some latent bugs, but perhaps not as bad as before (though I don't find having to use an assert build reassuring ;) Anyhow, go ahead and we'll figure out something else. On Tue, Apr 27, 202

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D100776#2703273 , @echristo wrote: > As is mentioned there are tradeoffs around this though: a) it does make it > harder to have clang generate code with

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

Meinersbur added a comment. In D91054#2709712 , @jdoerfert wrote: > OK, we really need to provide the PrivCB impl so we can start removing clang > code. > This is generally fine with me, @fghanim @Meinersbur any concerns? It might be OK to start with th

[PATCH] D100901: [CMake][llvm] avoid conflict w/ (and use when available) new builtin check_linker_flag

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100901/new/ https://reviews.llvm.org/D100901 __

[PATCH] D101400: [Driver] Add -print-multiarch-triple

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa921d2d2fb46: [Driver] Add -print-multiarch (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[clang] a921d2d - [Driver] Add -print-multiarch

Author: Petr Hosek Date: 2021-04-27T16:04:54-07:00 New Revision: a921d2d2fb46b898794091e7410426c518a4f0cc URL: https://github.com/llvm/llvm-project/commit/a921d2d2fb46b898794091e7410426c518a4f0cc DIFF: https://github.com/llvm/llvm-project/commit/a921d2d2fb46b898794091e7410426c518a4f0cc.diff LO

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek updated this revision to Diff 341015. phosek marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101400/new/ https://reviews.llvm.org/D101400 Files: clang/include/clang/Driver/Options.td clang/include/clang/Dri

[PATCH] D101400: [Driver] Add -print-multiarch-triple

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG Comment at: clang/test/Driver/print-multiarch.c:5 +// RUN:-resource-dir=%S/Inputs/resource_dir \ +// RUN: | FileCheck --check-prefix=PRINT-MULTIARCH %s +//

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

MaskRay added a comment. FWIW I have played `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` I see `lib/clang/13.0.0/lib/x86_64-unknown-linux-gnu/libclang_rt.*`. The directory name is `x86_64-unknown-linux-gnu`, which actually looks good to me. We don't necessarily copy the GCC x86_64-linux-gnu multiar

[PATCH] D52524: Add -Wpoison-system-directories warning

sbc100 added a comment. Would it make sense to have this apply to system library paths too? i.e. `-L/usr/local/lib`. We have a bespoke mechanism in emscripten right now that is a bit more flexible but I'd love to simple replace it with `-Wpoison-system-directories`. The name "system director

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek added a comment. In D101400#2720954 , @MaskRay wrote: > gcc has `--print-multiarch`. Just use `--print-multiarch`? I think our > semantics are compatible. I wasn't aware that GCC already has this option but using the same spelling definitely mak

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek updated this revision to Diff 341001. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101400/new/ https://reviews.llvm.org/D101400 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/ToolChain.h clang/lib/Driver/Driver

[PATCH] D101346: [AST] Fix getExprLoc reported for cxxDependentScopeMemberExpr

steveire updated this revision to Diff 340994. steveire added a comment. Fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101346/new/ https://reviews.llvm.org/D101346 Files: clang/include/clang/AST/ExprCXX.h clang/unittests/AST/

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/unittests/clang-query/QueryParserTest.cpp:249 + EXPECT_EQ("dump ", Comps[3 + static_cast(HasIntrospection)].TypedText); + EXPECT_EQ(

[PATCH] D101400: [Driver] Add -print-multiarch-triple

MaskRay added a comment. gcc has `--print-multiarch`. Just use `--print-multiarch`? I think our semantics are compatible. It seems odd to have print-runtime-dir tests in `immediate-options.c`. The tests should be moved to a `print-*` file. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D101400: [Driver] Add -print-multiarch-triple

phosek created this revision. phosek added reviewers: rnk, MaskRay. Herald added a subscriber: dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful in runtimes build for example which currently try to guess the correc

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. > we usually include them unconditionaly and .h itself has guards against > unsupported platforms @vitalybuka Did you mean something like this? Definitely simplifies the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan updated this revision to Diff 340983. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 Files: compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h Index: compiler-rt/lib/sanitizer

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

dexonsmith added a subscriber: sammccall. dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:738-740 + createOutputFileImpl(StringRef OutputPath, llvm::sys::fs::OpenFlags Flags, bool RemoveFileOnSignal, bool UseT

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

bjope added a comment. In D101194#2720787 , @phosek wrote: > In D101194#2720761 , @bjope wrote: > >> Or maybe the problem is that we use `-DLLVM_BUILTIN_TARGETS=default`? > > The use of `default` is the issue, the

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. I try to make Hurd.cpp close to Linux.cpp in general, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing lis

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

This revision was automatically updated to reflect the committed changes. Closed by commit rGe37c8fd364a9: Hurd: Clean up Debian multiarch /usr/include/ (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] e37c8fd - Hurd: Clean up Debian multiarch /usr/include/

Author: Samuel Thibault Date: 2021-04-27T13:36:12-07:00 New Revision: e37c8fd364a96d9d9f56a1e06e178e9e376beda3 URL: https://github.com/llvm/llvm-project/commit/e37c8fd364a96d9d9f56a1e06e178e9e376beda3 DIFF: https://github.com/llvm/llvm-project/commit/e37c8fd364a96d9d9f56a1e06e178e9e376beda3.dif

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

MaskRay added a comment. I see that this makes the code similar to the similar logic in Linux.cpp. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2720761 , @bjope wrote: > Got some problems with my builds after this commit. > > My cmake commands looks like this (well, this is after having tried to fix > the problem by replacing `x86_64-unknown-linux-gnu` by `x86_

[clang] bf9eef9 - Gnu: Replace with a GCCInstallation.isValid() check with assert

Author: Fangrui Song Date: 2021-04-27T13:31:37-07:00 New Revision: bf9eef92b6cd71d262ac12ce6c4919271bd6c910 URL: https://github.com/llvm/llvm-project/commit/bf9eef92b6cd71d262ac12ce6c4919271bd6c910 DIFF: https://github.com/llvm/llvm-project/commit/bf9eef92b6cd71d262ac12ce6c4919271bd6c910.diff

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

sthibaul added a comment. No, for now it only supports i686. This part is actually already being tested by hurd.cpp, /usr/include/i386-gnu wouldn't be getting included otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://re

[PATCH] D101324: Hurd: Clean up Debian multiarch /usr/include/

MaskRay added a comment. Does Hurd support non-i386? Ideally this should have a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101324/new/ https://reviews.llvm.org/D101324 ___ cfe-commits mailing li

[PATCH] D101347: hurd: Clean up test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb13e913b31a0: hurd: Clean up test (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] b13e913 - hurd: Clean up test

Author: Samuel Thibault Date: 2021-04-27T13:19:17-07:00 New Revision: b13e913b31a0703ebc15d701ff05fd82788dc02a URL: https://github.com/llvm/llvm-project/commit/b13e913b31a0703ebc15d701ff05fd82788dc02a DIFF: https://github.com/llvm/llvm-project/commit/b13e913b31a0703ebc15d701ff05fd82788dc02a.dif

[PATCH] D101347: hurd: Clean up test

MaskRay updated this revision to Diff 340966. MaskRay added a comment. Delete unneeded -no-canonical-prefixes Add --stdlib=platform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101347/new/ https://reviews.llvm.org/D101347 Files: clang/test/Dri

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

bjope added a comment. Got some problems with my builds after this commit. My cmake commands looks like this (well, this is after having tried to fix the problem by replacing `x86_64-unknown-linux-gnu` by `x86_64-linux-gnu` as I figured that might be needed after looking at the changes in this

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

sthibaul marked an inline comment as done. sthibaul added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014 llvm::opt::ArgStringList &CC1Args) const { - addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args); + if (!GCCInsta

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG932e8c324154: hurd: Detect libstdc++ include paths on Debian Hurd i386 (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Mo

[clang] 932e8c3 - hurd: Detect libstdc++ include paths on Debian Hurd i386

Author: Samuel Thibault Date: 2021-04-27T13:04:41-07:00 New Revision: 932e8c3241541c0216968a0f966c495b77bf4461 URL: https://github.com/llvm/llvm-project/commit/932e8c3241541c0216968a0f966c495b77bf4461 DIFF: https://github.com/llvm/llvm-project/commit/932e8c3241541c0216968a0f966c495b77bf4461.dif

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014 llvm::opt::ArgStringList &CC1Args) const { - addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args); + if (!GCCInstallation.isValid()) +return;

[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

MaskRay updated this revision to Diff 340960. MaskRay added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101331/new/ https://reviews.llvm.org/D101331 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/G

[PATCH] D100901: [CMake][llvm] The first argument to check_linker_flag is the language

radford updated this revision to Diff 340956. radford added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. [CMake][llvm] The first argument to check_linker_flag is the language Match the API for the new check_linker_flag and use it directly when available, leavi

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

nikic added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { spatel wrote: > aqjune wrote: > > aqjune wrote:

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

eugenis added a comment. Right, our commit process is a bit strange. Ideally, the change author should initiate commit after they have the necessary approvals, and then be responsible to deal with any fallout in a timely manner. As things are, the author does not control the timing of the commi

[PATCH] D101317: hurd: Fix i386 research path

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c552d27ee03: hurd: Fix i386 research path (authored by sthibaul, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101317/new/ https://r

[clang] 9c552d2 - hurd: Fix i386 research path

Author: Samuel Thibault Date: 2021-04-27T12:41:18-07:00 New Revision: 9c552d27ee03ad485c2d36827e73bea75faee5e1 URL: https://github.com/llvm/llvm-project/commit/9c552d27ee03ad485c2d36827e73bea75faee5e1 DIFF: https://github.com/llvm/llvm-project/commit/9c552d27ee03ad485c2d36827e73bea75faee5e1.dif

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

aeubanks added a comment. Sorry about that, although I don't think emails went to me since the email was somebody else's. But point taken, I'll coordinate better in the future when landing someone else's patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

spatel added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/unsigned-multiply-overflow-check.ll:20 +; FIXME: noundef should be attached to args define i1 @will_not_overflow(i64 %arg, i64 %arg1) { aqjune wrote: > aqjune wrote: > > spatel wrote

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

eugenis added a comment. I fixed another one in https://reviews.llvm.org/rG561f4b9087457e9ea3cf4aeb57dcd507e2fa6258 Please watch the bots after you land changes like this one and don't let them stay broken for an entire day! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D101389: [clang][CodeGen] Fix address space for sret

yaxunl created this revision. yaxunl added a reviewer: rjmccall. Herald added subscribers: kerbowa, tpr, nhaehnle, jvesely. yaxunl requested review of this revision. sret is returned through temporary variables allocated on stack, therefore it should use alloca address space. Currently clang use

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is useful for running cl

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340932. nickdesaulniers added a comment. - rebase on D101387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.org/D100919 Files: clang

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340931. nickdesaulniers added a comment. - rebase on D101387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files: clang

[PATCH] D101387: remove single quotes around sugguestion diagnostic

MaskRay added a subscriber: rtrieu. MaskRay added a comment. @rtrieu Do we have a way appending arbitrary messages to a diagnostic template? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 ___

[PATCH] D101387: remove single quotes around sugguestion diagnostic

nickdesaulniers created this revision. nickdesaulniers added reviewers: xiangzhangllvm, MaskRay, DavidSpickett. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clutters the sugguestion. Repository: rG LLVM Github Monorep

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers marked an inline comment as not done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/stack-protector-guard.c:59 +// INVALID-VALUE-AARCH64: error: invalid value 'tls' in 'mstack-protector-guard=','valid arguments to '-mstack-protector-guard='

[PATCH] D100872: Use OpenFlags instead of boolean to set a file as text/binary

abhina.sreeskantharajan added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100872/new/ https://reviews.llvm.org/D100872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers added a comment. In D101327#2718989 , @DavidSpickett wrote: > So if kernel builds are using a small subset of registers, just check for > those. The kernel uses just one for aarch64. It looks like GCC just feeds through whatever is spe

[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/test/SemaCXX/cxx17-undeduced-alignment.cpp:19 +void baz() { + // S(123) is undeduced, but when passed to foo() via bar() it is wrapped in + // Sub

[PATCH] D77598: Integral template argument suffix and cast printing

rnk added inline comments. Comment at: clang/lib/AST/TemplateBase.cpp:71-72 if (T->isBooleanType() && !Policy.MSVCFormatting) { Out << (Val.getBoolValue() ? "true" : "false"); } else if (T->isCharType()) { reikdas wrote: > rnk wrote: > > rsmith wrote

[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=

nickdesaulniers updated this revision to Diff 340915. nickdesaulniers added a comment. - prefer vanilla array + llvm::find Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101327/new/ https://reviews.llvm.org/D101327 Files: clang/lib/Driver/ToolCha

[PATCH] D99762: [OPENMP]Fix PR49777: Clang should not try to specialize orphaned directives in device codegen.

ABataev updated this revision to Diff 340909. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99762/new/ https://reviews.llvm.org/D99762 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CodeGen/CGOpenMPRu

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. (here's a build form a few minutes ago: http://45.33.8.238/macm1/8325/summary.html) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99741/new/ https://reviews.llvm.org/D99741 ___ c

[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

thakis added a comment. No effect, or even worse. We're back at 5:30 cycle time and we'v been in that state for over 2 weeks now. I think it's time to revert back to green, so this slowdown doesn't become permanent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D94355: [Passes] Add relative lookup table converter pass

nathanchance added a comment. In D94355#2717958 , @gulfem wrote: > @nathanchance do you prefer me to revert the patch first as it might take me > a while to investigate it? > Btw, I was able to reproduce the issue by following your steps. I would say if

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3138 } +if (EffectiveTriple.isAArch64() && Value != "sp_el0") { + D.Diag(diag::err_drv_invalid_value_with_suggestion) DavidSpickett wrote: > nickdesaulniers wro

[PATCH] D100919: [AArch64] Support customizing stack protector guard

nickdesaulniers updated this revision to Diff 340905. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - prefer err_drv_invalid_value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100919/new/ https://reviews.llvm.o

[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

thakis added a comment. In D100807#2719873 , @arphaman wrote: > We have M1 CI running internally but it's post > commit only right now Which tests is it running? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

njames93 updated this revision to Diff 340902. njames93 added a comment. Fix up tests(probably, see what premerge says) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101365/new/ https://reviews.llvm.org/D101365 Files: clang-tools-extra/clang-que

[PATCH] D101348: [Driver] Fix tests failing in per-target multiarch layout

This revision was automatically updated to reflect the committed changes. Closed by commit rG887bdff8bae7: [Driver] Fix tests failing in per-target multiarch layout (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101348/new/ http

[clang] 887bdff - [Driver] Fix tests failing in per-target multiarch layout

Author: Petr Hosek Date: 2021-04-27T10:19:00-07:00 New Revision: 887bdff8bae74ae0cedadbbe35f39141da3642c9 URL: https://github.com/llvm/llvm-project/commit/887bdff8bae74ae0cedadbbe35f39141da3642c9 DIFF: https://github.com/llvm/llvm-project/commit/887bdff8bae74ae0cedadbbe35f39141da3642c9.diff LO

[PATCH] D101325: [CodeGenOptions] make StackProtectorGuardOffset signed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGea8416bf4df4: [CodeGenOptions] make StackProtectorGuardOffset signed (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES S

  1   2   3   >