rsmith added a comment.

Note that, per 
https://clang.llvm.org/docs/InternalsManual.html#the-format-string,

> Diagnostics should never take random English strings as arguments: you 
> shouldn’t use “you have a problem with %0” and pass in things like “your 
> argument” or “your return value” as arguments.

... so this diagnostic needs to be fundamentally restructured: either it should 
be split into multiple diagnostics for the various individual messages, or a 
`%select` should be added with the appropriate message text, or similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101387/new/

https://reviews.llvm.org/D101387

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D101387: ... Nick Desaulniers via Phabricator via cfe-commits
    • [PATCH] D101... Fangrui Song via Phabricator via cfe-commits
    • [PATCH] D101... Richard Trieu via Phabricator via cfe-commits
    • [PATCH] D101... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D101... Nick Desaulniers via Phabricator via cfe-commits

Reply via email to