[PATCH] D100085: [X86] Support -march=rocketlake

MaskRay added a comment. In D100085#2675919 , @FreddyYe wrote: > Hi @MaskRay, I tried to refactor, but met some difficulties. Since these > defines are dictionary ordered, a new #define may insert into a common CHECK. > So it is difficult to let differe

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 336011. tentzen marked an inline comment as done. tentzen added a comment. clang-format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.org/D80344 Files: clang/include/cl

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. Hi @MaskRay, I tried to refactor, but met some difficulties. Since these defines are dictionary ordered, a new #define may insert into a common CHECK. So it is difficult to let different RUN share common CHECKs. // RUN: %clang -march=pentium-mmx -m32 -E -dM %s -o - 2

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe updated this revision to Diff 336007. FreddyYe added a comment. Updating according to comments. Test refactoring not done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 Files: clang/lib/Basic

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:458 +same number of arguments as the caller. The types of the return value and all +arguments must be similar, including the implicit "this" argument, if any. +Any variables in scope, including all

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336004. haberman marked 19 inline comments as done. haberman added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Returned validation to ActOnAttributedStmt() so it works with templates. - Merge branch 'main' into mustta

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe added a comment. THX for review! Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1396 +// RUN: %clang -march=rocketlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown-linux \ MaskRay wrote: > The file may need some refactor

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:101 INTEL_COREI7_ALDERLAKE, + INTEL_COREI7_ROCKETLAKE, AMDFAM19H_ZNVER3, This order is defined by libgcc. We can't insert in the middle unless ZNVER3 was in the wrong pla

[PATCH] D100087: Include `count` in AppleClang toolchains.

delcypher created this revision. delcypher added reviewers: arphaman, JDevlieghere. Herald added a subscriber: mgorny. delcypher requested review of this revision. Herald added a project: clang. The motivation here is so we can run the compiler-rt tests from a standalone build against AppleClang.

[PATCH] D100086: Include `llvm-config` and `not` in AppleClang toolchains.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73cbc7f60ed9: Include `llvm-config` and `not` in AppleClang toolchains. (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 73cbc7f - Include `llvm-config` and `not` in AppleClang toolchains.

Author: Dan Liew Date: 2021-04-07T21:29:52-07:00 New Revision: 73cbc7f60ed90ad207b54b55aaf0efa0e5c38c47 URL: https://github.com/llvm/llvm-project/commit/73cbc7f60ed90ad207b54b55aaf0efa0e5c38c47 DIFF: https://github.com/llvm/llvm-project/commit/73cbc7f60ed90ad207b54b55aaf0efa0e5c38c47.diff LOG:

[PATCH] D100086: Include `llvm-config` and `not` in AppleClang toolchains.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100086/new/ https://reviews.llvm.org/D100086 __

[PATCH] D100086: Include `llvm-config` and `not` in AppleClang toolchains.

delcypher created this revision. delcypher added reviewers: JDevlieghere, arphaman. Herald added a subscriber: mgorny. delcypher requested review of this revision. Herald added a project: clang. The motivation here is so that we can configure and run compiler-rt tests from a standalone build again

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac5e440615d: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/

[clang] 8ac5e44 - [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

Author: Fangrui Song Date: 2021-04-07T21:01:10-07:00 New Revision: 8ac5e440615dd3dc9fd2eb88c0bad32fdc5f678c URL: https://github.com/llvm/llvm-project/commit/8ac5e440615dd3dc9fd2eb88c0bad32fdc5f678c DIFF: https://github.com/llvm/llvm-project/commit/8ac5e440615dd3dc9fd2eb88c0bad32fdc5f678c.diff

[PATCH] D100085: [X86] Support -march=rocketlake

MaskRay added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1396 +// RUN: %clang -march=rocketlake -m32 -E -dM %s -o - 2>&1 \ +// RUN: -target i386-unknown-linux \ The file may need some refactoring first. You can let RUN lin

[PATCH] D100085: [X86] Support -march=rocketlake

FreddyYe created this revision. Herald added subscribers: dexonsmith, pengfei, hiraditya. FreddyYe requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

tianqing updated this revision to Diff 335980. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 Files: clang/lib/Headers/uintrintrin.h llvm/lib/Target/X86/X86ExpandPseudo.cpp llvm/test/CodeGen/X86/x86-64-intrcc-uintr.ll Index: llvm/test/Code

[PATCH] D100074: [RISCV] Use multiclass inheritance to simplify some of riscv_vector.td. NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f6b3d1833fd: [RISCV] Use multiclass inheritance to simplify some of riscv_vector.td. NFCI (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 5f6b3d1 - [RISCV] Use multiclass inheritance to simplify some of riscv_vector.td. NFCI

Author: Craig Topper Date: 2021-04-07T17:33:21-07:00 New Revision: 5f6b3d1833fdf20e18a3c8bf3ede7b5060130f73 URL: https://github.com/llvm/llvm-project/commit/5f6b3d1833fdf20e18a3c8bf3ede7b5060130f73 DIFF: https://github.com/llvm/llvm-project/commit/5f6b3d1833fdf20e18a3c8bf3ede7b5060130f73.diff

[PATCH] D100074: [RISCV] Use multiclass inheritance to simplify some of riscv_vector.td. NFCI

khchen accepted this revision. khchen added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100074/new/ https://reviews.llvm.org/D100074 __

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

rsmith added a comment. Sorry for the late review. Comment at: clang/lib/Sema/SemaChecking.cpp:10294-10303 +void CheckFreeArgumentsPlus(Sema &S, const std::string &CalleeName, +const UnaryOperator *UnaryExpr) { + const auto *Lambda = dyn_cast( +

[PATCH] D91466: [WIP][clang][Fuchsia] Support HWASan for Fuchsia

leonardchan updated this revision to Diff 335951. leonardchan added a comment. Rebase against submitted changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91466/new/ https://reviews.llvm.org/D91466 Files: clang/cmake/caches/Fuchsia-stage2.cm

[PATCH] D100074: [RISCV] Use multiclass inheritance to simplify some of riscv_vector.td. NFCI

craig.topper created this revision. craig.topper added reviewers: khchen, HsiangKai, evandro, arcbbb. Herald added subscribers: StephenFan, vkmr, frasercrmck, dexonsmith, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D99231: [AST] Add introspection support for more base nodes

steveire added a comment. @njames93 ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99231/new/ https://reviews.llvm.org/D99231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D99291: [AIX] Support init priority attribute

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:663 + // Create our global prioritized cleanup function. + if (!PrioritizedCXXStermFinalizers.empty()) { ---

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1219 + } else { +SrcElementTy = SrcTy; +DstElementTy = DstTy; We should be able to assert here that both types are not matrix types, I think? Comment at: clang

[PATCH] D100054: Handle flags such as -m32 when computing the triple prefix for programs

arichardson planned changes to this revision. arichardson added a comment. In D100054#2675152 , @joerg wrote: > This sounds wrong. If you are using 'x86_64-freebsd' as triple and -m32, it > should still call 'x86_64-freebsd-ld', but it is the responsibil

[PATCH] D100054: Handle flags such as -m32 when computing the triple prefix for programs

joerg added a comment. This sounds wrong. If you are using 'x86_64-freebsd' as triple and -m32, it should still call 'x86_64-freebsd-ld', but it is the responsibility of the driver to ensure that also the right set of linker flags are passed as well. Compare `netbsd::Linker::ConstructJob` for o

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova marked 3 inline comments as done. hankadusikova added a comment. In D100057#2675085 , @jfb wrote: > A few nits, but this is good otherwise! Having an aggregate with multiple (empty) bases initialised with nonempty {} is a hard error, hence

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova updated this revision to Diff 335922. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D100057 Files: clang/lib/Sema/SemaInit.cpp clang/test/SemaCXX/aggregate-initialization.cpp Index: clang/test/SemaCXX/aggregate-initialization.cpp =

[PATCH] D99965: [RISCV][Clang] Add more RVV load/store intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99965/new/ https://reviews.llvm.org/D99965 _

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. A few nits, but this is good otherwise! Comment at: clang/lib/Sema/SemaInit.cpp:1013 - auto *ParentRD = - Entity.getParent()->getType()->castAs()->getDecl(); - if (CXXReco

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

mikhail.ramalho added a comment. Indeed it looks like a copy & paste error, I'm surprised no one found it earlier. Regarding the tests, we used to have `make check-clang-analysis-z3` (or something similar) that would run only the analyzer's tests, but using Z3 as the constraint solver. It look

[PATCH] D100055: Fix missing generate capture expression for novariants's condition

jyu2 closed this revision. jyu2 added a comment. committed rGebf2dc33287e : Fix missing generate capture expression for novariants condition. (authored by jyu2). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D97653: [clang-tidy] Fix RenamerClangTidy checks breaking lambda captures.

aaron.ballman added a comment. In D97653#2593287 , @njames93 wrote: > Where would be a good place for testing refersToDefaultCapture support? Thank you for your patience while I thought about this a bit more, sorry for the delay in reviewing it! I think

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. In D99381#2651896 , @mcgrathr wrote: > I don't think this is warranted. There should not be any references to such > things when building for Fuchsia. > This looks like it's intended to satisfy one reference in dead code in

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. Hopefully this will work. My IDE is a bit wonky and it will take hours to rebuild for me after rebase. So pushed here with the hope that this could be validated using web build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D99901: [Driver][test] Test intended target only

This revision was automatically updated to reflect the committed changes. Closed by commit rGa723310b419b: [Driver][test] Test intended target only (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99901/new/ https://reviews.llvm.org

[clang] a723310 - [Driver][test] Test intended target only

Author: Jinsong Ji Date: 2021-04-07T20:08:26Z New Revision: a723310b419be870acf72aafd3bfabacbaace642 URL: https://github.com/llvm/llvm-project/commit/a723310b419be870acf72aafd3bfabacbaace642 DIFF: https://github.com/llvm/llvm-project/commit/a723310b419be870acf72aafd3bfabacbaace642.diff LOG: [D

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1453 + CGF.CGM.getIntrinsic(llvm::Intrinsic::convert_to_fp16, + CGF.CGM.FloatTy), + Res); Not sure why this was changed. Perhaps clang

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha updated this revision to Diff 335913. SaurabhJha added a comment. Rebased with latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99037/new/ https://reviews.llvm.org/D99037 Files: clang/include/clang/AST/OperationKinds.def cl

[clang] ebf2dc3 - Fix missing generate capture expression for novariants condition.

Author: Jennifer Yu Date: 2021-04-07T12:35:49-07:00 New Revision: ebf2dc33287ea414059d3b2f3568f6653ddd4b51 URL: https://github.com/llvm/llvm-project/commit/ebf2dc33287ea414059d3b2f3568f6653ddd4b51 DIFF: https://github.com/llvm/llvm-project/commit/ebf2dc33287ea414059d3b2f3568f6653ddd4b51.diff L

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d8513b7f2e9: [clang] Move int <-> float scalar conversion to a separate function (authored by SaurabhJha, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 7d8513b - [clang] Move int <-> float scalar conversion to a separate function

Author: Saurabh Jha Date: 2021-04-07T12:34:16-07:00 New Revision: 7d8513b7f2e996fbbb35e0ffce4fe1d4f695928b URL: https://github.com/llvm/llvm-project/commit/7d8513b7f2e996fbbb35e0ffce4fe1d4f695928b DIFF: https://github.com/llvm/llvm-project/commit/7d8513b7f2e996fbbb35e0ffce4fe1d4f695928b.diff L

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

yaxunl updated this revision to Diff 335904. yaxunl added a comment. fix test failure on windows. need to specify triple since it affects name mangling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 Files: clang/lib/Sema/SemaExpr.cpp clan

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

SaurabhJha added a comment. In D100051#2674849 , @erichkeane wrote: > Alright, validating it now, then I'll push. Thanks very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100051/new/ https://revie

[PATCH] D100049: Remove .gitignore entries not relevant in the monorepo.

This revision was automatically updated to reflect the committed changes. Closed by commit rG676a9ab5e406: Remove .gitignore entries not relevant in the monorepo. (authored by probinson). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

fhahn added a comment. In D100051#2674849 , @erichkeane wrote: > Alright, validating it now, then I'll push. Thanks Erich! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100051/new/ https://reviews.llvm.o

[clang] 676a9ab - Remove .gitignore entries not relevant in the monorepo.

Author: Paul Robinson Date: 2021-04-07T12:25:02-07:00 New Revision: 676a9ab5e406f3a54179b3dd7be1ccd141841d19 URL: https://github.com/llvm/llvm-project/commit/676a9ab5e406f3a54179b3dd7be1ccd141841d19 DIFF: https://github.com/llvm/llvm-project/commit/676a9ab5e406f3a54179b3dd7be1ccd141841d19.diff

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

erichkeane added a comment. Alright, validating it now, then I'll push. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100051/new/ https://reviews.llvm.org/D100051 ___ cfe-commits mailing list cfe-commits

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

rjmccall added a comment. > Yes. We now have a motivational reason to do so, it wouldn't be "just expose > the UB for the sake of miscompiling the program". Nobody thinks you're proposing this just for the sake of miscompiling. We understand that there are optimization benefits to having this

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova marked an inline comment as done. hankadusikova added a comment. In D100057#2674820 , @lebedev.ri wrote: > This patch says what it does, but not why it does what it does. > Did the pattern become idiomatic so that we now want to not warn?

[PATCH] D98902: [Clang][OpenMP][NVPTX] Fixed failure in openmp-offload-gpu.c if the system has CUDA

Hahnfeld added a comment. Can we get this fixed somehow? It's annoying that there is a test failure in Clang without building the OpenMP runtime, just because I have CUDA installed on my machine... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D989

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

lebedev.ri added a comment. This patch says what it does, but not why it does what it does. Did the pattern become idiomatic so that we now want to not warn? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D100057

[PATCH] D99791: [CGCall] Annotate pointer argument with alignment

lebedev.ri updated this revision to Diff 335894. lebedev.ri added a comment. Herald added subscribers: jansvoboda11, dexonsmith, dang. Add an option to toggle this optimization. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99791/new/ https://revie

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

lebedev.ri updated this revision to Diff 335893. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Unguard the UBSan check under `-fstrict*`. In D100037#2674610 , @rsmith wrote: > I assume your intent here is to eventually add LLVM

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova updated this revision to Diff 335892. hankadusikova added a comment. Fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100057/new/ https://reviews.llvm.org/D100057 Files: clang/lib/Sema/SemaInit.cpp clang/test/SemaCXX/aggre

[PATCH] D99964: [RISCV][Clang] Add all RVV Reduction intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99964/new/ https://reviews.llvm.org/D99964 _

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

SaurabhJha added a comment. I don't have commit rights so if it looks good to you, please commit on my behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100051/new/ https://reviews.llvm.org/D100051

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

miscco added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:1013 - auto *ParentRD = - Entity.getParent()->getType()->castAs()->getDecl(); - if (CXXRecordDecl *CXXRD = dyn_cast(ParentRD)) -if (CXXRD->getNumBases()) - return false; + // Allows elide bra

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

hankadusikova created this revision. hankadusikova added a reviewer: clang. hankadusikova requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Removes this warning: template struct StdArray { T contents[N]; }; template struct A

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

SaurabhJha updated this revision to Diff 335884. SaurabhJha added a comment. Rename the function to `EmitScalarCast` and directly returning from `if` branches now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100051/new/ https://reviews.llvm.org/D

[PATCH] D100056: [SystemZ][z/OS] Set files in FileRemapper.cpp are text

abhina.sreeskantharajan created this revision. abhina.sreeskantharajan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch sets files in FileRemapper to open as text. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D100055: Fix missing generate capture expression for novariants's condition

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100055/new/ https://reviews.llvm.org/D100055 ___

[PATCH] D100055: Fix missing generate capture expression for novariants's condition

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 requested review of this revision. Herald added a project: clang. This is fix missing capture expression for novariants's condition Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100055 Files: clang/li

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

SaurabhJha added a comment. In D100051#2674674 , @erichkeane wrote: > Hrmph... Phab ate my other comment, which was that the name > `EmitCastBetweenScalarTypes` feels clunky. Does `EmitScalarCast` or > `EmitScalarScalarCast` sound better and capture t

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

lebedev.ri added a comment. In D100037#2674610 , @rsmith wrote: >> This is somewhat related to the following RFC by @rjmccall: >> https://lists.llvm.org/pipermail/llvm-dev/2016-January/094012.html > > It looks to me like this direction is in conflict with

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

nickdesaulniers added a comment. > Let's first give users tools to weed out the cases where the pointer > passed into function's argument is underaligned. Isn't there already `-Walign-mismatch` in clang? We definitely have 1 unresolved case of that affecting the Linux kernel ATM: https://githu

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

erichkeane added a comment. Hrmph... Phab ate my other comment, which was that the name `EmitCastBetweenScalarTypes` feels clunky. Does `EmitScalarCast` or `EmitScalarScalarCast` sound better and capture the meaning correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1209 +if (isa(DstTy)) + Res = Builder.CreateIntCast(Src, DstTy, InputSigned, "conv"); +else if (InputSigned) fhahn wrote: > now that' this is a separate function, we sho

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

MaskRay added a comment. In D6#2673276 , @sylvestre.ledru wrote: > To understand better, we will be fixing a bug from 2015, correct? Yes. In D6#2674407 , @arichardson wrote: > I believe adding the defaul

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

fhahn added reviewers: rsmith, erichkeane. fhahn added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:1209 +if (isa(DstTy)) + Res = Builder.CreateIntCast(Src, DstTy, InputSigned, "conv"); +else if (InputSigned) now that' this is a se

[PATCH] D99994: [CodeView] Add CodeView support for PGO debug information

akhuang added a comment. think this looks good overall; maybe it should also have an IR to codeview test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/new/ https://reviews.llvm.org/D4 ___ cfe-

[PATCH] D100054: Handle flags such as -m32 when computing the triple prefix for programs

arichardson created this revision. arichardson added reviewers: MaskRay, phosek. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncoo

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

rsmith added a comment. > This is somewhat related to the following RFC by @rjmccall: > https://lists.llvm.org/pipermail/llvm-dev/2016-January/094012.html It looks to me like this direction is in conflict with that RFC. In particular, it says: > It is not undefined behavior to create a pointer

[clang] 028092e - Correct the tablegen logic for MutualExclusions attribute checking.

Author: Aaron Ballman Date: 2021-04-07T14:04:08-04:00 New Revision: 028092eb613e5553ce0833878e7d36fcaf11fcb2 URL: https://github.com/llvm/llvm-project/commit/028092eb613e5553ce0833878e7d36fcaf11fcb2 DIFF: https://github.com/llvm/llvm-project/commit/028092eb613e5553ce0833878e7d36fcaf11fcb2.diff

[PATCH] D100037: [clang][UBSan] Passing underaligned pointer as a function argument is undefined behaviour

lebedev.ri updated this revision to Diff 335872. lebedev.ri added a comment. Fix usage of clang function argument -> llvm function argument mapping reading. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100037/new/ https://reviews.llvm.org/D100037

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || Ok if you allow

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

kiranchandramohan accepted this revision. kiranchandramohan added a comment. LGTM. Might be good to have a test for fdebug-dump-parse-tree-no-sema. Comment at: flang/include/flang/Frontend/FrontendOptions.h:54 + /// Parse, run semantics and then output the parse tree, skip

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

srhines added a comment. Adding Dan as an FYI. While this doesn't impact Android platform or regular NDK users, I suppose that someone could have some esoteric build rules that are relying on this, but they should probably be more explicit about what they're running in those cases anyways. Re

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

nickdesaulniers accepted this revision. nickdesaulniers added a comment. I don't foresee this affecting Linux kernel builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 _

[PATCH] D98856: Always emit error for wrong interfaces to scalable vectors, unless cmdline flag is passed.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5066 +CmdArgs.push_back("-mllvm"); +CmdArgs.push_back("-treat-scalable-fixed-error-as-warning"); + } sdesmalen wrote: > MaskRay wrote: > > Does this introduce an option in t

[PATCH] D99037: [Matrix] Implement C-style explicit type conversions for matrix types

SaurabhJha added a comment. > I think the issue might be that adding this additional cast-kind caused the > value to exceed the maximum supported by the `CastExprBitfields`; the > bitfield can only store 64 values, but after adding `MatrixCast`, > `CK_IntToOCLSampler` will have value `64`, so a

[PATCH] D100051: [clang] Move int <-> float scalar conversion to a separate function

SaurabhJha created this revision. SaurabhJha requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As prelude to this patch https://reviews.llvm.org/D99037, we want to move the int-float conversion into a separate function that can be reused by

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

kamleshbhalui added a reviewer: rnk. kamleshbhalui added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99580/new/ https://reviews.llvm.org/D99580 ___ cfe-commits mailing list cfe-commits

[PATCH] D100045: [HIP] Fix rocm-detect.hip test path

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf59850038d8: [HIP] Fix rocm-detect.hip test path (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D100045?vs

[clang] df59850 - [HIP] Fix rocm-detect.hip test path

Author: Aaron En Ye Shi Date: 2021-04-07T17:20:59Z New Revision: df59850038d800e8e8b062a5fc2e3d4ed624b526 URL: https://github.com/llvm/llvm-project/commit/df59850038d800e8e8b062a5fc2e3d4ed624b526 DIFF: https://github.com/llvm/llvm-project/commit/df59850038d800e8e8b062a5fc2e3d4ed624b526.diff LO

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

arichardson added a comment. I believe adding the default triple is causing the wrong linker to be selected for me when compiling with -m32, so I'd be happy for this code to be removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ http

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 _

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 _

[PATCH] D99409: [clang] Speedup line offset mapping computation

serge-sans-paille added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1262 + unsigned char n) { + return ((x - ~0UL / 255 * (n + 1)) & ~x & + (x & ~0UL / 255 * 127) + ~0UL / 255 * (127 - (m - 1))) &

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen added a comment. The fact that Clang chooses to (explicitly) forget about a builtin in SemaDecl.cpp was quite puzzling to me. Maybe that just shows that I don't fully understand how the builtin mechanism is supposed to work. @rsmith and @tambre, git history showed me you have more expe

[PATCH] D99669: [RISCV][Clang] Add more RVV Floating-Point intrinsic functions.

khchen updated this revision to Diff 335846. khchen marked 4 inline comments as done. khchen added a comment. address Craig's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99669/new/ https://reviews.llvm.org/D99669 Files: clang/include

[PATCH] D100046: [AArch64] ACLE: Fix issue for mismatching enum types with builtins.

sdesmalen created this revision. Herald added subscribers: danielkiss, kristof.beyls. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes an issue with the SVE prefetch and qinc/qdec intrinsics that take an `enum` arg

[PATCH] D99526: [RISCV][Clang] Add RVV Widening Integer Add/Subtract intrinsic functions.

khchen updated this revision to Diff 335840. khchen added a comment. align implementation to https://github.com/riscv/rvv-intrinsic-doc/pull/77. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99526/new/ https://reviews.llvm.org/D99526 Files: clan

[PATCH] D99646: [clang-tidy] misc-avoid-std-io-outside-main: a new check

mgartmann updated this revision to Diff 335839. mgartmann added a comment. Corrected check's entry in `list.rst` after renaming the check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99646/new/ https://reviews.llvm.org/D99646 Files: clang-tool

[PATCH] D99554: [ThinLTO] During module importing, close one source module before open another one for distributed mode.

wenlei added subscribers: weiwang, wenlei. wenlei added a comment. Does this help non-distributed ThinLTO as well? cc: @weiwang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99554/new/ https://reviews.llvm.org/D99554 __

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

awarzynski added a comment. In D99353#2672503 , @protze.joachim wrote: > In D99353#2669046 , @awarzynski > wrote: > >> Btw, how important are these aliases for you? > > It's just not obvious from `flang --help` th

[PATCH] D99645: [flang][driver] Add debug options not requiring semantic checks

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:4378 HelpText<"Run the InputOuputTest action. Use for development and testing only.">; +def fdebug_unparse_no_sema : Flag<["-"], "fdebug-unparse-no-sema">, Group, + HelpText<"Unparse and sto

  1   2   >