MaskRay added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5066
+    CmdArgs.push_back("-mllvm");
+    CmdArgs.push_back("-treat-scalable-fixed-error-as-warning");
+  }
----------------
sdesmalen wrote:
> MaskRay wrote:
> > Does this introduce an option in the CC1 command line for most cases? We 
> > should shorten the CC1 command line for common cases...
> The option is purely temporary and will be removed in the future. I guess it 
> depends on the meaning of the word 'common' in this context, but it enables 
> experimental use of Clang for scalable vectors, which is common if the 
> targets support them. We'd like to remove this flag sooner rather than later, 
> although there is work involved in LLVM before we can remove it.
> 
> Are you specifically concerned with the length (as in: number of characters) 
> of the cc1 command?
> Are you specifically concerned with the length (as in: number of characters) 
> of the cc1 command?

Yes.

I looked at a random SVE unrelated `clang -###` and found this option... Now I 
tried again and can't find the option now. Reducing CC1 length without making 
internal implementation difficult is generally good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98856/new/

https://reviews.llvm.org/D98856

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to