[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

tejohnson added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1069 + if (!CodeGenOpts.ThinLTOIndexFile.empty()) { +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and tri

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGff50b121e336: [SYCL] Ignore file-scope asm during device-side SYCL compilation. (authored by ArturGainullin). Repository: rG LLVM Github Monorepo

[clang] ff50b12 - [SYCL] Ignore file-scope asm during device-side SYCL compilation.

Author: Artur Gainullin Date: 2021-02-12T17:00:45-08:00 New Revision: ff50b121e336503621da80676116f82d82e91196 URL: https://github.com/llvm/llvm-project/commit/ff50b121e336503621da80676116f82d82e91196 DIFF: https://github.com/llvm/llvm-project/commit/ff50b121e336503621da80676116f82d82e91196.dif

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

njames93 added a comment. I don't see the use case you suggest as a strong enough motivation for this, clang-format does this job very well and we shouldn't be reinventing the wheel here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96607/new/ h

[PATCH] D96471: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

jonpa added a comment. Committed after changed to use __builtin_memcpy() instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96471/new/ https://reviews.llvm.org/D96471 ___ cfe-commits mailing list cfe

[PATCH] D96471: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb3ac5b84cdd4: [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst. (authored by jonpa). Herald added a

[clang] b3ac5b8 - [SystemZ] Fix vecintrin.h to not emit alignment hints in vec_xl/vec_xst.

Author: Jonas Paulsson Date: 2021-02-12T18:26:36-06:00 New Revision: b3ac5b84cdd46fc62a7215ae6b11f3c005900461 URL: https://github.com/llvm/llvm-project/commit/b3ac5b84cdd46fc62a7215ae6b11f3c005900461 DIFF: https://github.com/llvm/llvm-project/commit/b3ac5b84cdd46fc62a7215ae6b11f3c005900461.diff

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, vitalybuka wrote: > delcypher wrote

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 ___ c

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. @jansvoboda11 I noticed that the `Options.td` file is making use of some fancy mixins that mean the option gets automatically marshalled by the frontend into the codegen options :). I tried this out using the patch to this patch and all my tests seem to pass. Should I

[PATCH] D95903: [OpenMP][NFC] Pre-commit test changes regarding PR48933

jdoerfert added a comment. ping and follow up patches. Fixes PR49158 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95903/new/ https://reviews.llvm.org/D95903 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D96607: [clang-tidy] Add check 'readability-pointer-type-star-placement'.

Eugene.Zelenko added a comment. I think it'll be much more reasonable to use `clang-format` and filter its output to select only changes with stars in build rule. `clang-format-diff` is another method to introduce formatting changes gradually. Comment at: clang-tools-extra/c

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 created this revision. zero9178 added reviewers: rnk, russell.gallop. zero9178 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When targeting a MSVC triple, --dependant-libs with the name of the clang runtime library for profiling

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

abhinavgaba added a comment. Thanks for the changes, Alexey! I tried the patch locally, and it looks stable. It handled several tests I tried, including the following case involving array section on a pointer to pointer base, and nested mappers with `PTR_AND_OBJ` maps successfully: #include

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 323480. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Addressing reviewers' comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D96344 Files: clang/include/clang/Driver/Options

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:166 +assert((isa(S) || isa(S)) && + "Canonical loop must be a for loop (range-based or otherwise)"); +SubStmts[LOOPY_STMT] = S; Meinersbur wrote: > jdenny wrote: > >

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka added a comment. In D79043#2560867 , @aganea wrote: > In D79043#2560710 , @vitalybuka > wrote: > >> This patch is relatively recent. I'd like to revert this for D96203 >>

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > delcypher wrote

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

sgraenitz added a comment. @v.g.vassilev Great to see this getting upstreamed! @teemperor Thanks for adding, I will take a look in the next days. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96033/new/ https://reviews.llvm.org/D96033 ___ cf

[PATCH] D96538: [SYCL] Ignore file-scope asm during device-side SYCL compilation.

ArturGainullin updated this revision to Diff 323456. ArturGainullin added a comment. Rebase for retesting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96538/new/ https://reviews.llvm.org/D96538 Files: clang/lib/CodeGen/CodeGenModule.cpp clan

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, delcypher wrote: > vitalybuka wrote

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. Thank you for your patience. LGTM now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 ___

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher updated this revision to Diff 323455. delcypher added a comment. Add documentation for `-fsanitize-address-destructor-kind=` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 Files: clang/

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added a comment. Just a note: >> 4.b. still feels like a hack because there are captures variables outside of >> any CapturedStmt and therefore complicated the AST. Comparable directive >> such as master don't do this. It is not a hack, this was an optimization to minimize the number o

[PATCH] D96265: [PowerPC] Change target data layout for 16-byte stack alignment

saghir updated this revision to Diff 323451. saghir added a comment. Updated tests to add run line for llc and target datalayout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96265/new/ https://reviews.llvm.org/D96265 Files: clang/lib/Basic/Tar

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

ahatanak added a comment. Thanks! I didn't realize it hadn't been fixed in the patch I committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 ___ cfe-commits

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

aganea added a comment. In D79043#2560710 , @vitalybuka wrote: > This patch is relatively recent. I'd like to revert this for D96203 > > Can we user just pointo to /dev/null if file is not needed? You mean just use `-fn

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323449. sammccall added a comment. Add doc comments to bind methods Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files: clang-tools-extra/clangd/ClangdLSPServer.

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 323443. dgoldman added a comment. - Add class method test case + swap to auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D96625: [clangd] Allow modules to bind LSP methods/notifications/commands

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo ht

[clang] 6280bb4 - [clang] Remove redundant condition (NFC).

Author: Florian Hahn Date: 2021-02-12T20:14:24Z New Revision: 6280bb4cd80e39b0e54b1c8dd091f2b7175381eb URL: https://github.com/llvm/llvm-project/commit/6280bb4cd80e39b0e54b1c8dd091f2b7175381eb DIFF: https://github.com/llvm/llvm-project/commit/6280bb4cd80e39b0e54b1c8dd091f2b7175381eb.diff LOG:

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323438. sammccall added a comment. Revert to previous version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall added a comment. whoops, meant to create a new review for that followup change, not update this one... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544

[PATCH] D96544: [clangd] Extract binding of typed->untyped LSP handlers to LSPBinder. NFC

sammccall updated this revision to Diff 323436. sammccall added a comment. [clangd] Allow modules to bind LSP methods/notifications/commands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96544/new/ https://reviews.llvm.org/D96544 Files: clang-t

[clang] 0c4935b - [docs/Coverage] Document -show-region-summary

Author: Vedant Kumar Date: 2021-02-12T12:05:45-08:00 New Revision: 0c4935bb85166a4a0bf87a320b81e400d7be04f0 URL: https://github.com/llvm/llvm-project/commit/0c4935bb85166a4a0bf87a320b81e400d7be04f0 DIFF: https://github.com/llvm/llvm-project/commit/0c4935bb85166a4a0bf87a320b81e400d7be04f0.diff

[clang] 13bd6fb - [docs/Coverage] Answer FAQ about optimization

Author: Vedant Kumar Date: 2021-02-12T12:05:38-08:00 New Revision: 13bd6fb43da9e9b1d7e82272325ec781d1f16456 URL: https://github.com/llvm/llvm-project/commit/13bd6fb43da9e9b1d7e82272325ec781d1f16456 DIFF: https://github.com/llvm/llvm-project/commit/13bd6fb43da9e9b1d7e82272325ec781d1f16456.diff

[PATCH] D96597: [DebugInfo] Keep the DWARF64 flag in the module metadata

dblaikie accepted this revision. dblaikie added a subscriber: aprantl. dblaikie added a comment. This revision is now accepted and ready to land. @aprantl - mind having a look at this/signing off as well, if you're OK with it? Since it's a core metadata change, wouldn't mind some extra eyes on it

[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

MartinG added a comment. More than 3.5 years later and this extremely basic feature hasn't been merged yet? Clang-tidy's interface is completely broken. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D34654/new/ https://reviews.llvm.org/D34654

[PATCH] D95502: WIP: Frontend: Adopt llvm::vfs::OutputManager in CompilerInstance

dexonsmith updated this revision to Diff 323435. dexonsmith added a comment. Herald added a subscriber: jfb. Rebase on top of newer https://reviews.llvm.org/D95501. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95502/new/ https://reviews.llvm.org/D95502 Files: clang/include/clang/Fro

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/SanitizerBlacklist.h:20 #include #include This file should go into a separate patch. It touches multiple files with simple changes but unlikely will case rollback. It's unrelated to mo

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

jyknight added a comment. > I ended up reverting the changes I made to llvm/lib/IR/AutoUpgrade.cpp as the > file was including llvm/Analysis/ObjCARCUtil.h, which was violating layering. It looks like it was not actually reverted in the version ultimately submitted. I've pushed commit 3c06676de1

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov marked an inline comment as done. azabaznov added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15289 +ExpectedResultType->getAs()) { + ExpectedResultType = SemaRef.Context.getCanonicalType( + RemoveAddressSpaceFromPtr(SemaRef, Ex

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reopen to attract attention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79043/new/ https://reviews.llvm.org/D79043 __

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. In D96203#2559792 , @mibintc wrote: > In D96203#2559426 , @vitalybuka > wrote: > FWIW I would prefer denylist as well. (Also uses of whitelist should be allowlist, but also in

[PATCH] D79043: [Driver] Skip validation of system sanitizer blacklists files if -fno-sanitizer-blacklist was specified

vitalybuka added a comment. This patch is relatively recent. I'd like to revert this for D96203 Can we user just pointo to /dev/null if file is not needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79043/new/

[PATCH] D95497: Frontend: Respect -working-directory when checking if output files can be written

dexonsmith updated this revision to Diff 323422. dexonsmith added a comment. ping / rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95497/new/ https://reviews.llvm.org/D95497 Files: clang/lib/Frontend/CompilerInstance.cpp clang/test/Frontend/output-paths.c Index: clang/test/

[PATCH] D96178: [OpenCL] Create VoidPtrTy with generic AS in C++ for OpenCL mode

azabaznov updated this revision to Diff 323421. azabaznov added a comment. Rewrote 'RemoveAddressSpaceFromPtr' to return canonical type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96178/new/ https://reviews.llvm.org/D96178 Files: clang/lib/AST

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51bf4c0e6d4c: [clang] Add -ffinite-loops & -fno-finite-loops options. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D9641

[clang] 51bf4c0 - [clang] Add -ffinite-loops & -fno-finite-loops options.

Author: Florian Hahn Date: 2021-02-12T19:25:49Z New Revision: 51bf4c0e6d4cbc6dfa57857fc78003413cbeb17f URL: https://github.com/llvm/llvm-project/commit/51bf4c0e6d4cbc6dfa57857fc78003413cbeb17f DIFF: https://github.com/llvm/llvm-project/commit/51bf4c0e6d4cbc6dfa57857fc78003413cbeb17f.diff LOG:

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb marked 3 inline comments as done. cjdb added inline comments. Comment at: clang/test/Analysis/free.c:84 + // expected-warning@-1{{Argument to free() is a block, which is not memory allocated by malloc()}} + // expected-warning@-2{{attempt to call free on non-heap object :

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 323414. cjdb added a comment. fixes block expressions @aaron.ballman I'm not sure I follow what you're after re lambdas. Could you please provide a test case that I can work with? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D96588: [OpenCL] Remove FIXME in getOpenCLFeatureDefines

Anastasia added a comment. > The suggestion in D92277 was to move > OpenCLOptions into LanguageOptions, but > this is not viable. Sema's LangOpts is immutable, and embedding > OpenCLOptions into LangOpts would make OpenCLOptions immutable too. > This is incomp

[PATCH] D85817: [analyzer] Fix crash with pointer to members values

RedDocMD added a comment. @vsavchenko, why did you chose NamedDecl instead of ValueDecl to account for the indirect fields? I couldn't quite follow it from the discussion above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85817/new/ https://revi

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

njames93 added a comment. I'm not an objc guy, but can you add a test case demonstrating class(?) methods showing as `+name:`? Comment at: clang-tools-extra/clangd/AST.cpp:224-226 + if (const ObjCContainerDecl *C = dyn_cast(&ND)) +return printObjCContainer(*C); + if (con

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added inline comments. Comment at: clang/include/clang/Driver/Options.td:1485 +def sanitize_address_destructor_kind_EQ : Joined<["-"], "fsanitize-address-destructor-kind=">, + MetaVarName<"">, + Flags<[CC1Option]>, vitalybuka wrote: > What is the dif

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

delcypher added a comment. Note this patch depends on https://reviews.llvm.org/D96571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96572/new/ https://reviews.llvm.org/D96572 ___ cfe-commits mailing list

[clang] 3fe465f - Revert "[DebugInfo] Add an attribute to force type info to be emitted for"

Author: Amy Huang Date: 2021-02-12T10:18:17-08:00 New Revision: 3fe465fb2cd64cd7bd910c761920e3378fe8d1b0 URL: https://github.com/llvm/llvm-project/commit/3fe465fb2cd64cd7bd910c761920e3378fe8d1b0 DIFF: https://github.com/llvm/llvm-project/commit/3fe465fb2cd64cd7bd910c761920e3378fe8d1b0.diff LOG

[clang] 1b5c291 - [DebugInfo] Add an attribute to force type info to be emitted for

Author: Amy Huang Date: 2021-02-12T10:16:49-08:00 New Revision: 1b5c2915a2318705727ada586290de15e2cad202 URL: https://github.com/llvm/llvm-project/commit/1b5c2915a2318705727ada586290de15e2cad202 DIFF: https://github.com/llvm/llvm-project/commit/1b5c2915a2318705727ada586290de15e2cad202.diff LOG

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2560280 , @Anastasia wrote: > In D96515#2559424 , @svenvh wrote: > >> It probably makes sense to update `clang/docs/UsersManual.rst` as part of >> this change. In particular th

[PATCH] D96616: [OpenCL][Docs] Change documentation for the OpenCL standard headers

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. After updating the user interface (https://reviews.llvm.org/D96515), make sure the doc reflects the change. https://reviews.llvm.org/D9661

[PATCH] D96611: [analyzer][tests] Fix issue comparison script

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx!~ Comment at: clang/utils/analyzer/CmpRuns.py:401-402 + +old = filter_issues(old, common) +new = filter_issues(new, common) +common = set()

[PATCH] D95043: [clangd] Use Dirty Filesystem for cross file rename.

njames93 updated this revision to Diff 323379. njames93 added a comment. Rebase and fix up tests after changes to rename. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95043/new/ https://reviews.llvm.org/D95043 Files: clang-tools-extra/clangd/Cl

[PATCH] D94554: [clangd] Add a Filesystem that overlays Dirty files.

njames93 updated this revision to Diff 323378. njames93 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94554/new/ https://reviews.llvm.org/D94554 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/clan

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed4718eccb12: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of (authored by ahatanak). Repository: rG LLVM Github Monorepo CHAN

[clang] ed4718e - [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of

Author: Akira Hatanaka Date: 2021-02-12T09:51:57-08:00 New Revision: ed4718eccb12bd42214ca4fb17d196d49561c0c7 URL: https://github.com/llvm/llvm-project/commit/ed4718eccb12bd42214ca4fb17d196d49561c0c7 DIFF: https://github.com/llvm/llvm-project/commit/ed4718eccb12bd42214ca4fb17d196d49561c0c7.diff

[PATCH] D96419: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn updated this revision to Diff 323373. fhahn added a comment. Rebased the patch to apply wihtout D96418 . Will land soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96419/new/ https://reviews.llvm.org/D964

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk added inline comments. Comment at: llvm/docs/CoverageMappingFormat.rst:277 +There is one difference between versions 6 and 5: + +There is one difference between versions 5 and 4: I think the above bullet point could go in this section? Repository: rG LLVM

[PATCH] D95753: Store compilation dir separately in coverage mapping

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. The pre-merge checks appear to have flagged some issues, but I don't anticipate any major revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D96244: [clangd] Introduce Modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2423a3863e07: [clangd] Introduce Modules (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang-tools-extra] 2423a38 - [clangd] Introduce Modules

Author: Kadir Cetinkaya Date: 2021-02-12T18:37:16+01:00 New Revision: 2423a3863e0743635f76d30062413f21b2c59349 URL: https://github.com/llvm/llvm-project/commit/2423a3863e0743635f76d30062413f21b2c59349 DIFF: https://github.com/llvm/llvm-project/commit/2423a3863e0743635f76d30062413f21b2c59349.dif

[PATCH] D96608: [clangd] Delay binding LSP methods until initialize. NFC

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:165 return false; -if (!Server.Server) { - elog("Notification {0} before initialization", Met

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia added a comment. In D96515#2559424 , @svenvh wrote: > It probably makes sense to update `clang/docs/UsersManual.rst` as part of > this change. In particular the following sentence is no longer true after > this patch: "By default the OpenCL he

[PATCH] D95704: [CodeGen] Introduce DWARF tag for SwiftTail and emit it in CodeGen.

varungandhi-apple updated this revision to Diff 323364. varungandhi-apple added a comment. Tweak test case diff to adjust for change in previous commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95704/new/ https://reviews.llvm.org/D95704 Files

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 323363. varungandhi-apple added a comment. Fix test case for debuginfo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561 Files: clang/include/clang-c/Index.h

[PATCH] D96515: [OpenCL] Add builtin declarations by default.

Anastasia updated this revision to Diff 323362. Anastasia added a comment. Changed command line option text. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96515/new/ https://reviews.llvm.org/D96515 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/Types.h cl

[PATCH] D96244: [clangd] Introduce Modules

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:33 #include "clang/Tooling/Core/Replacement.h" +#include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/FunctionExtras.h" sammccall wrote: > (include no longer used?) well it is still

[PATCH] D96244: [clangd] Introduce Modules

kadircet updated this revision to Diff 323361. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96244/new/ https://reviews.llvm.org/D96244 Files: clang-tools-ex

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with -finclude-defa

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. @steakhal > In the upcoming days, I'm gonna schedule this on our CI. We will see the > results. Thank you. That would be great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 ___

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:27 + // expected-error@-3 0+{{no matching function for call to 'barrier'}} + // expected-error@* {{typedef type cl_mem_fence_flags not found; include the base header with -finclude-d

[clang-tools-extra] 8dd6dd9 - [clangd] Work around presumed MSVC stdlib bug

Author: Sam McCall Date: 2021-02-12T18:00:43+01:00 New Revision: 8dd6dd947c148515bbd5fc06c0b5786148038750 URL: https://github.com/llvm/llvm-project/commit/8dd6dd947c148515bbd5fc06c0b5786148038750 DIFF: https://github.com/llvm/llvm-project/commit/8dd6dd947c148515bbd5fc06c0b5786148038750.diff LO

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Categories will now be printed

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple added inline comments. Comment at: clang/test/CodeGen/debug-info-cc.c:60-66 +// [FIXME: swiftasynccc] Update debuginfo tag to SwiftAsync once LLVM support lands. +// LINUX: !DISubprogram({{.*}}"add_swiftasynccall", {{.*}}type: ![[FTY:[0-9]+]] +// LINUX: ![[FTY]

[PATCH] D96204: [clangd] Fix clang tidy provider when multiple config files exist in directory tree

This revision was automatically updated to reflect the committed changes. Closed by commit rGba3ea9c60f0f: [clangd] Fix clang tidy provider when multiple config files exist in directory… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] ba3ea9c - [clangd] Fix clang tidy provider when multiple config files exist in directory tree

Author: Nathan James Date: 2021-02-12T16:55:46Z New Revision: ba3ea9c60f0f259f0ccc47e47daf8253a5885531 URL: https://github.com/llvm/llvm-project/commit/ba3ea9c60f0f259f0ccc47e47daf8253a5885531 DIFF: https://github.com/llvm/llvm-project/commit/ba3ea9c60f0f259f0ccc47e47daf8253a5885531.diff LOG:

[PATCH] D96611: [analyzer][tests] Fix issue comparison script

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added subscribers: steakhal, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko requested review of this revision. Herald added a project:

[PATCH] D96507: [clangd] Move command handlers into a map in ClangdLSPServer. NFC

thakis added a comment. Looks like this doesn't build on Windows: http://45.33.8.238/win/33161/step_4.txt (clang-cl + msvc stdlib) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96507/new/ https://reviews.llvm.org/D96507 __

[clang] fb4d8fe - [clang] Update mustprogress tests.

Author: Florian Hahn Date: 2021-02-12T16:53:51Z New Revision: fb4d8fe807016fed221263d9a406e3856c8dfa4c URL: https://github.com/llvm/llvm-project/commit/fb4d8fe807016fed221263d9a406e3856c8dfa4c DIFF: https://github.com/llvm/llvm-project/commit/fb4d8fe807016fed221263d9a406e3856c8dfa4c.diff LOG:

[PATCH] D96524: [OpenCL] Add support of OpenCL C 3.0 __opencl_c_fp64

Anastasia added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9899 def err_opencl_requires_extension : Error< - "use of %select{type|declaration}0 %1 requires %2 extension to be enabled">; + "use of %select{type|declaration}0 %1 requires %2 %se

[PATCH] D96204: [clangd] Fix clang tidy provider when multiple config files exist in directory tree

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry about dropping this (and others, i'm trying to get through them now) Agree about cherrypicking this. Regarding the extra test case... I'm not sure either. It's a nice test, but the

[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class

sammccall added a comment. Sorry for the looong delay getting back to this :-\ I do think this should be nullable (and const-friendly) but otherwise this is good to land. Comment at: clang-tools-extra/clangd/HeuristicResolver.h:73 + std::vector + resolveDependentMember(cons

[PATCH] D93110: [analyzer] Implement fine-grained suppressions via attributes

vsavchenko added a comment. In D93110#2534690 , @aaron.ballman wrote: > In D93110#2529917 , @NoQ wrote: > >>> What I want to avoid is having a static analyzer-specific suppression >>> attribute, and a different on

[PATCH] D96223: [clang-tidy] Simplify static assert check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG with a few nits. Comment at: clang-tools-extra/clang-tidy/misc/StaticAssertCheck.cpp:49-51 + expr(anyOf(expr(anyOf(AssertExprRoot, +un

[PATCH] D96407: [flang][driver] Add extension options and -finput-charset

awarzynski added a comment. Thank you for submitting this @FarisRehman ! Overall this looks good to me. I've left a few minor comments inline. Also, I think that it is worth adding a help message for `-finput-charset`. Lack of it in `clang` feels like an accidental omission. We can follow GCC h

[PATCH] D87519: [analyzer][Liveness][NFC] Enqueue the CFGBlocks post-order

Szelethus added a comment. I don't insist on this patch, though I will end up removing the FIXME even if I leave the actual code unchanged, as it seems to be outdated. Comment at: clang/lib/Analysis/LiveVariables.cpp:522 - // FIXME: we should enqueue using post order. - fo

[PATCH] D96542: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33f35a4b793b: [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] 33f35a4 - [clang-tidy] Fix `TransformerClangTidyCheck`'s handling of include insertions.

Author: Yitzhak Mandelbaum Date: 2021-02-12T16:23:53Z New Revision: 33f35a4b793bb53b830f8893110af57672e1dc79 URL: https://github.com/llvm/llvm-project/commit/33f35a4b793bb53b830f8893110af57672e1dc79 DIFF: https://github.com/llvm/llvm-project/commit/33f35a4b793bb53b830f8893110af57672e1dc79.diff

[PATCH] D96139: [clang-tidy] Simplify inaccurate erase check

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LG with nit. Comment at: clang-tools-extra/clang-tidy/bugprone/InaccurateEraseCheck.cpp:25-27 + 1, anyOf(cxxMemberCallExpr(callee(cxxMethodDecl(hasName("end"

[PATCH] D96138: [clang-tidy] Simplify delete null ptr check

njames93 added a comment. Seems that your test cases are failing on windows, I'm guessing this is a MSVC template compatibility issue. Probably need to add `-fno-delayed-template-parsing` to the clang driver args (after `-- --`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D90851: [clang-tidy] Extending bugprone-signal-handler with POSIX functions.

balazske updated this revision to Diff 323340. balazske added a comment. Changed definition of size_t in test header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 Files: clang-tools-extra/clang-tidy/bu

  1   2   >