[clang] c5d100f - [test] Fix conditional-temporaries.cpp

Author: Arthur Eubanks Date: 2020-12-28T20:17:31-08:00 New Revision: c5d100fdf2d782886215061e1ae0b4b072babce0 URL: https://github.com/llvm/llvm-project/commit/c5d100fdf2d782886215061e1ae0b4b072babce0 DIFF: https://github.com/llvm/llvm-project/commit/c5d100fdf2d782886215061e1ae0b4b072babce0.diff

[PATCH] D93883: [WebAssembly] Prototype prefetch instructions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei added a comment. Hi Simon, I found we have the same problem for fadd/fmul. See https://godbolt.org/z/3YKaGx X86 Intrinsics imply `reassoc` flag, but `llvm.vector.reduce.*` doesn't. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93179/new/ h

[PATCH] D93072: Fix PR35902: incorrect alignment used for ubsan check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ddf140c0040: Fix PR35902: incorrect alignment used for ubsan check. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D93

[clang] 4ddf140 - Fix PR35902: incorrect alignment used for ubsan check.

Author: James Y Knight Date: 2020-12-28T18:11:17-05:00 New Revision: 4ddf140c00408ecee9d20f4470e69e0f696d8f8a URL: https://github.com/llvm/llvm-project/commit/4ddf140c00408ecee9d20f4470e69e0f696d8f8a DIFF: https://github.com/llvm/llvm-project/commit/4ddf140c00408ecee9d20f4470e69e0f696d8f8a.diff

[PATCH] D92445: [PowerPC] Add powerpcle target.

Bdragon28 updated this revision to Diff 313655. Bdragon28 added a comment. Fix merge base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ https://reviews.llvm.org/D92445 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTa

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

craig.topper added a comment. @rsmith or @rjmccall do you have any opinions on whether we should use builtin types like SVE or create a new attribute for RISCV? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___

[PATCH] D93775: [WebAssembly] Prototype extending pairwise add instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e09e9979bc6: [WebAssembly] Prototype extending pairwise add instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 5e09e99 - [WebAssembly] Prototype extending pairwise add instructions

Author: Thomas Lively Date: 2020-12-28T14:11:14-08:00 New Revision: 5e09e9979bc60f0fca0e80e7f72f1260bd1bbca5 URL: https://github.com/llvm/llvm-project/commit/5e09e9979bc60f0fca0e80e7f72f1260bd1bbca5 DIFF: https://github.com/llvm/llvm-project/commit/5e09e9979bc60f0fca0e80e7f72f1260bd1bbca5.diff

[PATCH] D93873: [clangd] Cache preambles of closed files

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. When a file is close

[PATCH] D93653: [clangd] Avoid reallocating buffers for each message read:

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. I'm easy with this. Comment at: clang-tools-extra/clangd/JSONTransport.cpp:202 for (;;) { Out.resize(Size + BufSize); // Handle EINTR which is sent when a de

[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34405b41d615: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGE

[clang] 34405b4 - [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller

Author: Akira Hatanaka Date: 2020-12-28T11:52:27-08:00 New Revision: 34405b41d61580ff893057784b1b19f81f66bad3 URL: https://github.com/llvm/llvm-project/commit/34405b41d61580ff893057784b1b19f81f66bad3 DIFF: https://github.com/llvm/llvm-project/commit/34405b41d61580ff893057784b1b19f81f66bad3.diff

[PATCH] D93273: [CodeGen][ObjC] Destroy callee-destroyed arguments in the caller function when the receiver is nil

ahatanak updated this revision to Diff 313881. ahatanak marked an inline comment as done. ahatanak added a comment. Make `isParamDestroyedInCallee` a method of `ParmVarDecl`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93273/new/ https://reviews.

[PATCH] D93861: [clang-tidy][NFC] Split up some headers

njames93 updated this revision to Diff 313878. njames93 marked 3 inline comments as done. njames93 added a comment. Fix clang-tidy lint and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93861/new/ https://reviews.llvm.org/D93861 Files:

[PATCH] D93861: [clang-tidy][NFC] Split up some headers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyContext.h:9 -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDYDIAGNOSTICCONSUMER_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_CLANGTIDYDIAGNOSTICCONSUMER_H Should header g

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder updated this revision to Diff 313872. tbaeder added reviewers: jansvoboda11, thakis, Bigcheese. tbaeder added a comment. Rebased on lastest main branch and added a few more reviewers from git blame'ing the Options.td file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93375/new/

[PATCH] D93656: Moving UniqueInternalLinkageNamesPass to the start of IR pipelines.

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. LGTM with nit, but somebody else more familiar with this should LGTM to make sure this makes sense Comment at: llvm/test/Transforms/UniqueLinkageNames/unique-internal-l

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544-8556 + EXPECT_EQ("struct foo {\n" +" int i;\n" +"\n" +"private:\n" +" int j;\n" +"}\n", +format("struct foo {\n" --

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg marked 10 inline comments as done. thezbyg added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1220 + if (Style.InsertEmptyLineBeforeAccessModifier && PreviousLine && + PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && RootTok

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544-8556 + EXPECT_EQ("struct foo {\n" +" int i;\n" +"\n" +"private:\n" +" int j;\n" +"}\n", +format("struct foo {\n"

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

thezbyg updated this revision to Diff 313863. thezbyg added a comment. Option renamed to EmptyLineBeforeAccessModifier. Placed new configuration member in correct place alphabetically. Last token in previous line is no longer checked when EmptyLineBeforeAccessModifier is false. Executed clang/doc

[PATCH] D93861: [clang-tidy][NFC] Split up some headers

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, kadircet, arphaman, kbarton, xazax.hun, nemanjai. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extract the ClangTidy

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:252 + + if (Tok && Tok->is(tok::kw_template) && + Style.BraceWrapping.SplitEmptyRecord && EmptyBlock) { HazardyKnusperkeks wrote: > Why is this not just al

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:68 + /// \endcode + bool InsertEmptyLineBeforeAccessModifier; + HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > quite a mouthful... maybe just `NewLineBeforeAccessModifi

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:68 + /// \endcode + bool InsertEmptyLineBeforeAccessModifier; + MyDeveloperDay wrote: > quite a mouthful... maybe just `NewLineBeforeAccessModifier` ? A new line is always

[clang-tools-extra] c3b9d85 - [clang-tidy][NFC] Remove unnecessary headers

Author: Nathan James Date: 2020-12-28T15:01:51Z New Revision: c3b9d85bd4b7249af9efe3594c6c152a032f83f8 URL: https://github.com/llvm/llvm-project/commit/c3b9d85bd4b7249af9efe3594c6c152a032f83f8 DIFF: https://github.com/llvm/llvm-project/commit/c3b9d85bd4b7249af9efe3594c6c152a032f83f8.diff LOG:

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay updated this revision to Diff 313853. MyDeveloperDay added a comment. Addressing additional usecase found issues in C# tests too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93839/new/ https://reviews.llvm.org/D93839 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D93220: [clangd] Add error handling (elog) in code completion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0999408aea79: [clangd] Add error handling (elog) in code completion. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang-tools-extra] 0999408 - [clangd] Add error handling (elog) in code completion.

Author: Adam Czachorowski Date: 2020-12-28T15:22:54+01:00 New Revision: 0999408aea79dd69f182cfcb618006f6cf2b6d4e URL: https://github.com/llvm/llvm-project/commit/0999408aea79dd69f182cfcb618006f6cf2b6d4e DIFF: https://github.com/llvm/llvm-project/commit/0999408aea79dd69f182cfcb618006f6cf2b6d4e.d

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

curdeius added a comment. My 2 cents. Otherwise I agree with @MyDeveloperDay's comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1219-1228 + if (Style.InsertEmptyLineBeforeAccessModifier && PreviousLine && + PreviousLine->Last->isOneOf(tok::semi, tok::r_br

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Misc/loop-opt-setup.c:26 // Check br i1 to make sure the loop is gone, there will still be a label branch for the infinite loop. // CH

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 313842. aguinet added a comment. Replace a just introduced `const auto` usage. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/clang/Basic/Attr.td cla

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 313841. aguinet added a comment. Clang format fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files: clang/include/clang-c/Index.h clang/include/clang/Basic/A

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 313838. aguinet added a comment. Rebased on current master branch, and added clang sema tests cc @aaron.ballman . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 Files:

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6204 case HalfRank: llvm_unreachable("Complex half is not supported"); +case Ibm128Rank: llvm_unreachable("Complex __ibm128 is not supported"); case FloatRank: return FloatComplexTy;

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf updated this revision to Diff 313835. qiucf marked 14 inline comments as done. qiucf added a comment. Address comments and add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93377/new/ https://reviews.llvm.org/D93377 Files: clang/bindings/python/clang/cindex.py clang/inc

[PATCH] D88220: [C++20] P1825R0: More implicit moves

nullptr.cpp updated this revision to Diff 313831. nullptr.cpp added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88220/new/ https://reviews.llvm.org/D88220 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/c

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

tonyelewis added a comment. @njames93 Thank you very much for your continued input on this. Is your ping for an automated process or a human? If the latter, is it for me or for the reviewers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new