MyDeveloperDay added inline comments.

================
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:252
+
+      if (Tok && Tok->is(tok::kw_template) &&
+          Style.BraceWrapping.SplitEmptyRecord && EmptyBlock) {
----------------
HazardyKnusperkeks wrote:
> Why is this not just also in the previous if?
> I see that the condition is a bit different, but what would happen if the 
> condition is `SplitEmptyRecord && !EmptyBlock`?
non empty blocks are handled by the code below.

The reason the condition is different is to do with the fact that the merging 
is required to ensure concepts are not overly broken apart, this condition 
purely detects where we want to ensure we split the empty block.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93839/new/

https://reviews.llvm.org/D93839

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D9383... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... Johel Ernesto Guerrero Peña via Phabricator via cfe-commits
    • [PATCH] ... Björn Schäpers via Phabricator via cfe-commits
    • [PATCH] ... Johel Ernesto Guerrero Peña via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... Marek Kurdej via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits
    • [PATCH] ... Marek Kurdej via Phabricator via cfe-commits
    • [PATCH] ... MyDeveloperDay via Phabricator via cfe-commits

Reply via email to