[PATCH] D92826: [clang][cli] CompilerInvocationTest: rename member variable in fixture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf825ec86e14b: [clang][cli] CompilerInvocationTest: rename member variable in fixture (authored by jansvoboda11). Repository: rG LLVM Github Monore

[clang] 35621cc - [clang][cli] CompilerInvocationTest: add tests for boolean options

Author: Jan Svoboda Date: 2020-12-09T08:58:46+01:00 New Revision: 35621cc2e3b3778abc2bacf37f3b1e9dfac52895 URL: https://github.com/llvm/llvm-project/commit/35621cc2e3b3778abc2bacf37f3b1e9dfac52895 DIFF: https://github.com/llvm/llvm-project/commit/35621cc2e3b3778abc2bacf37f3b1e9dfac52895.diff L

[PATCH] D92825: [clang][cli] CompilerInvocationTest: join two test fixtures into one

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf2bb2239252: [clang][cli] CompilerInvocationTest: join two test fixtures into one (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[clang] 216d430 - [clang][cli] CompilerInvocationTest: join and add test cases

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 216d43053b4e7327e5f9eb5705a7c8e4f6ae850b URL: https://github.com/llvm/llvm-project/commit/216d43053b4e7327e5f9eb5705a7c8e4f6ae850b DIFF: https://github.com/llvm/llvm-project/commit/216d43053b4e7327e5f9eb5705a7c8e4f6ae850b.diff L

[clang] 03692ba - [clang][cli] CompilerInvocationTest: check arg parsing does not produce diagnostics

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 03692bae1fc9b6232de7caea3b57ad2f3dc2a9d0 URL: https://github.com/llvm/llvm-project/commit/03692bae1fc9b6232de7caea3b57ad2f3dc2a9d0 DIFF: https://github.com/llvm/llvm-project/commit/03692bae1fc9b6232de7caea3b57ad2f3dc2a9d0.diff L

[clang] 4894e42 - [clang][cli] CompilerInvocationTest: remove unnecessary command line arguments

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 4894e423e7b4b121bd4fb23cdba9870ff0f2a6b6 URL: https://github.com/llvm/llvm-project/commit/4894e423e7b4b121bd4fb23cdba9870ff0f2a6b6 DIFF: https://github.com/llvm/llvm-project/commit/4894e423e7b4b121bd4fb23cdba9870ff0f2a6b6.diff L

[clang] 5afff86 - [clang][cli] CompilerInvocationTest: split enum test into two

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: 5afff86d26163bc3ba93fb299ccfc2522d3fdc94 URL: https://github.com/llvm/llvm-project/commit/5afff86d26163bc3ba93fb299ccfc2522d3fdc94 DIFF: https://github.com/llvm/llvm-project/commit/5afff86d26163bc3ba93fb299ccfc2522d3fdc94.diff L

[clang] f825ec8 - [clang][cli] CompilerInvocationTest: rename member variable in fixture

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: f825ec86e14b1369a9edf382d65259351eae679e URL: https://github.com/llvm/llvm-project/commit/f825ec86e14b1369a9edf382d65259351eae679e DIFF: https://github.com/llvm/llvm-project/commit/f825ec86e14b1369a9edf382d65259351eae679e.diff L

[clang] cf2bb22 - [clang][cli] CompilerInvocationTest: join two test fixtures into one

Author: Jan Svoboda Date: 2020-12-09T08:58:45+01:00 New Revision: cf2bb2239252c0e1970e646308ae6fb552fcb002 URL: https://github.com/llvm/llvm-project/commit/cf2bb2239252c0e1970e646308ae6fb552fcb002 DIFF: https://github.com/llvm/llvm-project/commit/cf2bb2239252c0e1970e646308ae6fb552fcb002.diff L

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

hliao added a comment. LGTM if there's a regression test available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92893/new/ https://reviews.llvm.org/D92893 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D92917: [Driver] Pass -plugin-opt=no-new-pass-manager to the linker

MaskRay created this revision. MaskRay added reviewers: aeubanks, asbirlea, ychen. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. So that if -fno-new-pass-manager is requested for an -DENABLE_EXPERIMENTAL_NEW_PASS_MANAGER=on build,

[PATCH] D92915: [Driver] Add -f[no-]new-pass-manager to supersede -f[no-]experimental-new-pass-manager

MaskRay created this revision. MaskRay added reviewers: aeubanks, reames, rsmith. Herald added subscribers: dang, steven_wu, hiraditya. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new PM is considered stable and many downstr

Buildbot to listen main branch

Hello everyone, To follow the main branch creation I'm going to update the buildbot to listen for the changes in this branch and instruct all the workers to checkout this branch. No work is required on the workers. Please check your annotated scripts to make sure it accepts the branch name from

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:18 +// RUN: %clang -### -target x86_64-linux-gnu -c %s -gdwarf-5 -gembed-source 2>&1 | FileCheck %s --check-prefix=DWARF-CLAMP +// CHECK: debug information option '{{-gz|-fdebug-info

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 310416. aorlov added a comment. Simplify the patch. @Quuxplusone, Actually you've pushed me to some thinking of what more syntactic cases it could be. And I came to that we can get rid of this hack and simplify the patch pretty much. Hope, this fix will be mo

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > (One idea we've been playing with is that traversal of the AST usually goes > through TranslationUnitDecls::decls_begin(), which triggers loading from the > preamble. We could add a stateful flag to DeclContext that causes this to > behave like noload_decls_begin in

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

dexonsmith added a comment. This seems fine to me, I agree this option doesn't need to be present all the time. Thanks for clarifying that `-triple` is still there. @Bigcheese, WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https:

[PATCH] D92006: Refactoring the attrubute plugin example to fit the new API

psionic12 updated this revision to Diff 310401. psionic12 added a comment. Fix grammar Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92006/new/ https://reviews.llvm.org/D92006 Files: clang/examples/Attribute/Attribute.cpp

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added a comment. Oh and in the description > This means that when using OptBisect under the NPM it runs twice when it > should only run once. doesn't really make sense. I'd say something like > e.g. -opt-bisect-limit=1 will run both the first optional optimization pass > and the firs

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith added a comment. Thanks for the reviews! Pushed 2878e965af27ce037378a4f0409e89039108c09f . Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +ret

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

aeubanks added a comment. Thanks for looking into this! Can you upload the diff with full context (e.g. use `diff -U ` or use arcanist to upload)? Comment at: clang/lib/CodeGen/BackendUtil.cpp:1153 + // Sets legacy pass manager OptBisect to the same one as npm so passes

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

This revision was automatically updated to reflect the committed changes. dexonsmith marked an inline comment as done. Closed by commit rG2878e965af27: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D

[clang] 2878e96 - Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

Author: Duncan P. N. Exon Smith Date: 2020-12-08T18:10:53-08:00 New Revision: 2878e965af27ce037378a4f0409e89039108c09f URL: https://github.com/llvm/llvm-project/commit/2878e965af27ce037378a4f0409e89039108c09f DIFF: https://github.com/llvm/llvm-project/commit/2878e965af27ce037378a4f0409e89039108

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

This revision was automatically updated to reflect the committed changes. Closed by commit rG75cd8d756d6e: Support: Add RedirectingFileSystem::create from simple list of redirections (authored by dexonsmith). Changed prior to commit: https://reviews.llvm.org/D91317?vs=304702&id=310398#toc Repo

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder marked 2 inline comments as done. tmroeder added inline comments. Comment at: clang/test/ASTMerge/generic-selection-expr/Inputs/generic.c:1 +void f() { + int x; aaron.ballman wrote: > Should we also have a C++ test for a result-dependent use of _Generic

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310394. tmroeder edited the summary of this revision. tmroeder added a comment. Added C++ tests for result-dependent uses, and added that fact to the description as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5207f19d103d: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC (authored by dexonsmith). Changed prior to commit: https://revi

[clang-tools-extra] 5207f19 - ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-08T17:33:19-08:00 New Revision: 5207f19d103dc3e0ec974fa64d2c031d84d497a8 URL: https://github.com/llvm/llvm-project/commit/5207f19d103dc3e0ec974fa64d2c031d84d497a8 DIFF: https://github.com/llvm/llvm-project/commit/5207f19d103dc3e0ec974fa64d2c031d84d4

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

yaxunl added a comment. LGTM. Can we have a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92893/new/ https://reviews.llvm.org/D92893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:2328 + CGF.CGM.getTarget().getTriple().isAArch64() && + !CGF.CGM.getTarget().getTriple().isOSWindows()) { +auto *callBase = cast(value); rjmccall wrote: > It would be good to e

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak updated this revision to Diff 310387. ahatanak marked 2 inline comments as done. ahatanak edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92808/new/ https://reviews.llvm.org/D92808 Files: clang/lib/CodeG

[PATCH] D91673: [PGO] Enable preinline and cleanup when optimize for size

xur accepted this revision. xur added a comment. Sorry to the late response (I somehow missed the reply). (1) Can we add some comments to explain the reason for enabling this for -Oz -- I think the comments from @rnk is useful to some people (at least to me). (2) Also please add a testcase. Fe

[PATCH] D92897: Set legacy pass manager OptBisect to same as NPM OptBisect

swamulism created this revision. swamulism added a reviewer: aeubanks. swamulism requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently there is an issue where the legacy pass manager uses a different OptBisect counter

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:296 +def warn_drv_dwarf_version_limited_by_target : Warning< + "debug information option '%0' is not supported. It needs DWARF-%2 but target '%1' only provides DWARF-%3.">, + InGroup; ---

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis requested changes to this revision. eugenis added a comment. This revision now requires changes to proceed. I wonder if we could just disable unused argument warning for both -disable-noundef-analysis -Xclang -disable-noundef-analysis I don't see any precedents for this kind of thing

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

eugenis added a comment. > simply naming it as %clang_noundef would be clearer, Hmm, yeah, that's a little better. > This new substitution is going to be used for the noundef checks in D81678 > only anyway. I'm not sure what you mean by this. The substitution

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

tra added a comment. In D91281#2441147 , @tra wrote: > I think `isCUDADeviceBuiltinTextureType` has problem handling texture refs > within templates. Proposed fix: https://reviews.llvm.org/D92893 Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310381. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:114 assert(!ProjectRoot.empty()); +ChannelStatusWatcher = std::thread([&Channel]() { + grpc_connectivity_state Status = sammccall wrote: > The thread is a b

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with the other patches. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91317/new/ https://reviews.llvm.org/D91317 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92888/new/ https://reviews.llvm.org/D92888 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D92267: [clang-tidy][NFC] Use moves instead of copies when constructing OptionsProviders.

njames93 updated this revision to Diff 310378. njames93 marked 2 inline comments as done. njames93 added a comment. Use pass by value for FileOptionsBaseProvider constructor. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92267/new/ https://re

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

efriedma added a comment. I'm not sure this direction really makes sense. There's a long history of defining utility functions in headers as "static inline". Non-static inline functions in C have confusing semantics. In C++, the semantics are less confusing, but "static inline" still isn't ra

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

dexonsmith added a comment. Thanks for the review! Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:180 + template + IntrusiveRefCntPtr(std::unique_ptr &&S) : Obj(S.release()) { +retain(); dblaikie wrote: > Pass 'S' by value here - that's the usual

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good with one minor tweak Comment at: llvm/include/llvm/ADT/IntrusiveRefCntPtr.h:180 + template + IntrusiveRefCntPtr(std::unique_ptr &&S) : Obj(S.release()) { +

[PATCH] D92893: [CUDA] Do not diagnose host/device variable access in dependent types.

tra created this revision. tra added reviewers: yaxunl, hliao. Herald added a subscriber: bixia. tra requested review of this revision. Herald added a project: clang. `isCUDADeviceBuiltinSurfaceType()`/`isCUDADeviceBuiltinTextureType()` do not work on dependent types as they rely on specific type

[PATCH] D92627: Basic: Add hashing support for FileEntryRef and DirectoryEntryRef

dexonsmith added inline comments. Comment at: clang/include/clang/Basic/DirectoryEntry.h:104 + bool isSpecialDenseMapKey() const { +return ME == llvm::DenseMapInfo::getEmptyKey() || + ME == llvm::DenseMapInfo::getTombstoneKey(); jansvoboda11 wrote:

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

Quuxplusone added subscribers: mpark, Quuxplusone. Quuxplusone added a comment. I agree with your reasoning, but in practice I still see a lot of people using `static inline` for functions (especially function templates) in .h files. I'm not sure exactly why — maybe to reduce the burden on the l

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr + create(ArrayRef> RemappedFiles, dexonsmith wrote: > JDevlieghere wrote: >

[PATCH] D92888: ADT: Allow IntrusiveRefCntPtr construction from std::unique_ptr, NFC

dexonsmith created this revision. dexonsmith added reviewers: JDevlieghere, dblaikie. Herald added subscribers: usaxena95, ributzka, kadircet, arphaman. dexonsmith requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Allow a `std::unique_pt

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-comm

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to check this patch again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commi

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310357. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-to

[PATCH] D92886: [Sema] Warn about unused functions even when they're inline

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, efriedma, rsmith. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Being inline doesn't change anything about a function having internal linkage, s

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 updated this revision to Diff 310352. njames93 added a comment. Made GlobList::specifies const. Made check validation function static and only taking a StringRef. This will make it easier to refactor out at a later date if this functionality wants to be used elsewhere. Repository: r

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441141 , @jrtc27 wrote: > What gets done currently for i386? That suffers potentially the same problem > given both /usr/lib/gcc/x86_64-linux-gnu/$V/32 and > /usr/lib/gcc/i386-linux-gnu/$V are possible locations for a

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

rjmccall added a comment. Your patch description doesn't mention the changes to the inliner. Comment at: clang/lib/CodeGen/CGObjC.cpp:2282 +static const char *markerKey = "clang.arc.retainAutoreleasedReturnValueMarker"; + This is too generic for a global vari

[clang-tools-extra] 86436a4 - [clang-tidy][NFC] Made Globlist::contains const

Author: Nathan James Date: 2020-12-08T22:26:55Z New Revision: 86436a4343628f0f98d72169a013cf99a3be5973 URL: https://github.com/llvm/llvm-project/commit/86436a4343628f0f98d72169a013cf99a3be5973 DIFF: https://github.com/llvm/llvm-project/commit/86436a4343628f0f98d72169a013cf99a3be5973.diff LOG:

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

dexonsmith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr + create(ArrayRef> RemappedFiles, JDevlieghere wrote: > - Do you need to k

[PATCH] D91281: [CUDA][HIP] Diagnose reference of host variable

tra added a comment. It appears that we need to add special handling for texture/surface references. Nominally they are host-side objects, but they are accessed/used from device functions as far as Sema is concerned. E.g. https://godbolt.org/z/z1YnE3 NVCC and older clang compile it, but the re

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. i.e. can we not just support both approaches and prefer x86_64-linux-gnux32 if it exists? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52050/new/ https://reviews.llvm.org/D52050 ___

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. In D52050#2441133 , @glaubitz wrote: > In D52050#2441094 , @hvdijk wrote: > >> I've been able to check what Ubuntu 20.10 offers in terms of x32 support. >> Its kernel supports x32 binaries,

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

glaubitz added a comment. In D52050#2441094 , @hvdijk wrote: > I've been able to check what Ubuntu 20.10 offers in terms of x32 support. Its > kernel supports x32 binaries, it provides x32 versions of core system > libraries in separate packages (e.g. li

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGCall.cpp:3824 +// that may have type parameters in its signature. +static bool isObjCMethodWithTypeParams(const ObjCMethodDecl *method

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. I've been able to check what Ubuntu 20.10 offers in terms of x32 support. Its kernel supports x32 binaries, it provides x32 versions of core system libraries in separate packages (e.g. libc6-x32, libx32stdc++6, libx32z1), and it provides a compiler that targets x32 by de

[PATCH] D91317: Support: Add RedirectingFileSystem::create from simple list of redirections

JDevlieghere added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:735 + /// Redirect each of the remapped files from first to second. + static std::unique_ptr + create(ArrayRef> RemappedFiles, - Do you need to know that this is a `

[PATCH] D92883: De-templatify EmitCallArgs argument type checking, NFCI

rnk created this revision. rnk added reviewers: compnerd, aeubanks, rsmith. rnk requested review of this revision. Herald added a project: clang. This template exists to abstract over FunctionPrototype and ObjCMethodDecl, which have similar APIs for storing parameter types. In place of a template,

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc updated this revision to Diff 310338. mibintc added a comment. Thanks @Anastasia ; I modified CGBuiltin.cpp to use EmitRuntimeCall when creating calls to runtime functions instead of Builder.CreateCall so this is setting the CallingConvention on the Call node using the ABIInfo. I change

[PATCH] D92630: ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry

This revision was automatically updated to reflect the committed changes. Closed by commit rGb85c6e5bcd1a: ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry (authored by dexonsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92630/ne

[clang] b85c6e5 - ARCMigrate: Use hash_combine in the DenseMapInfo for EditEntry

Author: Duncan P. N. Exon Smith Date: 2020-12-08T13:46:21-08:00 New Revision: b85c6e5bcd1a9de941c318f9a5dc742818752a56 URL: https://github.com/llvm/llvm-project/commit/b85c6e5bcd1a9de941c318f9a5dc742818752a56 DIFF: https://github.com/llvm/llvm-project/commit/b85c6e5bcd1a9de941c318f9a5dc74281875

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85c18d3521e8: [Driver] Add -gno-split-dwarf which can disable debug fission (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 85c18d3 - [Driver] Add -gno-split-dwarf which can disable debug fission

Author: Fangrui Song Date: 2020-12-08T13:24:59-08:00 New Revision: 85c18d3521e87a22c742be512245665d6bb5bfe2 URL: https://github.com/llvm/llvm-project/commit/85c18d3521e87a22c742be512245665d6bb5bfe2 DIFF: https://github.com/llvm/llvm-project/commit/85c18d3521e87a22c742be512245665d6bb5bfe2.diff

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

MaskRay updated this revision to Diff 310331. MaskRay added a comment. Test there is no -ggnu-pubnames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92809/new/ https://reviews.llvm.org/D92809 Files: clang/include/clang/Driver/Options.td clang/

[clang] b13f741 - APINotes: add bitcode format schema definitions

Author: Saleem Abdulrasool Date: 2020-12-08T21:15:41Z New Revision: b13f74151137f33327e0549adc9778aebf98a299 URL: https://github.com/llvm/llvm-project/commit/b13f74151137f33327e0549adc9778aebf98a299 DIFF: https://github.com/llvm/llvm-project/commit/b13f74151137f33327e0549adc9778aebf98a299.diff

[PATCH] D91997: APINotes: add bitcode format schema definitions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb13f74151137: APINotes: add bitcode format schema definitions (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D91997?vs=

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG843f2dbf003f: [Driver] Don't make -gsplit-dwarf imply -g2 (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 843f2db - [Driver] Don't make -gsplit-dwarf imply -g2

Author: Fangrui Song Date: 2020-12-08T13:14:34-08:00 New Revision: 843f2dbf003f2a51d0d4ab8cf40647c99ded2e93 URL: https://github.com/llvm/llvm-project/commit/843f2dbf003f2a51d0d4ab8cf40647c99ded2e93 DIFF: https://github.com/llvm/llvm-project/commit/843f2dbf003f2a51d0d4ab8cf40647c99ded2e93.diff

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. I have also notified ChromeOS/Android NDK/Bazel maintainers since they use -gsplit-dwarf (though might not be affected). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 ___

[PATCH] D91296: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG51f3432f4b52: Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost… (authored by dexonsmith). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 51f3432 - Frontend: Clarify logic for using the preamble in ASTUnit::CodeComplete, almost NFC

Author: Duncan P. N. Exon Smith Date: 2020-12-08T12:52:17-08:00 New Revision: 51f3432f4b5217b35dc2694c6e46d6cfc7defad6 URL: https://github.com/llvm/llvm-project/commit/51f3432f4b5217b35dc2694c6e46d6cfc7defad6 DIFF: https://github.com/llvm/llvm-project/commit/51f3432f4b5217b35dc2694c6e46d6cfc7de

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh added a comment. In D92812#2439324 , @RKSimon wrote: > it looks like a very bad merge imo. Yep, Thank you! I will post smaller incremental patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9281

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D91885: [clang-tidy] Add support for diagnostics with no location

This revision was automatically updated to reflect the committed changes. Closed by commit rG27553933a869: [clang-tidy] Add support for diagnostics with no location (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91885/new/ htt

[clang-tools-extra] 2755393 - [clang-tidy] Add support for diagnostics with no location

Author: Nathan James Date: 2020-12-08T20:29:31Z New Revision: 27553933a8693d508eb7f7c24a14f66b3d006d2c URL: https://github.com/llvm/llvm-project/commit/27553933a8693d508eb7f7c24a14f66b3d006d2c DIFF: https://github.com/llvm/llvm-project/commit/27553933a8693d508eb7f7c24a14f66b3d006d2c.diff LOG:

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added a comment. @kadircet, ping, do you still have concerns? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91297/new/ https://reviews.llvm.org/D91297 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39431e479ffd: [clang-tidy] Introduce misc No Integer To Pointer Cast check (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 39431e4 - [clang-tidy] Introduce misc No Integer To Pointer Cast check

Author: Roman Lebedev Date: 2020-12-08T22:55:13+03:00 New Revision: 39431e479ffddc81120911f031921b2d637e967f URL: https://github.com/llvm/llvm-project/commit/39431e479ffddc81120911f031921b2d637e967f DIFF: https://github.com/llvm/llvm-project/commit/39431e479ffddc81120911f031921b2d637e967f.diff

[PATCH] D64034: [c++] Implement P1957R0 - narrowing pointer-to-bool

lichray abandoned this revision. lichray added a comment. Implemented in 7ef45f45f67 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64034/new/ https://reviews.llvm.org/D64034 _

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

lebedev.ri added a comment. In D91055#2440344 , @aaron.ballman wrote: > LGTM! Thank you for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91055/new/ https://reviews.llvm.org/D91055 __

[PATCH] D92874: [clangd] Validate clang-tidy Checks in clangd config.

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Add instrumentation in ConfigCompi

[PATCH] D92852: [NFC] Reduce include files dependency and AA header cleanup (part 2).

dfukalov added inline comments. Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:800 case Instruction::Invoke: - return getModRefInfo((const InvokeInst *)I, Loc, AAQIP); + return getModRefInfo((const CallBase *)I, Loc, AAQIP); case Instruction::CatchPad:

[clang] fc750f6 - [PPC] Fixing a typo in altivec.h. Commenting out an unnecessary macro

Author: Masoud Ataei Date: 2020-12-08T19:21:02Z New Revision: fc750f609dfb2fd51b6810cc55058568dfe4b3a9 URL: https://github.com/llvm/llvm-project/commit/fc750f609dfb2fd51b6810cc55058568dfe4b3a9 DIFF: https://github.com/llvm/llvm-project/commit/fc750f609dfb2fd51b6810cc55058568dfe4b3a9.diff LOG:

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c5bed734f9e: [clangd] ExpandAutoType: Do not offer code action on lambdas. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 3c5bed7 - [clangd] ExpandAutoType: Do not offer code action on lambdas.

Author: Adam Czachorowski Date: 2020-12-08T20:03:16+01:00 New Revision: 3c5bed734f9e02bd3bc4fbd1e0acc53506823ebf URL: https://github.com/llvm/llvm-project/commit/3c5bed734f9e02bd3bc4fbd1e0acc53506823ebf DIFF: https://github.com/llvm/llvm-project/commit/3c5bed734f9e02bd3bc4fbd1e0acc53506823ebf.d

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92809/new/ https://reviews.llvm.org/D92809 __

[PATCH] D67429: Improve code generation for thread_local variables:

wristow added a comment. This commit appears to be the root cause of a run-time crash related to the interaction of global initializers and the wrapper functions to access `thread_local` variables -- reported as PR48030 . Repository: rL LLVM CHA

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

jwakely added a comment. In D87974#2440533 , @BillyONeal wrote: > Of course if it's already publicly documented for you the horse has > presumably already left the barn which makes the discussion moot? It's not in a shipping release yet. But the point of

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 310290. gulfem marked an inline comment as done. gulfem added a comment. Add a new line at the end of the test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files

[PATCH] D92847: [clangd] ExpandAutoType: Do not offer code action on lambdas.

adamcz added a comment. Also added some "const" to make clang-tidy happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92847/new/ https://reviews.llvm.org/D92847 ___ cfe-commits mailing list cfe-commits@

  1   2   3   >